Commit Graph

972 Commits

Author SHA1 Message Date
mcarton
f309dc3c0f Add the MATCH_SAME_ARMS lint 2016-02-12 14:30:52 +01:00
mcarton
cbbc667b1b Dogfood for future MATCH_SAME_ARMS lint 2016-02-12 14:30:26 +01:00
mcarton
5ddc615a40 Add missing types to eq_ty 2016-02-12 14:30:26 +01:00
mcarton
ee830ba55e Extend IF_SAME_THEN_ELSE to ifs sequences 2016-02-12 14:30:26 +01:00
mcarton
88beb35194 Implement Expr spanless-hashing 2016-02-12 14:30:26 +01:00
mcarton
afee209d5a Add missing ExprLoop to SpanlessEq 2016-02-12 14:30:26 +01:00
mcarton
91c16fc8e6 Refactor Expr comparisons 2016-02-12 14:30:26 +01:00
mcarton
e1c7914c2e Add missing ExprIndex to is_exp_equal 2016-02-12 14:30:26 +01:00
llogiq
d305bca25b fixed README 2016-02-12 12:31:13 +01:00
llogiq
9ee462625b Merge pull request #637 from mcarton/debug
Lint usage of `Debug`-based formatting
2016-02-12 12:18:15 +01:00
Manish Goregaokar
c1edd6ff1e Merge pull request #651 from oli-obk/improve_no_effect
improve the `no_effect` lint
2016-02-11 19:24:56 +05:30
Oliver Schneider
eed9ec15fb improve the no_effect lint 2016-02-11 13:50:41 +01:00
Manish Goregaokar
1013026f18 Merge branch 'pr-645' 2016-02-10 10:20:23 +05:30
Joshua Holmer
7e06737d6f Improve testing and suggestion messages on bool_comparison 2016-02-09 15:44:07 -05:00
mcarton
2db6965c81 Lint usage of Debug-based formatting 2016-02-09 21:22:54 +01:00
mcarton
1a8b8cd28f Don’t use {:?} and use span_suggestion in TOPLEVEL_REF_ARG 2016-02-09 21:22:30 +01:00
mcarton
d27aa960b6 Remove unused Display implementation for consts 2016-02-09 21:22:30 +01:00
mcarton
34812e82d0 Use const_eval in loops 2016-02-09 21:22:30 +01:00
Joshua Holmer
2687a3f6b5 Update lints 2016-02-09 14:52:20 -05:00
Joshua Holmer
14292674b0 display suggestion separately from lint 2016-02-09 14:44:42 -05:00
Manish Goregaokar
93461afffc Merge branch 'pr-613'
Conflicts:
	src/lib.rs
	src/types.rs
2016-02-10 01:03:26 +05:30
Joshua Holmer
56b3e7b4c2 lint comparison to bool (e.g. y == true)
Addresses #630
2016-02-09 14:10:22 -05:00
Manish Goregaokar
8c886f1e75 Merge pull request #642 from Manishearth/regex_macro
Regex macro
2016-02-09 14:17:46 +05:30
llogiq
275795fab3 speed up lint using blocks and types 2016-02-09 06:18:08 +01:00
llogiq
3b0b9e0e06 Merge remote-tracking branch 'origin/master' into regex_macro 2016-02-08 23:51:30 +01:00
llogiq
6525471214 fix #595 2016-02-08 23:48:04 +01:00
Manish Goregaokar
d68dc8e25a Merge pull request #640 from oli-obk/fix/639
prevent panic in enum glob import lint if a crate's elements are glob imported
2016-02-08 16:15:59 +05:30
Oliver Schneider
672beb4138 prevent panic in enum glob import lint if a crate's elements are glob imported
fixes #639
2016-02-08 11:28:18 +01:00
llogiq
ceb9a8bdd7 regex macro lint 2016-02-07 22:50:54 +01:00
Manish Goregaokar
4d5cd7255d Merge pull request #635 from mcarton/fix-wiki
Fix wiki
2016-02-07 19:48:03 +05:30
mcarton
d14c4ea187 Fix wiki
Markdown is hell.
2016-02-07 15:14:12 +01:00
llogiq
2c212dc301 Merge pull request #603 from mcarton/copies
Die copy & paste, die
2016-02-07 14:48:13 +01:00
mcarton
a9e1b1fba0 Small cleanup 2016-02-07 14:40:45 +01:00
mcarton
344698377f Fix typo 2016-02-07 13:27:09 +01:00
mcarton
cd7a913200 Add - and / to EQ_OP 2016-02-07 13:26:34 +01:00
mcarton
8e22d08129 Improve is_exp_equal 2016-02-07 13:26:34 +01:00
mcarton
d862495d19 Lint ifs with the same then and else blocks 2016-02-07 13:26:34 +01:00
mcarton
fe6f2a22ba Lint about consecutive ifs with same condition 2016-02-07 13:26:34 +01:00
Manish Goregaokar
9ba5d45509 Merge branch 'pr-581'
Conflicts:
	README.md
2016-02-07 17:40:48 +05:30
Manish Goregaokar
b5105f5667 Merge pull request #631 from mcarton/regex
Fix false negative in TRIVIAL_REGEX
2016-02-06 22:51:26 +05:30
mcarton
d9a2a7ac3c Fix false negative in TRIVIAL_REGEX 2016-02-06 18:13:19 +01:00
Manish Goregaokar
f53a830c8c Merge pull request #623 from mcarton/redundant
Be more consistent in lint declarations
2016-02-06 12:14:03 +05:30
mcarton
f2a7c8cca0 Update update_wiki.py to extract default lint level 2016-02-06 00:42:55 +01:00
mcarton
83a82a1d86 Remove redundancy in lint documentation
The default level is always given in the declare_lint! macro, no need to
add it inconsistently in the documentation.
2016-02-06 00:41:54 +01:00
mcarton
13f245f6c9 Fix util/update_wiki.py warnings and be consistent in declare_lint! invocations 2016-02-06 00:13:29 +01:00
Manish Goregaokar
b9bb298a4b Merge pull request #622 from mcarton/regex
Lint about trivial regexes
2016-02-06 04:27:35 +05:30
mcarton
a02b8124de Lint about trivial regexes 2016-02-05 23:10:48 +01:00
mcarton
70124cf591 Fix case conventions 2016-02-05 21:54:29 +01:00
llogiq
0494071ab7 Merge pull request #564 from mcarton/hashmap
Lint looping on maps ignoring the keys or values
2016-02-05 20:42:39 +01:00
mcarton
c0063e172d Improve error message 2016-02-05 19:46:11 +01:00