Small cleanup
This commit is contained in:
parent
344698377f
commit
a9e1b1fba0
@ -54,15 +54,10 @@ fn check_expr(&mut self, cx: &LateContext, expr: &Expr) {
|
||||
/// Implementation of `IF_SAME_THEN_ELSE`.
|
||||
fn lint_same_then_else(cx: &LateContext, expr: &Expr) {
|
||||
if let ExprIf(_, ref then_block, Some(ref else_expr)) = expr.node {
|
||||
let must_lint = if let ExprBlock(ref else_block) = else_expr.node {
|
||||
is_block_equal(cx, &then_block, &else_block, false)
|
||||
}
|
||||
else {
|
||||
false
|
||||
};
|
||||
|
||||
if must_lint {
|
||||
span_lint(cx, IF_SAME_THEN_ELSE, expr.span, "this if has the same then and else blocks");
|
||||
if let ExprBlock(ref else_block) = else_expr.node {
|
||||
if is_block_equal(cx, &then_block, &else_block, false) {
|
||||
span_lint(cx, IF_SAME_THEN_ELSE, expr.span, "this if has the same then and else blocks");
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user