6639: Use `ExpandResult` instead of `MacroResult` r=jonas-schievink a=jonas-schievink
`MacroResult` is redundant.
bors r+ 🤖
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
6637: Publish diagnostics on file open r=jonas-schievink a=jonas-schievink
Diagnostics are sometimes only showing up when typing. This should fix that.
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/6381
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
6496: Use builtin scopes more r=matklad a=georgewfraser
VSCode has added more builtin fallback scopes, so we can remove some of our fallback scopes by aligning with their conventions.
Note that the macro scope doesn't seem to actually *work* at the moment. I have filed a bug with VSCode: https://github.com/microsoft/vscode/issues/110150
Co-authored-by: George Fraser <george@fivetran.com>
6625: hir_expand: propagate expansion errors r=jonas-schievink a=jonas-schievink
This is needed to collect and report expansion errors later.
bors r+ 🤖
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
6618: Properly infer tuple patterns when encountering ellipsis r=Veykril a=Veykril
We basically just split the subpatterns into two halves when the ellipsis is present and then offset the latter half to account for the ignored bindings.
Fixes#6616
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
6620: cargo update (without cargo_metadata) r=kjeremy a=kjeremy
This is a `cargo update` run without updating `cargo_metadata`.
`cargo_metadata` `0.12.1` pins `semver-parser` to `0.10.0` (4e88e5624c) which brings back the compile time blowup that @matklad tried so hard to avoid in https://github.com/steveklabnik/semver-parser/pull/50.
Co-authored-by: kjeremy <kjeremy@gmail.com>
6610: add 'Re-enable this test' assist r=SomeoneToIgnore a=jakobhellermann
The `Ignore this test` assist previously allowed ignoring multiple times, each time adding a `#[ignore]` attribute.
This PR instead shows an assist to undo the ignoring.
Co-authored-by: Jakob Hellermann <jakob.hellermann@protonmail.com>
6598: Textmate grammar: ensure word boundary after `true` r=dustypomerleau a=dustypomerleau
Adding round brackets ensures word boundaries on both sides of booleans (reported in https://github.com/dustypomerleau/rust-syntax/issues/7).
Co-authored-by: Dusty Pomerleau <dustypomerleau@users.noreply.github.com>
6595: Don't wrap parens around expr in remove_dbg assist if its in conditions r=Veykril a=Veykril
If the expr in the `dbg!` macro consists of multiple elements it won't remove the parentheses if its in a `match` or condition-using construct, as these are followed by siblings causing the `is_leaf` check to fail.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
6585: Link rustc error page and clippy lint page via CodeDescription r=kjeremy a=Veykril
Fixes#6371
This makes the error code in here clickable, same for clippy lints
For clippy I just chose the master build of the site as I believe that to be pretty much always the best fitting.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
