mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove fixed FIXME, propagate errors better

Browse Source
This commit is contained in:
Jonas Schievink 2020-11-24 21:52:19 +01:00
parent e2d8e1120f
commit 9a3bb19d32
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crates/hir_expand/src/db.rs
View File

@ -359,11 +359,7 @@ pub fn parse_macro_with_arg(
match result.error {
Some(error) => {
// FIXME:
// In future, we should propagate the actual error with recovery information
// instead of ignore the error here.
// Safe check for recurisve identity macro
// Safety check for recursive identity macro.
let node = parse.syntax_node();
let file: HirFileId = macro_file.into();
let call_node = match file.call_node(db) {
@ -374,7 +370,7 @@ pub fn parse_macro_with_arg(
};
if !diff(&node, &call_node.value).is_empty() {
MacroResult { value: Some((parse, Arc::new(rev_token_map))), error: None }
MacroResult { value: Some((parse, Arc::new(rev_token_map))), error: Some(error) }
} else {
return MacroResult::error(error);
}