bors[bot]
951c7c157a
Merge #5852
...
5852: Add Early Return rule to style r=matklad a=matklad
bors r+
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-24 10:56:04 +00:00
bors[bot]
6eddcfd7a5
Merge #5853
...
5853: Avoid monomorphization
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-24 10:50:04 +00:00
Aleksey Kladov
fc3e591bdb
Avoid monomorphization
2020-08-24 12:49:36 +02:00
Aleksey Kladov
d7ece3028d
Add Early Return rule to style
2020-08-24 12:22:28 +02:00
bors[bot]
e65d48d1fb
Merge #5823
...
5823: Don't underline function definition if self is &mut r=Nashenas88 a=matklad
The self is right there, and is already underlined, so it makes little
sense to emit even more underlines.
before:
after:
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-22 14:41:17 +00:00
bors[bot]
d7466c9f9e
Merge #5839
...
5839: Dont ask me why... r=kjeremy a=Veetaha
Co-authored-by: Veetaha <veetaha2@gmail.com>
2020-08-21 19:47:22 +00:00
Veetaha
54d4bc2622
Dont ask me why...
2020-08-21 21:14:40 +03:00
bors[bot]
aab5aaccf2
Merge #5838
...
5838: ⬆️ autocfg
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-21 17:15:09 +00:00
Aleksey Kladov
95f33bb5f7
⬆️ autocfg
2020-08-21 19:14:44 +02:00
Aleksey Kladov
863b1fb731
⬆️ ungrammar
2020-08-21 19:14:05 +02:00
bors[bot]
df54561a68
Merge #5835
...
5835: Switch to expect_test from crates.io
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-21 11:21:05 +00:00
Aleksey Kladov
b0fd3faf36
Switch to expect_test from crates.io
2020-08-21 13:19:31 +02:00
Aleksey Kladov
66e0c9f840
Remove expect crate
2020-08-21 13:15:56 +02:00
bors[bot]
71d2c4a027
Merge #5832
...
5832: Update crates r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
2020-08-20 16:52:02 +00:00
kjeremy
41c5d9caaa
Update crates
2020-08-20 12:50:43 -04:00
bors[bot]
844e1aa725
Merge #5824
...
5824: Optimize reference search
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 22:55:54 +00:00
Aleksey Kladov
e262149b7c
Optimize reference search
2020-08-20 00:54:44 +02:00
bors[bot]
5dafd39ad4
Merge #5813
...
5813: Try lld r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 20:01:59 +00:00
Aleksey Kladov
97d380c0d5
Use lld on winsows
2020-08-19 20:17:49 +02:00
Aleksey Kladov
8000d1d30d
Don't underline function definition if self is &mut
...
The self is right there, and is already underlined, so it makes little
sense to emit even more underlines.
2020-08-19 20:02:33 +02:00
bors[bot]
9051d6bc36
Merge #5822
...
5822: Remove dead code
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 17:56:19 +00:00
Aleksey Kladov
eb7bb2cba0
Remove dead code
2020-08-19 19:54:00 +02:00
bors[bot]
bb07e6bdee
Merge #5821
...
5821: **Remove Unused Parameter** refactoring
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 17:49:36 +00:00
Aleksey Kladov
4b5b55f6f3
**Remove Unused Parameter** refactoring
2020-08-19 19:40:55 +02:00
bors[bot]
f5b7540f38
Merge #5820
...
5820: Future proof find-usages API
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 17:00:01 +00:00
Aleksey Kladov
81b0976187
Future proof find-usages API
...
We might want to provide more efficient impls for check if usages
exist, limiting the search, filtering and cancellation, so let's
violate YAGNI a bit here.
2020-08-19 18:58:48 +02:00
bors[bot]
686a6a26fd
Merge #5819
...
5819: Apply couple of rule of thumbs to simplify highlighting code
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 15:57:21 +00:00
Aleksey Kladov
b56e020077
Apply couple of rule of thumbs to simplify highlighting code
...
Main one: instead of adding a parameter to function to handle special
case, make the caller handle it.
Second main one: make sure that function does a reasonable thing.
`highlight_def` picks a color for def, *regardless* of the context
the def is use. Feeding an info from the call-site muddies the
responsibilities here.
Minor smells, flagging the function as having space for improvement in
the first place:
* many parameters, some of which are set as constants on most
call-sites (introduce severalfunction instad)
* boolean param (add two functions instead)
2020-08-19 17:53:41 +02:00
bors[bot]
45c24ae0a5
Merge #5818
...
5818: Some trivial local simiplifications r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 15:42:26 +00:00
Aleksey Kladov
11a1bb1c3e
Inline trivial function
2020-08-19 17:41:56 +02:00
Aleksey Kladov
a9778c6d73
Simplify
2020-08-19 17:37:19 +02:00
Aleksey Kladov
0b62b990ba
Minor
2020-08-19 17:33:25 +02:00
Aleksey Kladov
422ac441c2
Minor cleanups
2020-08-19 17:31:26 +02:00
Aleksey Kladov
5da1dc9a8b
Better name
2020-08-19 17:30:43 +02:00
bors[bot]
a4b7ce94ba
Merge #5817
...
5817: Better API factoring around self access modes
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 15:03:35 +00:00
Aleksey Kladov
61754678fb
Better API factoring around self access modes
2020-08-19 17:02:50 +02:00
bors[bot]
1d19084317
Merge #5816
...
5816: Better error if Cargo is not in Path
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 14:34:36 +00:00
Aleksey Kladov
73f4fcbd0f
Better error if Cargo is not in Path
2020-08-19 16:34:11 +02:00
bors[bot]
22d2e34bf3
Merge #5815
...
5815: Introduce hir::Param
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 14:05:22 +00:00
Aleksey Kladov
70fd542822
Introduce hir::Param
...
We generally shouldn't expose TypeRef out of hir. So, let's just use a
placehoder here.
2020-08-19 16:04:18 +02:00
bors[bot]
e8d266fa6d
Merge #5814
...
5814: Add SelfParam to code_model
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 13:17:05 +00:00
Aleksey Kladov
b9b4693ce3
Add SelfParam to code_model
2020-08-19 15:16:24 +02:00
bors[bot]
422856d70f
Merge #5812
...
5812: Minor cleanups
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 11:51:47 +00:00
Aleksey Kladov
a3b0a3aeb8
Minor cleanups
2020-08-19 13:46:34 +02:00
bors[bot]
63ac896655
Merge #5811
...
5811: Minor
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-19 11:34:29 +00:00
Aleksey Kladov
80ea7f3c81
Minor
2020-08-19 13:33:51 +02:00
bors[bot]
529ca7e5e0
Merge #5643
...
5643: Add new consuming modifier, apply consuming and mutable to methods r=matklad a=Nashenas88
This adds a new `consuming` semantic modifier for syntax highlighters.
This also emits `mutable` and `consuming` in two cases:
- When a method takes `&mut self`, then it now has `function.mutable` emitted.
- When a method takes `self`, and the type of `Self` is not `Copy`, then `function.consuming` is emitted.
CC @flodiebold
Co-authored-by: Paul Daniel Faria <Nashenas88@users.noreply.github.com>
2020-08-19 11:27:02 +00:00
bors[bot]
c1cfd01009
Merge #5809
...
5809: ⬆️ crates
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-18 21:57:52 +00:00
Aleksey Kladov
6b0b9178b3
⬆️ crates
2020-08-18 23:52:29 +02:00
bors[bot]
2a58adf4d3
Merge #5808
...
5808: Make RacyFlag actually work
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-18 21:51:29 +00:00
