I'd like a chance to audit all the code that rustdoc is inserting into
the docs. Currently I am skeptical that showing serde's internal usages
of APIs is a net benefit to the public documentation. I am also
skeptical that quite so many examples are needed, and that they should
be featured so prominently in comparison to handwritten docs. Lastly I
wish there were a way to turn this behavior off on a more granular
basis.
Containers for the most part do not have any trait requirements for
iterating over them. So these bounds are unnecessary when Serializing
only.
This relaxation is part of Rust 1.34
GitHub's default timeout is 6 hours. Recently some of my GitHub Actions
jobs have started randomly stalling for that long, which is inconvenient
because it ties up a chunk of my runner quota. It apepars to be very
rare for a job to recover after stalling. It's better to time out
quicker and retry on a different runner.
warning: lint `clippy::let_underscore_drop` has been renamed to `let_underscore_drop`
--> serde_derive/src/lib.rs:46:5
|
46 | clippy::let_underscore_drop,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `let_underscore_drop`
|
= note: `#[warn(renamed_and_removed_lints)]` on by default
error: dereferencing a tuple pattern where every element takes a reference
--> serde/src/private/de.rs:1813:39
|
1813 | let map = content.iter().map(|&(ref k, ref v)| {
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
= note: `-D clippy::needless-borrowed-reference` implied by `-D clippy::all`
help: try removing the `&` and `ref` parts
|
1813 - let map = content.iter().map(|&(ref k, ref v)| {
1813 + let map = content.iter().map(|(k, v)| {
|
error: dereferencing a tuple pattern where every element takes a reference
--> serde/src/private/de.rs:2110:25
|
2110 | let &(ref variant, ref value) = match iter.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
2110 - let &(ref variant, ref value) = match iter.next() {
2110 + let (variant, value) = match iter.next() {
|
error: dereferencing a tuple pattern where every element takes a reference
--> serde/src/private/de.rs:2257:22
|
2257 | Some(&Content::Seq(ref v)) => {
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
2257 - Some(&Content::Seq(ref v)) => {
2257 + Some(Content::Seq(v)) => {
|
error: dereferencing a tuple pattern where every element takes a reference
--> serde/src/private/de.rs:2280:22
|
2280 | Some(&Content::Map(ref v)) => {
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
2280 - Some(&Content::Map(ref v)) => {
2280 + Some(Content::Map(v)) => {
|
error: dereferencing a tuple pattern where every element takes a reference
--> serde/src/private/de.rs:2283:22
|
2283 | Some(&Content::Seq(ref v)) => {
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
2283 - Some(&Content::Seq(ref v)) => {
2283 + Some(Content::Seq(v)) => {
|
error: dereferencing a tuple pattern where every element takes a reference
--> serde/src/private/de.rs:2406:22
|
2406 | Some(&(ref key, ref value)) => {
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
2406 - Some(&(ref key, ref value)) => {
2406 + Some((key, value)) => {
|
error: dereferencing a tuple pattern where every element takes a reference
--> serde/src/private/ser.rs:528:25
|
528 | for &(ref k, ref v) in entries {
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
528 - for &(ref k, ref v) in entries {
528 + for (k, v) in entries {
|
serde:🇩🇪:format::Buf is a private type, so this makes it explicit by
declaring the type `pub(super)`. In addition, it marks the function
`Buf::as_str` as unsafe, which lets us document the callsites with
`// Safety: ...` comments to explain why it is safe to use.
