Christoph Beberweil
f9c6335a0f
feat: 7125 code snippets are wrapped in backticks
2023-11-24 17:47:31 +01:00
Christoph Beberweil
bce869f0c0
fix: 7125 lint message should start with a small letter
2023-11-24 17:29:03 +01:00
Christoph Beberweil
2512341fe4
feat: 7125 shorten lint text
2023-11-24 10:38:45 +01:00
Christoph Beberweil
c58d692e1f
fix: 7125 update lint applicability to Unspecified
2023-11-24 10:30:19 +01:00
Christoph Beberweil
447edf92b4
suggest alternatives to iterate an array of ranges
...
Co-authored-by: ThinkerDreamer <74881094+ThinkerDreamer@users.noreply.github.com>
2023-11-23 23:07:36 +01:00
Philipp Krones
6fab1485c3
Merge remote-tracking branch 'upstream/master' into rustup
2023-11-16 19:02:04 +01:00
Yudai Fukushima
a9d42e6d6d
fix: reduce [manual_memcpy
] indexing when array length is same to loop range
...
Format
refactor: extract function to shrink function length
fix: remove cmp to calculate range
fix: replace if_chain with let chains
2023-11-14 22:05:44 +09:00
Alex Macleod
13b4bb12ad
Clean up after if chain removal
2023-11-10 18:03:13 +00:00
Alex Macleod
9681b4afe0
Run if-to-let-chain clippy*/**/*.rs
...
https://github.com/Alexendoo/if-to-let-chain
2023-11-10 17:29:28 +00:00
y21
294df80e2c
[unused_enumerate_index
]: don't ICE on empty tuples
2023-11-03 21:13:51 +01:00
bors
2d9af160af
Auto merge of #117507 - nnethercote:rustc_span, r=Nilstrieb
...
`rustc_span` cleanups
Just some things I found while looking over this crate.
r? `@oli-obk`
2023-11-03 14:57:40 +00:00
Philipp Krones
77c1e3aaa1
Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup
2023-11-02 17:35:56 +01:00
Philipp Krones
62a82b361c
Format let-chains across the code base
...
In the updated nightly version, it seems that rustfmt now supports formatting
let-chains. Since we're using them a lot, it's a lot of reformatting.
2023-11-02 17:24:30 +01:00
Nicholas Nethercote
e1ec2d5cc9
Minimize pub
usage in source_map.rs
.
...
Most notably, this commit changes the `pub use crate::*;` in that file
to `use crate::*;`. This requires a lot of `use` items in other crates
to be adjusted, because everything defined within `rustc_span::*` was
also available via `rustc_span::source_map::*`, which is bizarre.
The commit also removes `SourceMap::span_to_relative_line_string`, which
is unused.
2023-11-02 19:35:00 +11:00
Dinu Blanovschi
bb9cc6d47c
refactor: extract common pat_is_wild to clippy_utils
...
This function was previously defined for the iter_kv_map,
for_kw_map, and unused_enumerate_index lints. This commit extracts
it into clippy_utils.
2023-11-01 14:19:23 +01:00
Dinu Blanovschi
14b82909b0
Apply suggestions from code review
...
Co-authored-by: Alejandra González <blyxyas@gmail.com>
2023-10-31 18:21:34 +01:00
Dinu Blanovschi
0b90f72064
feat: unused_enumerate_index lint
2023-10-31 17:53:24 +01:00
Alex Macleod
4622203c9b
Move configuration to new clippy_config
crate
2023-10-23 20:05:10 +00:00
Alex Macleod
7347c1803f
Set existing doc-tests to no_run
2023-10-23 15:28:26 +00:00
Philipp Krones
8e7d1678c4
Merge commit '2b030eb03d9e5837440b1ee0b98c50b97c0c5889' into clippyup
2023-10-21 14:16:11 +02:00
y21
e6f29f1900
dogfood
2023-10-04 18:08:30 +02:00
Philipp Krones
772296c50e
Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup
2023-09-25 11:28:58 +02:00
Alex Macleod
01c25a8eb6
Remove most usage of hir_ty_to_ty
2023-09-20 14:05:00 +00:00
Philipp Krones
471469d30f
Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup
2023-09-12 18:44:06 +02:00
Mario Carneiro
4e0a3465d1
fix vec.rs test, comment
2023-09-04 06:35:51 +02:00
Mario Carneiro
1317378b9e
fix todo item check, remove unimplemented
2023-09-03 17:16:06 +02:00
Mario Carneiro
61a2f972b3
skip todo
/ unimplemented
in never_loop
2023-09-03 01:54:28 -04:00
Mario Carneiro
b3980d8497
catch never loops through diverging functions
2023-09-02 07:51:34 -04:00
Mario Carneiro
39b316db61
an empty match diverges
2023-09-02 07:32:38 -04:00
Mario Carneiro
68011893d8
Rewrite never_loop
as a strict reachability pass
...
fixes #11004
2023-09-02 03:14:19 -04:00
Ben Schofield
be55a96d80
Add config flag for reborrows in explicit_iter_loop
...
This commit adds a config flag for enforcing explicit into iter lint
for reborrowed values. The config flag, enforce_iter_loop_reborrow, can be
added to clippy.toml files to enable the linting behaviour. By default
the lint is not enabled.
2023-08-27 21:45:14 -06:00
Philipp Krones
f730a2655a
Merge commit '1e8fdf492808a25d78a97e1242b835ace9924e4d' into clippyup
2023-08-11 14:05:13 +02:00
Philipp Krones
17b9c42572
Merge remote-tracking branch 'upstream/master' into rustup
2023-08-10 21:15:24 +02:00
Nilstrieb
ed0dfed24f
Improve spans for indexing expressions
...
Indexing is similar to method calls in having an arbitrary
left-hand-side and then something on the right, which is the main part
of the expression. Method calls already have a span for that right part,
but indexing does not. This means that long method chains that use
indexing have really bad spans, especially when the indexing panics and
that span in coverted into a panic location.
This does the same thing as method calls for the AST and HIR, storing an
extra span which is then put into the `fn_span` field in THIR.
2023-08-04 13:17:39 +02:00
Philipp Krones
b0e64a9c09
Merge commit '5436dba826191964ac1d0dab534b7eb6d4c878f6' into clippyup
2023-07-31 23:53:53 +02:00
Jason Newcomb
71cc39e1f2
Add debug assertions to implements_trait
...
Improve debug assertions for `make_projection`
2023-07-30 00:38:04 -04:00
Philipp Krones
3d60241841
Merge remote-tracking branch 'upstream/master' into rustup
2023-07-28 23:44:28 +02:00
Centri3
51b57723d1
new lint redundant_guards
2023-07-22 06:28:05 -05:00
Philipp Krones
d6d530fd0b
Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup
2023-07-17 10:22:32 +02:00
Mahdi Dibaiee
fdb2e363d3
refactor(rustc_middle): Substs -> GenericArg
2023-07-14 13:27:35 +01:00
Philipp Krones
415fdb2d1a
Merge remote-tracking branch 'upstream/master' into rustup
2023-07-14 13:36:16 +02:00
Alex Macleod
2811effe34
Add imports_granularity = "Module"
to rustfmt.toml
2023-07-13 12:44:57 +00:00
xFrednet
31397b489a
Update version attribute for 1.71 lints
2023-07-11 19:23:42 +02:00
Boxy
cbe468222a
Move TyCtxt::mk_x
to Ty::new_x
where applicable
2023-07-05 20:27:07 +01:00
Philipp Krones
cb3ecf7b79
Merge commit '37f4c1725d3fd7e9c3ffd8783246bc5589debc53' into clippyup
2023-07-02 14:59:02 +02:00
Samuel Moelius
420f3d11e8
"try this" -> "try"
2023-07-01 07:08:01 -04:00
Philipp Krones
8010c3462d
Merge remote-tracking branch 'upstream/master' into rustup
2023-06-30 16:09:06 +02:00
Maybe Waffle
555bd985d2
Support hir::ExprKind::Become
in clippy
2023-06-26 08:56:32 +00:00
Catherine
6a1084c26f
Check if if
conditions always evaluate to true in never_loop
2023-06-22 04:31:05 -05:00
Jason Newcomb
949712c90a
Reborrow mutable references in explicit_iter_loop
2023-06-09 21:40:03 -04:00