bors
06722c0c15
Auto merge of #7775 - F3real:no_effect, r=xFrednet
...
Detect underscored variables with no side effects
Fixes #7545
changelog: Lint on underscored variables with no side effects in [`no_effect`]
2021-10-20 09:33:45 +00:00
F3real
6b22bba902
Lint on underscore variable assignment
...
Fix tests after no_effect update
Add a drop testcase
Don't lint _ variables in macro expansion
Address review comments and update tests
Don't shadow unnecessary operation lint if no_effect is allowed
Revert shadowing change and remove no_effect allows
Update clippy_lints/src/no_effect.rs
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Update clippy_lints/src/no_effect.rs
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Address review comments
2021-10-20 00:39:28 +02:00
Samuel E. Moelius III
c9599d79a3
Add format_in_format_args
and to_string_in_format_args
lints
...
Fixes #7667 and #7729
2021-10-15 12:44:38 -04:00
bors
b9b11a96d2
Auto merge of #7805 - aDotInTheVoid:transmute-num-bits, r=camsteffen
...
Add lint transmute_num_to_bytes
Closes #7803
changelog: [`transmute_num_to_bytes`] new lint
2021-10-13 19:40:33 +00:00
Nixon Enraght-Moony
58969807ab
Add lint transmute_num_to_bytes
...
Closes #7803
changelog: [`transmute_num_to_bytes`] new lint
2021-10-13 20:05:05 +01:00
bors
3d9c4a655b
Auto merge of #7682 - Qwaz:uninit_vec, r=xFrednet
...
Implement uninit_vec lint
changelog: add the new lint [`uninit_vec`]
Fix #7681
2021-10-12 21:04:13 +00:00
Serial
9e0ce14700
Add match_str_case_mismatch lint
2021-10-11 20:19:34 -04:00
Yechan Bae
452181c69d
Implement uninit_vec lint
2021-10-09 05:38:19 -04:00
Serial
412b862fba
Add undocumented_unsafe_blocks lint
2021-10-07 17:06:21 -04:00
Michael Sproul
fbd0fb9aed
Restriction lint for function pointer casts
2021-10-07 09:11:47 -05:00
hkalbasi
388a3d0983
Implement equatable if let lint
2021-10-04 22:16:42 +03:30
Yechan Bae
fb0353b28d
Update documentation and name for non_send_fields_in_send_ty lint
2021-10-02 19:22:37 -04:00
Yechan Bae
e4c3000e5b
Initial implementation
2021-10-01 14:04:20 -04:00
bors
08cead31a1
Auto merge of #7727 - flip1995:changelog, r=xFrednet
...
Update changelog to 1.56
As expected a pretty short changelog, because of the missed sync last release cycle.
[Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md )
changelog: none
2021-09-28 10:27:47 +00:00
flip1995
7f11e5a914
Fix CHANGELOG formatting
2021-09-28 11:08:40 +01:00
Andrew Pollack
b6ffb29315
Adjusting changelog
2021-09-27 22:23:17 -07:00
Andrew Pollack
9a3ccd8547
Removed value from changelog to get pass
2021-09-27 22:23:17 -07:00
Andrew Pollack
b7d40bc103
Adding new linting
2021-09-27 22:23:17 -07:00
flip1995
46f8aa9c31
Update changelog to 1.56
2021-09-27 11:59:33 +02:00
Labelray
543b638dbe
Add new lint if_then_panic
2021-09-24 22:14:20 +08:00
F3real
bb971e0f58
Add missing reference to box_vec
2021-09-22 20:06:03 +02:00
F3real
63ed2f9eb4
Expand BOX_VEC to BOX_COLLECTION
2021-09-20 10:23:55 +02:00
lengyijun
e2cdaec984
same_name_method
2021-09-14 09:20:27 +08:00
Labelray
8f88acdbfa
add new lint iter_not_returning_iterator
2021-09-09 09:21:38 +08:00
bors
7a0d7d8283
Auto merge of #7596 - lengyijun:option_needless_deref, r=llogiq
...
New lint: option_needless_deref
changelog: [`option_needless_deref`]
fix #7571
2021-09-05 18:11:56 +00:00
hamidreza kalbasi
8221f9e795
add derivable impls lint
2021-09-05 01:25:59 +04:30
lengyijun
4184cc369a
needless_option_as_deref
2021-09-04 22:18:23 +08:00
flip1995
c7c2036cb9
Fix remaining dogfood errors
...
Except for the missing docs ones
2021-09-02 12:40:52 +01:00
flip1995
61bb96738c
Merge remote-tracking branch 'upstream/master' into rustup2
2021-09-02 12:38:17 +01:00
bors
de80188c64
Auto merge of #7543 - DevinR528:disallowed-mod, r=Manishearth
...
Add module_style lint to style
changelog: Add new [`module_style`] style lint
This is a configurable (no mod file/mod file) lint that determines if `mod.rs` is used consistently or if `mod.rs` is never used (using the new mod layout).
2021-08-25 15:20:28 +00:00
Devin Ragotzy
31738b1da3
Add module_style lint to restriction
...
Add tests for disallowed_mod in ui-cargo test section
Use correct algorithm to determine if mod.rs is missing
Move to two lints and remove config option
Switch lint names so they read "warn on ..."
Emit the same help info for self_named_mod_file warnings
Bail when both lints are Allow
Reword help message for both module_style lints
2021-08-24 15:53:58 -04:00
bors
22606e7358
Auto merge of #7539 - Labelray:master, r=camsteffen
...
Add new lint `negative_feature_names` and `redundant_feature_names`
Add new lint [`negative_feature_names`] to detect feature names with prefixes `no-` or `not-` and new lint [`redundant_feature_names`] to detect feature names with prefixes `use-`, `with-` or suffix `-support`
changelog: Add new lint [`negative_feature_names`] and [`redundant_feature_names`]
2021-08-23 13:56:18 +00:00
Labelray
0a021d5900
Add new lints negative_feature_names
and redundant_feature_names
2021-08-23 21:05:44 +08:00
Jason Newcomb
a7f376fbd3
Add lint manual_split_once
2021-08-16 09:34:58 -04:00
flip1995
1ad5464200
Merge commit '7bfc26ec8e7a454786668e7e52ffe527fc649735' into clippyup
2021-08-12 11:16:25 +02:00
Jade
11ef04728c
Add unwrap_or_else_default lint
...
This will catch `unwrap_or_else(Default::default)` on Result and Option
and suggest `unwrap_or_default()` instead.
2021-08-10 14:40:26 -07:00
Fridtjof Stoldt
35a74a1a6b
Updated config value name in changelog for 1.54
2021-07-29 16:26:26 +02:00
xFrednet
fdf29c04ae
Updated changelog for 1.55
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
2021-07-29 13:58:15 +02:00
flip1995
2b20f49841
Merge commit '0cce3f643bfcbb92d5a1bb71858c9cbaff749d6b' into clippyup
2021-07-29 12:16:06 +02:00
flip1995
54e539121d
Rename two lints to comply with our lint naming convention
...
self_named_constructor -> self_named_constructors
append_instead_of_extend -> extend_with_drain
2021-07-29 12:10:18 +02:00
flip1995
884ef4c287
Merge commit '4c41a222ca5d1325fb4b6709395bd06e766cc042' into clippyup
2021-07-19 11:52:05 +02:00
bors
f70a07454b
Auto merge of #7403 - Anthuang:redundant-method-names, r=Manishearth
...
New lint: [`self_named_constructor`]
Adds the `self_named_constructor` lint for detecting when an implemented method has the same name as the type it is implemented for.
changelog: [`self_named_constructor`]
closes : #7142
2021-07-19 06:49:51 +00:00
flip1995
1d084b13a5
Merge commit '54a20a02ecd0e1352a871aa0990bcc8b8b03173e' into clippyup
2021-07-15 10:44:10 +02:00
flip1995
69fbd64e2a
Merge remote-tracking branch 'upstream/master' into rustup
2021-07-15 10:32:06 +02:00
Ryan Levick
30c5c2ff03
Add s to non_fmt_panic
2021-07-06 20:12:56 +02:00
Anthony Huang
357a8f0344
Add redundant_method_names lint
2021-07-05 14:15:20 -04:00
Mateusz Gacek
59a164e86c
Add new lint: strlen_on_c_strings
2021-07-05 11:10:45 +02:00
bors
84209994ad
Auto merge of #7316 - lengyijun:rc_mutex, r=llogiq
...
Add new lint: `rc_mutex`
changelog: Add new lint `rc_mutex`.
It lints on `Rc<Mutex<T>>`.
`Rc<Mutex<T>>` should be corrected to `Rc<RefCell<T>>`
2021-07-03 10:26:03 +00:00
flip1995
ebe52869a3
Merge commit '61eb38aeda6cb54b93b872bf503d70084c4d621c' into clippyup
2021-07-01 18:17:38 +02:00
Igor Aleksanov
018be41dee
Implement 'disallowed_script_idents' lint
2021-06-30 19:06:33 +03:00