Aleksey Kladov
b45dd9ef54
Use the same abstraction for attrs and docs
...
Doc comments *are* attributes, so there's no reason to have two crates
here.
2020-08-25 12:13:31 +02:00
bors[bot]
59c77ff062
Merge #5866
...
5866: Improve logging
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 09:46:21 +00:00
Aleksey Kladov
3a72afed8c
Improve logging
2020-08-25 11:43:21 +02:00
bors[bot]
ed51f5b424
Merge #5865
...
5865: Rename rust_analyzer lib in the binaries before publishing r=matklad a=pksunkara
@matklad Tested and working with publish dry run. Please run the action manually once merged.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-08-25 09:40:36 +00:00
Pavan Kumar Sunkara
2d75b3305d
Rename rust_analyzer lib in the binaries before publishing
2020-08-25 11:32:22 +02:00
bors[bot]
96cbad9fb5
Merge #4873
...
4873: Resolve links in hover documentation r=matklad a=zacps
This PR resolves links in hover documentation. Both the upcoming intra-doc-links style and the old "path-based" style.
## Todo
* [x] More tests
* [ ] Benchmark (Is there an easy way to benchmark this?)
* [x] ~~Resolve issues with the markdown parser/get rid of it~~ Migrate to `pulldown_cmark_to_cmark`
* [x] Reorganise code (Tips appreciated)
---
Fixes #503
Co-authored-by: Zac Pullar-Strecker <zacmps@gmail.com>
2020-08-25 09:11:26 +00:00
bors[bot]
b4bc346498
Merge #5863
...
5863: Cleanup invert-if
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 09:01:12 +00:00
Aleksey Kladov
7721accebf
Cleanup invert-if
...
* stick to trivial factory functions in make
* compress the logic for inverting Option/Result
2020-08-25 11:00:32 +02:00
Zac Pullar-Strecker
b835f06cec
Merge remote-tracking branch 'upstream/master' into 503-hover-doc-links
2020-08-25 16:44:36 +12:00
Zac Pullar-Strecker
452afaebe1
Changes from review
2020-08-25 16:40:43 +12:00
bors[bot]
ef9cea945d
Merge #5861
...
5861: Support extern types r=matklad a=jonas-schievink
This is a currently unstable feature tracked at https://github.com/rust-lang/rust/issues/43467
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2020-08-24 20:10:16 +00:00
Jonas Schievink
f3ac19e8cd
Support extern types
2020-08-24 22:02:55 +02:00
bors[bot]
ed09bd3cc6
Merge #5859
...
5859: Allow rust-analyzer auto publishing r=matklad a=pksunkara
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-08-24 15:31:25 +00:00
Pavan Kumar Sunkara
b2d43daeb4
Allow rust-analyzer auto publishing
2020-08-24 17:27:17 +02:00
bors[bot]
d7f4711321
Merge #5841
...
5841: Gate stream.pipeline workaround on fixed versions of node r=matklad a=Veetaha
Fixes the symptom of https://github.com/cdr/code-server/issues/1810
Original report here: https://github.com/rust-analyzer/rust-analyzer/issues/3167#issuecomment-678390564
Thanks to @hjfreyer for precise investigation :D
Co-authored-by: Veetaha <veetaha2@gmail.com>
2020-08-24 14:33:35 +00:00
bors[bot]
81fa00c5b5
Merge #5733
...
5733: Fix expand glob import bugs r=matklad a=unexge
fixes https://github.com/rust-analyzer/rust-analyzer/issues/5709
TODOs:
- [x] Incorrect node replacing
<details>
<summary>Details</summary>
```rust
use crate::{
body::scope::{ExprScopes, ScopeId},
body::Body,
builtin_type::BuiltinType,
db::DefDatabase,
expr::{ExprId, PatId},
generics::GenericParams,
item_scope::{BuiltinShadowMode, BUILTIN_SCOPE},
nameres::CrateDefMap,
path::*<|>,
per_ns::PerNs,
visibility::{RawVisibility, Visibility},
AdtId, AssocContainerId, ConstId, ContainerId, DefWithBodyId, EnumId, EnumVariantId,
FunctionId, GenericDefId, HasModule, ImplId, LocalModuleId, Lookup, ModuleDefId, ModuleId,
StaticId, StructId, TraitId, TypeAliasId, TypeParamId, VariantId,
};
```
becames
```rust
use crate::{PathKind, name, name, ModPath};
```
</details>
- [x] Ignoring visibility
<details>
<summary>Details</summary>
```rust
mod foo {
mod bar {
pub struct Bar;
}
}
use foo::bar::*;
fn baz(bar: Bar) {}
```
becames
```rust
mod foo {
mod bar {
pub struct Bar;
}
}
use foo::bar::Bar;
fn baz(bar: Bar) {}
```
although mod `bar` is private
</details>
- [x] Eating attributes
Co-authored-by: unexge <unexge@gmail.com>
2020-08-24 14:26:33 +00:00
bors[bot]
3aa35e2845
Merge #5855
...
5855: Add TBD description to arena r=matklad a=pksunkara
Sorry I missed this, @matklad. Please run manually again once this is merged.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-08-24 11:39:56 +00:00
Pavan Kumar Sunkara
63f63acc7c
Add TBD description to arena
2020-08-24 13:29:10 +02:00
bors[bot]
31cb13dde8
Merge #4776
...
4776: Do a weekly minor publish to crates.io r=matklad a=pksunkara
This is the same system I set up on Chalk repo.
Every week it creates a new minor version, pushes it to github and then deploys it to crates.io.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-08-24 11:14:45 +00:00
bors[bot]
150e3843b0
Merge #5845
...
5845: Omit lenses for not runnable doctests r=matklad a=SomeoneToIgnore
Ideally, we should properly parse the doctest attributes before, but since I need it for the code lens only, this way should suffice for now
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
2020-08-24 11:08:11 +00:00
Pavan Kumar Sunkara
335add49db
Add description for crates that will be published
2020-08-24 13:07:22 +02:00
Pavan Kumar Sunkara
35fd9a8e0b
Added weekly publish workflow
2020-08-24 13:07:17 +02:00
bors[bot]
b00702b738
Merge #5851
...
5851: Invert if should be smart about is_some, is_none, is_ok, is_err r=matklad a=dragfire
Fixes #5827
Co-authored-by: dragfire <asem.devajit@gmail.com>
2020-08-24 11:01:56 +00:00
bors[bot]
951c7c157a
Merge #5852
...
5852: Add Early Return rule to style r=matklad a=matklad
bors r+
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-24 10:56:04 +00:00
bors[bot]
6eddcfd7a5
Merge #5853
...
5853: Avoid monomorphization
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-24 10:50:04 +00:00
Aleksey Kladov
fc3e591bdb
Avoid monomorphization
2020-08-24 12:49:36 +02:00
Aleksey Kladov
d7ece3028d
Add Early Return rule to style
2020-08-24 12:22:28 +02:00
Zac Pullar-Strecker
5452368fad
Renames, comments, and dead code removal
2020-08-24 21:50:30 +12:00
Zac Pullar-Strecker
7bbca7a1b3
Merge remote-tracking branch 'upstream/master' into 503-hover-doc-links
2020-08-24 21:20:13 +12:00
Pavan Kumar Sunkara
a8fa5cd42e
Add version to deps in cargo.toml
2020-08-24 11:10:41 +02:00
Zac Pullar-Strecker
ca464650ee
Add a test to document unimplemented case
2020-08-24 20:47:10 +12:00
Zac Pullar-Strecker
4f5f608b49
Reorganise code
2020-08-24 20:26:45 +12:00
dragfire
1d129a7172
Invert if should be smart about is_some, is_none, is_ok, is_err
2020-08-23 22:30:34 -06:00
Kirill Bulatov
cdd75a699a
Omit lenses for not runnable doctests
2020-08-22 22:03:02 +03:00
bors[bot]
e65d48d1fb
Merge #5823
...
5823: Don't underline function definition if self is &mut r=Nashenas88 a=matklad
The self is right there, and is already underlined, so it makes little
sense to emit even more underlines.
before:
![before](https://user-images.githubusercontent.com/1711539/90672843-0d379500-e257-11ea-840f-b0caed4410f1.png )
after:
![after](https://user-images.githubusercontent.com/1711539/90672840-0c9efe80-e257-11ea-9739-23af433841c6.png )
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-22 14:41:17 +00:00
bors[bot]
d7466c9f9e
Merge #5839
...
5839: Dont ask me why... r=kjeremy a=Veetaha
Co-authored-by: Veetaha <veetaha2@gmail.com>
2020-08-21 19:47:22 +00:00
Veetaha
74ed42c8e9
Gate stream.pipeline workaround on fixed versions of node
2020-08-21 22:15:04 +03:00
Veetaha
54d4bc2622
Dont ask me why...
2020-08-21 21:14:40 +03:00
bors[bot]
aab5aaccf2
Merge #5838
...
5838: ⬆️ autocfg
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-21 17:15:09 +00:00
Aleksey Kladov
95f33bb5f7
⬆️ autocfg
2020-08-21 19:14:44 +02:00
Aleksey Kladov
863b1fb731
⬆️ ungrammar
2020-08-21 19:14:05 +02:00
bors[bot]
df54561a68
Merge #5835
...
5835: Switch to expect_test from crates.io
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-21 11:21:05 +00:00
Aleksey Kladov
b0fd3faf36
Switch to expect_test from crates.io
2020-08-21 13:19:31 +02:00
Aleksey Kladov
66e0c9f840
Remove expect crate
2020-08-21 13:15:56 +02:00
unexge
ef54e8451d
Use new Definition::usages
API in expand glob import
2020-08-20 21:35:47 +03:00
unexge
5cff4b60be
Fix importing private modules in expand glob import
2020-08-20 21:34:53 +03:00
unexge
5d28dec7b9
Fix importing unused traits in expand glob import
2020-08-20 21:34:53 +03:00
unexge
585f5d4901
Use fixme instead of todo
2020-08-20 21:34:53 +03:00
unexge
0847bc801e
Use Definition::find_usages
for finding used items in expand glob import
2020-08-20 21:34:53 +03:00
unexge
11d048af03
Run rustfmt
2020-08-20 21:34:53 +03:00