Aleksey Kladov
4f6ca0e081
Minor
2020-08-25 18:07:25 +02:00
bors[bot]
33c4afeae0
Merge #5880
...
5880: Opportunistically check indel overlap r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 16:01:47 +00:00
Aleksey Kladov
7239d8ca95
Provide better stack trace for overlapping edits
...
Overlapping indels are a bug. Checking this *always* is tricky (needs
a sorted data structure to not suffer O(N^2) perf). But
opportunistically checking small indels should give provide 80% of the
benefits.
2020-08-25 17:59:37 +02:00
Rüdiger Herrmann
3dbe062741
Update mentions of 'ra_vfs' in architecture doc
...
Adjust the paragraph about `ra_vfs` to point to the `vfs` crate that is used now.
2020-08-25 17:57:29 +02:00
bors[bot]
3f721683de
Merge #5878
...
5878: Prepare to share sysroot lowering code between Cargo & ProjectJSON
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 15:54:05 +00:00
Aleksey Kladov
7fcda5aa46
Prepare to share sysroot lowering code between Cargo & ProjectJSON
2020-08-25 17:53:24 +02:00
bors[bot]
32be2d60af
Merge #5877
...
5877: Complete `pub` in fields
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 15:23:16 +00:00
Aleksey Kladov
18b667cfcb
Complete pub
in fields
2020-08-25 17:22:23 +02:00
bors[bot]
ad7e7d6b8e
Merge #5876
...
5876: Prep work for overriding sysroot
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 15:04:47 +00:00
Aleksey Kladov
6b8bc132dc
Prep work for overriding sysroot
...
The idea here is to make auto-discovery optional, and to allow to set
the path to sysroot directly. This is handy for JSON projects.
2020-08-25 17:04:24 +02:00
bors[bot]
81a3404d8f
Merge #5875
...
5875: Remove monomorphisation from doclinks resolving code
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 12:59:22 +00:00
Aleksey Kladov
cd9ecdf467
Remove monomorphisation from doclinks resolving code
2020-08-25 14:58:22 +02:00
bors[bot]
2441e8eaaf
Merge #5873
...
5873: Correct sed replacement when called in a bash file r=matklad a=pksunkara
There's so much trial and error regarding shells and stuff I needed to do to get this correctly working on github runner.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-08-25 12:51:28 +00:00
bors[bot]
34754bd0e2
Merge #5874
...
5874: Remove AttrDef
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 12:45:02 +00:00
Aleksey Kladov
66e5ced894
Remove AttrDef
2020-08-25 14:44:15 +02:00
Pavan Kumar Sunkara
6d46583f0f
Correct sed replacement when called in a bash file
2020-08-25 14:43:22 +02:00
bors[bot]
8a845eda7b
Merge #5870
...
5870: Move code_model attrs to a new module r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 10:58:27 +00:00
Aleksey Kladov
7487885309
Simplify
2020-08-25 12:58:00 +02:00
Aleksey Kladov
575fb9ab6a
Move attrs from code_module to a separate module
2020-08-25 12:56:01 +02:00
bors[bot]
463d44075f
Merge #5869
...
5869: Minor
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 10:48:51 +00:00
Aleksey Kladov
663749beab
Minor
2020-08-25 12:48:00 +02:00
bors[bot]
4f91478e50
Merge #5867
...
5867: Use the same abstraction for attrs and docs
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 10:14:45 +00:00
Aleksey Kladov
b45dd9ef54
Use the same abstraction for attrs and docs
...
Doc comments *are* attributes, so there's no reason to have two crates
here.
2020-08-25 12:13:31 +02:00
bors[bot]
59c77ff062
Merge #5866
...
5866: Improve logging
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 09:46:21 +00:00
Aleksey Kladov
3a72afed8c
Improve logging
2020-08-25 11:43:21 +02:00
bors[bot]
ed51f5b424
Merge #5865
...
5865: Rename rust_analyzer lib in the binaries before publishing r=matklad a=pksunkara
@matklad Tested and working with publish dry run. Please run the action manually once merged.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-08-25 09:40:36 +00:00
Pavan Kumar Sunkara
2d75b3305d
Rename rust_analyzer lib in the binaries before publishing
2020-08-25 11:32:22 +02:00
bors[bot]
96cbad9fb5
Merge #4873
...
4873: Resolve links in hover documentation r=matklad a=zacps
This PR resolves links in hover documentation. Both the upcoming intra-doc-links style and the old "path-based" style.
## Todo
* [x] More tests
* [ ] Benchmark (Is there an easy way to benchmark this?)
* [x] ~~Resolve issues with the markdown parser/get rid of it~~ Migrate to `pulldown_cmark_to_cmark`
* [x] Reorganise code (Tips appreciated)
---
Fixes #503
Co-authored-by: Zac Pullar-Strecker <zacmps@gmail.com>
2020-08-25 09:11:26 +00:00
bors[bot]
b4bc346498
Merge #5863
...
5863: Cleanup invert-if
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 09:01:12 +00:00
Aleksey Kladov
7721accebf
Cleanup invert-if
...
* stick to trivial factory functions in make
* compress the logic for inverting Option/Result
2020-08-25 11:00:32 +02:00
Zac Pullar-Strecker
b835f06cec
Merge remote-tracking branch 'upstream/master' into 503-hover-doc-links
2020-08-25 16:44:36 +12:00
Zac Pullar-Strecker
452afaebe1
Changes from review
2020-08-25 16:40:43 +12:00
bors[bot]
ef9cea945d
Merge #5861
...
5861: Support extern types r=matklad a=jonas-schievink
This is a currently unstable feature tracked at https://github.com/rust-lang/rust/issues/43467
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2020-08-24 20:10:16 +00:00
Jonas Schievink
f3ac19e8cd
Support extern types
2020-08-24 22:02:55 +02:00
bors[bot]
ed09bd3cc6
Merge #5859
...
5859: Allow rust-analyzer auto publishing r=matklad a=pksunkara
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-08-24 15:31:25 +00:00
Pavan Kumar Sunkara
b2d43daeb4
Allow rust-analyzer auto publishing
2020-08-24 17:27:17 +02:00
bors[bot]
d7f4711321
Merge #5841
...
5841: Gate stream.pipeline workaround on fixed versions of node r=matklad a=Veetaha
Fixes the symptom of https://github.com/cdr/code-server/issues/1810
Original report here: https://github.com/rust-analyzer/rust-analyzer/issues/3167#issuecomment-678390564
Thanks to @hjfreyer for precise investigation :D
Co-authored-by: Veetaha <veetaha2@gmail.com>
2020-08-24 14:33:35 +00:00
bors[bot]
81fa00c5b5
Merge #5733
...
5733: Fix expand glob import bugs r=matklad a=unexge
fixes https://github.com/rust-analyzer/rust-analyzer/issues/5709
TODOs:
- [x] Incorrect node replacing
<details>
<summary>Details</summary>
```rust
use crate::{
body::scope::{ExprScopes, ScopeId},
body::Body,
builtin_type::BuiltinType,
db::DefDatabase,
expr::{ExprId, PatId},
generics::GenericParams,
item_scope::{BuiltinShadowMode, BUILTIN_SCOPE},
nameres::CrateDefMap,
path::*<|>,
per_ns::PerNs,
visibility::{RawVisibility, Visibility},
AdtId, AssocContainerId, ConstId, ContainerId, DefWithBodyId, EnumId, EnumVariantId,
FunctionId, GenericDefId, HasModule, ImplId, LocalModuleId, Lookup, ModuleDefId, ModuleId,
StaticId, StructId, TraitId, TypeAliasId, TypeParamId, VariantId,
};
```
becames
```rust
use crate::{PathKind, name, name, ModPath};
```
</details>
- [x] Ignoring visibility
<details>
<summary>Details</summary>
```rust
mod foo {
mod bar {
pub struct Bar;
}
}
use foo::bar::*;
fn baz(bar: Bar) {}
```
becames
```rust
mod foo {
mod bar {
pub struct Bar;
}
}
use foo::bar::Bar;
fn baz(bar: Bar) {}
```
although mod `bar` is private
</details>
- [x] Eating attributes
Co-authored-by: unexge <unexge@gmail.com>
2020-08-24 14:26:33 +00:00
bors[bot]
3aa35e2845
Merge #5855
...
5855: Add TBD description to arena r=matklad a=pksunkara
Sorry I missed this, @matklad. Please run manually again once this is merged.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-08-24 11:39:56 +00:00
Pavan Kumar Sunkara
63f63acc7c
Add TBD description to arena
2020-08-24 13:29:10 +02:00
bors[bot]
31cb13dde8
Merge #4776
...
4776: Do a weekly minor publish to crates.io r=matklad a=pksunkara
This is the same system I set up on Chalk repo.
Every week it creates a new minor version, pushes it to github and then deploys it to crates.io.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-08-24 11:14:45 +00:00
bors[bot]
150e3843b0
Merge #5845
...
5845: Omit lenses for not runnable doctests r=matklad a=SomeoneToIgnore
Ideally, we should properly parse the doctest attributes before, but since I need it for the code lens only, this way should suffice for now
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
2020-08-24 11:08:11 +00:00
Pavan Kumar Sunkara
335add49db
Add description for crates that will be published
2020-08-24 13:07:22 +02:00
Pavan Kumar Sunkara
35fd9a8e0b
Added weekly publish workflow
2020-08-24 13:07:17 +02:00
bors[bot]
b00702b738
Merge #5851
...
5851: Invert if should be smart about is_some, is_none, is_ok, is_err r=matklad a=dragfire
Fixes #5827
Co-authored-by: dragfire <asem.devajit@gmail.com>
2020-08-24 11:01:56 +00:00
bors[bot]
951c7c157a
Merge #5852
...
5852: Add Early Return rule to style r=matklad a=matklad
bors r+
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-24 10:56:04 +00:00
bors[bot]
6eddcfd7a5
Merge #5853
...
5853: Avoid monomorphization
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-24 10:50:04 +00:00
Aleksey Kladov
fc3e591bdb
Avoid monomorphization
2020-08-24 12:49:36 +02:00
Aleksey Kladov
d7ece3028d
Add Early Return rule to style
2020-08-24 12:22:28 +02:00
Zac Pullar-Strecker
5452368fad
Renames, comments, and dead code removal
2020-08-24 21:50:30 +12:00