bors[bot]
6fccb152b4
Merge #8746
...
8746: Don't store call-site text offsets in hygiene info r=matklad a=jonas-schievink
This threads a lot more database references around in order to avoid storing a bare `TextOffset` in the hygiene info. This `TextOffset` made hygiene info and `ItemTree`s more volatile than they should be, leading to excessive recomputation of `ItemTree`s.
The incremental test added in https://github.com/rust-analyzer/rust-analyzer/pull/8721 is now passing with these changes.
closes https://github.com/rust-analyzer/rust-analyzer/pull/8721
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-05-06 21:53:05 +00:00
Jonas Schievink
20ae41c1a1
Reuse database in LowerCtx
2021-05-06 23:23:50 +02:00
Aleksey Kladov
c4f9cb9b53
Update crates/hir_def/src/nameres/tests/incremental.rs
...
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2021-05-06 20:00:43 +02:00
Aleksey Kladov
548e5a5c29
internal: add failing incremental test
2021-05-06 20:00:11 +02:00
Jonas Schievink
976a3226fe
Don't store call-site text offsets in hygiene info
2021-05-06 19:59:54 +02:00
bors[bot]
b37b709459
Merge #8718
...
8718: 1.52.0 r=SomeoneToIgnore a=matklad
A lot of APIs we use in this release!
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
2021-05-06 17:29:30 +00:00
Kirill Bulatov
607d8a2f61
Small macro fix
2021-05-06 20:12:30 +03:00
Aleksey Kladov
6a16ec52aa
internal: use API stabilized in 1.52
2021-05-06 20:12:15 +03:00
Lukas Tobias Wirth
d97a4b8e49
Support goto_type_definition for types
2021-05-06 17:05:49 +02:00
bors[bot]
3b4d5df840
Merge #8744
...
8744: minor: simplify r=edwin0cheng a=edwin0cheng
cc #8742
bors r+
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2021-05-06 14:48:16 +00:00
bors[bot]
6e99f42f30
Merge #8743
...
8743: internal: explain why sentence-per-line r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-05-06 14:41:14 +00:00
Aleksey Kladov
d4a51241ce
internal: explain why sentence-per-line
2021-05-06 17:40:36 +03:00
Edwin Cheng
1fb20e3231
Simplify
2021-05-06 22:39:51 +08:00
bors[bot]
65bdf84bea
Merge #8742
...
8742: fix: Do not overwrite comments and attrs in trait impl completion r=Veykril a=Jesse-Bakker
Fixes #8739
Co-authored-by: Jesse Bakker <github@jessebakker.com>
2021-05-06 14:26:26 +00:00
Jesse Bakker
10254b5d95
Fix: Do not overwrite comments and attrs in trait impl completion
2021-05-06 16:16:38 +02:00
Dawer
90a5dca0a2
Fix build
2021-05-06 10:22:51 +05:00
Dawer
0a156c80af
Hide implementation details of TokenText
2021-05-06 10:07:06 +05:00
Dawer
d9b4ac8128
Clean up
2021-05-06 10:07:06 +05:00
Dawer
d7e169fe55
Borrow text from nodes of immutable syntax trees
2021-05-06 10:07:06 +05:00
Dawer
dc4fa504ea
Adapt to a new rowan borrowing node API.
2021-05-06 10:06:52 +05:00
Dawer
52143f389f
Update to rowan 0.13.0-pre.5
2021-05-06 10:04:39 +05:00
bors[bot]
c3596371d8
Merge #8674
...
8674: fix for #8664 : Emit folding ranges for multi-line where clauses r=matklad a=m5tfi
#8664
I added a test that assert folding multi-line where clauses while leaving single lined one. Please, let me know if the code needs further improvements.
Co-authored-by: m5tfi <72708423+m5tfi@users.noreply.github.com>
2021-05-05 21:14:12 +00:00
bors[bot]
b10d5e342c
Merge #8736
...
8736: Update salsa r=jonas-schievink a=jonas-schievink
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2021-05-05 21:03:50 +00:00
Jonas Schievink
851bd2a32b
Update salsa
2021-05-05 23:00:29 +02:00
bors[bot]
ecc722de40
Merge #8735
...
8735: simplify r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Tobias Wirth <lukastw97@gmail.com>
2021-05-05 20:56:42 +00:00
Lukas Tobias Wirth
3f796fea9f
simplify
2021-05-05 22:55:12 +02:00
m5tfi
c2cf34db90
remove unneeded visited_where_clauses
2021-05-05 06:28:41 +02:00
bors[bot]
957760a47f
Merge #8733
...
8733: Add some cov marks for qualified_path completion r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Tobias Wirth <lukastw97@gmail.com>
2021-05-04 20:36:26 +00:00
Lukas Tobias Wirth
d26fb188c1
Add some cov marks for qualified_path completion
2021-05-04 22:35:37 +02:00
bors[bot]
5b663f1b07
Merge #8732
...
8732: internal: refactor expansion queries r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-05-04 19:42:30 +00:00
Aleksey Kladov
1ea4dae596
Document expansion queries
2021-05-04 22:41:46 +03:00
Aleksey Kladov
3f6980e4e1
simplify macro expansion code
...
Using `Option` arguments such that you always pass `None` or `Some` at
the call site is a code smell.
2021-05-04 22:41:46 +03:00
Aleksey Kladov
95dc8ef265
make illegal states unrepresentable
...
only declarative macros have def-site token map
2021-05-04 22:41:43 +03:00
Aleksey Kladov
7d9ea39de6
Cleanups
2021-05-04 22:40:59 +03:00
bors[bot]
010e4c8fe0
Merge #8731
...
8731: Complete enum variants through type aliases r=Veykril a=Veykril
Fixes #8730
bors r+
Co-authored-by: Lukas Tobias Wirth <lukastw97@gmail.com>
2021-05-04 19:05:19 +00:00
Lukas Tobias Wirth
8b94bf7b2d
Complete enum variants through type aliases
2021-05-04 21:04:19 +02:00
bors[bot]
e17748e4b2
Merge #8727
...
8727: minor: use standard import style r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-05-04 17:37:09 +00:00
Aleksey Kladov
2e97dbcbb8
minor: use standard import style
2021-05-04 20:36:48 +03:00
bors[bot]
5e87f84211
Merge #8726
...
8726: internal: reduce visibility r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-05-04 17:29:55 +00:00
Aleksey Kladov
87f827bfaf
internal: reduce visibility
2021-05-04 20:29:30 +03:00
bors[bot]
871bc1cd08
Merge #8725
...
8725: internal: env var to toggle slow benches r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-05-04 15:31:10 +00:00
Aleksey Kladov
a1f42ef8ad
internal: env var to toggle slow benches
2021-05-04 18:21:36 +03:00
bors[bot]
ff78f3a56d
Merge #8724
...
8724: minor: unconfuse myself about macro def vs macro rules r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-05-04 15:20:38 +00:00
Aleksey Kladov
16f7c3ea91
minor: unconfuse myself about macro def vs macro rules
2021-05-04 18:20:10 +03:00
bors[bot]
a231da9d24
Merge #8720
...
8720: internal: add integrated completion benchmark r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-05-04 12:14:56 +00:00
Aleksey Kladov
b2f040fc9a
internal: add integrated completion benchmark
2021-05-04 15:14:33 +03:00
bors[bot]
d9f1b5fc7c
Merge #8719
...
8719: Fix block comment intra doc link injection ranges r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Tobias Wirth <lukastw97@gmail.com>
2021-05-04 12:00:30 +00:00
Lukas Tobias Wirth
5a78d96d0e
Fix block comment intra doc link injection ranges
2021-05-04 13:51:57 +02:00
bors[bot]
6d812efcd9
Merge #8711
...
8711: Only resolve selected assist r=matklad a=SomeoneToIgnore
Part of https://github.com/rust-analyzer/rust-analyzer/issues/8700
Now resolves only the assist that was selected out of the list, while before the whole assist list was resolved despite a single popup selection.
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
2021-05-04 11:51:09 +00:00
Aleksey Kladov
41f8ae7daa
More searchable name
2021-05-04 10:23:47 +03:00