Support goto_type_definition for types

This commit is contained in:
Lukas Tobias Wirth 2021-05-06 17:05:49 +02:00
parent 5b663f1b07
commit d97a4b8e49
2 changed files with 24 additions and 0 deletions

View File

@ -196,6 +196,10 @@ pub fn resolve_label(&self, lifetime: &ast::Lifetime) -> Option<Label> {
self.imp.resolve_label(lifetime)
}
pub fn resolve_type(&self, ty: &ast::Type) -> Option<Type> {
self.imp.resolve_type(ty)
}
pub fn type_of_expr(&self, expr: &ast::Expr) -> Option<Type> {
self.imp.type_of_expr(expr)
}
@ -476,6 +480,14 @@ fn resolve_label(&self, lifetime: &ast::Lifetime) -> Option<Label> {
ToDef::to_def(self, src)
}
fn resolve_type(&self, ty: &ast::Type) -> Option<Type> {
let scope = self.scope(ty.syntax());
let ctx = body::LowerCtx::new(self.db.upcast(), scope.file_id);
let ty = hir_ty::TyLoweringContext::new(self.db, &scope.resolver)
.lower_ty(&crate::TypeRef::from_ast(&ctx, ty.clone()));
Type::new_with_resolver(self.db, &scope.resolver, ty)
}
fn type_of_expr(&self, expr: &ast::Expr) -> Option<Type> {
self.analyze(expr.syntax()).type_of_expr(self.db, expr)
}

View File

@ -30,6 +30,7 @@ pub(crate) fn goto_type_definition(
ast::Expr(it) => sema.type_of_expr(&it)?,
ast::Pat(it) => sema.type_of_pat(&it)?,
ast::SelfParam(it) => sema.type_of_self(&it)?,
ast::Type(it) => sema.resolve_type(&it)?,
_ => return None,
}
};
@ -146,6 +147,17 @@ fn goto_def_for_self_param() {
impl Foo {
fn f(&self$0) {}
}
"#,
)
}
#[test]
fn goto_def_for_type_fallback() {
check(
r#"
struct Foo;
//^^^
impl Foo$0 {}
"#,
)
}