2787: Add missing expr cases for expand macro r=flodiebold a=edwin0cheng
I will open another issues for tracking adding back the cases implemented in the PR.
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2786: Proper handling local in hover r=flodiebold a=edwin0cheng
This PR implement back the `Local` hover information generation, which is fall back to a general case catch previously :
9a44f627be/crates/ra_ide/src/hover.rs (L173-L182)
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2779: Parse trait aliases r=matklad a=kiljacken
Implements the needed changes to correctly parse trait aliases.
This is my first change in the parser code, so would appreciate a comment on whether this is the right way to go about it.
Co-authored-by: Emil Lauridsen <mine809@gmail.com>
2772: Actually test references r=kjeremy a=kjeremy
This will be a little more work when `ReferenceSearchResults` change but I think it's easier to maintain in the end. It also follows a similar pattern to navigation targets and call hierarchy.
Co-authored-by: kjeremy <kjeremy@gmail.com>
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
2771: Remove the Default impl for SourceRoot r=matklad a=michalt
Let's be always explicit whether we create a library (i.e., an immutable
dependency) or a local `SourceRoot`, since it can have a large impact on
the validation performance in salsa. (we found it the hard way recently,
where the `Default` instance made it quite tricky to spot a bug)
Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>
Co-authored-by: Michal Terepeta <michal.terepeta@gmail.com>
Let's be always explicit whether we create a library (i.e., an immutable
dependency) or a local `SourceRoot`, since it can have a large impact on
the validation performance in salsa. (we found it the hard way recently,
where the `Default` instance made it quite tricky to spot a bug)
Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>
2738: [Draft] Adds a way to limits reference search by StructLiteral r=matklad a=mikhail-m1
first draft for #2549
Co-authored-by: Mikhail Modin <mikhailm1@gmail.com>
2758: Add "code-oss" Visual Studio Code binary name r=matklad a=leo-lb
When Visual Studio Code is manually compiled from the upstream
source tree the binary is named "code-oss".
Co-authored-by: leo-lb <lle-bout@zaclys.net>
