xFrednet
d38fddd899
Refactor camel_case
util functions for new StrIndex
2021-10-24 21:13:43 +02:00
xFrednet
1b91d986ea
Rename clippy_utils::camal_case
to clippy_utils::str_utils
2021-10-24 17:42:13 +02:00
bors
ba0cfc7deb
Auto merge of #7867 - dswij:utils-typo, r=llogiq
...
Fix typo on utils/lib
Found some typo when looking through `clippy_utils/src/lib.rs` 🙂
changelog: none
2021-10-23 16:09:45 +00:00
Dharma Saputra Wijaya
a5a3e6192d
Fix typo on utils/lib
2021-10-23 23:42:31 +08:00
bors
df65291edd
Auto merge of #7856 - Manishearth:impl-safety, r=xFrednet
...
missing_safety_doc: Handle 'implementation safety' headers as well
We hit some FPs on this in `yoke`, it's somewhat normal to mark trait impl safety with "implementation safety". We could also broaden the check for headers which contain the word "safety" somehow, or split out impl safety stuff to only apply to traits.
changelog: handle 'implementation safety' headers in `missing_safety_doc`
2021-10-21 21:51:24 +00:00
Manish Goregaokar
9def82d382
use a variable
2021-10-21 14:40:33 -07:00
bors
6714eff09a
Auto merge of #7857 - flip1995:fix_deploy, r=xFrednet
...
Fix deploy script
I broke this script in #7502 , so that the stable symlink isn't generated
anymore. This reverts this change.
changelog: none
2021-10-21 20:54:47 +00:00
bors
2ba1a6a331
Auto merge of #7801 - aDotInTheVoid:empty-format, r=camsteffen
...
Make useless_format recognize format!("")
Closes #7796
changelog: [`useless_format`] Fix for false negitive for `format!("")`
2021-10-21 18:15:23 +00:00
bors
c97a06d9af
Auto merge of #7850 - ThibsG:PossibleCastTruncation5395, r=camsteffen
...
Fix FP: no lint when cast is coming from `signum` method call for `cast_possible_truncation` lint
Fixes a FP when cast is coming from `signum` method call
fixes : #5395
changelog: [`cast_possible_truncation`] Fix FP when cast is coming from `signum` method call
2021-10-21 18:01:39 +00:00
Nixon Enraght-Moony
081d0f82f4
Make useless_format recognize format!("")
...
Closes #7796
2021-10-21 19:01:28 +01:00
ThibsG
566244a8bc
Do not lint when cast is coming from signum
method call
2021-10-21 19:15:26 +02:00
flip1995
96126e7ce9
Fix deploy script
...
I broke this script in #7502 , so that the stable symlink isn't generated
anymore. This reverts this change.
2021-10-21 18:00:57 +02:00
Manish Goregaokar
1e8d9fb18c
Handle 'implementation safety' headers as well
2021-10-21 08:50:50 -07:00
bors
91496c2ac6
Auto merge of #7853 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
changelog: none
2021-10-21 10:23:11 +00:00
flip1995
8e48333bf1
Bump nightly version -> 2021-10-21
2021-10-21 12:19:46 +02:00
flip1995
122233091a
Bump Clippy Version -> 0.1.58
2021-10-21 12:19:32 +02:00
flip1995
085181e29d
Merge remote-tracking branch 'upstream/master' into rustup
2021-10-21 12:18:12 +02:00
bors
535262cc8c
Auto merge of #7852 - surechen:fix_typo, r=xFrednet
...
Fix typo for invalid_null_ptr_usage and missing_inline_in_public_items.
Fix typo for invalid_null_ptr_usage and missing_inline_in_public_items.
changelog: none
2021-10-21 09:08:22 +00:00
surechen
abb7ae9a79
Fix typo for INVALID_NULL_PTR_USAGE and MISSING_INLINE_IN_PUBLIC_ITEMS.
2021-10-21 14:33:43 +08:00
bors
300b821d51
Auto merge of #7838 - nhamovitz:trailing_zs_arr_wo_repr, r=Manishearth
...
Warn on structs with a trailing zero-sized array but no `repr` attribute
Closes #2868
changelog: Implement ``[`trailing_empty_array`]``, which warns if a struct is defined where the last field is a zero-sized array but there are no `repr` attributes. Zero-sized arrays aren't very useful in Rust itself, so such a struct is likely being created to pass to C code or in some other situation where control over memory layout matters. Either way, a `repr` attribute is needed.
2021-10-20 20:35:58 +00:00
bors
f11905af15
Auto merge of #7849 - ThibsG:SafetyDoc, r=llogiq
...
FIx FP in `missing_safety_doc` lint
Fix FP where lint souldn't fire if any parent has `#[doc(hidden)]` attribute
fixes : #7347
changelog: [`missing_safety_doc`] Fix FP if any parent has `#[doc(hidden)]` attribute
2021-10-20 16:46:38 +00:00
ThibsG
3630afb57f
Do not lint if any parent has hidden attribute
2021-10-20 17:53:05 +02:00
bors
76150a4922
Auto merge of #7848 - Veykril:patch-1, r=xFrednet
...
Fix doc heading of `transmute_num_to_bytes`
changelog: none
2021-10-20 12:02:32 +00:00
Lukas Wirth
9cf68e40fe
Fix doc heading of TRANSMUTE_NUM_TO_BYTES
2021-10-20 13:46:12 +02:00
bors
06722c0c15
Auto merge of #7775 - F3real:no_effect, r=xFrednet
...
Detect underscored variables with no side effects
Fixes #7545
changelog: Lint on underscored variables with no side effects in [`no_effect`]
2021-10-20 09:33:45 +00:00
bors
ee8c155527
Auto merge of #7840 - dswij:question-mark-result, r=llogiq
...
Cover `Result` for `question_mark`
closes #7135
changelog: [`question_mark`] now covers `Result`
2021-10-20 07:27:13 +00:00
dswij
083a4546f6
Small refactor on question_mark
condition checks
2021-10-20 13:41:44 +08:00
bors
5bdd2cebe2
Auto merge of #7833 - Dmitry-Borodin:patch-1, r=giraffate
...
Add reference to another doc with explanation
Add reference to another doc that explains which repository should be passed in this command since this is not covered in the command help itself.
changelog: none
2021-10-19 23:47:20 +00:00
F3real
6b22bba902
Lint on underscore variable assignment
...
Fix tests after no_effect update
Add a drop testcase
Don't lint _ variables in macro expansion
Address review comments and update tests
Don't shadow unnecessary operation lint if no_effect is allowed
Revert shadowing change and remove no_effect allows
Update clippy_lints/src/no_effect.rs
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Update clippy_lints/src/no_effect.rs
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Address review comments
2021-10-20 00:39:28 +02:00
Nathaniel Hamovitz
0f9f591e30
Rename lint
2021-10-19 14:33:43 -07:00
Nathaniel Hamovitz
60da4c9cb6
remove resolved note
2021-10-19 14:23:55 -07:00
bors
c1e7a07c9c
Auto merge of #7811 - rust-lang:eq-op-testless, r=xFrednet
...
avoid `eq_op` in test code
Add a check to `eq_op` that will avoid linting in functions annotated with `#[test]`
---
*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: avoid `eq_op` in test functions
2021-10-19 19:54:40 +00:00
Yuki Okushi
30cc96efce
Rollup merge of #88860 - nbdd0121:panic, r=m-ou-se
...
Deduplicate panic_fmt
std's begin_panic_fmt and core's panic_fmt are duplicates. Merge them to declutter code and remove a lang item.
2021-10-20 04:35:14 +09:00
Andre Bogus
e88c956e1e
avoid eq_op
in test code
2021-10-19 21:02:30 +02:00
Dmitry Borodin
7246731ad8
made description of intellij a link by moving outside of code block.
2021-10-19 20:33:39 +02:00
Gary Guo
ebf4f03f7d
Remove begin_panic_fmt from clippy
2021-10-19 15:15:59 +01:00
dswij
3fc99b6a33
Update test for question_mark
to cover Result
2021-10-19 18:50:49 +08:00
dswij
687f3925da
Cover Result
for question_mark
2021-10-19 18:50:49 +08:00
Nathaniel Hamovitz
5283d24b38
formatting 🙃
2021-10-18 18:42:01 -07:00
Nathaniel Hamovitz
4c8e816972
Use real type in doc examples
2021-10-18 18:32:00 -07:00
Nathaniel Hamovitz
02b1f266d6
Remove explicit lifetime
2021-10-18 18:20:35 -07:00
Nathaniel Hamovitz
bc32be0fec
Remove comment
2021-10-18 18:03:00 -07:00
Nathaniel Hamovitz
c654cc56da
One more test + final tidying
2021-10-18 17:41:27 -07:00
Nathaniel Hamovitz
6303d2d075
Revert "!: this is the commit that demonstrates the ICE"
...
This reverts commit d85f903c91
.
2021-10-18 17:18:07 -07:00
Nathaniel Hamovitz
d85f903c91
!: this is the commit that demonstrates the ICE
2021-10-18 17:07:51 -07:00
Nathaniel Hamovitz
48cf9c284a
Don't need rustc_attr
anymore
2021-10-18 16:53:17 -07:00
Nathaniel Hamovitz
18c863dd0e
Improve help message
2021-10-18 16:53:05 -07:00
Nathaniel Hamovitz
d8bacf078a
All five has_repr_attr
agree + are correct
2021-10-18 15:33:11 -07:00
Nathaniel Hamovitz
3a41f226c5
Exploring emitting other sorts of span
s
2021-10-18 07:02:00 -07:00
Nathaniel Hamovitz
ab9fa25e82
Better testcase names
2021-10-18 04:59:03 -07:00