Lukas Wirth
7776aad166
internal: Flatten Definition::ModuleDef
variant
2021-11-11 00:05:53 +01:00
bors[bot]
c96481e25f
Merge #10691
...
10691: minor: Use array `into_iter` in more places r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-11-04 05:52:05 +00:00
Laurențiu Nicola
139bf9b4e1
Use array into_iter in more places
2021-11-04 07:51:20 +02:00
Lukas Wirth
96db0d8bdd
Add Semantics::original_ast_node for upmapping nodes out of macro files
2021-11-03 21:12:36 +01:00
Lukas Wirth
7fdbdc4ab2
Enable auto-import and qualify-path in derive attributes
2021-10-28 18:40:38 +02:00
Lukas Wirth
3018ffd85e
Refactor ide handling for paths in derive inputs
2021-10-28 16:47:19 +02:00
bors[bot]
210a1d5ece
Merge #10629
...
10629: Add assist for replacing turbofish with explicit type. r=Veykril a=terrynsun
Converts `::<_>` to an explicit type assignment.
```
let args = args.collect::<Vec<String>>();
```
->
```
let args: Vec<String> = args.collect();
```
Closes #10285
Co-authored-by: Terry Sun <terrynsun@gmail.com>
2021-10-27 21:40:28 +00:00
Terry Sun
d800a1bc93
fixup! rustfmt
2021-10-27 10:58:31 -07:00
Terry Sun
3bbd61d674
fixup! delay to_string() until assist is called
2021-10-27 10:46:25 -07:00
Terry Sun
6abdbdd0c9
fixup! narrow range; method calls; check for only one type
2021-10-26 17:50:25 -07:00
Lukas Wirth
a2365ea18a
fix: fix extract_variable not working on macro_call
2021-10-25 21:46:44 +02:00
Terry Sun
324d7d33e8
Add assist for replacing turbofish with explicit type.
...
Converts `::<_>` to an explicit type assignment.
```
let args = args.collect::<Vec<String>>();
```
->
```
let args: Vec<String> = args.collect();
```
Closes #10285
2021-10-24 17:38:45 -07:00
Laurențiu Nicola
8457ae34bd
Set MSRV
2021-10-23 15:07:11 +03:00
bors[bot]
fe7c516084
Merge #10602
...
10602: Add qualify method call assist r=Veykril a=qepasa
This adds `qualify_method_call` assist that allows to replace a method (or trait) call that resolves with its fully qualified path.
For example, for stuct method:
```rust
struct Foo;
impl Foo {
fn foo(&self) {}
}
```
```
let foo = Foo {};
foo.fo$0o();
```
becomes
```rust
let foo = Foo {};
Foo::foo(&foo);
```
for a trait method:
```rust
struct Foo;
trait FooTrait {
fn foo(&self) {}
}
impl FooTrait for Foo {
fn foo(&self) {}
}
```
following call:
```rust
let foo = Foo {};
foo.fo$0o();
```
becomes:
```rust
let foo = Foo {};
FooTrait::foo(&foo);
```
fixes #10453
Co-authored-by: Paweł Palenica <pawelpalenica11@gmail.com>
2021-10-23 08:34:51 +00:00
bors[bot]
a75353e8ac
Merge #9939
...
9939: feat: Adding extract_module assist r=Veykril a=feniljain
Should solve https://github.com/rust-analyzer/rust-analyzer/issues/9591
Co-authored-by: vi_mi <fenil.jain2018@vitstudent.ac.in>
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-10-22 09:29:16 +00:00
vi_mi
3e73a46660
fix: making tests compatible with new trimmed sel_range
2021-10-22 09:16:56 +00:00
Paweł Palenica
bfc86f64c3
apply code review suggestions
2021-10-21 23:42:14 -07:00
Laurențiu Nicola
ca44b6892e
Use array IntoIter
2021-10-22 09:23:29 +03:00
Lukas Wirth
1294bfce86
Migrate to edition 2021
2021-10-21 20:10:40 +02:00
Paweł Palenica
91988f46b7
Add generated docs
2021-10-20 23:54:22 -07:00
Paweł Palenica
c2fd0c48a6
cleanup qualify_path
2021-10-20 23:39:25 -07:00
Paweł Palenica
b3d92052ce
Remove comment
2021-10-20 23:38:28 -07:00
Paweł Palenica
c8820d342f
Run cargo fmt
2021-10-20 23:35:14 -07:00
Paweł Palenica
bb00b09d22
Add qualify method call assist
2021-10-20 23:28:30 -07:00
bors[bot]
6877240fdf
Merge #10563
...
10563: feat: Make "Generate getter" assist use semantic info r=agluszak a=agluszak
This PR makes "Generate getter" assist use semantic info instead of dealing with types encoded as strings.
Getters for types which are:
- `Copy` no longer return references
- `AsRef<str>` (i.e. `String`) return `&str` (instead of `&String`)
- `AsRef<[T]>` (i.e. `Vec<T>`) return `&[T]` (instead of `&Vec<T>`)
- `AsRef<T>` (i.e. `Box<T>`) return `&T` (instead of `&Box<T>`)
- `Option<T>` return `Option<&T>` (instead of `&Option<T>`)
- `Result<T, E>` return `Result<&T, &E>` (instead of `&Result<T, E>`)
String, Vec, Box and Option were previously handled as special cases.
Closes #10295
Co-authored-by: Andrzej Głuszak <gluszak.andrzej@gmail.com>
2021-10-20 21:02:46 +00:00
Andrzej Głuszak
88e2f07826
Fixes
2021-10-20 22:35:31 +02:00
Andrzej Głuszak
a2242dcf1b
Fixes
2021-10-20 21:35:35 +02:00
rainy-me
1ea2c72386
Fix: remove extra newline
2021-10-19 23:46:43 +09:00
rainy-me
adb3729b91
Fix: expand glob import to empty braces if the glob is unused
2021-10-19 23:31:30 +09:00
bors[bot]
580a6c41eb
Merge #10568
...
10568: fix(assist): fix #10566 and #10567 r=bnjjj a=bnjjj
close #10566
close #10567
Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2021-10-19 12:57:24 +00:00
Benjamin Coenen
3a5147e9fe
fix(assist): delete trailing whitespaces
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2021-10-19 14:54:29 +02:00
bors[bot]
e77fc481ad
Merge #10587
...
10587: fix: Fix `add_missing_match_arm` panicking on failed upmapping r=Veykril a=Veykril
Closes https://github.com/rust-analyzer/rust-analyzer/issues/10580#issuecomment-946170475
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-10-19 12:16:30 +00:00
Lukas Wirth
7e1d6e5265
fix: Fix add_missing_match_arm panicking
2021-10-19 14:00:24 +02:00
Yoshua Wuyts
e346d32e69
fix Ordering::Equal path
2021-10-18 14:45:24 +02:00
Yoshua Wuyts
41fd824415
Revert "Simplify generated PartialOrd code"
...
This reverts commit 601ed3a10d
.
2021-10-18 14:41:38 +02:00
Yoshua Wuyts
a9ec345cf7
Fix PartialOrd codegen
2021-10-18 12:44:05 +02:00
Benjamin Coenen
7ee1a77235
fix(assist): fix #10566 and #10567
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2021-10-17 20:24:40 +02:00
Andrzej Głuszak
98676efdc5
Semantic getter
2021-10-17 16:33:14 +02:00
bors[bot]
401daa5f77
Merge #10417
...
10417: feat(assist): add new assist to unwrap the result return type r=bnjjj a=bnjjj
do the opposite of assist "wrap the return type in Result"
Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com>
2021-10-17 13:32:35 +00:00
Coenen Benjamin
ccf05debfe
Update crates/ide_assists/src/handlers/unwrap_result_return_type.rs
...
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-10-17 15:24:20 +02:00
Laurențiu Nicola
2bf5f14666
Use trimmed selection range
2021-10-16 13:39:55 +03:00
vi_mi
2efcff7f75
fix: Adding tuple fields in ADT, chore: test action section
...
unindentation
2021-10-16 13:36:06 +03:00
vi_mi
227490c069
fix: arbitary noop of assist and same file double writes
2021-10-16 13:36:06 +03:00
vi_mi
32b95ea310
feat: Adding extract_module assist
2021-10-16 13:36:06 +03:00
Laurențiu Nicola
cd0c45fdbc
Hide private methods in generate_delegate_methods
2021-10-16 13:16:22 +03:00
bors[bot]
c67db1b952
Merge #10543
...
10543: Narrow add_missing_match_arms assist range r=Veykril a=antonfirsov
Contributes to #10220 with logic borrowed from #10267 .
Note: if anyone has recommendations for further analyzers to check, I'm happy to (hard to do it on my own, I'm completely new to the language).
Co-authored-by: Anton Firszov <antonfir@gmail.com>
2021-10-15 16:05:15 +00:00
Anton Firszov
3d9ce6b6ce
cov_mark for add_missing_match_arms special cases
2021-10-15 17:53:01 +02:00
Anton Firszov
1c0eed5f97
undo unnecessary test changes
2021-10-15 14:45:11 +02:00
Anton Firszov
cc6eee1b60
cosmetics
2021-10-15 14:36:37 +02:00
Anton Firszov
e25b20e48d
update generated.rs
2021-10-15 14:33:44 +02:00