Benjamin Coenen
fdf86637bf
Merge branch 'master' of github.com:rust-analyzer/rust-analyzer
2020-05-02 13:39:05 +02:00
Benjamin Coenen
6d5f3922f7
Add unwrap block assist #4156
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-02 12:31:11 +02:00
bors[bot]
fb8fb65131
Merge #4234
...
4234: Support local_inner_macros r=jonas-schievink a=edwin0cheng
This PR implements `#[macro_export(local_inner_macros)]` support.
Note that the rustc implementation is quite [hacky][1] too. :)
[1]: 614f273e93/src/librustc_resolve/macros.rs (L456)
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2020-05-02 10:30:49 +00:00
Benjamin Coenen
0b40876b99
Merge branch 'master' of github.com:rust-analyzer/rust-analyzer
2020-05-02 12:25:04 +02:00
Benjamin Coenen
eea21738ab
Add unwrap block assist #4156
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-02 12:20:39 +02:00
bors[bot]
75bc024946
Merge #4257
...
4257: ast::EffectExpr r=matklad a=matklad
closes #4230
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-02 09:57:45 +00:00
Aleksey Kladov
b73dbbfbf2
Add missing members generates indented blocks
2020-05-02 11:53:07 +02:00
bors[bot]
235728319f
Merge #4256
...
4256: Improve formatting of analyzer status text r=flodiebold a=eminence
The old formatting had everything on 1 line, making it quite hard to read:
requests: 1 textDocument/documentSymbol 2ms 2 textDocument/codeAction 2ms 3 rust-analyzer/inlayHints 20ms 4 textDocument/foldingRange 108ms 6 textDocument/codeLens 66ms 5 textDocument/semanticTokens/range 76ms 8 rust-analyzer/inlayHints 195ms 7 textDocument/semanticTokens 250ms 9 textDocument/semanticTokens/range 108ms
It now looks like this:
```
requests:
* 1 textDocument/documentSymbol 11ms
2 textDocument/codeAction 15ms
3 rust-analyzer/inlayHints 4ms
5 textDocument/foldingRange 3ms
4 textDocument/semanticTokens/range 45ms
6 textDocument/codeLens 182ms
8 rust-analyzer/inlayHints 124ms
7 textDocument/semanticTokens 127ms
9 textDocument/documentHighlight 2ms
10 textDocument/codeAction 3ms
```
Co-authored-by: Andrew Chin <achin@eminence32.net>
2020-05-02 09:45:37 +00:00
Aleksey Kladov
b58dfd24f1
Add smoke test for decorated blocks
2020-05-02 11:27:28 +02:00
Aleksey Kladov
623faefcda
Cleanup inline tests
2020-05-02 11:21:39 +02:00
Aleksey Kladov
642a3392d9
Update test data
2020-05-02 11:21:39 +02:00
Aleksey Kladov
4f2134cc33
Introduce EffectExpr
2020-05-02 11:21:39 +02:00
bors[bot]
06fb7247d8
Merge #4258
...
4258: Test/check the whole package r=matklad a=matklad
Closes #4255
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-02 09:12:31 +00:00
Aleksey Kladov
247d32cbfd
Test/check the whole package
...
Closes #4255
2020-05-02 10:57:37 +02:00
Edwin Cheng
edf0b4c152
Test whether it is bang macro properly
2020-05-02 10:16:26 +08:00
Edwin Cheng
291d03949b
Add test in name resolutions
2020-05-02 10:06:17 +08:00
Edwin Cheng
443762cda9
Update crates/ra_hir_expand/src/builtin_derive.rs
...
Fix spacing
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2020-05-02 09:56:38 +08:00
Andrew Chin
65234e8828
Remove workspaceLoaded
setting
...
The `workspaceLoaded` notification setting was originally designed to
control the display of a popup message that said:
"workspace loaded, {} rust packages"
This popup was removed and replaced by a much sleeker message in the
VSCode status bar that provides a real-time status while loading:
rust-analyzer: {}/{} packages
This was done as part of #3587
The new status-bar indicator is unobtrusive and shouldn't need to be
disabled. So this setting is removed.
2020-05-01 21:04:41 -04:00
bors[bot]
3c96de5380
Merge #4254
...
4254: Put ? back in place r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-01 23:16:19 +00:00
Andrew Chin
76f34a15e6
Improve formatting of analyzer status text
2020-05-01 19:13:52 -04:00
Aleksey Kladov
fd030f9450
Revert "Merge #4233 "
...
This reverts commit a5f2b16366
, reversing
changes made to c96b2180c1
.
2020-05-02 01:12:37 +02:00
bors[bot]
a984587c47
Merge #4252
...
4252: Update crates r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
2020-05-01 22:28:03 +00:00
kjeremy
810c961961
Update crates
2020-05-01 18:26:42 -04:00
bors[bot]
3232fd5179
Merge #4220 #4240
...
4220: Introduce LowerCtx r=matklad a=edwin0cheng
This PR introduces `LowerCtx` for path lowering.
After this PR, there are only 2 places remains for using deprecated `Path::from_ast`, which is related to `AstTransform` I am not familiar. I would like to change these in another PR by others ;)
related disscusiion: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Path.3A.3Afrom_src
And also fixed part of https://github.com/rust-analyzer/rust-analyzer/issues/4176#issuecomment-620672930
4240: Bump deps r=matklad a=lnicola
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-05-01 20:16:25 +00:00
bors[bot]
d79a699f8e
Merge #4236
...
4236: Document Gnome Builder support r=matklad a=lnicola
Closes #3758 .
CC @gwutz
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-05-01 20:09:12 +00:00
bors[bot]
8d02b24b25
Merge #4244
...
4244: Show unsafe trait in hover r=matklad a=DianaNites
Following on #2450 and #4210 , for traits.
`unsafe` is the only qualifier they can have, though.
Co-authored-by: Diana <5275194+DianaNites@users.noreply.github.com>
2020-05-01 19:45:48 +00:00
bors[bot]
21588e15df
Merge #4246
...
4246: Validate uses of self and super r=matklad a=djrenren
This change follows on the validation of the `crate` keyword in paths. It verifies the following things:
`super`:
- May only be preceded by other `super` segments
- If in a `UseItem` then all semantically preceding paths also consist only of `super`
`self`
- May only be the start of a path
Just a note, a couple times while working on this I found myself really wanting a Visitor of some sort so that I could traverse descendants while skipping sub-trees that are unimportant. Iterators don't really work for this, so as you can see I reached for recursion. Considering paths are generally small a fancy debounced visitor probably isn't important but figured I'd say something in case we had something like this lying around and I wasn't using it.
Co-authored-by: John Renner <john@jrenner.net>
2020-05-01 19:24:25 +00:00
bors[bot]
302777f004
Merge #4248
...
4248: Fix Typos on guide.md r=matklad a=lonesometraveler
Co-authored-by: KENTARO OKUDA <lonesometraveler@mac.com>
2020-05-01 19:04:56 +00:00
bors[bot]
26079c7f2c
Merge #4167
...
4167: Filter out code actions if unsupported by the client and advertise our capabilities r=matklad a=kjeremy
This PR does three things:
1. If the client does not support `CodeActionKind` this will filter the results and only send `Command[]` back.
2. Correctly advertises to the client that the server supports `CodeActionKind`. This may cause clients to not request code actions if they are checking for the provider to be `true` (or implement LSP < 3.8) in the caps but I will fix that in a followup PR.
3. Marks most CodeActions as <strike>"refactor" so that they show up in the menu in vscode.</strike>`""`.
Part of #144
#4147
#2833
Co-authored-by: kjeremy <kjeremy@gmail.com>
2020-05-01 18:57:55 +00:00
kjeremy
99826dab15
Address comments
2020-05-01 14:12:31 -04:00
KENTARO OKUDA
f5d20b6525
Fix Typos on guide.md
2020-05-01 14:00:06 -04:00
kjeremy
ee1628dba0
Mark most assists as the base "refactor" type
...
Most of them area. We will separate them out later but this gets them to
show up in the "refactor" menu of vscode.
2020-05-01 13:44:32 -04:00
kjeremy
e75565c73f
Advertise support for all the builtin CodeActionKinds
...
Even thought we don't return all of these we eventually will so might as
well advertise now.
2020-05-01 13:44:32 -04:00
kjeremy
e3ee61f5e8
Filter out CodeActions if a server only support commands.
2020-05-01 13:44:32 -04:00
bors[bot]
4d33cdcfb2
Merge #4242
...
4242: Fix Typos r=jonas-schievink a=lonesometraveler
Co-authored-by: KENTARO OKUDA <lonesometraveler@mac.com>
2020-05-01 17:02:36 +00:00
bors[bot]
0b59be5747
Merge #4247
...
4247: Fix pub(self) visibility? r=matklad a=DianaNites
Clippy complained about it and it seems wrong, copy paste error?
Co-authored-by: Diana <5275194+DianaNites@users.noreply.github.com>
2020-05-01 16:19:14 +00:00
Diana
375dd18dc0
Fix pub(self) visibility?
...
Clippy complained about it and it seems wrong
2020-05-01 12:09:47 -04:00
John Renner
3bb46042fb
Validate uses of self and super
2020-05-01 08:59:24 -07:00
Diana
ebff5762e9
Test for unsafe trait
2020-05-01 11:49:51 -04:00
Diana
6833183ab4
Unsafe traits
2020-05-01 11:49:41 -04:00
Benjamin Coenen
df7899e47a
Add unwrap block assist #4156
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-01 16:41:29 +02:00
Benjamin Coenen
dc34162450
Merge branch 'master' of github.com:rust-analyzer/rust-analyzer
2020-05-01 16:26:30 +02:00
Benjamin Coenen
19e28888aa
wip
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-01 16:26:22 +02:00
KENTARO OKUDA
eafb2107dd
Fix Typos
2020-05-01 09:43:08 -04:00
Edwin Cheng
7bbdeb43a4
Make AttrQuery copyable
2020-05-01 20:58:24 +08:00
Laurențiu Nicola
1e20467c3a
Bump deps
2020-05-01 15:29:03 +03:00
Edwin Cheng
44f5e2048c
Remove lower_path from AssistCtx to Semantic
2020-05-01 20:05:12 +08:00
Edwin Cheng
bdcf6f5658
Introduce LowerCtx for path lowering
2020-05-01 20:01:17 +08:00
Edwin Cheng
1635d22a35
Add test
2020-05-01 20:01:17 +08:00
Laurențiu Nicola
c185e482e9
Document Gnome Builder support
2020-05-01 11:20:58 +03:00