Remove workspaceLoaded
setting
The `workspaceLoaded` notification setting was originally designed to control the display of a popup message that said: "workspace loaded, {} rust packages" This popup was removed and replaced by a much sleeker message in the VSCode status bar that provides a real-time status while loading: rust-analyzer: {}/{} packages This was done as part of #3587 The new status-bar indicator is unobtrusive and shouldn't need to be disabled. So this setting is removed.
This commit is contained in:
parent
3232fd5179
commit
65234e8828
@ -49,7 +49,6 @@ pub enum FilesWatcher {
|
||||
|
||||
#[derive(Debug, Clone)]
|
||||
pub struct NotificationsConfig {
|
||||
pub workspace_loaded: bool,
|
||||
pub cargo_toml_not_found: bool,
|
||||
}
|
||||
|
||||
@ -83,10 +82,7 @@ fn default() -> Self {
|
||||
lru_capacity: None,
|
||||
proc_macro_srv: None,
|
||||
files: FilesConfig { watcher: FilesWatcher::Notify, exclude: Vec::new() },
|
||||
notifications: NotificationsConfig {
|
||||
workspace_loaded: true,
|
||||
cargo_toml_not_found: true,
|
||||
},
|
||||
notifications: NotificationsConfig { cargo_toml_not_found: true },
|
||||
|
||||
cargo: CargoConfig::default(),
|
||||
rustfmt: RustfmtConfig::Rustfmt { extra_args: Vec::new() },
|
||||
@ -129,7 +125,6 @@ pub fn update(&mut self, value: &serde_json::Value) {
|
||||
Some("client") => FilesWatcher::Client,
|
||||
Some("notify") | _ => FilesWatcher::Notify
|
||||
};
|
||||
set(value, "/notifications/workspaceLoaded", &mut self.notifications.workspace_loaded);
|
||||
set(value, "/notifications/cargoTomlNotFound", &mut self.notifications.cargo_toml_not_found);
|
||||
|
||||
set(value, "/cargo/noDefaultFeatures", &mut self.cargo.no_default_features);
|
||||
|
@ -415,8 +415,7 @@ fn loop_turn(
|
||||
});
|
||||
}
|
||||
|
||||
let show_progress =
|
||||
!loop_state.workspace_loaded && world_state.config.notifications.workspace_loaded;
|
||||
let show_progress = !loop_state.workspace_loaded;
|
||||
|
||||
if !loop_state.workspace_loaded
|
||||
&& loop_state.roots_scanned == loop_state.roots_total
|
||||
|
@ -205,11 +205,6 @@
|
||||
"default": [],
|
||||
"description": "Paths to exclude from analysis."
|
||||
},
|
||||
"rust-analyzer.notifications.workspaceLoaded": {
|
||||
"type": "boolean",
|
||||
"default": true,
|
||||
"markdownDescription": "Whether to show `workspace loaded` message."
|
||||
},
|
||||
"rust-analyzer.notifications.cargoTomlNotFound": {
|
||||
"type": "boolean",
|
||||
"default": true,
|
||||
|
Loading…
Reference in New Issue
Block a user