David Barsky
bd545a1c10
Address review comments
2023-03-14 12:49:35 -04:00
David Barsky
78aed305e1
rename "addProject" command
2023-03-13 15:37:58 -04:00
David Barsky
cb93c12c31
fmt
2023-03-13 13:33:39 -04:00
David Barsky
56273b3cf5
Remove rust-analyzer/addProject
in favor of notifying r-a that configuration has changed
2023-03-13 13:30:19 -04:00
David Barsky
8d9bff0c74
Add a workspace config-based approach to reloading discovered projects.
2023-03-13 13:30:19 -04:00
David Barsky
91371494ee
move rust-analyzer.discoverProjectCommand
above $generated-start
to avoid failing tests
2023-03-13 13:30:19 -04:00
David Barsky
7a6e1119af
Update crates/rust-analyzer/src/handlers.rs
...
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2023-03-13 13:30:19 -04:00
David Barsky
68d3eaead4
fix typo in package.json.
2023-03-13 13:30:19 -04:00
David Barsky
1f5c535089
remove errant --
in executeDiscoverProject
2023-03-13 13:30:19 -04:00
David Barsky
46e022098f
fmt
2023-03-13 13:30:19 -04:00
David Barsky
8af3d6367e
This commit add Cargo-style project discovery for Buck and Bazel users.
...
This feature requires the user to add a command that generates a
`rust-project.json` from a set of files. Project discovery can be invoked
in two ways:
1. At extension activation time, which includes the generated
`rust-project.json` as part of the linkedProjects argument in
InitializeParams
2. Through a new command titled "Add current file to workspace", which
makes use of a new, rust-analyzer specific LSP request that adds
the workspace without erasing any existing workspaces.
I think that the command-running functionality _could_ merit being
placed into its own extension (and expose it via extension contribution
points), if only provide build-system idiomatic progress reporting and
status handling, but I haven't (yet) made an extension that does this.
2023-03-13 13:30:18 -04:00
bors
9549753352
Auto merge of #14333 - lnicola:sync-from-rust, r=lnicola
...
minor: sync from downstream
2023-03-13 08:25:23 +00:00
Laurențiu Nicola
bdbd2a59b0
Merge branch 'master' into sync-from-rust
2023-03-13 10:21:53 +02:00
bors
f1e51afa45
Auto merge of #14328 - lnicola:build-scripts-extra-args, r=Veykril
...
fix: Pass flycheck extra args when running build scripts
Closes #14315
Not sure if we want to do it like this or to add an extra config key, though.
2023-03-12 15:19:29 +00:00
Laurențiu Nicola
c3864eb511
Add and use rust-analyzer.cargo.extraArgs setting
2023-03-12 13:04:24 +02:00
Laurențiu Nicola
cfc9d5cd3b
Pass flycheck extra args when running build scripts
2023-03-11 19:28:02 +02:00
bors
70e10deee8
Auto merge of #14326 - iDawer:refactor, r=Veykril
...
internal: Rename `hir::diagnostics::MissingMatchArms.match_expr` field
`hir::diagnostics::MissingMatchArms.match_expr` had confusing name: it is pointing to scrutinee expression. Renamed to `scrutinee_expr` and used better fitting type for it.
Also small refactorings/cleanup.
2023-03-11 07:36:00 +00:00
bors
6d42e75ce8
Auto merge of #14323 - ComputerDruid:fix_overlap_indexes, r=Veykril
...
Fix overlap deduping infinite loop
Fixes : #14276
2023-03-11 06:54:36 +00:00
Dan Johnson
2691143a67
Fix overlap deduping infinite loop
...
Fixes: 14276
2023-03-10 17:01:21 -08:00
iDawer
17b9d35b31
Refactor: Distinguish scrutinee expression from match expression
2023-03-10 18:43:50 +05:00
iDawer
5e8c586f3b
Refactor hir::diagnostics::MissingMatchArms fields, better naming
2023-03-10 18:22:32 +05:00
iDawer
8f189f62c6
Remove unnecessary argument
2023-03-10 16:35:04 +05:00
iDawer
c38aa5f4f0
Use anonymous lifetimes
2023-03-10 16:16:28 +05:00
bors
9fca0a4afe
Auto merge of #14316 - HKalbasi:master, r=HKalbasi
...
Fix stack overflow when derefrencing `&!`
fix #14310
2023-03-10 10:25:20 +00:00
hkalbasi
a980b562a7
Fix stack overflow when derefrencing &!
2023-03-10 13:44:34 +03:30
bors
070f8f8578
Auto merge of #14313 - Veykril:notifs, r=Veykril
...
Make project loading errors less intrusive
cc https://github.com/rust-lang/rust-analyzer/issues/14193 closes https://github.com/rust-lang/rust-analyzer/issues/9909
![image](https://user-images.githubusercontent.com/3757771/224274817-a5a8cb0c-7bda-454d-9772-5f839f360b9a.png )
2023-03-10 10:12:15 +00:00
Lukas Wirth
c03775e477
Fix is_quiescent reporting
2023-03-10 10:26:02 +01:00
Lukas Wirth
2cb60343ed
Add fancy buttons to the vscode status message
2023-03-10 10:13:30 +01:00
Lukas Wirth
0d19ccb3df
Make project loading errors less intrusive
2023-03-10 09:49:37 +01:00
bors
1b5bba4535
Auto merge of #14312 - HKalbasi:master, r=lnicola
...
Revert #14285
fix #14305
2023-03-10 08:34:27 +00:00
hkalbasi
71e1c025f8
Revert #14285
2023-03-10 11:57:30 +03:30
bors
552aea508d
Auto merge of #14311 - Veykril:lib-diags, r=Veykril
...
internal: Don't attempt to calculate diagnostics in library crates
We already filtered these later on, but we might as well stop calculating them alltogether. This way we also show cargo diagnostics that occur outside of the workspace which can happen when something goes very wrong (and which usually then causes no check diagnostics to appear in the workspace at all)
2023-03-10 08:10:37 +00:00
Lukas Wirth
116775bc83
Don't attempt to calculate diagnostics in library crates
2023-03-10 09:08:20 +01:00
bors
14b9d182d5
Auto merge of #14306 - HKalbasi:master, r=HKalbasi
...
fix block with no termination in or patterns
fix #14298
2023-03-09 19:03:47 +00:00
hkalbasi
8593132a43
fix block with no termination in or patterns
2023-03-09 22:32:12 +03:30
bors
8ce5a53934
Auto merge of #14302 - Veykril:db-memory-usage, r=Veykril
...
internal: Add missing queries to per_query_memory_usage
2023-03-09 16:02:43 +00:00
Lukas Wirth
c49f753403
Add missing queries to per_query_memory_usage
2023-03-09 16:31:10 +01:00
bors
10a652a1e4
Auto merge of #14300 - lnicola:rustc-flycheck, r=lnicola
...
fix: Watch both stdout and stderr in flycheck
Fixes #14217
This isn't great because it un-mixes the messages from the two streams, but maybe it's not such a big problem?
2023-03-09 15:28:42 +00:00
Laurențiu Nicola
209cf7dc61
Watch both stdout and stderr in flycheck
2023-03-09 16:58:25 +02:00
Lukas Wirth
879cac4b28
minor: Remove dead code
2023-03-09 15:40:51 +01:00
bors
de3b12d686
Auto merge of #14299 - Veykril:local-search, r=Veykril
...
fix: Fix search not searching bodies of attributed items
Closes https://github.com/rust-lang/rust-analyzer/issues/14229
2023-03-09 14:33:17 +00:00
Lukas Wirth
3427d36d0e
fix: Fix search not searching bodies of attributed items
2023-03-09 15:30:17 +01:00
Lukas Wirth
e158dc7246
Remove unnecessary special local handling in search
2023-03-09 15:10:26 +01:00
bors
a738737520
Auto merge of #14297 - Veykril:proc-macro-deps, r=Veykril
...
Add core lib to proc_macro dependencies
Fixes https://github.com/rust-lang/rust-analyzer/issues/14292
2023-03-09 13:44:59 +00:00
Lukas Wirth
d8c80e7d95
Add core lib to proc_macro dependencies
2023-03-09 12:58:07 +01:00
bors
8e404f4928
Auto merge of #14291 - HKalbasi:master, r=HKalbasi
...
fix multiple definition binding in match to let-else
fix #14290
2023-03-09 11:52:22 +00:00
hkalbasi
811190b913
fix multiple definition binding in match to let-else
2023-03-09 00:34:31 +03:30
bors
38e9a110d4
Auto merge of #14287 - Veykril:rustc_private-proc-macro, r=Veykril
...
minor: Fixup dylib extensions for rustc_private proc-macro loading
Follow up to https://github.com/rust-lang/rust-analyzer/pull/14282
2023-03-08 13:56:45 +00:00
Lukas Wirth
4ee2abaf38
minor: Fixup dylib extensions for rustc_private proc-macro loading
2023-03-08 14:45:47 +01:00
bors
3d904e024b
Auto merge of #14286 - Veykril:block-def-tail-mac, r=Veykril
...
fix: Fix block defmap not looking into tail expressions for macro calls
Fixes https://github.com/rust-lang/rust-analyzer/issues/14263
2023-03-08 13:37:47 +00:00