Oliver Schneider
0bea3e76d4
fix explicit_into_iter_loop on references
...
fixes #1398
2017-02-21 12:01:41 +01:00
sinkuu
bf21c84629
Ensure deref_span is empty for Vec and String
2017-02-21 19:45:45 +09:00
Oliver Schneider
89d98a8732
Simplify calling update-all-references.sh
2017-02-21 11:18:05 +01:00
Oliver Schneider
3af04c7816
Cleanup test suite
2017-02-21 11:11:33 +01:00
sinkuu
cb86c57c5f
Integrate suggestion spans
2017-02-21 19:03:50 +09:00
sinkuu
3516d45d7c
Use multispan_sugg
2017-02-21 18:44:31 +09:00
Oliver Schneider
55ea08102a
Merge pull request #1543 from Manishearth/fix-windows-tests
...
fix windows tests
2017-02-21 10:34:49 +01:00
Oliver Schneider
3fa1cd9411
Don't run cargo clippy on 64 bit
2017-02-21 09:38:33 +01:00
Oliver Schneider
f07f793fa8
Merge pull request #1544 from bood/master
...
Add lint for unnecessary casts (cast to same type)
2017-02-21 09:16:07 +01:00
Oliver Schneider
3900223762
Merge pull request #1559 from theotherphil/master
...
Use span of impl/trait in len_without_is_empty error message, rather …
2017-02-21 09:13:11 +01:00
Oliver Schneider
7c1efc6570
Merge pull request #1538 from Manishearth/publish
...
only require rustfmt and update_lints for version bumps
2017-02-21 08:30:53 +01:00
Andre Bogus
2f7babba82
New zero_ptr lint.
...
This fixes #1047 . I did not bother to add a full suggestion,
because replacing with `std::ptr::null()` may still lead to
inference failures.
2017-02-21 04:36:59 +01:00
sinkuu
627d24c80f
Fix suggestion for let <pat>
2017-02-21 00:27:12 +09:00
sinkuu
263e60ce0b
Run update_lints.py
2017-02-20 16:55:52 +09:00
sinkuu
f1b0b774e7
Support non-moving usages at match
...
This `match` is not moving the `String`:
```rust
fn foo(x: Option<String>) -> i32 {
match x {
Some(_) => 1,
None => 2,
}
}
```
With this change, it will be linted and suggested to add `*` to deref it.
```rust
fn foo(x: &Option<String>) -> i32 {
match *x {
Some(_) => 1,
None => 2,
}
}
```
2017-02-20 16:45:37 +09:00
sinkuu
0a6bc6031a
Rename lint to needless_take_by_value
...
And fixes false-positives for generics and `match`
2017-02-20 16:02:48 +09:00
Phil Ellison
d6a4d2cb18
Fix typo
2017-02-19 15:39:40 +00:00
Phil Ellison
0396756098
Add test that adding allow attribute on impl block containing len silences len_without_is_empty. Add extra impl block to PubOne to check that this doesn't get flagged@
2017-02-19 15:36:17 +00:00
Phil Ellison
2dd45b7317
Use span of impl/trait in len_without_is_empty error message, rather than the span of the len method
2017-02-19 15:14:30 +00:00
sinkuu
d2f73e7818
Add explanation
2017-02-19 18:07:37 +09:00
sinkuu
d81d961ba7
Lint needless take-by-value
2017-02-19 07:59:44 +09:00
Oliver Schneider
8a227c7577
Merge pull request #1550 from sinkuu/should_assert_eq
...
Lint `assert!(x == y)`
2017-02-18 08:23:11 +01:00
Bood Qian
ee86d46cd1
Update README
2017-02-18 11:13:38 +08:00
Bood Qian
97d46232b4
Merge branch 'master' of github.com:Manishearth/rust-clippy
2017-02-18 11:12:13 +08:00
sinkuu
d2b9b7ece2
Fix language & if_let_chain usage
2017-02-18 10:14:25 +09:00
sinkuu
8cb2ec804d
Support generic type
2017-02-18 10:14:25 +09:00
sinkuu
16e53c9868
Run update_lints.py
2017-02-18 10:14:20 +09:00
sinkuu
6bb426b0e3
Add should_assert_eq lint ( fixes #641 )
2017-02-18 10:13:56 +09:00
Oliver Schneider
9d8dc689c7
rustfmt again
2017-02-17 13:41:59 +01:00
Oliver Schneider
0682c950bc
Merge pull request #1548 from mathstuf/missing-eol
...
main: end error messages with a newline
2017-02-17 13:40:51 +01:00
Oliver Schneider
96c93036af
Merge pull request #1549 from Manishearth/never_loop
...
New never loop lint
2017-02-17 13:40:05 +01:00
Oliver Schneider
5aa41ffd06
Choose a better commit message
2017-02-17 13:27:57 +01:00
Oliver Schneider
b1f766b37b
fix dogfood tests
2017-02-17 13:23:19 +01:00
Andre Bogus
6c8a6c18ab
deal with binary op short-circuit
2017-02-17 08:49:34 +01:00
Andre Bogus
505eb53d29
New never loop lint
...
This lint detects loops that unconditionally break or return.
Closes #257
2017-02-17 04:53:14 +01:00
Bood Qian
05a6945adc
Rust fmt
2017-02-17 08:39:58 +08:00
llogiq
51931c70b3
Merge pull request #1547 from mathstuf/comma-typos
...
typos: coma -> comma
2017-02-16 20:04:31 +01:00
Ben Boeckel
1b0749a6d0
main: end error messages with a newline
2017-02-16 13:18:00 -05:00
Ben Boeckel
84509ca48a
typos: coma -> comma
2017-02-16 11:23:28 -05:00
Bood Qian
2f00ea3a07
Suppress lint for unsuffixed number casts
2017-02-16 22:55:41 +08:00
Oliver Schneider
3b8d348fd5
create a commit with just changelog and Cargo.toml changes
2017-02-16 09:49:47 +01:00
Andre Bogus
99d67b8dfc
Merge branch 'fix-windows-tests' of https://github.com/Manishearth/rust-clippy into fix-windows-tests
2017-02-16 08:47:19 +01:00
Andre Bogus
1b5efd22f4
add RUST_BACKTRACE=1 to appveyor build
2017-02-16 08:38:18 +01:00
Bood Qian
afce85e96d
Add lint for unnecessary casts (cast to same type)
2017-02-15 22:20:20 +08:00
Oliver Schneider
f158bec188
satisfy rustfmt
2017-02-15 08:36:44 +01:00
Andre Bogus
d904a01140
fix windows tests
...
Windows has a different error message than POSIX, so the ui tests fail for the clippy-config-fail tests.
This commit splits those tests up in target-os specific subdirectories and extends compile-test.rs to
run either of them based on the target os. Here's hope we'll get a green appveyor build.
2017-02-14 17:30:55 +01:00
Oliver Schneider
0773b80d65
only require rustfmt and update_lints for version bumps
2017-02-14 11:22:21 +01:00
Oliver Schneider
c76517d6c4
Merge pull request #1531 from F001/clonedCollect
...
Add a lint for `slice.iter().cloned().collect()`
2017-02-13 16:35:53 +01:00
Oliver Schneider
8b3ad61dd3
update ui tests
2017-02-13 11:57:14 +01:00
Oliver Schneider
40ea5e8c5d
run util/update_lint
2017-02-13 11:40:27 +01:00
