bors
a77ac93b2a
Auto merge of #13128 - Veykril:invocation-strategy, r=Veykril
...
Implement invocation strategy config
Fixes https://github.com/rust-lang/rust-analyzer/issues/10793
This allows to change how we run build scripts (and `checkOnSave`), exposing two configs:
- `once`: run the specified command once in the project root (the working dir of the server)
- `per_workspace`: run the specified command per workspace in the corresponding workspace
This also applies to `checkOnSave` likewise, though `once_in_root` is useless there currently, due to https://github.com/rust-lang/cargo/issues/11007
2022-10-19 21:53:19 +00:00
Lukas Wirth
46732369f4
Remove simplistic interpolation for manifest-path
2022-10-19 23:53:00 +02:00
Lukas Wirth
7db50294a3
{manifest-path} interpolation
2022-10-19 23:21:34 +02:00
Lukas Wirth
5174b65ed8
Use correct invocation strategy config for checkOnSave
2022-10-19 23:21:34 +02:00
Lukas Wirth
4a287d2525
Implement invocation strategy config for checkOnSave
...
Note that due to how cargo works, none of the modes currently work for r-a
2022-10-19 23:21:34 +02:00
Lukas Wirth
7e2c41dbd6
Implement invocation strategy config for build scripts
2022-10-19 23:21:29 +02:00
bors
82ac6f7d48
Auto merge of #13441 - Veykril:sysroot-logging, r=Veykril
...
Add some sysroot logging
2022-10-19 20:27:09 +00:00
Lukas Wirth
653dafa7b1
Add some sysroot logging
2022-10-19 22:26:44 +02:00
bors
339257397d
Auto merge of #13439 - Veykril:simplify, r=Veykril
...
Simplify
2022-10-19 19:18:00 +00:00
Lukas Wirth
9d3e616f82
Simplify
2022-10-19 21:17:11 +02:00
bors
97b357e41b
Auto merge of #13433 - rust-lang:revert-13354-try-stuff, r=Veykril
...
Revert "feat: Diagnose some incorrect usages of the question mark operator"
Reverts rust-lang/rust-analyzer#13354
It seems like we are getting stuck with inference variables here, not just placeholders and errors so there is probably more wrong here that I don't understand. Reverting seems like the best solution right now as I don't have the time to look into this this week.
2022-10-18 12:19:58 +00:00
Lukas Wirth
8047512dca
Revert "feat: Diagnose some incorrect usages of the question mark operator"
2022-10-18 14:18:59 +02:00
bors
4d4c05d32b
Auto merge of #13428 - Veykril:fmt-stuck, r=Veykril
...
fix: Fix formatting requests hanging when r-a is still starting
The reason for that was that we were calculating the crate defmaps of the file we are saving by accident causing us to get stuck waiting on their expensive computation, while we only need the relevant crate id.
Closes https://github.com/rust-lang/rust-analyzer/issues/4054
Closes https://github.com/rust-lang/rust-analyzer/issues/11654
2022-10-17 16:21:32 +00:00
Lukas Wirth
a762baca02
fix: Fix formatting requests hanging when r-a is still starting
...
The reason for that was that we were calculating the crate defmaps
of the file we are saving by accident causing us to get stuck waiting
on their expensive computation, while we only need the relevant crate
id.
2022-10-17 18:21:18 +02:00
bors
106285b5c4
Auto merge of #13427 - Veykril:cancel-check, r=Veykril
...
feat: Make flycheck workdone progress reports cancellable
In clients that support this (like VSCode), the clients will now render a cancel button on the notification message which can be clicked to cancel the flycheck instead.
Closes https://github.com/rust-lang/rust-analyzer/issues/6895
![Code_VbXgP3SbFD](https://user-images.githubusercontent.com/3757771/196205329-2df93451-c143-4d1b-a700-d988edf55efa.gif )
2022-10-17 14:41:57 +00:00
Lukas Wirth
e41023ce46
Make flycheck workdone progress reports cancellable
2022-10-17 16:32:47 +02:00
bors
067c410c45
Auto merge of #13426 - Veykril:client-refactor, r=Veykril
...
Refactor language client handling
Follow up to https://github.com/rust-lang/rust-analyzer/pull/12847 (turns out they fixed parts of the problem)
The PR will attempt to allow us to dispose more resources at will, so that we can implement restarts for the server properly instead of restating the entire extension as well as allowing us to implement a stop command.
Closes https://github.com/rust-lang/rust-analyzer/issues/12936
Closes https://github.com/rust-lang/rust-analyzer/issues/4697
2022-10-17 14:12:01 +00:00
Lukas Wirth
d63c44e650
Cleanup output channels
2022-10-17 16:01:39 +02:00
Lukas Wirth
7b5c943129
Downgrade vscode types dependency
2022-10-17 15:48:36 +02:00
Lukas Wirth
0421756b42
Implement stop and start server commands
2022-10-17 15:45:57 +02:00
Lukas Wirth
d68616a140
Make more things private
2022-10-17 15:05:20 +02:00
Lukas Wirth
8aaafddee8
Properly reload changed configs for server start
2022-10-17 14:53:46 +02:00
Lukas Wirth
6f435977df
Refactor language client handling
2022-10-17 14:21:12 +02:00
bors
f0797929e5
Auto merge of #13302 - Veykril:auto-publish, r=Veykril
...
Don't auto-publish lib crates
I believe this should *just* work? With this cargo-workspaces should not consider them
2022-10-17 10:22:25 +00:00
bors
40cbeb5b3d
Auto merge of #13423 - Veykril:vscode-vars, r=Veykril
...
Substitute some VSCode variables in the VSCode client
cc https://github.com/rust-lang/rust-analyzer/issues/13405
2022-10-17 10:08:12 +00:00
bors
a2e4f783a2
Auto merge of #13399 - DropDemBits:assists-format-args-capture-pt2, r=Veykril
...
Migrate assists to format args captures, part 2
Continuation of #13379
Migrates:
- `generate_constant`
- `generate_default_from_enum_variant`
- `generate_default_from_new`
- `generate_delegate_methods`
- `generate_deref`
- `generate_documentation_template`
- `generate_enum_is_method`
- `generate_enum_projection_method`
- `generate_from_impl_for_enum`
- `generate_function`
- `generate_getter`
- `generate_impl`
- `generate_new`
- `generate_setter`
2022-10-17 09:54:07 +00:00
Lukas Wirth
d5f467aa4a
Substitute some VSCode variables in the VSCode client
2022-10-16 19:45:08 +02:00
bors
0531aab522
Auto merge of #13397 - zyctree:zyctree-patch-2, r=lnicola
...
fix link in syntax.md
2022-10-16 17:40:21 +00:00
zyctree
ea8b62f9b0
update link in syntax.md
2022-10-17 01:39:19 +08:00
zyctree
5df03c2c18
update link in syntax.md
2022-10-16 23:41:32 +08:00
bors
ee2d9eddb6
Auto merge of #13354 - Veykril:try-stuff, r=Veykril
...
feat: Diagnose some incorrect usages of the question mark operator
Trying to figure out how the type stuff in r-a works some more, I think I am doing this correct here but I am not quite sure :)
2022-10-16 11:11:08 +00:00
Lukas Wirth
381366f1dd
Diagnose incorrect usages of the question mark operator
2022-10-16 12:58:24 +02:00
bors
4876693708
Auto merge of #13408 - lowr:patch/bump-chalk-0.86, r=Veykril
...
Bump chalk
There's a bug in current chalk that prevents us from properly supporting GATs, which is supposed to be fixed in v0.86. Note the following:
- v0.86 is only going to be released next Sunday so I'll keep this PR as draft until then.
- This doesn't compile without https://github.com/rust-lang/chalk/pull/779 , which I hope will be included in v0.86. I confirmed this compiles with it locally.
Two breaking changes from v0.84:
- `TypeFolder` has been split into `TypeFolder` and `FallibleTypeFolder` (https://github.com/rust-lang/chalk/pull/772 )
- `ProjectionTy::self_type_parameter()` has been removed (https://github.com/rust-lang/chalk/pull/778 )
2022-10-16 10:57:23 +00:00
Ryo Yoshida
310a72bf47
Bump chalk to 0.86
...
Two breaking changes:
- `TypeFolder` has been split into `TypeFolder` and `FallibleTypeFolder`
- `ProjectionTy::self_type_parameter()` has been removed
2022-10-16 19:23:34 +09:00
bors
8406380b5a
Auto merge of #13421 - rust-lang:Veykril-patch-1, r=Veykril
...
Update guide.md to reflect support for proc-macros
2022-10-16 09:52:16 +00:00
Lukas Wirth
88d0efc243
Update guide.md to reflect support for proc-macros
2022-10-16 11:52:01 +02:00
bors
c09151c619
Auto merge of #13402 - HKalbasi:patch-1, r=Veykril
...
Cast runnableEnv items to string
fix #13390
An alternative approach could be raising an error if there is non string values.
2022-10-16 09:20:38 +00:00
bors
8267966180
Auto merge of #13420 - volsa:master, r=Veykril
...
fix: Ignore auto-import assist on parameter names
Fixes #13105 ; before & after
https://user-images.githubusercontent.com/29666622/195999489-0474c93a-b2bf-41c4-b7da-a4242a8082d8.mov
https://user-images.githubusercontent.com/29666622/195999571-605ee09c-bc6f-4ee5-bfe4-73e37254c647.mov
2022-10-16 08:42:24 +00:00
Volkan Sagcan
dd4d3f0a09
fix #13105 : Ignore auto-import assist on parameter names
2022-10-15 18:00:32 +02:00
bors
5174d3d030
Auto merge of #13419 - lnicola:bump-setup-node, r=lnicola
...
Bump `actions/setup-node`
Fixes more Node 12 deprecation warnings.
2022-10-15 11:48:14 +00:00
Laurențiu Nicola
7bf6f188de
Bump actions/setup-node
2022-10-15 14:47:53 +03:00
bors
855cd5c280
Auto merge of #13418 - lnicola:bump-deps, r=lnicola
...
Bump deps
2022-10-15 11:27:12 +00:00
Laurențiu Nicola
342764d31a
Add new license
2022-10-15 14:26:30 +03:00
Laurențiu Nicola
b513111f3c
Bump the rest of the deps
2022-10-15 13:06:10 +03:00
Laurențiu Nicola
119e1bafcc
Bump notify
2022-10-15 13:03:39 +03:00
Laurențiu Nicola
f5bbf9a06a
Bump proc-macro2
2022-10-15 13:02:10 +03:00
Laurențiu Nicola
792920f441
Bump pulldown-cmark-to-cmark
2022-10-15 13:00:41 +03:00
Laurențiu Nicola
275848803b
Bump mimalloc
2022-10-15 12:59:56 +03:00
Laurențiu Nicola
39777bf941
Bump rowan
2022-10-15 12:58:57 +03:00
Laurențiu Nicola
97eebbfab6
Bump url
2022-10-15 12:57:30 +03:00