DropDemBits
6f68cd3394
Remove unwraps from destructure_tuple_binding
2023-11-13 18:42:58 -05:00
DropDemBits
4aaa592a9a
Migrate destructure_tuple_binding
to mutable ast
...
Due to the way the current tree mutation api works, we need to collect
changes before we can apply them to the real syntax tree, and also can only
switch to a file once.
`destructure_tuple_binding_in_sub_pattern` also gets migrated even
though can't be used.
2023-11-11 21:07:19 -05:00
DropDemBits
f3dcc67dfa
Migrate add_type_ascription
2023-11-11 21:05:27 -05:00
DropDemBits
5fc8cc52e2
Add LetStmt::set_ty
...
Way for setting and removing the type ascription of a let stmt
2023-11-11 21:05:27 -05:00
DropDemBits
92422f7488
Use syntax's version of SyntaxElement
2023-11-11 21:05:27 -05:00
DropDemBits
cc4e06f04b
Migrate add_turbo_fish
to mutable ast
...
`add_type_ascription` is still left as-is since it's a different assist
2023-11-11 21:05:26 -05:00
DropDemBits
02c7b8b9ba
Add MethodCallExpr::get_or_create_generic_arg_list
...
Mirrors `PathSegment's` version, except that it always generates a
turbofish
2023-11-11 21:05:26 -05:00
bors
3b7c7f97e4
Auto merge of #15849 - HKalbasi:fix-sync, r=HKalbasi
...
Update rustc dependencies
Except `rustc_parse_format` that was broken by upstream.
2023-11-07 22:13:41 +00:00
hkalbasi
1086b294c2
update rustc dependencies
2023-11-08 01:16:47 +03:30
bors
2a48432819
Auto merge of #15843 - roife:master, r=lnicola
...
minor: correct a typo in a comment in base-db/lib.rs
2023-11-07 07:11:28 +00:00
roife
13249b7dd9
fix: correct a typo in a comment in base-db/lib.rs
2023-11-07 14:51:34 +08:00
bors
c1c9e10f72
Auto merge of #15832 - Young-Flash:generate_mut_trait, r=lnicola
...
feat: add generate_mut_trait_impl assist
![generate_mut_trait_impl](https://github.com/rust-lang/rust-analyzer/assets/71162630/362a5a93-e109-4ffc-996e-9b6e4f54fcfa )
Generate proper `index_mut` method body refer to `index` method body may impossible due to the unpredicable case (#15581 ).
Here just leave the `index_mut` method body be same as `index` method body, user can modify it manually to meet their need.
2023-11-05 14:00:24 +00:00
Young-Flash
b84940b199
make generate_mut_trait_impl assist trigged for std trait only
2023-11-05 12:27:10 +08:00
Young-Flash
8d8d12120d
feat: add generate_mut_trait_impl assist
2023-11-05 12:27:10 +08:00
bors
69432287cb
Auto merge of #15834 - lnicola:derive-docs, r=lnicola
...
fix: Fix docs path for derive macros
Fixes #15831 .
Not sure about `attr`, I don't think those are documented anyway. And many macros don't work because we pick the wrong path.
2023-11-04 11:44:56 +00:00
Laurențiu Nicola
19bf0da9d7
Fix docs path for derive macros
2023-11-04 13:33:19 +02:00
bors
0fec61aabf
Auto merge of #15827 - notpeter:vscode_rust_formatter, r=lnicola
...
VSCode metadata. category:formatters
If you invoke cmd+p `Format Document` without rust-analyzer installed in the workspace, VSCode suggests you "install a formatter" which triggers a search for `category:formatters rust`. Sadly rust-analyzer extension is not suggested.
Tweak VSCode Extension Metadata so rust-analyzer shows up in 'category:formatters rust' search.
You can see the valid values for categories in the [extension manifest: field reference](https://code.visualstudio.com/api/references/extension-manifest#fields ) docs.
<img width="270" alt="search2" src="https://github.com/rust-lang/rust-analyzer/assets/145113/5bd86497-2450-4be4-a073-e134d0616226 ">
<img width="432" alt="search_1" src="https://github.com/rust-lang/rust-analyzer/assets/145113/1ad1b375-58a1-4b37-b485-78e2a26b8342 ">
2023-11-03 06:52:57 +00:00
Peter Tripp
fccdde63c9
Maybe not a linter.
2023-11-02 18:21:31 -04:00
Peter Tripp
1b7bb9a7bd
VSCode search: 'category:formatters rust' metadata.
2023-11-02 15:54:32 -04:00
bors
11a263d5ee
Auto merge of #15819 - wasd96040501:feat/skip_tt_count_limit, r=lnicola
...
feat: skip checking token tree count for include! macro call
fix #15335 #15648
2023-11-02 10:48:51 +00:00
luoyangze.ptrl
b76f2c8ee0
fix: using name(include) instead of str
2023-11-02 10:14:54 +08:00
luoyangze.ptrl
740a864b7c
feat: skip checking tt count for include macro call
2023-11-02 00:27:11 +08:00
bors
99e94d2938
Auto merge of #15788 - Young-Flash:import_anonymously, r=lnicola
...
feat: import trait with alias
![import_trait_with_alias](https://github.com/rust-lang/rust-analyzer/assets/71162630/81601160-fe55-46e3-ab8d-b2705e1aa696 )
cc `@Veykril`
close https://github.com/rust-lang/rust-analyzer/issues/15684
2023-10-31 14:33:00 +00:00
Young-Flash
929544ef28
use check_assist_by_label
to pick assist
2023-10-31 22:13:07 +08:00
Young-Flash
a723acf346
simplify the code
2023-10-31 21:03:26 +08:00
bors
a2e2881676
Auto merge of #15815 - Sarrus1:chore/fix-guide-url, r=lnicola
...
chore: fix urls in guide.md
This PR fixes two URLs in the guide.md file.
2023-10-30 18:49:16 +00:00
Sarrus1
9d290f1d4c
chore: fix urls in guide.md
2023-10-30 19:40:24 +01:00
bors
16f3398ff4
Auto merge of #15812 - cuishuang:master, r=lnicola
...
Fix some typos
2023-10-30 06:48:55 +00:00
cui fliter
9c99afe3aa
Fix some typos
...
Signed-off-by: cui fliter <imcusg@gmail.com>
2023-10-30 10:31:50 +08:00
bors
f493207744
Auto merge of #15809 - Young-Flash:extract_variable_in_place, r=HKalbasi
...
feat: make extract_variable assist in place
![extract_variable_without_select](https://github.com/rust-lang/rust-analyzer/assets/71162630/96be2de4-42c9-4b24-b3e1-8b3e3a2da1d9 )
close https://github.com/rust-lang/rust-analyzer/issues/15796
2023-10-28 06:20:35 +00:00
Young-Flash
7186a28717
chore: add unapplicable test for extract_variable without select
2023-10-28 10:06:09 +08:00
Young-Flash
00cdbe6c96
feat: make extract_variable assist in place
2023-10-27 21:16:34 +08:00
bors
46c395d570
Auto merge of #15806 - gigaroby:master, r=lnicola
...
internal: scip: update crate to version 0.3.1.
While the git repo has been updated constantly, crates.io has only now been updated after more than a year of activity.
2023-10-26 16:33:19 +00:00
Roberto Bampi
99ec3aa8a3
scip: update crate to version 0.3.1.
...
While the git repo has been updated constantly, crates.io has only now
been updated after more than a year of activity.
2023-10-26 16:20:06 +02:00
bors
2f6961aaaf
Auto merge of #15780 - Young-Flash:auto_import, r=lnicola
...
fix: import trait if needed for `unqualify_method_call` assist
before:
![before](https://github.com/rust-lang/rust-analyzer/assets/71162630/66fda67d-afcb-453f-91a9-7e85993c3d2a )
after:
![after](https://github.com/rust-lang/rust-analyzer/assets/71162630/72ffbda4-1615-4413-836e-480eb52e9728 )
follow up https://github.com/rust-lang/rust-analyzer/pull/13825
2023-10-23 16:56:22 +00:00
Young-Flash
45ee88f9cb
fix: remove unwrap
2023-10-23 23:12:07 +08:00
bors
10872952c0
Auto merge of #15789 - HKalbasi:unused-var, r=HKalbasi
...
Store binding mode for each instance of a binding independently
fix #15787
2023-10-22 20:26:11 +00:00
hkalbasi
8b82ea4f51
Store binding mode for each instance independently
2023-10-22 23:35:33 +03:30
Young-Flash
4f5f7e2800
feat: import trait with alias
2023-10-22 21:39:00 +08:00
bors
7c11399b6b
Auto merge of #15786 - lnicola:detect-insiders, r=lnicola
...
fix: Fix VS Code detection for Insiders version
Addresses https://github.com/rust-lang/rust-analyzer/discussions/15784 .
2023-10-21 16:10:22 +00:00
Laurențiu Nicola
094cecd3bd
Fix VS Code detection for Insiders version
2023-10-21 19:08:41 +03:00
bors
954fb1d673
Auto merge of #15727 - DaniPopes:lintgen-unstable-book, r=HKalbasi
...
feat: generate descriptors for all unstable features
Most unstable features don't have their own chapter in the unstable book, so a rustc helper tool (`src/tools/unstable-book-gen`) generates shims to fill the gaps.
Run this tool to generate the full unstable-book source before parsing it.
2023-10-20 16:42:23 +00:00
bors
bd38871a98
Auto merge of #15736 - rmehri01:15678_module_incorrect_case_diagnostics, r=HKalbasi
...
fix: add incorrect case diagnostics for module names
Adds diagnostics for checking both inline and file module names are snake case.
Closes #15678
2023-10-20 16:20:40 +00:00
bors
0cae1ca656
Auto merge of #15783 - lnicola:autopublish-space, r=lnicola
...
internal: Free up some disk space on auto-publish
`@bors` r+
2023-10-19 16:36:42 +00:00
Laurențiu Nicola
94eb142e6d
Free up some disk space on auto-publish
2023-10-19 19:03:10 +03:00
Young-Flash
a7f77d89a9
fix: auto import trait if needed
2023-10-19 17:34:17 +08:00
bors
4586a6b26c
Auto merge of #15779 - Veykril:open-docs, r=Veykril
...
Add command for only opening external docs and attempt to fix vscode-remote issue
opening URI in a remote env causes vscode to ask the OS to handle `vscode-remote` URIs as there is no handler registered for such a scheme. This attempts to instruct vscode to handle those.
This is untested, as I can't figure out how to open a debug session on WSL rn.
2023-10-18 12:13:01 +00:00
Lukas Wirth
4296fe52ba
Add command for only opening external docs and attempt to fix vscode-remote issue
2023-10-18 14:06:07 +02:00
bors
7f1e6fdfee
Auto merge of #15775 - Young-Flash:refactor, r=Veykril
...
refactor: change generated variable name
change generated variable name in `replace_is_some_with_if_let_some` assist
close https://github.com/rust-lang/rust-analyzer/issues/15765
2023-10-18 06:39:34 +00:00
Young-Flash
1a0fe58d81
refactor: change generated variable name
2023-10-17 17:34:11 +08:00