92279 Commits

Author SHA1 Message Date
Esteban Küber
6aa4c992bc Suggest appropriate path when calling associated item on bare types
When looking at the documentation for `std::f32` or `std::str`, for
example, it is easy to get confused and assume `std::f32` and `f32`
are the same thing. Because of this, it is not uncommon to attempt
writing `f32::consts::PI` instead of the correct
`std::f32::consts::PI`. When encountering the former, which results
in an access error due to it being an inexistent path, try to access
the same path under `std`. If this succeeds, this information is
stored for later tweaking of the final E0599 to provide an
appropriate suggestion.

This suggestion applies to both E0233 and E0599 and is only checked
when the first ident of a path corresponds to a primitive type.
2019-04-18 19:18:26 -07:00
bors
e928e94411 Auto merge of #60046 - euclio:missing-error-code-descriptions, r=estebank
hide `--explain` hint if error has no extended info

Fixes #59848.

r? @estebank
2019-04-18 21:26:53 +00:00
bors
5d20ff4d27 Auto merge of #58702 - taiki-e:libcore-2018, r=Centril
libcore => 2018

Transitions `libcore` to Rust 2018; cc #58099

r? @Centril
2019-04-18 17:48:21 +00:00
Andy Russell
b6f148c8bd
hide --explain hint if error has no extended info 2019-04-18 13:29:28 -04:00
bors
d6f513ec7d Auto merge of #60025 - JohnTitor:rename-files, r=petrochenkov
Rename files about error codes

fixes #60017

This PR will be failed in tidy.

<details>
<summary>The log is here:</summary>

```
tidy check
tidy error: duplicate error code: 411
tidy error: Documents\GitHub\rust\src\librustc_resolve\diagnostics.rs:83:             __diagnostic_used!(E0411);
tidy error: Documents\GitHub\rust\src\librustc_resolve\diagnostics.rs:84:             err.code(DiagnosticId::Error("E0411".to_owned()));
tidy error: duplicate error code: 424
tidy error: Documents\GitHub\rust\src\librustc_resolve\diagnostics.rs:90:             debug!("smart_resolve_path_fragment: E0424, source={:?}", source);
tidy error: Documents\GitHub\rust\src\librustc_resolve\diagnostics.rs:92:             __diagnostic_used!(E0424);
tidy error: Documents\GitHub\rust\src\librustc_resolve\diagnostics.rs:93:             err.code(DiagnosticId::Error("E0424".to_owned()));
some tidy checks failed
```

</details>

I'd like to fix this but I don't know what to do.
I will work on later. Please let me know if you have any solutions.

r? @petrochenkov
2019-04-18 14:52:45 +00:00
bors
bf843eb9c2 Auto merge of #60071 - RalfJung:miri, r=oli-obk
update miri

Fixes https://github.com/rust-lang/rust/issues/60040
2019-04-18 11:55:13 +00:00
Ralf Jung
fc0cfdbc2a update miri 2019-04-18 11:05:10 +02:00
bors
e577e49b9f Auto merge of #60058 - varkor:const-generics-ty-refactor, r=cramertj
Make const parameters enforce no variance constraints

Fixes https://github.com/rust-lang/rust/issues/60047. Also includes some minor const refactoring for convenience.
2019-04-18 08:58:45 +00:00
bors
be1dbaffed Auto merge of #60048 - estebank:issue-54954, r=sanxiyn
Fix ICE on const evaluation of const method

Fix #54954.
2019-04-18 06:00:06 +00:00
Taiki Endo
e28bce7a51 Update stdsimd 2019-04-18 14:51:11 +09:00
Taiki Endo
360432f1e8 libcore => 2018 2019-04-18 14:47:35 +09:00
bors
fb1b222f04 Auto merge of #60051 - estebank:fn-sugg, r=davidtwco
Do not mention missing `PartialOrd` impl when involving uncalled fns
2019-04-18 03:06:17 +00:00
Esteban Küber
84af684b48 review comment: add extra doc 2019-04-17 16:42:52 -07:00
varkor
318a10e906 Add a test for unused const parameters 2019-04-18 00:30:50 +01:00
varkor
15033a9ba7 Const parameters should impose no variance constraints 2019-04-18 00:30:50 +01:00
varkor
3b7dd97e26 Add a FIXME to collector 2019-04-18 00:30:50 +01:00
varkor
a759e2cc12 Add own_requires_monomorphization 2019-04-18 00:30:50 +01:00
bors
9387927ae2 Auto merge of #60054 - Centril:rollup-o40xxaa, r=Centril
Rollup of 4 pull requests

Successful merges:

 - #59908 (Re-export core::str::{EscapeDebug, EscapeDefault, EscapeUnicode} in std)
 - #59984 (Remove collection-specific `with_capacity` documentation from `std::collections`)
 - #60036 (Remove nrc from toolstate pings)
 - #60037 (Resolve inconsistency in error messages between "parameter" and "variable".)

Failed merges:

r? @ghost
2019-04-17 22:24:11 +00:00
Mazdak Farrokhzad
42b3cf107d
Rollup merge of #60037 - eddyb:actually-its-param, r=estebank
Resolve inconsistency in error messages between "parameter" and "variable".

The inconsistency was introduced in 104fe1c4db24f860b890dfd25577f23ee111279a (#33619), when a label saying `type variable` was added to an error with a message talking about `type parameters`.
Given that `parameter` is far more prevalent when referring to generics in the context of Rust, IMO it should be that in both the message and the label.

r? @nikomatsakis or @estebank
2019-04-18 00:23:40 +02:00
Mazdak Farrokhzad
4664a50089
Rollup merge of #60036 - rust-lang:nrc-patch-1, r=Xanewok
Remove nrc from toolstate pings

🙉
2019-04-18 00:23:39 +02:00
Mazdak Farrokhzad
43985d965a
Rollup merge of #59984 - gluyas:collections-with_capacity-doc-fix, r=rkruppe
Remove collection-specific `with_capacity` documentation from `std::collections`

Fixes #59931

The style of `std::collections` module doc is very much a beginner friendly guide, and documenting niche, collection-specific behaviour feels out of place, if not brittle.

The note about `VecDeque` is outdated (see issue), and while `Vec` probably won't change its guarantees any time soon, the users who are interested in its allocation properties will find that in its own documentation.
2019-04-18 00:23:38 +02:00
Mazdak Farrokhzad
a20438773b
Rollup merge of #59908 - lzutao:str_escape, r=SimonSapin
Re-export core::str::{EscapeDebug, EscapeDefault, EscapeUnicode} in std

cc #59893
2019-04-18 00:23:36 +02:00
Esteban Küber
8f77a035a4 Do not mention missing PartialOrd impl when involving uncalled fns 2019-04-17 14:37:52 -07:00
Yuki OKUSHI
a1d2f7222c Rename module 2019-04-18 06:27:30 +09:00
Yuki OKUSHI
3ec0219432 Remove unnecessary condition 2019-04-18 06:22:48 +09:00
Yuki OKUSHI
53084ff92e Rename diagnositc_list into error_codes 2019-04-18 06:21:30 +09:00
Yuki OKUSHI
c97b2589ec Rename files in doc 2019-04-18 06:20:07 +09:00
bors
3c3d3c1777 Auto merge of #59527 - matklad:sized-index, r=Centril
Add test checking that Index<T: ?Sized> works

I've noticed that we have an `Idx: ?Sized` bound on the **index** in the `Index`, which seems strange given that we accept index by value. My guess is that it was meant to be removed in https://github.com/rust-lang/rust/pull/23601, but was overlooked.

If I remove this bound, `./x.py src/libstd/ src/libcore/` passes, which means at least that this is not covered by test.

I think there's three things we can do here:

* run crater with the bound removed to check if there are any regressions, and merge this, to be consistent with other operator traits
* run crater, get regressions, write a test for this with a note that "hey, we tried to fix it, its unfixable"
* decide, in the light of by-value DSTs, that this is a feature rather than a bug, and add a test

cc @rust-lang/libs

EDIT: the forth alternative is that there exist a genuine reason why this is the case, but I failed to see it :D
2019-04-17 19:18:51 +00:00
Esteban Küber
d56c82074b Fix ICE on const evaluation of const method 2019-04-17 12:00:35 -07:00
bors
8260e96760 Auto merge of #60013 - NieDzejkob:fix-16bit-usize, r=sanxiyn
Fix the max value of usize on 16-bit platforms
2019-04-17 16:23:25 +00:00
bors
6ed6f1461d Auto merge of #60034 - rasendubi:fix-comments, r=Centril
Small comments fix

- Fix comments around test harness generation
- Promote regular comments to rustdoc comments
2019-04-17 13:26:29 +00:00
Aleksey Kladov
cc3abc4d27 add a test for unsized index 2019-04-17 15:31:52 +03:00
Eduard-Mihai Burtescu
5f7055988b Resolve inconsistency in error messages between "parameter" and "variable". 2019-04-17 13:25:07 +03:00
Nick Cameron
dbbf87583b
Remove nrc from toolstate pings 2019-04-17 22:07:13 +12:00
bors
efe2f32a6b Auto merge of #60030 - Centril:rollup-3d0t24t, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #59128 (Emit ansi color codes in the `rendered` field of json diagnostics)
 - #59646 (const fn: Improve wording)
 - #59986 (Miri: refactor new allocation tagging)
 - #60003 (LLD is not supported on Darwin)
 - #60018 (Miri now supports entropy, but is still slow)

Failed merges:

r? @ghost
2019-04-17 10:03:02 +00:00
Yuki OKUSHI
b9599d1210 Rename filename 2019-04-17 18:40:45 +09:00
Yuki OKUSHI
9ad56e3b94 Rename modules 2019-04-17 18:21:34 +09:00
Yuki OKUSHI
90821add81 Rename error_reporting to diagnostics 2019-04-17 18:21:17 +09:00
Yuki OKUSHI
5f3b8d0883 Rename diagnostics to error_codes 2019-04-17 18:19:14 +09:00
Alexey Shmalko
56c0125568
Promote regular comments to rustdoc comments 2019-04-17 12:03:39 +03:00
Alexey Shmalko
7bf33f00bf
Fix comments around test harness generation 2019-04-17 12:02:04 +03:00
Mazdak Farrokhzad
eb958e1b2e
Rollup merge of #60018 - RalfJung:miri-test-libstd, r=oli-obk
Miri now supports entropy, but is still slow

Adjust the `cfg` and their comments in the test suites accordingly.
2019-04-17 10:31:37 +02:00
Mazdak Farrokhzad
23e8aaf471
Rollup merge of #60003 - petrhosek:llvm-lto-lld, r=cramertj
LLD is not supported on Darwin

Don't enable LLD when LTO is enabled on Darwin.
2019-04-17 10:31:36 +02:00
Mazdak Farrokhzad
3049f05ca1
Rollup merge of #59986 - RalfJung:miri-new-alloc, r=oli-obk
Miri: refactor new allocation tagging

Tagging and initializing `AllocExtra` now go hand-in-hand so one cannot forget to do one when doing the other. In particular, `memory.allocate` is now much easier to use correctly (because it will already return a tagged pointer).

r? @oli-obk
2019-04-17 10:31:35 +02:00
Mazdak Farrokhzad
0349b78e80
Rollup merge of #59646 - JohnTitor:improve-wording, r=oli-obk
const fn: Improve wording

fixes #59611

This might need discussion. Feel free to close this PR if we don't need to fix.
2019-04-17 10:31:33 +02:00
Mazdak Farrokhzad
c89bc54d4f
Rollup merge of #59128 - oli-obk:colorful_json, r=mark-i-m,eddyb
Emit ansi color codes in the `rendered` field of json diagnostics

cc @ljedrz

Implemented for https://github.com/rust-lang/rust/pull/56595#issuecomment-447645115 (x.py clippy)
2019-04-17 10:31:30 +02:00
Ralf Jung
d55e4b7a25 test sort_unstable in Miri 2019-04-17 09:47:36 +02:00
bors
e4e032a0ae Auto merge of #60027 - jethrogb:jb/sgx-reentry-abort, r=cramertj
SGX target: change re-entry abort logic

Even though re-entry after exit is generally not acceptable, there is a race condition where the enclave thinks it's exited but userspace doesn't know that yet. An entry during that time will currently result in an enclave panic (see https://github.com/rust-lang/rust/pull/59997#issuecomment-483846291, https://github.com/rust-lang/rust/pull/60003#issuecomment-483888170). Instead of panicking, just do a regular exit on re-entry.

cc @jseyfried
2019-04-17 07:05:39 +00:00
bors
258e3b3a75 Auto merge of #59974 - Centril:boostrap-to-2019-04-11, r=pietroalbini,Mark-Simulacrum
Bump bootstrap compiler to 2019-04-11

r? @pietroalbini
cc @Mark-Simulacrum
cc https://github.com/rust-lang/rust/pull/58702
2019-04-17 04:10:13 +00:00
Mazdak Farrokhzad
f2371e3b7d bump bootstrap; remove redundant 'use libc;' on macOS. 2019-04-17 05:45:37 +02:00