Mara Bos
6b44662669
Parse the format string for the panic_fmt lint for better warnings.
2020-10-20 22:25:42 +02:00
est31
00d23cf220
Make {u,}int_range functions a bit nicer
...
.into() guarantees safety of the conversion.
Furthermore, the minimum value of all uints is known to be 0.
2020-10-20 19:36:44 +02:00
est31
c647735f40
rustc_lint: remove unused to_string
...
In this instance, we can just pass a &str slice
and save an allocation.
2020-10-20 19:30:09 +02:00
Yuki Okushi
378ca5e640
Rollup merge of #77931 - aticu:fix_60336, r=petrochenkov
...
Fix false positive for `unused_parens` lint
Fixes #60336
2020-10-20 12:11:06 +09:00
Mara Bos
0f193d1a62
Small cleanups in assert!() and panic_fmt lint.
...
(From the PR feedback.)
Co-authored-by: Esteban Küber <esteban@kuber.com.ar>
2020-10-19 21:14:05 +02:00
Mara Bos
d3b41497fe
Also apply panic_fmt lint suggestions to debug_assert!().
2020-10-19 00:45:07 +02:00
Mara Bos
9615d27ab7
Don't see {{}}
as placeholder in panic_fmt lint.
2020-10-19 00:05:19 +02:00
Mara Bos
b8a8b681b8
Formatting.
2020-10-18 23:25:57 +02:00
Mara Bos
ded269fa10
Improve panic_fmt message for panic!("{}") with a fmt placeholder.
2020-10-18 23:25:06 +02:00
Mara Bos
f228efc3f5
Make panic_fmt lint work properly for assert!(expr, msg) too.
2020-10-18 22:29:40 +02:00
Mara Bos
da66a501f6
Specialize panic_fmt lint for the {core,std}::panic!() macros.
...
It now only reacts to expansion of those macros, and suggests
inserting `"{}", ` in the right place.
2020-10-18 22:26:36 +02:00
Mara Bos
a46679098f
Add lint to warn about braces in a panic message.
2020-10-18 22:24:15 +02:00
bors
e0ef0fc392
Auto merge of #78779 - LeSeulArtichaut:ty-visitor-return, r=oli-obk
...
Introduce `TypeVisitor::BreakTy`
Implements MCP rust-lang/compiler-team#383 .
r? `@ghost`
cc `@lcnr` `@oli-obk`
~~Blocked on FCP in rust-lang/compiler-team#383.~~
2020-11-17 12:24:34 +00:00
Bastian Kauschke
2bf93bd852
compiler: fold by value
2020-11-16 22:34:57 +01:00
LeSeulArtichaut
07b37cf791
Use TypeVisitor::BreakTy
in ProhibitOpaqueTypes
2020-11-14 22:16:16 +01:00
LeSeulArtichaut
65cdc21f06
Set the default BreakTy
to !
2020-11-14 21:46:39 +01:00
LeSeulArtichaut
e0f3119103
Introduce TypeVisitor::BreakTy
2020-11-14 20:25:27 +01:00
Dániel Buga
a7f2bb6343
Reserve space in advance
2020-11-13 11:19:25 +01:00
bors
834821e3b6
Auto merge of #78066 - bugadani:wat, r=jonas-schievink
...
Clean up small, surprising bits of code
This PR clean up a small number of unrelated, small things I found while browsing the code base.
2020-10-18 13:50:31 +00:00
Dániel Buga
2e99439900
Replace unnecessary map_or_else with map_or
2020-10-18 11:01:09 +02:00
bors
6af9846fcc
Auto merge of #77124 - spastorino:const-exprs-rfc-2920, r=oli-obk
...
Implement const expressions and patterns (RFC 2920)
cc `@ecstatic-morse` `@lcnr` `@oli-obk` `@petrochenkov`
2020-10-17 14:44:51 +00:00
Santiago Pastorino
547e5eb498
Do not check unused braces on inline consts
2020-10-16 17:14:37 -03:00
Santiago Pastorino
03defb627c
Add check_generic_arg early pass
2020-10-16 17:14:36 -03:00
Yuki Okushi
f7150be674
Suggest minimal subset features in incomplete_features
lint
2020-10-17 02:01:08 +09:00
est31
4fa5578774
Replace target.target with target and target.ptr_width with target.pointer_width
...
Preparation for a subsequent change that replaces
rustc_target::config::Config with its wrapped Target.
On its own, this commit breaks the build. I don't like making
build-breaking commits, but in this instance I believe that it
makes review easier, as the "real" changes of this PR can be
seen much more easily.
Result of running:
find compiler/ -type f -exec sed -i -e 's/target\.target\([)\.,; ]\)/target\1/g' {} \;
find compiler/ -type f -exec sed -i -e 's/target\.target$/target/g' {} \;
find compiler/ -type f -exec sed -i -e 's/target.ptr_width/target.pointer_width/g' {} \;
./x.py fmt
2020-10-15 12:02:24 +02:00
est31
215cd36e1c
Remove unused code from remaining compiler crates
2020-10-14 04:14:32 +02:00
aticu
39867f3c9f
Fixed false positive for unused_parens
lint
2020-10-14 01:16:40 +02:00
Yuki Okushi
410fc0e3db
Do not provide suggestions for non standard characters
2020-10-11 07:41:25 +09:00
bors
8ae3b50976
Auto merge of #77119 - GuillaumeGomez:unclosed-html-tag-lint, r=jyn514
...
Unclosed html tag lint
Part of #67799 .
I think `@ollie27` will be interested (`@Manishearth` too since they opened the issue ;) ).
r? `@jyn514`
2020-10-07 09:56:51 +00:00
Matthew Jasper
f958e6c246
Separate bounds and predicates for associated/opaque types
2020-10-06 11:19:29 +01:00
Felix S. Klock II
afa2a67545
Prevent forbid from being ignored if overriden at the same level.
...
That is, this changes `#[forbid(foo)] #[allow(foo)]` from allowing foo to
forbidding foo.
2020-10-04 13:14:01 -04:00
Guillaume Gomez
e6027a42e1
Add unclosed_html_tags
lint
2020-10-03 14:16:23 +02:00
Michael Howell
cd159fd7f9
Uplift drop-bounds lint from clippy
2020-10-01 12:06:33 -07:00
Joshua Nelson
03d8be0896
Separate private_intra_doc_links
and broken_intra_doc_links
into separate lints
...
This is not ideal because it means `deny(broken_intra_doc_links)` will
no longer `deny(private_intra_doc_links)`. However, it can't be fixed
with a new lint group, because `broken` is already in the `rustdoc` lint
group; there would need to be a way to nest groups somehow.
This also removes the early `return` so that the link will be generated
even though it gives a warning.
2020-09-27 09:58:29 -04:00
Ralf Jung
9e02642fb3
Rollup merge of #77211 - est31:remove_unused_allow, r=oli-obk
...
Remove unused #[allow(...)] statements from compiler/
2020-09-26 12:58:34 +02:00
est31
12187b7f86
Remove unused #[allow(...)] statements from compiler/
2020-09-26 01:25:55 +02:00
marmeladema
bb8e1764bb
Simplify some match statements on `DefPathDataName'
2020-09-25 22:46:15 +01:00
marmeladema
657ecdb75e
Rename DefPathData::get_name()
to DefPathData::name()
2020-09-25 22:46:15 +01:00
marmeladema
f1878d19fa
Move from {{closure}}#0 syntax to {closure#0} for (def) path components
2020-09-25 22:46:14 +01:00
Jonas Schievink
6f3da3d53f
Rollup merge of #77121 - duckymirror:html-root-url, r=jyn514
...
Updated html_root_url for compiler crates
Closes #77103
r? @jyn514
2020-09-25 02:29:45 +02:00
Erik Hofmayer
138a2e5eaa
/nightly/nightly-rustc
2020-09-23 21:51:56 +02:00
Erik Hofmayer
dd66ea2d3d
Updated html_root_url for compiler crates
2020-09-23 21:14:43 +02:00
Dylan DPC
bcdbe79f0c
Rollup merge of #76994 - yuk1ty:fix-small-typo, r=estebank
...
fix small typo in docs and comments
Fixed `the the` to `the`, as far as I found.
2020-09-23 14:54:07 +02:00
ecstatic-morse
0863f9a965
Rollup merge of #77032 - lcnr:visit-all-the-item-likes, r=davidtwco
...
lint missing docs for extern items
fixes #76991
2020-09-21 20:41:01 -07:00
ecstatic-morse
50d4aebc7a
Rollup merge of #76914 - lcnr:path-no-more, r=ecstatic-morse
...
extend `Ty` and `TyCtxt` lints to self types
blocked on #76891
r? @ecstatic-morse cc @Aaron1011
2020-09-21 20:40:57 -07:00
Bastian Kauschke
d452744100
lint missing docs for extern items
2020-09-22 00:02:46 +02:00
Bastian Kauschke
8fc782afc2
add test
2020-09-21 20:36:05 +02:00
yuk1ty
16047d46a1
fix typo in docs and comments
2020-09-21 12:14:28 +09:00
Ralf Jung
7ff17c13bc
Rollup merge of #76910 - lcnr:foreign-item-like, r=oli-obk
...
transmute: use diagnostic item
closes #66075 , we now have no remaining uses of `match_def_path` in the compiler while some uses still remain in `clippy`.
cc @RalfJung
2020-09-20 15:52:04 +02:00
Ralf Jung
8405d50e12
Rollup merge of #76890 - matthiaskrgr:matches_simpl, r=lcnr
...
use matches!() macro for simple if let conditions
2020-09-20 15:52:01 +02:00