Takayuki Nakata
6494bd0bac
Revert "Add rustfmt::skip
as a work around"
...
This reverts commit 0e803417f997ba35c0045704dd347e64c2a1786c.
Fixed by https://github.com/rust-lang/rustfmt/issues/4528 .
2020-11-18 12:36:47 +09:00
bors
8c2e2fd4ec
Auto merge of #6340 - giraffate:improve_doc_for_map_clone, r=Manishearth
...
Improve doc about `map_clone`
A follow up of https://github.com/rust-lang/rust-clippy/issues/6239#issuecomment-719100677 .
`map_clone` works with not only `Iterator` but `Option` although not written in [doc](https://rust-lang.github.io/rust-clippy/master/#map_clone ). Also, an example in the doc shows a usage of dereferencing, but this isn't also written.
changelog: Improve doc about `map_clone`
2020-11-18 02:49:29 +00:00
Takayuki Nakata
0502ac2a87
Improve doc about map_clone
2020-11-18 08:33:25 +09:00
bors
44d944586c
Auto merge of #6070 - matsujika:unnecessary_wrap, r=flip1995
...
Add new lint `unnecessary_wrap`
Fixes #5969
changelog: New lint [`unnecessary_wraps`]
2020-11-17 20:28:32 +00:00
bors
5464cbed2f
Auto merge of #6337 - ThibsG:FixIce6332, r=Manishearth
...
Remove `expect()` calls to avoid ICEs in `deref_addrof` lint
Fixes : #6332
changelog: none
2020-11-17 17:55:46 +00:00
bors
a8cafc6196
Auto merge of #6338 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
changelog: none
2020-11-17 17:10:04 +00:00
flip1995
bf2d31d053
Run cargo dev fmt
2020-11-17 18:08:12 +01:00
Hirochika Matsumoto
c7445d7f2c
Pluralize lint name
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
1f577c0300
Fix embarrassing grammatical error
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
4e5c02e898
Ignore trait implementations
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
4c8d248190
Update stderr files
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
86331a46e4
Update stderr files
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
bf46f78ca7
Fix clippy error
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
532d205218
Skip functions in PartialOrd
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
9d96311d73
Remove wildcard use
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
e998d61fe6
Downgrade applicability to MaybeIncorrect
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
30632fb8e6
Allow this lint on lint tests
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
c7692cf749
Skip function with no exprs contained
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
c5447eb3c1
Make lint skip macros
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
12474c62ff
Add support for methods
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
2f85aa736e
Make lint skip closures
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
8392bc7946
Run cargo dev fmt
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
1bdac87128
Improve lint message
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
eec7f5c111
Update clippy_lints/src/unnecessary_wrap.rs
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
df0d565e59
Move find_all_ret_expressions
into utils
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
6b55f3fec9
Add test case
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
cdb72df6f9
Split lint suggestion into two
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
a433d4690e
Run rustfmt
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
c775856727
Call diag.multipart_suggestion
instead
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
3ed8902623
Fix typo
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
6a62390c86
Optout rustfix test
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
ebdd4e2c72
Refactor code according to reivews
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
0e9d227c04
Add test cases
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
0335b8d6a7
Fix lint example
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
750c118b34
Add suggestion on type signatures
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
a7ac441760
Add new lint to detect unnecessarily wrapped value
2020-11-18 01:28:37 +09:00
bors
a467c514a3
Auto merge of #78779 - LeSeulArtichaut:ty-visitor-return, r=oli-obk
...
Introduce `TypeVisitor::BreakTy`
Implements MCP rust-lang/compiler-team#383 .
r? `@ghost`
cc `@lcnr` `@oli-obk`
~~Blocked on FCP in rust-lang/compiler-team#383.~~
2020-11-17 12:24:34 +00:00
ThibsG
5b8f2b6c93
Remove expect()
calls to avoid ICEs in deref_addrof
lint
2020-11-16 23:30:11 +01:00
Bastian Kauschke
3567ea546f
clippy: fold by value
2020-11-16 22:42:09 +01:00
bors
ad4f82997a
Auto merge of #6119 - rsulli55:find_is_some_on_strs, r=flip1995
...
Add a case to `lint_search_is_some` to handle searching strings
Fixes : #6010
This adds a lint which recommends using `contains()` instead of `find()` followed by `is_some()` on strings as suggested in #6010 .
This was added as an additional case to
5af88e3c2d/clippy_lints/src/methods/mod.rs (L3037)
I would really appreciate any comments/suggestions for my code!
changelog: Added case to `lint_search_is_some` to handle searching strings
2020-11-16 08:45:10 +00:00
bors
df3bb5881d
Auto merge of #6336 - giraffate:sync-from-rust, r=flip1995
...
Rustup
changelog: none
2020-11-16 08:23:27 +00:00
Takayuki Nakata
0e803417f9
Add rustfmt::skip
as a work around
...
because comments are checked and removed by rustfmt for some reason
2020-11-16 12:32:16 +09:00
bors
db0464103e
Auto merge of #6334 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
changelog: none
2020-11-15 13:09:53 +00:00
Jonas Schievink
27a15721c5
Rollup merge of #79016 - fanzier:underscore-expressions, r=petrochenkov
...
Make `_` an expression, to discard values in destructuring assignments
This is the third and final step towards implementing destructuring assignment (RFC: rust-lang/rfcs#2909, tracking issue: #71126 ). This PR is the third and final part of #71156 , which was split up to allow for easier review.
With this PR, an underscore `_` is parsed as an expression but is allowed *only* on the left-hand side of a destructuring assignment. There it simply discards a value, similarly to the wildcard `_` in patterns. For instance,
```rust
(a, _) = (1, 2)
```
will simply assign 1 to `a` and discard the 2. Note that for consistency,
```
_ = foo
```
is also allowed and equivalent to just `foo`.
Thanks to ````@varkor```` who helped with the implementation, particularly around pre-expansion gating.
r? ````@petrochenkov````
2020-11-15 13:39:48 +01:00
LeSeulArtichaut
1b55cc79cc
Set the default BreakTy
to !
2020-11-14 21:46:39 +01:00
LeSeulArtichaut
cbb6b1c338
Introduce TypeVisitor::BreakTy
2020-11-14 20:25:27 +01:00
bors
0c7a48c5f0
Auto merge of #78809 - vn-ki:fix-issue-76064, r=oli-obk
...
add error_occured field to ConstQualifs,
fix #76064
I wasn't sure what `in_return_place` actually did and not sure why it returns `ConstQualifs` while it's sibling functions return `bool`. So I tried to make as minimal changes to the structure as possible. Please point out whether I have to refactor it or not.
r? `@oli-obk`
cc `@RalfJung`
2020-11-14 18:03:17 +00:00
Fabian Zaiser
864e554b9a
Add underscore expressions for destructuring assignments
...
Co-authored-by: varkor <github@varkor.com>
2020-11-14 13:53:12 +00:00
bors
408b615d34
Auto merge of #6320 - giraffate:fix_suggestion_in_manual_range_contains_using_float, r=llogiq
...
Fix suggestion in `manual_range_contains` when using float
Fix #6315
changelog: Fix suggestion in `manual_range_contains` when using float
2020-11-14 08:06:00 +00:00
Vishnunarayan K I
7987f39ad5
update clippy test ouput
2020-11-13 17:11:13 +05:30