León Orell Valerian Liehr
63caef372a
Improve support for code block attributes
2020-08-26 15:55:06 +02:00
bors[bot]
d58a3a277a
Merge #5885
...
5885: Make inlay hints colors more configurable r=matklad a=Veetaha
**[BREAKING CHANGE]**
Tackles https://github.com/rust-analyzer/rust-analyzer/issues/5337#issuecomment-680018601 and generally related to #5337 .
Added `foreground/background` color configurations with optional more specific overrides `foreground.(type|parameter|chaining)Hints`.
One problem I see is that the config keys are long and don't fit into the on-hover hints in the `settings.json` file entirely...
<details>
<summary>Demo</summary>
![demo](https://user-images.githubusercontent.com/36276403/91238334-77fc3b00-e745-11ea-836b-2822015ece98.gif )
</details>
Co-authored-by: Veetaha <veetaha2@gmail.com>
2020-08-26 13:07:06 +00:00
bors[bot]
ad60b4e6ea
Merge #5890
...
5890: Simplify
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-26 11:41:20 +00:00
Aleksey Kladov
7431ec82c9
Simplify
2020-08-26 13:40:45 +02:00
bors[bot]
868aaf2bc6
Merge #5889
...
5889: Allow logging to file r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-26 11:21:17 +00:00
Aleksey Kladov
ed6304131a
Simplify
2020-08-26 13:20:46 +02:00
Aleksey Kladov
bb50614d88
Simplify help
2020-08-26 13:20:46 +02:00
Aleksey Kladov
a53c6f6fee
Allow redirecting logs to a specific file
...
There's a surprising lack of crates which are like env_logger, but
also allow writing to a file. Let's write our own then!
2020-08-26 13:20:46 +02:00
bors[bot]
51f5af223f
Merge #5888
...
5888: **Inline Variable** works with field shorthand
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-26 11:04:00 +00:00
Aleksey Kladov
0fc8fd2bd5
**Inline Variable** works with field shorthand
2020-08-26 13:03:14 +02:00
Veetaha
5b9a882edc
Make inlay hints colors more configurable
2020-08-26 02:53:42 +03:00
bors[bot]
f647edcb08
Merge #5884
...
5884: Add sysroot shortcut to rust-project.json
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 17:42:27 +00:00
Aleksey Kladov
189521a4db
Add sysroot shortcut to rust-project.json
2020-08-25 19:41:56 +02:00
bors[bot]
91bedefe49
Merge #5883
...
5883: Cleanup heavy tests
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 17:29:50 +00:00
Aleksey Kladov
c6dffe479b
Cleanup heavy tests
2020-08-25 19:26:45 +02:00
bors[bot]
6141e2706a
Merge #5882
...
5882: Don't expose indexing details
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 16:41:10 +00:00
Aleksey Kladov
9786a8f2d4
Don't expose indexing details
2020-08-25 18:40:41 +02:00
bors[bot]
13fd8846b4
Merge #5881
...
5881: Minor
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 16:08:56 +00:00
Aleksey Kladov
4f6ca0e081
Minor
2020-08-25 18:07:25 +02:00
bors[bot]
33c4afeae0
Merge #5880
...
5880: Opportunistically check indel overlap r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 16:01:47 +00:00
Aleksey Kladov
7239d8ca95
Provide better stack trace for overlapping edits
...
Overlapping indels are a bug. Checking this *always* is tricky (needs
a sorted data structure to not suffer O(N^2) perf). But
opportunistically checking small indels should give provide 80% of the
benefits.
2020-08-25 17:59:37 +02:00
bors[bot]
3f721683de
Merge #5878
...
5878: Prepare to share sysroot lowering code between Cargo & ProjectJSON
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 15:54:05 +00:00
Aleksey Kladov
7fcda5aa46
Prepare to share sysroot lowering code between Cargo & ProjectJSON
2020-08-25 17:53:24 +02:00
bors[bot]
32be2d60af
Merge #5877
...
5877: Complete `pub` in fields
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 15:23:16 +00:00
Aleksey Kladov
18b667cfcb
Complete pub
in fields
2020-08-25 17:22:23 +02:00
bors[bot]
ad7e7d6b8e
Merge #5876
...
5876: Prep work for overriding sysroot
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 15:04:47 +00:00
Aleksey Kladov
6b8bc132dc
Prep work for overriding sysroot
...
The idea here is to make auto-discovery optional, and to allow to set
the path to sysroot directly. This is handy for JSON projects.
2020-08-25 17:04:24 +02:00
bors[bot]
81a3404d8f
Merge #5875
...
5875: Remove monomorphisation from doclinks resolving code
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 12:59:22 +00:00
Aleksey Kladov
cd9ecdf467
Remove monomorphisation from doclinks resolving code
2020-08-25 14:58:22 +02:00
bors[bot]
2441e8eaaf
Merge #5873
...
5873: Correct sed replacement when called in a bash file r=matklad a=pksunkara
There's so much trial and error regarding shells and stuff I needed to do to get this correctly working on github runner.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-08-25 12:51:28 +00:00
bors[bot]
34754bd0e2
Merge #5874
...
5874: Remove AttrDef
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 12:45:02 +00:00
Aleksey Kladov
66e5ced894
Remove AttrDef
2020-08-25 14:44:15 +02:00
Pavan Kumar Sunkara
6d46583f0f
Correct sed replacement when called in a bash file
2020-08-25 14:43:22 +02:00
bors[bot]
8a845eda7b
Merge #5870
...
5870: Move code_model attrs to a new module r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 10:58:27 +00:00
Aleksey Kladov
7487885309
Simplify
2020-08-25 12:58:00 +02:00
Aleksey Kladov
575fb9ab6a
Move attrs from code_module to a separate module
2020-08-25 12:56:01 +02:00
bors[bot]
463d44075f
Merge #5869
...
5869: Minor
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 10:48:51 +00:00
Aleksey Kladov
663749beab
Minor
2020-08-25 12:48:00 +02:00
bors[bot]
4f91478e50
Merge #5867
...
5867: Use the same abstraction for attrs and docs
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 10:14:45 +00:00
Aleksey Kladov
b45dd9ef54
Use the same abstraction for attrs and docs
...
Doc comments *are* attributes, so there's no reason to have two crates
here.
2020-08-25 12:13:31 +02:00
bors[bot]
59c77ff062
Merge #5866
...
5866: Improve logging
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 09:46:21 +00:00
Aleksey Kladov
3a72afed8c
Improve logging
2020-08-25 11:43:21 +02:00
bors[bot]
ed51f5b424
Merge #5865
...
5865: Rename rust_analyzer lib in the binaries before publishing r=matklad a=pksunkara
@matklad Tested and working with publish dry run. Please run the action manually once merged.
Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-08-25 09:40:36 +00:00
Pavan Kumar Sunkara
2d75b3305d
Rename rust_analyzer lib in the binaries before publishing
2020-08-25 11:32:22 +02:00
bors[bot]
96cbad9fb5
Merge #4873
...
4873: Resolve links in hover documentation r=matklad a=zacps
This PR resolves links in hover documentation. Both the upcoming intra-doc-links style and the old "path-based" style.
## Todo
* [x] More tests
* [ ] Benchmark (Is there an easy way to benchmark this?)
* [x] ~~Resolve issues with the markdown parser/get rid of it~~ Migrate to `pulldown_cmark_to_cmark`
* [x] Reorganise code (Tips appreciated)
---
Fixes #503
Co-authored-by: Zac Pullar-Strecker <zacmps@gmail.com>
2020-08-25 09:11:26 +00:00
bors[bot]
b4bc346498
Merge #5863
...
5863: Cleanup invert-if
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-25 09:01:12 +00:00
Aleksey Kladov
7721accebf
Cleanup invert-if
...
* stick to trivial factory functions in make
* compress the logic for inverting Option/Result
2020-08-25 11:00:32 +02:00
Zac Pullar-Strecker
b835f06cec
Merge remote-tracking branch 'upstream/master' into 503-hover-doc-links
2020-08-25 16:44:36 +12:00
Zac Pullar-Strecker
452afaebe1
Changes from review
2020-08-25 16:40:43 +12:00
bors[bot]
ef9cea945d
Merge #5861
...
5861: Support extern types r=matklad a=jonas-schievink
This is a currently unstable feature tracked at https://github.com/rust-lang/rust/issues/43467
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2020-08-24 20:10:16 +00:00