Aleksey Kladov
0650f77dd9
internal: remove one more immutable tree
2021-05-14 16:19:27 +03:00
Aleksey Kladov
ad0648dc95
Cleanup imports
2021-05-13 13:44:47 +03:00
Jonas Schievink
b8d40a02a9
Document viewCrateGraph request
2021-05-11 16:45:51 +02:00
John Renner
7ae3967e57
Formatting and docs
2021-05-10 13:34:09 -07:00
Lukas Wirth
59c2efe4b6
Update docs
2021-05-10 22:10:12 +02:00
Aleksey Kladov
078c8f7488
fix: fix manual rendering
...
We add `// see the other repo` comments before headers (==). This one isn't a header, but a closing of the example block.
2021-05-10 15:43:01 +03:00
Aleksey Kladov
ca0aef2f3f
feat: make troubleshooting a top-level section
2021-05-08 13:48:25 +03:00
Aleksey Kladov
a191b24fec
feat: friendlier trouble shooting guide
2021-05-08 13:18:25 +03:00
Méven Car
b39578d816
docs: Add Kate installation section
2021-05-08 07:33:24 +02:00
Aleksey Kladov
0fce38b138
fix: direct people to the right repository
2021-05-08 00:26:29 +03:00
Aleksey Kladov
d4a51241ce
internal: explain why sentence-per-line
2021-05-06 17:40:36 +03:00
Aleksey Kladov
3f6980e4e1
simplify macro expansion code
...
Using `Option` arguments such that you always pass `None` or `Some` at
the call site is a code smell.
2021-05-04 22:41:46 +03:00
bors[bot]
a2349366b5
Merge #8482
...
8482: Mention how to customize unsafe operation styles r=matklad a=danielzfranklin
I was confused about how to do this, so I filed #8474 . I apologize for initially filing this incorrectly and spamming people.
Co-authored-by: Daniel Franklin <daniel@danielzfranklin.org>
2021-05-03 16:57:51 +00:00
Daniel Franklin
13e9fb73f9
Merge with semantic style section
2021-05-03 17:54:09 +01:00
Aleksey Kladov
5c1a901035
internal: ensure that client and server-side configs are not mixed up
...
https://github.com/rust-lang/rust/issues/84647 would help big time here.
2021-04-28 13:13:30 +03:00
Jorge Mederos Alvarado
c4dba4077f
Add config options
2021-04-26 20:29:54 -04:00
bors[bot]
576f50637c
Merge #8605
...
8605: internal: Automatically categorize the changelog entries r=matklad a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-04-22 17:35:41 +00:00
bors[bot]
d1c9bd134d
Merge #8621
...
8621: feat: make sure nightly regressions don't break users r=lnicola a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-04-22 08:29:01 +00:00
Aleksey Kladov
27073f4fc3
feat: make sure nightly regressions don't break users
2021-04-22 11:15:20 +03:00
James Leitch
72718bc2d7
Code review feedback.
2021-04-21 15:10:53 -07:00
James Leitch
9fcad82980
Diagnostic Remap Path Prefixes added.
2021-04-21 15:10:53 -07:00
Laurențiu Nicola
39ce393a9e
Automatically categorize the changelog entries
2021-04-20 19:54:58 +03:00
bors[bot]
1834938d6f
Merge #8598
...
8598: minor: fix ugly line wrapping in the rendered manual r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-04-20 07:45:04 +00:00
Aleksey Kladov
0ce591d33d
minor: fix ugly line wrapping in the rendered manual
2021-04-20 10:44:06 +03:00
bors[bot]
15b34667c5
Merge #8588
...
8588: internal: Add guidelines for release notes PR descriptions r=matklad a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-04-19 18:38:34 +00:00
Laurențiu Nicola
bb4952da04
internal: Add guidelines for release notes PR descriptions
2021-04-19 21:30:44 +03:00
Aleksey Kladov
dcb759b727
Remove confusion around serverStatusNotification
2021-04-19 18:12:25 +03:00
Aleksey Kladov
e5d91e8992
Fix spec bug
2021-04-19 17:55:51 +03:00
Aleksey Kladov
453b9cf6f0
Update docs/dev/README.md
...
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
2021-04-19 16:08:50 +03:00
Aleksey Kladov
ad24310d41
internal: document review requesting etiquette
...
* don't feel obliged to quickly review every PR assigned to you
* so that other folks can notify you about interesting PRs without
thinking to much about creating additional work for you
2021-04-19 16:08:49 +03:00
Lukas Wirth
b501b59eda
Update lsp-extensions docs
2021-04-18 12:50:44 +02:00
Jonas Schievink
93128efef8
Fix markdown links
2021-04-15 19:45:07 +02:00
bors[bot]
3af303600a
Merge #8510 #8533
...
8510: Move cursor position when using item movers r=jonas-schievink a=jonas-schievink
This updates the cursor position when moving items around to stay in the same location within the moved node.
I changed the `moveItem` response to `SnippetTextEdit[]`, since that made more sense to me (the file was ignored by the client anyways, since the edits always apply to the current document). It also matches `onEnter`, which seems logical to me, but please let me know if this doesn't make sense.
There's still a bug in the client-side snippet code that will cause the cursor position to be slightly off when moving parameters in the same line (presumably we don't track the column correctly after deleting `$0`). Not really sure how to fix that immediately, but this PR should already be an improvement despite that bug.
8533: Fix typo in style guide r=jonas-schievink a=jonas-schievink
Fixes bold text rendering
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2021-04-15 16:42:36 +00:00
Jonas Schievink
6e575d8c73
Fix typo in style guide
2021-04-15 18:38:52 +02:00
Jonas Schievink
30aae2cefb
Move cursor position when using item movers
2021-04-14 00:03:04 +02:00
bors[bot]
9beed98f2a
Merge #8432
...
8432: decl_check: consider outer scopes' allows r=jonas-schievink a=lf-
Fix #8417 . Also makes it less noisy about no_mangle annotated stuff the
user can do nothing about.
Note: this still is broken with bitfield! macros. A repro in an ignore
test is included here. I believe this bug is elsewhere, and I don't
think I can work around it here.
I would like help filing the remaining bug, as it does actually affect
users, but I don't know how to describe the behaviour (or even if it
is unintended).
Co-authored-by: Jade <software@lfcode.ca>
2021-04-13 12:02:26 +00:00
Aleksey Kladov
db2a989565
internal: don't use #[should_panic] for tests
2021-04-13 12:21:59 +03:00
Aleksey Kladov
c8f48f50b3
internal: clarify who a rls-2.0 wg
2021-04-12 19:19:16 +03:00
Daniel Franklin
23429a08d5
Mention how to customize unsafe operation styles
...
I was confused about how to do this, so I filed [an issue][issue].
[issue]: rust-analyzer/rust-analyzer#8474
2021-04-12 16:18:04 +01:00
Aleksey Kladov
186c5c47cb
feat: avoid checking the whole project during initial loading
2021-04-12 15:29:31 +03:00
Jade
4529f1be81
decl_check: consider outer scopes' allows
...
Fix #8417 . Also makes it less noisy about no_mangle annotated stuff the
user can do nothing about.
Note: this still is broken with bitfield! macros. A repro in an ignore
test is included here. I believe this bug is elsewhere, and I don't
think I can work around it here.
2021-04-08 14:43:19 -07:00
Laurențiu Nicola
7221188b0d
Remove extra bracket in architecture docs
2021-04-08 17:51:19 +03:00
Kirill Bulatov
e785672f15
Adjust fixture docs a bit
2021-04-06 21:42:27 +03:00
Kirill Bulatov
b5f3815aee
Small grammar fixes
2021-04-06 21:42:27 +03:00
Kirill Bulatov
d5bedf8d6d
Update Zulip link and macro privacy statement
2021-04-06 21:42:27 +03:00
Aleksey Kladov
658776d4ed
internal: document broken windows
2021-04-06 20:11:42 +03:00
Aleksey Kladov
8fe20b19d4
More robust status notifications
2021-04-06 15:45:31 +03:00
Aleksey Kladov
a01fd1af19
internal: explain "extract if condition" refactoring
2021-04-05 13:02:47 +03:00
sim
d542a2b463
docs: Fix moveItem method name
2021-04-04 11:49:32 -07:00
Aleksey Kladov
636c3c49d2
internal: document style for helper functions and variables
2021-04-02 14:52:00 +03:00
Aleksey Kladov
27b779d1fd
internal: document Cargo.lock maintenance process
2021-04-02 13:59:36 +03:00
Aleksey Kladov
ff8142d47e
internal: touch up dev readme
2021-03-30 13:30:38 +03:00
PSeitz
14a1f0ce46
remove enumeration
2021-03-29 22:09:04 +02:00
PSeitz
3153a80261
update vim ycm installation instruction
2021-03-29 21:31:29 +02:00
Aleksey Kladov
b352b90c86
internal: make --log-file more discoverable
2021-03-29 15:11:31 +03:00
Laurențiu Nicola
ea8159893a
Mention the rustup version in the manual
2021-03-27 12:39:16 +02:00
Thiébaud Weksteen
1c68954a7d
Fix manual description for rust_project.json
2021-03-25 10:02:16 +01:00
Kirill Bulatov
5e83a56dfb
Bump the default hint length
2021-03-23 19:43:55 +02:00
Kirill Bulatov
f1e1a2c0a7
Limit the hints size by default
2021-03-23 19:04:48 +02:00
bors[bot]
d4fa6721af
Merge #8054
...
8054: Item movers r=matklad a=ivan770
Closes #6823
https://user-images.githubusercontent.com/14003886/111331579-b4f43480-8679-11eb-9af0-e4dabacc4923.mp4
Implementation issues:
- [ ] Most of items are non-movable, since _movability_ of any item has to be determined manually. Common ones are movable though
- [x] Cursor should move with the item
Co-authored-by: ivan770 <leshenko.ivan770@gmail.com>
2021-03-22 13:08:45 +00:00
bors[bot]
6f1f91cdcf
Merge #8136 #8146
...
8136: Introduce QuantifiedWhereClause and DynTy analogous to Chalk r=flodiebold a=flodiebold
This introduces a bunch of new binders in lots of places, which we have to be careful about, but we had to add them at some point. There's a lot of skipping of the binders; once we're done with the Chalk move, we should review the remaining ones.
8146: Document patch policy r=matklad a=matklad
bors r+
🤖
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-03-22 12:08:25 +00:00
Aleksey Kladov
79b4c89b89
Update docs/dev/README.md
...
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
2021-03-22 15:08:04 +03:00
Aleksey Kladov
aab148f943
Document patch policy
2021-03-22 14:59:56 +03:00
Aleksey Kladov
2469af3017
Apply suggestions from code review
...
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
2021-03-22 13:56:13 +03:00
Aleksey Kladov
2b427fa3dd
Update docs/user/manual.adoc
...
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
2021-03-22 13:55:16 +03:00
Aleksey Kladov
63e083122c
Document our security stance
...
changelog: feature
2021-03-22 13:53:00 +03:00
Aleksey Kladov
670964d802
Update docs/user/manual.adoc
2021-03-18 18:57:44 +03:00
Mickael Istria
c0425cbdbd
Update info about Eclipse Corrosion
2021-03-18 16:22:54 +01:00
ivan770
7d60458495
Item up and down movers
2021-03-18 11:22:27 +02:00
Aleksey Kladov
30dea3a727
Prefer match to if let else
2021-03-16 10:51:05 +03:00
Aleksey Kladov
469b739c28
Enable proc-macros by default
2021-03-15 18:19:08 +03:00
Laurențiu Nicola
dd9974c59d
Fix cargo xtask lint references
2021-03-14 15:24:34 +02:00
bors[bot]
7accf6bc37
Merge #7799
...
7799: Related tests r=matklad a=vsrs
This adds an ability to look for tests for the item under the cursor: function, constant, data type, etc
The LSP part is bound to change. But the feature itself already works and I'm looking for a feedback :)
Co-authored-by: vsrs <vit@conrlab.com>
2021-03-13 13:50:35 +00:00
Lukas Wirth
ebf4448f78
Fix remaining references to cargo xtask codegen
2021-03-12 15:10:33 +01:00
vsrs
49cdb2452a
Fix LSP extensions documentation
2021-03-11 17:59:27 +03:00
Aleksey Kladov
37b7b56821
Make code less surprising
...
Theres no reason to have literal `\n\n` in the source code
2021-03-09 14:47:42 +03:00
bors[bot]
844b7f7411
Merge #7927
...
7927: Add more documentation for rustc_private r=matklad a=jyn514
Co-authored-by: Joshua Nelson <jyn514@gmail.com>
2021-03-09 11:22:37 +00:00
Aleksey Kladov
5b2b310827
Clarify that all caps are experimental
2021-03-09 12:02:20 +03:00
Joshua Nelson
c7b0914b3f
Add more documentation for rustc_private
2021-03-08 16:56:42 -05:00
Laurențiu Nicola
fc9eed4836
Use upstream cov-mark
2021-03-08 22:19:44 +02:00
Aleksey Kladov
9faf8dd69a
Hygiene is an internal implementation detail of the compiler
2021-03-08 22:14:52 +03:00
Aleksey Kladov
1eb61203b7
Make code generation just work
...
Contributors don't need to learn about `cargo xtask codegen` if `cargo
test` just does the right thing.
2021-03-08 21:45:37 +03:00
bors[bot]
d57c9f7980
Merge #7891
...
7891: Improve handling of rustc_private r=matklad a=DJMcNab
This PR changes how `rust-analyzer` handles `rustc_private`. In particular, packages now must opt-in to using `rustc_private` in `Cargo.toml`, by adding:
```toml
[package.metadata.rust-analyzer]
rustc_private=true
```
This means that depending on crates which also use `rustc_private` will be significantly improved, since their dependencies on the `rustc_private` crates will be resolved properly.
A similar approach could be used in #6714 to allow annotating that your package uses the `test` crate, although I have not yet handled that in this PR.
Additionally, we now only index the crates which are transitive dependencies of `rustc_driver` in the `rustcSource` directory. This should not cause any change in behaviour when using `rustcSource: "discover"`, as the source used then will only be a partial clone. However, if `rustcSource` pointing at a local checkout of rustc, this should significantly improve the memory usage and lower indexing time. This is because we avoids indexing all crates in `src/tools/`, which includes `rust-analyzer` itself.
Furthermore, we also prefer named dependencies over dependencies from `rustcSource`. This ensures that feature resolution for crates which are depended on by both `rustc` and your crate uses the correct set for analysing your crate.
See also [introductory zulip stream](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Fixed.20crate.20graphs.20and.20optional.20builtin.20crates/near/229086673 )
I have tested this in [priroda](https://github.com/oli-obk/priroda/ ), and it provides a significant improvement to the development experience (once I give `miri` the required data in `Cargo.toml`)
Todo:
- [ ] Documentation
This is ready to review, and I will add documentation if this would be accepted (or if I get time to do so anyway)
Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
2021-03-08 16:51:20 +00:00
Daniel McNab
20007fd3a8
Document rustc_private in metadata
2021-03-08 16:47:40 +00:00
Daniel McNab
bbecea03fd
Revert "Support disabling rustc build scripts"
...
This reverts commit ddce6bb282
2021-03-08 16:37:52 +00:00
Aleksey Kladov
c7b5d6be4c
Make code completion "just work" in more cases
2021-03-08 14:57:56 +03:00
Daniel McNab
ddce6bb282
Support disabling rustc build scripts
2021-03-08 09:05:19 +00:00
bors[bot]
d54e1157b6
Merge #7889
...
7889: Make group imports configurable r=lnicola a=asv1
Co-authored-by: asv <asv7c2@gmail.com>
2021-03-07 08:24:02 +00:00
asv
96fc01a30b
Make group imports configurable
2021-03-07 10:15:17 +02:00
Florian Diebold
d6094c70fb
Add a line about code action commands to the CoC section of the docs
2021-03-06 11:35:04 +01:00
bors[bot]
16a76aa158
Merge #7868
...
7868: Migrate to user-centric config name for `cargo check` stuff r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-03-04 12:39:36 +00:00
Aleksey Kladov
3d80e0a154
Migrate to user-centric config name for cargo check stuff
2021-03-04 15:38:53 +03:00
Aleksey Kladov
e15621482c
Clarify comparison rule
2021-03-03 11:23:05 +03:00
Aleksey Kladov
979c26e1ae
Axe pre-commit
2021-03-01 21:30:21 +03:00
Vincent Esche
c4e2f32d73
Fixed remaining references to AnalysisChange (now: Change)
...
(The type was renamed/moved in 8716c4cec3
2021-02-28 12:57:41 +01:00
vsrs
5e88436517
Update lsp-extensions.md
2021-02-27 21:07:58 +03:00
boxdot
9b78a6f6d2
Fix typo.
2021-02-24 11:56:48 +01:00
azzamsa
ae50b18503
Fix typos
2021-02-20 17:53:19 +07:00
Aleksey Kladov
3f09e3fba6
document offsets
2021-02-16 19:22:09 +03:00
bors[bot]
d50a37d3aa
Merge #7643 #7663
...
7643: Automatically detect the rustc-src directory (fixes #3517 ) r=matklad a=bnjbvr
If the configured rustcSource was not set, then try to automatically
detect a source for the sysroot rustc directory.
I wasn't sure how to do it in the case of the project.json file, though.
7663: Tolerate spaces in nix binary patching r=matklad a=CertainLach
If path to original file contains space (I.e on code insiders, where
default data directory is ~/Code - Insiders/), then there is syntax
error evaluating src arg.
Instead pass path as str, and coerce to path back in nix expression
Co-authored-by: Benjamin Bouvier <public@benj.me>
Co-authored-by: Yaroslav Bolyukin <iam@lach.pw>
2021-02-14 15:42:07 +00:00
ivan770
13e9d9809a
Remove CodeLensResolveData mention from lsp-extensions.md
2021-02-13 19:36:29 +02:00
Benjamin Bouvier
4a6e602c94
Allow automatically detect the rustc-src directory ( fixes #3517 ).
...
If the configured rustcSource is set to "discover", try to automatically
detect a source from the sysroot rustc directory.
2021-02-13 18:20:46 +01:00
ivan770
185da286d2
Moved CodeLens to ide crate
2021-02-13 13:07:47 +02:00
Laurențiu Nicola
8814d1368d
Include a commit log summary in the changelog
2021-02-12 19:53:58 +02:00
bors[bot]
777d936c17
Merge #7653
...
7653: Document config pattern r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-02-12 15:10:50 +00:00
Aleksey Kladov
799810eaaa
Document config pattern
2021-02-12 18:10:16 +03:00
Peter Wischer
f18fc5a0ae
fix nightly warning legacy_derive_helpers
...
see https://github.com/rust-lang/rust/issues/79202
2021-02-12 13:57:38 +01:00
Aleksey Kladov
d932812134
Use track caller in test documentation
2021-02-10 11:26:48 +03:00
Aleksey Kladov
4b1279d0b1
Infra for "unit" benchmarking
2021-02-09 20:25:39 +03:00
Aleksey Kladov
ad7b0f670a
Add emacs guide
2021-02-08 19:08:02 +03:00
bors[bot]
433ad23988
Merge #7592
...
7592: [Doc] Note about Eclipse IDE support r=lnicola a=mickaelistria
Co-authored-by: Mickael Istria <mistria@redhat.com>
2021-02-08 09:16:01 +00:00
Mickael Istria
7e0854ec57
[Doc] Note about Eclipse IDE support
2021-02-08 09:52:46 +01:00
Ilya Bobyr
9ffe4ca26c
Vim docs: vim-lsp with initial configuration.
...
`vim-lsp` is another popular LSP client for Vim. And, as there is no
`rust-analyzer` specific UI, it is non-trivial to figure out how the
initial configuration is performed.
2021-02-07 20:24:56 -08:00
Ilya Bobyr
6781692732
Explain how initial configuration is sent over LSP.
2021-02-07 20:24:56 -08:00
Aleksey Kladov
cbebb70313
Add a section on entry points
2021-02-07 10:58:59 +03:00
Erick Tovar
a423a5196c
Fixing architecture image on dark theme
2021-02-07 10:57:39 +03:00
Edwin Cheng
a0475f10d8
Remove redunacny
2021-02-07 12:53:54 +08:00
Edwin Cheng
542e35e397
More information for mbe
2021-02-07 12:51:30 +08:00
Edwin Cheng
504a54b222
Update architecture.md for mbe and proc-macro
2021-02-07 12:31:33 +08:00
Adam Tuck
c2064e8bcf
Update architecture.md
...
Typo
2021-02-06 14:40:23 -08:00
kjeremy
8ff69055b9
Do not overwrite lock file
...
Use `npm ci` instead of `npm install`. `npm install` will overwrite
the lock file if you have a newer npm version than the one that
generated the package-lock.json
2021-02-05 10:57:36 -05:00
Aleksey Kladov
648d99537c
Add howtos
2021-02-05 17:45:14 +03:00
Aleksey Kladov
06aa34cd10
More architecture.md
2021-02-04 13:27:34 +03:00
Kushagra Gupta
b75e85998d
typo fixes
2021-02-03 21:30:42 +05:30
Kushagra Gupta
ed35e516b1
Grammar fixes
...
I think line 235 is still wrong, but I am not sure.
Is the `crated/tt` in line 252 supposed to be `crates/tt`?
2021-02-03 21:05:21 +05:30
Lukas Wirth
f82ce500a9
Fix spelling mistakes in docs/dev
2021-02-03 13:46:51 +01:00
Aleksey Kladov
1008aaae58
Make architecture more informative
...
Call out boundaries and invariants
2021-02-03 14:26:23 +03:00
Aleksey Kladov
283c3b0133
add useless types to the styleguide
2021-02-02 15:41:57 +03:00
Laurențiu Nicola
84c324b3dd
Improve nvim-lsp setup instructions
2021-02-01 20:20:15 +02:00
Laurențiu Nicola
5e61d62fdc
Explain what to do if a release fails
2021-02-01 16:46:23 +02:00
Edwin Cheng
d069ef60b6
Update lsp-extension.md hash
2021-01-29 01:32:31 +08:00
Edwin Cheng
edcafe7865
Update doc
2021-01-29 01:04:14 +08:00
bors[bot]
0ebf548ab7
Merge #7451
...
7451: rust-analyzer.files.excludeDirs r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-01-27 15:48:35 +00:00
bors[bot]
fc08fdaf5a
Merge #7457
...
7457: Add no-buffering file logging and wait for a debugger option. r=vsrs a=vsrs
Adds two command line flags: `--no-buffering` and `--wait-dbg`.
Not sure if someone else needs this, but personally I found both flags extremely useful trying to figure out why RA does not work with Visual Studio. Or better to say why Visual Studio does not work with RA.
Co-authored-by: vsrs <vit@conrlab.com>
2021-01-26 22:37:11 +00:00
Aleksey Kladov
d35bda6429
Make always-assert crate reusable
2021-01-26 22:13:42 +03:00
Aleksey Kladov
2870e70163
Add config option to ignore directories
2021-01-26 16:45:54 +03:00
Aleksey Kladov
c04b561e7e
Remove the need to manually sync config in package.json
2021-01-26 16:22:24 +03:00
Aleksey Kladov
2be55703d1
Document design label
2021-01-26 14:18:28 +03:00
vsrs
185cd736a6
Add RA_WAIT_DBG and docs
2021-01-25 17:46:03 +03:00
Laurențiu Nicola
f0cffb66b3
Fix typo in style guide
2021-01-25 14:14:43 +02:00
bors[bot]
83231dd987
Merge #7409 #7421
...
7409: Add References CodeLens. r=matklad a=vsrs
Closes #5836
7421: Fix RA_LOG example in dev docs r=lnicola a=lnicola
bors r+
Co-authored-by: vsrs <vit@conrlab.com>
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-01-25 11:18:58 +00:00
Laurențiu Nicola
83fd639829
Fix RA_LOG example in dev docs
2021-01-25 13:18:24 +02:00
vsrs
3618c4e0d3
Add References code lens.
...
For Struct, Enum, Union and Trait symbols.
2021-01-23 16:56:20 +03:00
Aleksey Kladov
e54a398bfb
Promote marks
2021-01-22 17:58:00 +03:00
Aleksey Kladov
4c92ef03ac
Style: use the right string
2021-01-22 15:29:31 +03:00
Aleksey Kladov
e5c5c0a040
Include countme crate to count important data structures.
2021-01-21 19:30:52 +03:00
Aleksey Kladov
74f8201586
Avoid intermediate collections
2021-01-20 14:49:29 +03:00
Aleksey Kladov
724059569b
Don't show runnable suggestions for other files
...
It't be actually great to have these once we have run anything dialog,
but for run the thing at point it makes sense to show a limited set.
2021-01-20 14:30:50 +03:00
Aleksey Kladov
8dc68ecdfc
Introduce more appropriate assertion mechanism
...
rust-analyzer is a long-running program, so we *should* handle assertion
failures.
See also https://www.sqlite.org/assert.html .
2021-01-14 18:25:19 +03:00
Aleksey Kladov
2d0464a6f3
Encourage gifs
2021-01-11 16:29:29 +03:00
Laurențiu Nicola
a7db8abab7
Use T! for bool keywords
2021-01-10 17:47:12 +02:00
Aleksey Kladov
8f994dda68
typo
2021-01-07 20:27:22 +03:00
Aleksey Kladov
5aed769afe
Styleguide readability
2021-01-07 20:11:55 +03:00
Aleksey Kladov
eb710a63ca
Document std::ops style
2021-01-07 19:27:47 +03:00
bors[bot]
b821264f86
Merge #7195
...
7195: Update remaining serverPath references r=lnicola a=lnicola
Fixes https://github.com/rust-analyzer/rust-analyzer/pull/7156#issuecomment-755487667
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-01-07 15:30:23 +00:00
Laurențiu Nicola
56497ce925
Update remaining serverPath references
2021-01-07 17:06:11 +02:00
bors[bot]
7967ce85cf
Merge #7184
...
7184: Changes Cursor Marker To $0 r=matklad a=kevaundray
Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
2021-01-07 12:27:17 +00:00
Kevaundray Wedderburn
72b9a4fbd3
Change <|> to $0 - Rebase
2021-01-07 12:09:23 +00:00
Aleksey Kladov
037caec62c
Use american spelling for config
...
As per
171c3c08fe/docs/dev/style.md (variable-naming)
2021-01-07 15:07:19 +03:00
Aleksey Kladov
f7a15b5cd1
More maintainable config
...
Rather than eagerly converting JSON, we losslessly keep it as is, and
change the shape of user-submitted data at the last moment.
This also allows us to remove a bunch of wrong Defaults
2021-01-06 15:39:28 +03:00
Aleksey Kladov
d7741d1610
Allow #anchor linking of config options
2021-01-05 13:09:06 +03:00
bors[bot]
5b86ff3e91
Merge #7113
...
7113: Manual updates r=matklad a=tekul
Add some details on how to build the manual and some clarification on how to deal with "proc macro2 warnings.
For context, this arose from [this question](https://users.rust-lang.org/t/how-to-disable-rust-analyzer-proc-macro-warnings-in-neovim/53150 ) on users.rust-lang.org.
Co-authored-by: Luke Taylor <tekul.hs@gmail.com>
2021-01-03 18:22:07 +00:00
bors[bot]
1cc73d60bb
Merge #7068
...
7068: Add VSCode command to view the hir of a function body r=theotherphil a=theotherphil
Will fix https://github.com/rust-analyzer/rust-analyzer/issues/7061 . Very rough initial version just to work out where I needed to wire everything up.
@matklad would you be happy merging a hir visualiser of some kind? If so, do you have any thoughts on what you'd like it show, and how?
I've spent very little time on this thus far, so I'm fine with throwing away the contents of this PR, but I want to avoid taking the time to make this more polished/interactive/useful only to discover that no-one else has any interest in this functionality.
Co-authored-by: Phil Ellison <phil.j.ellison@gmail.com>
2021-01-03 09:03:15 +00:00
Phil Ellison
db53db8046
Address review suggestion, fix tidy tests
2021-01-01 19:25:18 +00:00
Mara Bos
4833972067
Add support for Rust 2021.
2021-01-01 17:22:23 +01:00
Luke Taylor
6168a6f1ca
Expand contributing "tip" in manual.adoc
...
- Add link to asciidoc website
- Explain how to create the generated adoc files from the source code
- How to run asciidoctor to generate the manual
2020-12-31 22:23:06 +00:00
Aleksey Kladov
9c0c5f8e37
Improve commit message style
2020-12-28 13:43:07 +03:00
Heyward Fann
b1ec22c879
Update manual.adoc
2020-12-24 11:38:01 +08:00
Aleksey Kladov
7c07bb6381
Document, how to view config in effect
2020-12-23 10:47:05 +03:00
Rüdiger Herrmann
9f070531a6
Clean up descriptions for settings
...
Use two consecutive newlines (`\n\n`) to actually continue text on a
new line.
Use proper markup to reference related settings.
Consistently format references to files, editor commands, command line
arguments, files, etc. as `code`.
Fix typos, add missing full-stops, add missing default values.
2020-12-22 14:51:17 +01:00
Laurențiu Nicola
6fbe22bfbb
Split lines between sentences
2020-12-20 19:31:08 +02:00
Laurențiu Nicola
0ecb224d75
Document the version requirements for building from source
2020-12-20 17:10:54 +02:00
Aleksey Kladov
675390e012
Update docs/dev/README.md
...
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-12-16 18:07:21 +03:00
Aleksey Kladov
6e9023c763
Document new permissions
2020-12-16 18:04:24 +03:00
Aleksey Kladov
51f42db1d5
Add # to canonical test example
2020-12-15 11:49:22 +03:00
Aleksey Kladov
804ae284b9
Link config source
2020-12-14 15:06:24 +03:00
Christian Authmann
78d43eb1e8
Docs: Explain manual installation in VS Code
2020-12-13 15:21:11 +01:00
Aleksey Kladov
e179ed6f53
Use natural trait ordering in derive completion
...
derive(Clone, Copy) reads better than derive(Copy, Clone).
However, we preserve the reverse ordering in the lookup text for
sorting purposes. That way, it's convenient to type just `Ord` to
derive everything.
2020-12-11 15:45:53 +03:00
Laurențiu Nicola
3ecdb778c2
Improve docs for building from source
2020-12-10 19:31:46 +02:00
Aleksey Kladov
17f236c2b0
Normalize spelling to American English
2020-12-10 17:51:56 +03:00
Josh Stone
bb412f314d
Fix a typo in manual.adoc
2020-12-09 11:25:05 -08:00
Aleksey Kladov
0890512e1c
Include config into the manual
2020-12-09 15:31:10 +03:00
Daiki Ihara
4f008bf8b2
fix typo of README in dev
2020-12-09 00:30:00 +09:00
Aleksey Kladov
3e00bfce2b
Document statelessness invariant
2020-12-03 18:08:27 +03:00
Jonas Schievink
d171838d63
More accurately place proc-macro diagnostic
2020-11-27 16:29:40 +01:00
Jonas Schievink
0432aa0ed7
Publish diagnostics for macro expansion errors
2020-11-27 13:50:22 +01:00
Jakob Hellermann
7c6c812a74
fix typos in syntax.md
2020-11-17 15:16:52 +01:00
kjeremy
233fdb12ce
Latest LSP 3.16 protocol
...
Pulls in https://github.com/gluon-lang/lsp-types/pull/186
2020-11-16 15:10:13 -05:00
Anatol Liu
b1b7727e04
add open Cargo.toml action
2020-11-12 17:48:07 -08:00
Aleksey Kladov
7d2eb000b0
Switch to upstream protocol for resolving code action
...
Note that we have to maintain custom implementation on the client
side: I don't see how to marry bulitin resolve support with groups and
snippets.
2020-11-10 18:48:46 +01:00
Aleksey Kladov
9b1d4cc8ab
don\t indent tests
2020-11-06 20:29:41 +01:00
Aleksey Kladov
412d6b3db5
Update docs/dev/style.md
...
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-11-02 12:17:34 +01:00
Aleksey Kladov
4318828f21
Document doer object anti-pattern
2020-11-02 12:13:59 +01:00
Dave Lage
e6419350de
docs: Update Neovim nvim-lspconfig repository link
2020-10-29 11:08:12 -04:00
Laurențiu Nicola
f94d0252b3
Update client install command in dev docs
2020-10-27 09:49:57 +02:00
Jonas Schievink
5350c15e27
Fix name of InactiveCode diagnostic
2020-10-23 19:31:11 +02:00
Jonas Schievink
93dc6f511b
Diagnose #[cfg]s in bodies
2020-10-23 19:27:04 +02:00
bors[bot]
edf46a13a6
Merge #6325 #6327
...
6325: Add generated diagnostic docs to the manual r=matklad a=flodiebold
It seemed that we're not actually including the generated diagnostic docs anywhere yet? So I added something to the manual. This is completely untested though.
6327: Update debugging.md r=matklad a=stanciuadrian
`on_task` is no longer there.
I have used `on_request` instead.
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
Co-authored-by: Adrian Stanciu <stanciu.adrian@gmail.com>
2020-10-22 18:15:48 +00:00
Adrian Stanciu
5f5b1ffdd1
Update debugging.md
2020-10-22 21:04:09 +03:00
Florian Diebold
b59a0dbf6a
Add generated diagnostic docs to the manual
2020-10-22 19:42:01 +02:00
Benjamin Coenen
aa031e91f4
add completions for clippy lint in attributes
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-10-20 21:29:31 +02:00
Aleksey Kladov
f753c3ecd2
Support Display name in project.json
2020-10-20 17:13:15 +02:00
Aleksey Kladov
a261c7c539
Document logging of project model
2020-10-19 16:04:22 +02:00
Igor Aleksanov
d718366567
Document change of 'cargo' Runnable kind in lsp-extensions.md
2020-10-16 20:58:57 +03:00
bors[bot]
4271e4c703
Merge #6245
...
6245: Update GNOME Builder docs r=lnicola a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-10-16 12:59:11 +00:00
Aleksey Kladov
0c67edc0f7
Expand code order section
2020-10-16 12:50:09 +02:00
Laurențiu Nicola
b19013feaa
Update GNOME Builder docs
2020-10-15 20:00:09 +03:00
Aleksey Kladov
86cc93ebe3
Document awkward names
2020-10-15 18:14:30 +02:00
Aleksey Kladov
dedfaa3844
Cleanup alloc advice
2020-10-15 12:21:38 +02:00
Aleksey Kladov
9c285b0341
Style: default over new
2020-10-14 20:02:03 +02:00
Aleksey Kladov
190011168d
Introduce S-actionable and S-unactionable labels
...
I've noticed that a significant fraction of issues are inert.
They are valid, acknowledged and useful, but effectively can't be
fixed for variety of reasons (no reproduction, dependencies on some
other issues, no review capacity, etc).
Marking issues that can be fixed by just applying some elbow grease
seems useful!
2020-10-14 15:20:31 +02:00
Aleksey Kladov
d852189e56
Add reminder to update lsp-extensions.md
2020-10-14 13:30:06 +02:00
Zac Pullar-Strecker
f1decfc110
Fix send->sent typo
2020-10-08 15:04:57 +13:00
Zac Pullar-Strecker
62b76e7004
Document the protocol extension
2020-10-08 15:04:20 +13:00
Aleksey Kladov
5359e8f742
minor
2020-10-07 13:11:33 +02:00
Aleksey Kladov
1688e481b3
minor
2020-10-07 13:03:13 +02:00
Aleksey Kladov
6976494781
Add comparisons guideline to style
2020-10-07 12:57:49 +02:00
Aleksey Kladov
fdf2f6226b
Reorg style
2020-10-07 12:50:46 +02:00
Adrian Stanciu
f7641b2e35
Update manual.adoc
2020-10-07 00:44:32 +03:00
Aleksey Kladov
0599e64bb2
Document Clippy strategy
2020-10-02 10:13:58 +02:00
Laurențiu Nicola
2233749692
Improve grammar and fix code example in style guide
2020-10-01 21:02:39 +03:00
Aleksey Kladov
af8063fe37
Extend **Status** command to also show dep info for the file
...
This should help with troubleshooting wrong project configuration
2020-09-29 22:13:23 +02:00
Aleksey Kladov
b069c1c69a
More style advice
2020-09-29 14:42:09 +02:00
Masaki Hara
5cca4c9214
VS Code + WSL: describe binary location
...
It looks like VS Code server chooses a different location for `globalStorage`.
2020-09-21 23:07:54 +09:00
Yusuke Tanaka
4530b717cb
Fix typo
2020-09-21 01:44:38 +09:00
Yusuke Tanaka
203358a0d5
Fix typo
2020-09-21 00:53:14 +09:00
Jonas Schievink
888cb378b9
docs: suggest disabling the official extension
2020-09-18 18:26:58 +02:00
Aleksey Kladov
4f5d2ffac2
fmt import
2020-08-28 16:53:49 +02:00
bors[bot]
a0324a59e9
Merge #5879
...
5879: Update mentions of 'ra_vfs' in architecture doc r=matklad a=rherrmann
Adjust the paragraph about `ra_vfs` to point to the `vfs` crate that is used now.
Co-authored-by: Rüdiger Herrmann <ruediger.herrmann@gmx.de>
2020-08-26 13:38:31 +00:00
bors[bot]
d58a3a277a
Merge #5885
...
5885: Make inlay hints colors more configurable r=matklad a=Veetaha
**[BREAKING CHANGE]**
Tackles https://github.com/rust-analyzer/rust-analyzer/issues/5337#issuecomment-680018601 and generally related to #5337 .
Added `foreground/background` color configurations with optional more specific overrides `foreground.(type|parameter|chaining)Hints`.
One problem I see is that the config keys are long and don't fit into the on-hover hints in the `settings.json` file entirely...
<details>
<summary>Demo</summary>
</details>
Co-authored-by: Veetaha <veetaha2@gmail.com>
2020-08-26 13:07:06 +00:00
Aleksey Kladov
a53c6f6fee
Allow redirecting logs to a specific file
...
There's a surprising lack of crates which are like env_logger, but
also allow writing to a file. Let's write our own then!
2020-08-26 13:20:46 +02:00
Veetaha
5b9a882edc
Make inlay hints colors more configurable
2020-08-26 02:53:42 +03:00
Aleksey Kladov
189521a4db
Add sysroot shortcut to rust-project.json
2020-08-25 19:41:56 +02:00
Rüdiger Herrmann
3dbe062741
Update mentions of 'ra_vfs' in architecture doc
...
Adjust the paragraph about `ra_vfs` to point to the `vfs` crate that is used now.
2020-08-25 17:57:29 +02:00
Aleksey Kladov
3a72afed8c
Improve logging
2020-08-25 11:43:21 +02:00
bors[bot]
951c7c157a
Merge #5852
...
5852: Add Early Return rule to style r=matklad a=matklad
bors r+
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-24 10:56:04 +00:00
Aleksey Kladov
fc3e591bdb
Avoid monomorphization
2020-08-24 12:49:36 +02:00
Aleksey Kladov
d7ece3028d
Add Early Return rule to style
2020-08-24 12:22:28 +02:00
Aleksey Kladov
0c602bb963
Encourage rebases more
2020-08-18 18:52:12 +02:00
Aleksey Kladov
0d201638d9
Add default names section
2020-08-18 14:31:50 +02:00
bors[bot]
6826dd044a
Merge #5782
...
5782: Fix StatusNotification r=matklad a=vsrs
This PR fixes the following:
As per specification `params` property in [NotificationMessage ](https://microsoft.github.io/language-server-protocol/specifications/specification-current/#notificationMessage ) should be `array | object` while RA uses `"loading" | "ready" | "invalid" | "needsReload"`.
Co-authored-by: vsrs <vit@conrlab.com>
2020-08-17 14:23:03 +00:00
Aleksey Kladov
6a4c9fc9fd
Don't make fields private unless you have to
2020-08-17 16:11:29 +02:00
vsrs
1eed036a6e
Fix StatusNotification
2020-08-17 14:56:27 +03:00
Aleksey Kladov
200161c734
Document the most important CI invariant
2020-08-14 12:27:15 +02:00
Aleksey Kladov
1b0c7701cc
Rename ra_ide -> ide
2020-08-13 17:58:27 +02:00
Aleksey Kladov
fc34403018
Rename ra_assists -> assists
2020-08-13 17:33:38 +02:00
Aleksey Kladov
ae71a631fd
Rename ra_hir -> hir
2020-08-13 16:36:55 +02:00
Aleksey Kladov
ed20a857f4
Rename ra_db -> base_db
2020-08-13 16:29:33 +02:00
Aleksey Kladov
a1c187eef3
Rename ra_syntax -> syntax
2020-08-12 18:30:53 +02:00
Aleksey Kladov
50a02eb359
Rename ra_parser -> parser
2020-08-12 17:14:23 +02:00
