Mikhail Rakhmanov
5dda995538
Fix review comments
2020-06-05 13:17:17 +02:00
Mikhail Rakhmanov
74c3e7a1ad
Remove unnecessary return
2020-06-05 11:45:41 +02:00
Mikhail Rakhmanov
b0c8a2be7b
Remove AsName import
2020-06-04 10:03:44 +02:00
Mikhail Rakhmanov
a6d3c77bdd
Fixed tests
2020-06-03 20:43:57 +02:00
Mikhail Rakhmanov
eefa10bc6b
Merge branch 'master' into assists_extract_enum
2020-06-03 20:10:54 +02:00
Mikhail Rakhmanov
a9d5675848
Fix incorrect behaviour if not resolved
2020-06-03 20:10:33 +02:00
bors[bot]
794f6da821
Merge #4734
...
4734: Don't store generated docs in the repo r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-06-03 16:30:57 +00:00
Aleksey Kladov
5315934d88
Don't store generated docs in the repo
2020-06-03 18:26:50 +02:00
bors[bot]
636f597a86
Merge #4733
...
4733: Cargo update r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
2020-06-03 13:54:52 +00:00
kjeremy
bc2edc1d1a
Cargo update
2020-06-03 09:43:27 -04:00
bors[bot]
a33cfcb55d
Merge #4502
...
4502: Mark fixes from diagnostics as quick fixes r=kjeremy a=kjeremy
Populates the diagnostic UI with fixes:
Before:
After:
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
2020-06-03 13:39:30 +00:00
Jeremy Kolb
9e71fc0314
Mark fixes from diagnostics as quick fixes
2020-06-03 09:31:32 -04:00
bors[bot]
1edf6d2d4f
Merge #4730
...
4730: Document rust-project.json r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-06-03 13:18:12 +00:00
Aleksey Kladov
fa019c8f56
Document rust-project.json
2020-06-03 15:17:26 +02:00
bors[bot]
e644f64f2a
Merge #4678
...
4678: Unsquish parameter types in tooltips for macro-generated functions r=aloucks a=aloucks
Note the missing whitespace between `:` and the parameter type.
Before:
After:
Co-authored-by: Aaron Loucks <aloucks@cofront.net>
2020-06-03 11:27:10 +00:00
Aaron Loucks
f06b2bcd91
Use split1 when formatting function signature params
2020-06-03 07:26:15 -04:00
bors[bot]
c6b739bad0
Merge #4660
...
4660: Enable hover and autocomplete docs on macro generated items r=aloucks a=aloucks
Enable hover and autocomplete docs on macro generated items. This de-sugars doc comments into `doc` attributes in some cases, but not all. Comments and `doc` attributes are then merged together.
This PR is essentially a partial implementation of what's being suggested #3182 , but it's not all the way there yet. ~I still need to add unit tests~, but I wanted to first get feedback on whether or not this was an acceptable path forward.
Fixes #4564
Fixes #3984
Fixes #3180
Related #3182
Co-authored-by: Aaron Loucks <aloucks@cofront.net>
2020-06-03 11:05:52 +00:00
Aaron Loucks
ed86689264
Update generated feature docs
2020-06-03 06:55:27 -04:00
Aaron Loucks
85c4edb0af
Consolidate documentation expansion and merging
...
Removes the duplicated `expand_doc_attrs` and `merge_doc_comments_and_attrs`
functions from `ra_ide` and exposes the same functionality via
`ra_hir::Documentation::from_ast`.
2020-06-03 06:54:41 -04:00
Aaron Loucks
5837acce53
Add basic hover and completion doc tests for macro generated items
2020-06-03 06:46:07 -04:00
Aaron Loucks
4c655c01f3
Enable hover and autocomplete docs on macro generated items
2020-06-03 06:46:07 -04:00
bors[bot]
a36c1d3fbc
Merge #4727
...
4727: Drop test for old format r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-06-03 10:40:12 +00:00
Aleksey Kladov
2e7d12d2f3
Drop test for old format
2020-06-03 12:39:11 +02:00
bors[bot]
9b3d4be421
Merge #4726
...
4726: Groundwork for specifying the set of projects via config r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-06-03 10:26:38 +00:00
Aleksey Kladov
8baa4c5d07
Groundwork for specifying the set of projects via config
2020-06-03 12:22:01 +02:00
Aleksey Kladov
03a76191a1
Rename ProjectRoot -> ProjectManifest
2020-06-03 12:05:50 +02:00
Aleksey Kladov
0a88de809f
Move project discovery
2020-06-03 12:04:27 +02:00
bors[bot]
992e1256d0
Merge #4724
...
4724: Rename WorldState -> GlobalState r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-06-03 09:20:30 +00:00
Aleksey Kladov
a87cd8ecc6
Rename WorldState -> GlobalState
2020-06-03 11:20:01 +02:00
bors[bot]
5100f77073
Merge #4723
...
4723: Derive local roots from Workspaces r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-06-03 09:08:20 +00:00
Aleksey Kladov
ee181cf683
Drop no-project test
...
Eventually, we should support "just open random rust file" use case,
we don't really do this now, so let's avoid spending time on it until
we fix it properly.
2020-06-03 11:07:04 +02:00
Aleksey Kladov
d4b21476a8
Derive local roots from Workspaces
2020-06-03 10:52:35 +02:00
Aleksey Kladov
ca80544f4b
Put important things on top
2020-06-03 10:33:01 +02:00
Aleksey Kladov
ac4782ef11
Merge pull request #4382 from woody77/json_cfgs
...
Begin transition to new fields for JsonProject crate cfgs
2020-06-03 10:28:15 +02:00
bors[bot]
c29175f1ff
Merge #4715
...
4715: Don't exclude dirs that appear in project root parent path r=matklad a=Veetaha
Co-authored-by: veetaha <veetaha2@gmail.com>
2020-06-03 07:15:18 +00:00
bors[bot]
68f26dc1bb
Merge #4679
...
4679: Update a comment for the new source organization r=matklad a=nelhage
Co-authored-by: Nelson Elhage <nelhage@nelhage.com>
2020-06-03 06:47:18 +00:00
bors[bot]
1bbbeb886d
Merge #4703
...
4703: Start documenting review process r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-06-03 06:29:33 +00:00
Aleksey Kladov
994006585b
Start documenting review process
2020-06-03 08:28:12 +02:00
bors[bot]
6d38351db4
Merge #4721
...
4721: Hide squiggly for unused and unnecessary diagnostics r=matklad a=GabbeV
Fixes #4229
When working with JavaScript or TypeScript in VSCode unused valiables are faded but don't have a squiggle. This PR makes rust-analyzer work similarly by setting the severity to hint when applying the unnecessary tag.
VSCode usually shows a squiggle for error, warning and information and shows three dots for hint. When the unnecessary tag is present the squiggles will still show up but the three dots will not.
This is my first contribution to open source. Please tell me if i need to do anything more to get this PR considered.
Co-authored-by: Gabriel Valfridsson <gabriel.valfridsson@gmail.com>
2020-06-03 06:16:45 +00:00
Gabriel Valfridsson
599c105e6f
Hide squiggly for unused and unnecessary
2020-06-03 01:57:28 +02:00
bors[bot]
dff8140a2e
Merge #4720
...
4720: Add highlight support for unsafe fn calls and raw ptr deref r=matklad a=Nashenas88
Addresses ide highlighting for #190
Co-authored-by: Paul Daniel Faria <Nashenas88@users.noreply.github.com>
2020-06-02 23:13:09 +00:00
Paul Daniel Faria
a9cb2933fb
Add highlight support for unsafe fn calls and raw ptr deref
2020-06-02 18:54:00 -04:00
bors[bot]
2f6ab77708
Merge #4710
...
4710: New runnables r=matklad a=matklad
bors d=@vsrs
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-06-02 20:44:56 +00:00
veetaha
f2f3c554af
Don't exclude dirs that appear in project root parent path
2020-06-02 23:15:23 +03:00
bors[bot]
0035dafbfa
Merge #4711
...
4711: Disable rust-analyzer.{cargo,checkOnSave}.allFeatures by default r=matklad a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-06-02 16:16:38 +00:00
Laurențiu Nicola
7a66d99897
Disable rust-analyzer.{cargo,checkOnSave}.allFeatures by default
2020-06-02 19:14:34 +03:00
Aleksey Kladov
bc3db7c1de
Fix tests
2020-06-02 18:09:12 +02:00
Aleksey Kladov
a83ab820a4
Spec better runnables
2020-06-02 17:34:18 +02:00
Aleksey Kladov
0303982119
New runnables API
2020-06-02 17:22:42 +02:00
bors[bot]
f137b3a4e6
Merge #4709
...
4709: Minor r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-06-02 14:31:10 +00:00
