Commit Graph

4353 Commits

Author SHA1 Message Date
Josh Mcguigan
53c262048c Fix #1219 false positive for explicit_counter_loop 2018-09-07 19:58:19 -07:00
Josh Mcguigan
ce554267b8 Updated explicit_counter_loop tests based on discussion in #3135 2018-09-07 05:32:56 -07:00
Josh Mcguigan
edfa9feac2 Corrected explicit_counter_loop missing lints if variable used after loop 2018-09-06 06:20:25 -07:00
Josh Mcguigan
4b668159d2 Closes #1219 false positive for explicit_counter_loop 2018-09-05 19:14:01 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
ebb88a4208
Merge pull request #3131 from JoshMcguigan/ptr_arg-2293
Fix #2293 - ptr_arg
2018-09-05 16:22:03 +02:00
Josh Mcguigan
0f6d422817 Added test case for ptr_arg 2018-09-05 05:59:07 -07:00
Philipp Krones
ed38d9c79f
Merge pull request #3108 from daubaris/range-plus-one
range_plus_one suggestion should not remove braces fix
2018-09-04 21:13:30 +02:00
daubaris
009c29069c switched to ticks for chars 2018-09-04 18:56:48 +03:00
daubaris
db391c4613 Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one 2018-09-04 18:52:18 +03:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
b7587d8176
Merge pull request #3125 from nrc/pub-conf
Make `Default` do what `default` used to do
2018-09-04 10:09:38 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
f5804dd906
Merge pull request #3124 from phansch/cleanup_old_min_version_stuff
Cleanup old min_version stuff
2018-09-04 10:09:10 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
df646a88a9
Merge pull request #3109 from shssoichiro/3034-needless-collect
Lint against needless uses of `collect()`
2018-09-04 10:07:11 +02:00
Josh Holmer
f7d2aeefe8 Delete needless file 2018-09-04 00:00:06 -04:00
Josh Holmer
ed9cd1530d More if_chain 2018-09-03 23:58:10 -04:00
Josh Holmer
48e6be42d7 Rustup 2018-09-03 23:50:24 -04:00
Josh Holmer
061b2f3057 Apply applicability 2018-09-03 23:29:44 -04:00
Josh Holmer
dfed9751bd Majority of PR changes 2018-09-03 23:29:44 -04:00
Josh Holmer
fbc93c0166 Lint against needless uses of collect()
Handles cases of `.collect().len()`, `.collect().is_empty()`, and
`.collect().contains()`. This lint is intended to be generic enough to
be added to at a later time with other similar patterns that could be
optimized.

Closes #3034
2018-09-03 23:29:44 -04:00
Nick Cameron
4050a68989 Make Default do what default used to do 2018-09-04 09:13:48 +12:00
Philipp Hansch
20318ebc22
Cleanup old min_version stuff
This cleans up a few leftover things after
https://github.com/rust-lang-nursery/rust-clippy/pull/3018
2018-09-03 22:27:35 +02:00
daubaris
2f0a99a3a4 fixed known problems expression 2018-09-03 23:01:28 +03:00
daubaris
1f3676f7d0 Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one 2018-09-03 18:24:47 +03:00
daubaris
b825578a4a backticks and testcase 2018-09-03 18:24:38 +03:00
Philipp Hansch
c0513097ab
Merge pull request #3092 from illicitonion/issue-2879
default_trait_access skips <F as Default>::default()
2018-09-03 17:24:33 +02:00
daubaris
1615a8a2b6 Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one 2018-09-03 17:21:13 +03:00
Manish Goregaokar
78ec6e38b4
Merge pull request #3120 from rust-lang-nursery/ci_integration
Update travis integration tests to tool_lints
2018-09-03 09:37:18 +00:00
Philipp Krones
f5376a30a8
Merge pull request #3119 from joshtriplett/a-message-from-the-save-the-iters-foundation
iter conservation efforts: save the endangered .iter() and .into_iter()
2018-09-03 10:55:43 +02:00
Philipp Krones
4139207956
Update travis integration tests to tool_lints
`clippy_pedantic` -> `clippy::pedantic`
`clippy_nursery` -> `clippy::nursery`
2018-09-03 10:52:42 +02:00
Josh Triplett
779988303a iter conservation efforts: save the endangered .iter() and .into_iter()
Make explicit_iter_loop and explicit_into_iter_loop allow-by-default, so
that people can turn them on if they want to enforce that style; avoid
presenting them as *the* idiomatic Rust style, rather than just *a* style.
2018-09-03 01:24:46 -07:00
Philipp Hansch
2b7a5304f6
Merge pull request #3116 from phansch/fix_warning
Fix clippy -> clippy::all warning in CI
2018-09-03 07:35:24 +01:00
Philipp Hansch
f3839f0c1a
Fix clippy -> clippy::all warning in CI 2018-09-03 08:03:05 +02:00
Manish Goregaokar
2d0b7db980
Merge pull request #3115 from rust-lang-nursery/rm-token
Remove dependence of ci on github token
2018-09-03 05:48:46 +00:00
Manish Goregaokar
79d81ac3e7 Remove dependence of ci on github token 2018-09-03 09:20:15 +05:30
Manish Goregaokar
1d13c1f998
Merge pull request #2941 from rust-lang-nursery/prs
Run travis on rustc-master instead of nightly
2018-09-03 08:14:45 +05:30
Manish Goregaokar
6141339f88
Merge pull request #3114 from nrc/pub-conf
Make `Conf::default` available
2018-09-03 07:36:58 +05:30
Nick Cameron
d6f01f3a6c Make Conf::default available
Fixes RLS
2018-09-03 13:57:50 +12:00
Daniel Wagner-Hall
9f0216d520 Merge branch 'master' into issue-2879 2018-09-03 00:01:57 +01:00
Daniel Wagner-Hall
939d842ea1 Simplify 2018-09-02 23:42:07 +01:00
Daniel Wagner-Hall
368223a341 Use types rather than strings 2018-09-02 23:37:28 +01:00
Philipp Hansch
273e11fcaf
Trigger rebuild for AppVeyor (and fix grammar) 2018-09-02 11:31:39 +02:00
Philipp Hansch
8e0de3d120
Merge remote-tracking branch 'upstream/master' into prs 2018-09-02 11:05:49 +02:00
Manish Goregaokar
131c8f86b2
Merge pull request #3113 from mikerite/fix-3112
Fix #3112
2018-09-02 13:29:06 +05:30
Michael Wright
19157c02cb Fix #3112 2018-09-02 09:38:25 +02:00
daubaris
846c3dba2c resolved conflicts 2018-09-01 09:37:42 +03:00
Manish Goregaokar
c81d70e6bd
Merge pull request #2977 from flip1995/tool_lints
Implement tool_lints
2018-09-01 11:22:23 +05:30
Manish Goregaokar
9abf6fca9c Fix ptr offset tests 2018-08-31 00:38:27 -07:00
Manish Goregaokar
20dfaf7842 declare_lint -> declare_tool_lint 2018-08-31 00:34:48 -07:00
Oliver Schneider
73e8416df3
Merge pull request #3081 from mikerite/fix-3078
Fix #3078
2018-08-31 09:05:39 +02:00
Michael Wright
c6074a94b9 Merge branch 'master' into fix-3078 2018-08-31 06:17:11 +02:00
Michael Wright
daacac6b97 Revert "fix-3078: verify test case"
This reverts commit 6256ad05ba.
2018-08-31 06:15:55 +02:00