bors
4a07662d94
Auto merge of #8561 - FoseFx:use_unwrap_or, r=xFrednet
...
add `or_then_unwrap`
Closes #8557
changelog: New lint [`or_then_unwrap`]
2022-03-21 20:08:29 +00:00
bors
ff0a3687d8
Auto merge of #8520 - J-ZhengLi:issue8506, r=xFrednet
...
fix suggestion on `[map_flatten]` being cropped causing possible information loss
fixes #8506
Multi-line suggestion given by the lint is missing its bottom part, which could potentially contains useful information about the fix.
---
changelog: [`map_flatten`]: Long suggestions will now be splitup into two help messages
2022-03-21 19:51:56 +00:00
J-ZhengLi
5b6295d663
allowing [map_flatten] to split long suggestions
...
add new function `span_lint_and_sugg_` for edges in `clippy_utils::diagnostics`
2022-03-21 14:11:22 +08:00
Max Baumann
765cce11b1
refactor: remove need for MethodCall matching
2022-03-21 00:04:37 +01:00
Max Baumann
4580c8a9b7
refactor: use is_lang_ctor()
2022-03-20 23:54:04 +01:00
Max Baumann
0f83753934
feat: change error message
2022-03-20 23:43:17 +01:00
bors
47b93ea5ef
Auto merge of #8559 - pickfire:patch-1, r=xFrednet
...
Fix typo in bug report
repoduce -> reproduce
---
changelog: none
2022-03-20 22:32:12 +00:00
Max Baumann
20c352a4f6
test: add method chain test
2022-03-19 18:17:43 +01:00
Max Baumann
895de1f13e
feat: make fixable
2022-03-18 23:18:36 +01:00
Max Baumann
f00e844a1f
feat: use span_lint_and_sugg
2022-03-18 22:44:56 +01:00
Max Baumann
34ad33c57a
refactor: move into methods module
2022-03-18 21:11:54 +01:00
bors
a31dcb77be
Auto merge of #8562 - Jarcho:enum_tuple_variant_as_int, r=Manishearth
...
Add lint `cast_enum_constructor`
fixes : #1116
changelog: Add lint `cast_enum_constructor`
2022-03-18 15:54:45 +00:00
Max Baumann
fd2c860171
feat: add comment
2022-03-18 14:45:48 +01:00
bors
9fd3c2d788
Auto merge of #8543 - dswij:8393, r=giraffate
...
`unnecessary_lazy_eval` show suggestions on multiline lint
Closes #8393
changelog: [`unnecessary_lazy_eval`] now shows suggestions for long-line lints
2022-03-18 00:42:18 +00:00
Max Baumann
3c4192f3e9
fix: ran update_lints
2022-03-18 01:12:39 +01:00
Max Baumann
05e05eaed7
refactor: rename lint to or_then_unwrap
2022-03-18 01:04:33 +01:00
Jason Newcomb
39329d1d40
Add lint cast_enum_constructor
2022-03-17 19:57:35 -04:00
Max Baumann
44c62c9aa2
feat: add tests and fix existing ones
2022-03-18 00:51:26 +01:00
Max Baumann
17ff85081d
feat: rename variable in example
2022-03-18 00:34:24 +01:00
Max Baumann
4493fc7d27
refactor: use pattern matching for MethodCall arguments
...
Co-authored-by: xFrednet <xFrednet@gmail.com>
2022-03-18 00:23:55 +01:00
Max Baumann
c22ff6cd6e
fix: fix clippy_lints
2022-03-17 19:52:07 +01:00
Max Baumann
747bb245e7
fix: fix broken dogfood tests
2022-03-17 19:29:59 +01:00
Max Baumann
3f00f074de
fix: fix tests
2022-03-17 19:13:44 +01:00
Max Baumann
f49a2c3457
feat: add use_unwrap_or
2022-03-17 18:57:28 +01:00
bors
8d5c0eadde
Auto merge of #8552 - Jarcho:ptr_arg_8495, r=xFrednet
...
Don't lint `ptr_arg` on `&mut Cow<_>`
fixes : #8495
changelog: Don't lint `ptr_arg` on `&mut Cow<_>`
2022-03-17 17:05:26 +00:00
Ivan Tham
3ede557a62
Fix typo in bug report
...
repoduce -> reproduce
2022-03-17 22:53:27 +08:00
dswij
bd888d4354
Add some comments
2022-03-17 14:38:39 +08:00
bors
65e5cd0e95
Auto merge of #8553 - Jarcho:transmute_undefined_8499, r=llogiq
...
Don't lint `transmute_undefined_repr` when changing the type of generic params
Partially fixes #8499
changelog: Don't lint `transmute_undefined_repr` when changing the type of generic params
2022-03-16 19:27:44 +00:00
Jason Newcomb
8e5208cbff
Don't lint transmute_undefined_repr when changing the type of generic params
2022-03-16 12:56:23 -04:00
Jason Newcomb
851e715e5a
Don't lint ptr_arg on &mut Cow<_>
2022-03-16 12:00:27 -04:00
bors
d23ddab82d
Auto merge of #8544 - nellorocca:dev/5757, r=flip1995
...
Moved ``[try_err]`` to restriction
Fixes #5757
changelog: Moved try_err lint to rescrition for #5757
2022-03-16 09:55:39 +00:00
bors
2b0e730bf3
Auto merge of #8547 - Jarcho:transmute_8501, r=flip1995
...
More `transmute_undefined_repr` fixes
fixes : #8498
fixes : #8501
fixes : #8503
changelog: Allow `transumte_undefined_repr` between fat pointers and `(usize, usize)`
changelog: Allow `transumte_undefined_repr` when one side is a union
changelog: Fix `transumte_undefined_repr` on tuples with one non-zero-sized type.
2022-03-16 09:39:22 +00:00
bors
d6a3fbf8da
Auto merge of #8546 - KisaragiEffective:patch-1, r=llogiq
...
[`collapsible_if`] fix typo in code-block kind specifier
*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: [`collapsible_if`] fix typo in code-block kind specifier
2022-03-16 06:20:45 +00:00
Jason Newcomb
47c9ed697b
Fix checking transmutes with adjusted types
2022-03-15 23:11:11 -04:00
Jason Newcomb
911e10562a
Don't lint transmute_undefined_repr on unions.
2022-03-15 22:38:15 -04:00
Jason Newcomb
7fd52b5e3c
Small simplification to transmute_undefined_repr
2022-03-15 22:33:26 -04:00
Jason Newcomb
442d4ce1c3
Don't lint fat pointer to (usize, usize) conversion in transmute_undefined_repr
2022-03-15 22:31:07 -04:00
Jason Newcomb
e71ac41d44
Fix transmute_undefined_repr for single element tuples
2022-03-15 21:51:07 -04:00
Kisaragi
9f95e7622d
fix typo in code-block kind specifier
2022-03-16 10:19:19 +09:00
Kisaragi
fc5cbba1a4
fix typo in code-block kind specifier
2022-03-16 08:50:30 +09:00
Paolo Gentili
a39d649733
Lint list updated
2022-03-15 19:38:40 +01:00
Paolo Gentili
5c1843dbce
Moved lint to restriction
2022-03-15 18:45:01 +01:00
dswij
6a3dbe4798
unnecessary_lazy_eval show suggestions on multiline lint
2022-03-15 23:59:26 +08:00
bors
b83c6323c7
Auto merge of #8541 - flip1995:iter_with_drain_ambulance, r=giraffate
...
Move iter_with_drain to nursery
cc #8538 #8539
r? `@giraffate`
changelog: Move [`iter_with_drain`] to nursery
2022-03-15 09:02:38 +00:00
flip1995
b981748036
Move iter_with_drain to nursery
2022-03-15 09:46:49 +01:00
bors
71ecbc42f9
Auto merge of #8509 - smoelius:fix-8507, r=giraffate
...
Fix `unncessary_to_owned` false positive
Fix #8507
changelog: none
2022-03-15 01:08:47 +00:00
bors
9a1f6a9795
Auto merge of #8537 - xFrednet:7923-single-component-path-imports-for-macros, r=llogiq
...
Allow `single_component_path_imports` for all macros
Closes: https://github.com/rust-lang/rust-clippy/issues/7923
It can be useful to have `use macro_name` regardless of the visibility. This removes the visibility filter.
changelog: [`single_component_path_imports`]: no longer triggers on macros
2022-03-14 23:39:50 +00:00
bors
0e1311b70f
Auto merge of #8536 - xFrednet:8062-applicability-search-is-some, r=camsteffen
...
Make `search_is_some`s suggestion `MachineApplicable`
My biggest PR to date, about 0.3 Lines have been changed!
Closes https://github.com/rust-lang/rust-clippy/issues/8062
The suggestion seems to work well, as we've received no error reports since the implementation in December. This PR therefore promotes the suggestion to `MachineApplicable`. The tests already include `.fixed` files :)
changelog: [`search_is_some`]: Make more suggestions `MachineApplicable`
2022-03-14 22:12:25 +00:00
xFrednet
2ee5372389
Allow single_component_path_imports for all macros
2022-03-14 22:45:00 +01:00
xFrednet
fc5540a4d3
Make search_is_somes suggestion MachineApplicable
2022-03-14 22:02:10 +01:00
