88943 Commits

Author SHA1 Message Date
Rémy Rakic
489bc4a2c6 When mentioning lifetimes, put either the trait ref or the self type closer to the lifetimes
When mentioning lifetimes, only invert wording between the expected trait and the self type when the self type has the vid.
This way, the lifetimes always stay close to the self type or trait ref that actually contains them.
2019-01-27 10:52:45 +01:00
Rémy Rakic
1730ad4d1c Fix issue-57362-1.rs attributes 2019-01-27 10:52:45 +01:00
Niko Matsakis
790ed9128a comment the pattern 2019-01-27 10:52:44 +01:00
Niko Matsakis
ec6405bccd identify when implemented for "some specific lifetime" 2019-01-27 10:52:44 +01:00
Niko Matsakis
ab80162e3f add a lot more debug! to try_report_placeholders_trait 2019-01-27 10:52:44 +01:00
Niko Matsakis
c5dea5753f break apart tests 2019-01-27 10:52:43 +01:00
Remy Rakic
f5a74d40d9 Test new placeholder error messages in previously untested combinations 2019-01-27 10:52:43 +01:00
Remy Rakic
a79f135be6 Update test expectations for new placeholder error messages 2019-01-27 10:52:43 +01:00
lqd
ce61b1b9fa Update two E308 tests to the new placeholder error 2019-01-27 10:52:42 +01:00
lqd
55389f9171 Try to reword placeholder error messages to make them clearer 2019-01-27 10:52:42 +01:00
lqd
823c888be2 Try to resolve type vars in the placeholder errors trait refs
These can sometimes be unresolved: some of the rustc UI tests show this.
2019-01-27 10:52:41 +01:00
lqd
a6028263d2 Handle higher-ranked lifetime conflict errors where the subtype is the sup region
These are happening since the switch to universes, and will now go through the "placeholder error" path, instead of the current fallback of E308 "mismatched types" errors.
2019-01-27 10:52:41 +01:00
lqd
c1437c944c Make NiceRegionError use the InferCtxt instead of its TyCtxt
Some errors (e.g placeholder errors) have unresolved type vars so this will allow to use `resolve_type_vars_if_possible` when needed.
2019-01-27 10:52:40 +01:00
bors
1484d0d123 Auto merge of - euclio:applicability-rename, r=estebank
remove deprecated suggestion functions

This PR removes the (now unused) deprecated suggestion functions and removes `_with_applicability` from their replacements' names.

This PR will break clippy, but I'll open a clippy PR once this is merged.
2019-01-27 06:35:51 +00:00
Andy Russell
0897ffc28f
remove _with_applicability from suggestion fns 2019-01-26 23:07:55 -05:00
Andy Russell
8eaa84c79f
document Applicability 2019-01-26 23:06:08 -05:00
bors
677064b979 Auto merge of - fintelia:riscv-cas, r=nagisa
Enable RISC-V atomic compare and swap

Fixes 
2019-01-27 03:57:54 +00:00
bors
491680114a Auto merge of - Mark-Simulacrum:fix-compiletest-stamp, r=oli-obk
Correctly set filetime for copied LLVM

This also makes compiletest no longer always retest everything.

Fixes 
2019-01-27 00:07:53 +00:00
Jonathan Behrens
607c5431ae Enable RISC-V atomic compare and swap 2019-01-26 16:42:42 -05:00
bors
20c2cba61d Auto merge of - Centril:rollup, r=Centril
Rollup of 7 pull requests

Successful merges:

 -  (Stabilize extern_crate_self)
 -  (Make MutexGuard's Debug implementation more useful.)
 -  (Fix some minor warnings)
 -  (un-deprecate mem::zeroed)
 -  (Ignore aarch64 in simd-intrinsic-generic-reduction)
 -  (resolve: Fix span arithmetics in the import conflict error)
 -  (Change crate-visibility-modifier issue number in The Unstable Book)

Failed merges:

r? @ghost
2019-01-26 18:14:46 +00:00
Mazdak Farrokhzad
97833ee506
Rollup merge of - h-michael:fix-crate-visibility-modifier-issue-number, r=Centril
Change crate-visibility-modifier issue number in The Unstable Book

 is closed.
Because, it's duplicate issue of .
2019-01-26 18:21:49 +01:00
Mazdak Farrokhzad
bbe8dd9ca3
Rollup merge of - petrochenkov:errepice, r=estebank
resolve: Fix span arithmetics in the import conflict error

https://github.com/rust-lang/rust/pull/56937 rebased and fixed

Fixes https://github.com/rust-lang/rust/issues/56411
Fixes https://github.com/rust-lang/rust/issues/57071
Fixes https://github.com/rust-lang/rust/issues/57787

r? @estebank
2019-01-26 18:21:47 +01:00
Mazdak Farrokhzad
1206264fb2
Rollup merge of - parched:ignore, r=nikomatsakis
Ignore aarch64 in simd-intrinsic-generic-reduction

This fails on AArch64 see https://github.com/rust-lang/rust/issues/54510

Disabling it for now until it's fixed/implemented in LLVM

cc @gnzlbg
2019-01-26 18:21:46 +01:00
Mazdak Farrokhzad
5ce3f74096
Rollup merge of - RalfJung:zeroed, r=nikomatsakis
un-deprecate mem::zeroed

as per the discussion around <https://github.com/rust-lang/rust/issues/53491#issuecomment-451454793>
2019-01-26 18:21:45 +01:00
Mazdak Farrokhzad
51f53687e7
Rollup merge of - Xanewok:tiny-tweaks, r=nikomatsakis
Fix some minor warnings

Since apparently RLS works when initialized in the root repository (🎉) I decided to fix some of the issues it caught.

There are a lot of unused attribute warnings left on `rustc_on_unimplemented` and `rustc_layout_scalar_valid_range_start` but I imagine we can't do much about it due to 2-stage compilation?
2019-01-26 18:21:44 +01:00
Mazdak Farrokhzad
1e8fde07b6
Rollup merge of - m-ou-se:mutexguard-debug, r=cramertj
Make MutexGuard's Debug implementation more useful.

Fixes .
2019-01-26 18:21:42 +01:00
Mazdak Farrokhzad
5e6c2f40d0
Rollup merge of - mehcode:stabilize-extern-crate-self, r=Centril
Stabilize extern_crate_self

Fixes 
2019-01-26 18:21:41 +01:00
bors
46a43dc1e9 Auto merge of - davidtwco:issue-57819, r=estebank
Suggest removing leading left angle brackets.

Fixes .

This PR adds errors and accompanying suggestions as below:

```
bar::<<<<<T as Foo>::Output>();
     ^^^ help: remove extra angle brackets
```

r? @estebank
2019-01-26 15:33:43 +00:00
bors
ccd428befd Auto merge of - Zoxc:combine-early-lints, r=estebank
Combine all builtin early lints

This also adds a -Z no-interleave-lints option to allow benchmarking lints.

r? @estebank
2019-01-26 12:21:03 +00:00
bors
f95834b2a9 Auto merge of - alexcrichton:stabilize-atomics, r=sfackler
std: Stabilize fixed-width integer atomics

This commit stabilizes the `Atomic{I,U}{8,16,32,64}` APIs in the
`std::sync::atomic` and `core::sync::atomic` modules. Proposed in 
and tracked in  this feature has been unstable for quite some time
and is hopefully ready to go over the finish line now!

The API is being stabilized as-is. The API of `AtomicU8` and friends
mirrors that of `AtomicUsize`. A list of changes made here are:

* A portability documentation section has been added to describe the
  current state of affairs.
* Emulation of smaller-size atomics with larger-size atomics has been
  documented.
* As an added bonus, `ATOMIC_*_INIT` is now scheduled for deprecation
  across the board in 1.34.0 now that `const` functions can be invoked
  in statics.

Note that the 128-bit atomic types are omitted from this stabilization
explicitly. They have far less platform support than the other atomic
types, and will likely require further discussion about their best
location.

Closes 
Closes 
2019-01-26 09:46:10 +00:00
bors
42eb5ff404 Auto merge of - nagisa:optimize-attr, r=pnkfelix
Implement optimize(size) and optimize(speed) attributes

This PR implements both `optimize(size)` and `optimize(speed)` attributes.

While the functionality itself works fine now, this PR is not yet complete: the code might be messy in places and, most importantly, the compiletest must be improved with functionality to run tests with custom optimization levels. Otherwise the new attribute cannot be tested properly. Oh, and not all of the RFC is implemented – attribute propagation is not implemented for example.

# TODO

* [x] Improve compiletest so that tests can be written;
* [x] Assign a proper error number (E9999 currently, no idea how to allocate a number properly);
* [ ] Perhaps reduce the duplication in LLVM attribute assignment code…
2019-01-26 07:08:18 +00:00
Hirokazu Hata
b215fbdbb4 Change crate-visibility-modifier issue number in The Unstable Book 2019-01-26 15:50:05 +09:00
bors
9df043b543 Auto merge of - cuviper:llvm-monorepo, r=alexcrichton
Rebase to the llvm-project monorepo

The new git submodule src/llvm-project is a monorepo replacing src/llvm
and src/tools/{clang,lld,lldb}.  This also serves as a rebase for these
projects to the new 8.x branch from trunk.

The src/llvm-emscripten fork is unchanged for now.

r? @alexcrichton
2019-01-26 02:10:15 +00:00
Alex Crichton
059ed4f21f Update dlmalloc to 0.1.2
Remove usage of an old and removed wasm intrinsic
2019-01-25 15:40:53 -08:00
Josh Stone
15cf179c93 Set LLDB_NO_DEBUGSERVER=ON 2019-01-25 15:39:55 -08:00
Josh Stone
a920ed935c [rust-lldb] Adapt to changes in LLDB APIs 2019-01-25 15:39:54 -08:00
Josh Stone
400dec059e librustc_llvm: default to libc++ for darwin 2019-01-25 15:39:54 -08:00
Josh Stone
8b88324c56 Update LLVM for a CodeView fix 2019-01-25 15:39:54 -08:00
Josh Stone
cff0750090 Set the DICompileUnit emissionKind 2019-01-25 15:39:54 -08:00
Alex Crichton
75d0bceb0a Add two more wasm-related LLVM commits 2019-01-25 15:39:54 -08:00
Josh Stone
df0466d0bb Rebase to the llvm-project monorepo
The new git submodule src/llvm-project is a monorepo replacing src/llvm
and src/tools/{clang,lld,lldb}.  This also serves as a rebase for these
projects to the new 8.x branch from trunk.

The src/llvm-emscripten fork is unchanged for now.
2019-01-25 15:39:54 -08:00
bors
37d51aa8f3 Auto merge of - Centril:rollup, r=Centril
Rollup of 5 pull requests

Successful merges:

 -  (Miri and miri-related code contains repetitions of `(n << amt) >> amt`)
 -  (distinguish "no data" from "heterogeneous" in ABI)
 -  (Fix evaluating trivial drop glue in constants)
 -  (Add suggestion for moving type declaration before associated type bindings in generic arguments.)
 -  (Fix wording in diagnostics page)

Failed merges:

r? @ghost
2019-01-25 23:27:20 +00:00
Vadim Petrochenkov
1b659d69bc Address review comments and cleanup code 2019-01-26 01:49:55 +03:00
Mark Rousskov
82fae2be04 Correctly set filetime for copied LLVM
This also makes compiletest no longer always retest everything.
2019-01-25 14:31:38 -07:00
bors
bf669d1e32 Auto merge of - Dylan-DPC:fi/compiler-builtins-lock, r=alexcrichton
Update Cargo.lock to use the latest `compiler_builtins`

A very tiny PR per the request of @alexcrichton : rust-lang-nursery/compiler-builtins#267 (comment)

Rewrite of 

cc @Lokathor

r? @alexcrichton
2019-01-25 20:30:43 +00:00
Alex Crichton
14b36fb15a std: Stabilize fixed-width integer atomics
This commit stabilizes the `Atomic{I,U}{8,16,32,64}` APIs in the
`std::sync::atomic` and `core::sync::atomic` modules. Proposed in 
and tracked in  this feature has been unstable for quite some time
and is hopefully ready to go over the finish line now!

The API is being stabilized as-is. The API of `AtomicU8` and friends
mirrors that of `AtomicUsize`. A list of changes made here are:

* A portability documentation section has been added to describe the
  current state of affairs.
* Emulation of smaller-size atomics with larger-size atomics has been
  documented.
* As an added bonus, `ATOMIC_*_INIT` is now scheduled for deprecation
  across the board in 1.34.0 now that `const` functions can be invoked
  in statics.

Note that the 128-bit atomic types are omitted from this stabilization
explicitly. They have far less platform support than the other atomic
types, and will likely require further discussion about their best
location.

Closes 
Closes 
2019-01-25 11:48:10 -08:00
François Mockers
ac4b685650 do not suggest a fix for a import conflict in a macro 2019-01-25 22:39:14 +03:00
Simonas Kazlauskas
ce289c6c99 Resolve breakage 2019-01-25 19:20:38 +02:00
Mazdak Farrokhzad
0ae3d87d81
Rollup merge of - feinorgh:fix-diagnostics-typo, r=zackmdavis
Fix wording in diagnostics page

Fix a tiny wording error in the diagnostics text for E0070.
2019-01-25 16:59:31 +01:00
Mazdak Farrokhzad
7768358e72
Rollup merge of - davidtwco:issue-57385, r=estebank
Add suggestion for moving type declaration before associated type bindings in generic arguments.

Fixes .

r? @estebank
2019-01-25 16:59:29 +01:00