Commit Graph

1065 Commits

Author SHA1 Message Date
Oliver Schneider
3b7720f992 lint ! and != in if expressions with else branches 2016-02-29 12:34:48 +01:00
llogiq
35e00e20c9 Merge pull request #710 from oli-obk/enum_disrc_portability
lint unportable clike enum discriminants
2016-02-29 10:01:14 +01:00
Oliver Schneider
67213c9be4 lint unportable clike enum discriminants 2016-02-29 09:36:13 +01:00
llogiq
105a14f547 Merge pull request #721 from mcarton/while_let_loop
Fix wrong suggestion in `WHILE_LET_LOOP`
2016-02-28 22:49:56 +01:00
llogiq
5fe58d5c6e Merge pull request #723 from mcarton/swap
Swap lints
2016-02-28 22:48:41 +01:00
mcarton
76004306cc Lint manual swaps 2016-02-28 12:16:13 +01:00
mcarton
5fadfb3ea6 Fix wrong suggestion in WHILE_LET_LOOP
Ok, I lied in the title. This basically *removes* the problematic part
but:
  1) it was ugly with big bodies;
  2) it was not indented properly;
  3) it wasn’t very smart (see #675).
2016-02-28 12:09:28 +01:00
mcarton
72ef26272d Lint foo = bar; bar = foo sequences 2016-02-28 00:02:43 +01:00
llogiq
98eb623043 Merge pull request #720 from mcarton/formatting
Formatting lints for `=@` and `else if`s
2016-02-27 20:05:21 +01:00
mcarton
05178c92b9 Cleanup 2016-02-27 18:18:58 +01:00
mcarton
3a5b9a707c Fix (new?) rustc warnings 2016-02-27 18:18:58 +01:00
mcarton
1c3cce8ba5 Add a lint about suspiciously formatted else if 2016-02-27 18:18:53 +01:00
mcarton
810de56079 Add a lint about suspiciously formatted =@ ops
For `@` in {`*`, `!`, `-`}.
2016-02-27 17:57:36 +01:00
Martin Carton
14d2afbf03 Merge pull request #711 from mcarton/hashmap
Fix false positive in `FOR_KV_MAP` and `&mut` refs
2016-02-26 12:54:31 +01:00
mcarton
62cbd87728 Fix false positive in FOR_KV_MAP and &mut refs 2016-02-26 12:51:26 +01:00
llogiq
b3ffc1868f Merge pull request #689 from mcarton/entries
Improve the `MAP_ENTRY` lint
2016-02-26 12:18:34 +01:00
Manish Goregaokar
f13b841282 Merge branch 'pr-704'
Conflicts:
	src/len_zero.rs
2016-02-25 01:38:08 +05:30
llogiq
e3d9802072 Merge pull request #706 from mcarton/and_then
`span_suggestion` and macro checks
2016-02-24 21:05:37 +01:00
mcarton
783437eef0 Use span_suggestion in loops lints 2016-02-24 20:54:35 +01:00
mcarton
7b1a0a9434 Macro check len_zero 2016-02-24 20:53:15 +01:00
mcarton
c1b2fe31b7 Use span_suggestion in len_zero 2016-02-24 20:52:47 +01:00
mcarton
b753e77cbe Rustfmt and sort all use items 2016-02-24 17:38:57 +01:00
mcarton
d299b5d4d9 Bump to 0.0.44 2016-02-22 20:06:59 +01:00
Martin Carton
f38be64afc Merge pull request #701 from mcarton/fix-700
Fix ICE with match_def_path
2016-02-22 20:04:31 +01:00
mcarton
3b783152cc Fix ICE with match_def_path 2016-02-22 20:00:51 +01:00
Martin Carton
996a86fdab Merge pull request #699 from mcarton/format
Limit `USELESS_FORMAT` with args to string args
2016-02-22 18:00:05 +01:00
mcarton
2a0fb1fb44 Limit USELESS_FORMAT with args to string args 2016-02-22 17:54:46 +01:00
Manish Goregaokar
0e9ced5cb8 Bump to 0.0.43 2016-02-21 20:09:37 +05:30
Martin Carton
c47d5a615f Merge pull request #690 from quininer/fix-nightly
fix nightly (2016-02-17)
2016-02-21 15:38:31 +01:00
mcarton
d77ccdc338 Fix USELESS_FORMAT wiki 2016-02-21 13:21:04 +01:00
llogiq
9c36736f51 Merge pull request #692 from mcarton/format
Lint about `format!("string lit")` with no argument
2016-02-21 03:16:41 +01:00
mcarton
1a64a4890c Small cleanup 2016-02-20 21:20:56 +01:00
mcarton
ba3be83488 Lint about format!("{}", foo) 2016-02-20 21:15:05 +01:00
mcarton
b6443b9928 Replace all format!("{}", foo) calls 2016-02-20 21:03:45 +01:00
mcarton
ef4401d4ac Lint about usage of format!("string literal") 2016-02-20 17:46:20 +01:00
mcarton
222086d62b Remove all use of format!("string literal") 2016-02-20 17:46:20 +01:00
mcarton
5fe6e9f911 Build the import lint in update_lints.py 2016-02-20 17:46:16 +01:00
quininer kel
35a48bf512 fix nightly
9b40e1e5b3
2016-02-19 04:16:39 +08:00
Manish Goregaokar
78b31c61bd Merge pull request #688 from Manishearth/fix-671
improve str_add_assign lint description
2016-02-19 01:43:23 +05:30
mcarton
aa1df8e9ff Improve the MAP_ENTRY lint
Don’t span a suggestion when not appropriate but use a note and don’t
force it to be `if !cond`.
2016-02-18 20:19:16 +01:00
llogiq
1fd0676fa3 improve str_add_assign lint description 2016-02-18 20:12:33 +01:00
Martin Carton
eabc54406e Merge pull request #687 from oli-obk/fix_glob_enum_use
fix enum glob use (again)
2016-02-18 16:23:11 +01:00
Oliver Schneider
add483afed fix enum glob use (again) 2016-02-18 16:08:45 +01:00
Manish Goregaokar
05afde821c Merge pull request #673 from oli-obk/fix/665
don't lint on all caps enum variants starting with the same char
2016-02-18 11:12:58 +05:30
Manish Goregaokar
31db60ccc5 Bump and publish to 0.0.41 (fix #683) 2016-02-18 10:52:53 +05:30
Manish Goregaokar
e659ce1437 Merge pull request #664 from Manishearth/fix_regex
remove Visitor from regex_macro
2016-02-18 10:28:12 +05:30
Martin Carton
7250738edf Merge pull request #679 from mcarton/rustup
Rustup to 1.8.0-nightly (57c357d89 2016-02-16)
2016-02-17 15:53:28 +01:00
mcarton
227ff8c4ad Rustup to 1.8.0-nightly (57c357d89 2016-02-16) 2016-02-17 13:38:44 +01:00
Oliver Schneider
cf536d7a4f fallout 2016-02-17 13:33:32 +01:00
Oliver Schneider
e809eb61d7 fix enum_variant_names linting on all caps enum variants 2016-02-17 13:33:32 +01:00