Michael Howell
ccea908c17
rustdoc: add assertion for missing popover div
2022-06-28 18:20:19 -07:00
Michael Howell
f5f42a8cba
rustdoc: make keyboard commands work when checkboxes are selected
2022-06-28 17:29:55 -07:00
Michael Howell
cb8a7388fa
rustdoc: fix keyboard shortcuts bug in settings menu
...
This commit fixes the keyboard shorts code to call localStorage every time a
key is pressed. This matters because you're supposed to be able to change a
setting and have it immediately take effect.
2022-06-28 17:29:37 -07:00
bors
126e3df406
Auto merge of #98376 - nnethercote:improve-derive-PartialEq, r=petrochenkov
...
Improve some deriving code and add a test
The `.stdout` test is particularly useful.
r? `@petrochenkov`
2022-06-29 00:20:57 +00:00
Michael Howell
cec6988a07
rustdoc: fix help menu popover toggling
2022-06-28 16:02:44 -07:00
Michael Goulet
98af1bfecc
Migrate some rustc_borrowck diagnostics to SessionDiagnostic
2022-06-28 22:41:56 +00:00
Michael Goulet
8fd73560b3
Do not use a suggestion to change a binding's name to a type
2022-06-28 22:34:13 +00:00
Michael Goulet
f4fdcc7e24
Remove redundant logic to suggest as_ref
2022-06-28 22:34:13 +00:00
Eric Huss
78c9790e2a
Update cargo
2022-06-28 15:31:42 -07:00
Yan Chen
f97326de45
Fix #98260 , added the test case
2022-06-28 15:20:30 -07:00
Michael Goulet
862873d20b
Note concrete type being coerced into object
2022-06-28 21:56:18 +00:00
Michael Goulet
6c0a591dee
Fix trait object reborrow suggestion
2022-06-28 21:42:52 +00:00
bors
2953edc7b7
Auto merge of #98475 - notriddle:notriddle/index-fn-signatures, r=GuillaumeGomez
...
rustdoc: reference function signature types from the `p` array
This reduces the size of the function signature index, because it's common to have many functions that operate on the same types.
$ wc -c search-index-old.js search-index-new.js
5224374 search-index-old.js
3932314 search-index-new.js
By my math, this reduces the uncompressed size of the search index by 32%.
On compressed signatures, the wins are less drastic, a mere 8%:
$ wc -c search-index-old.js.gz search-index-new.js.gz
404532 search-index-old.js.gz
371635 search-index-new.js.gz
2022-06-28 21:40:10 +00:00
Dominik Stolz
053f48d91f
Address code review comments
2022-06-28 23:26:54 +02:00
DrMeepster
9039265c30
fix silly mistake
...
you should always run x.py check before pushing
2022-06-28 13:48:13 -07:00
Dominik Stolz
080525229b
Make consts mod private
2022-06-28 22:45:05 +02:00
Dominik Stolz
cd88bb332c
Improve pretty printing of valtrees for references
2022-06-28 22:38:32 +02:00
Josh Stone
c6f362a7c5
Let rust-analyzer ship on stable, non-preview
2022-06-28 12:28:01 -07:00
Eric Huss
b292d94a9a
Triagebot: Fix mentions word wrapping.
2022-06-28 11:38:07 -07:00
bors
8308806403
Auto merge of #98632 - matthiaskrgr:rollup-peg868d, r=matthiaskrgr
...
Rollup of 11 pull requests
Successful merges:
- #98548 (rustdoc-json: Allow Typedef to be different in sanity assert)
- #98560 (Add regression test for #85907 )
- #98564 (Remove references to `./tmp` in-tree)
- #98602 (Add regression test for #80074 )
- #98606 (⬆️ rust-analyzer)
- #98609 (Fix ICE for associated constant generics)
- #98611 (Fix glob import ICE in rustdoc JSON format)
- #98617 (Remove feature `const_option` from std)
- #98619 (Fix mir-opt wg name)
- #98621 (llvm-wrapper: adapt for removal of the ASanGlobalsMetadataAnalysis LLVM API)
- #98623 (fix typo in comment)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2022-06-28 18:36:42 +00:00
bors
4995b4e584
Auto merge of #9046 - xFrednet:rust-97660-expection-something-something, r=Jarcho
...
Fix `#[expect]` for most clippy lints
This PR fixes most `#[expect]` - lint interactions listed in rust-lang/rust#97660 . [My comment in the issue](https://github.com/rust-lang/rust/issues/97660#issuecomment-1147269504 ) shows the current progress (Once this is merged). I plan to work on `duplicate_mod` and `multiple_inherent_impl` and leave the rest for later. I feel like stabilizing the feature is more important than fixing the last few nits, which currently also don't work with `#[allow]`.
---
changelog: none
r? `@Jarcho`
cc: rust-lang/rust#97660
2022-06-28 18:28:38 +00:00
bors
a4130e1612
Auto merge of #8355 - Jarcho:explicit_auto_deref_2, r=flip1995
...
Add lint `explicit_auto_deref` take 2
fixes : #234
fixes : #8367
fixes : #8380
Still things to do:
* ~~This currently only lints `&*<expr>` when it doesn't trigger `needless_borrow`.~~
* ~~This requires a borrow after a deref to trigger. So `*<expr>` changing `&&T` to `&T` won't be caught.~~
* The `deref` and `deref_mut` trait methods aren't linted.
* Neither ~~field accesses~~, nor method receivers are linted.
* ~~This probably shouldn't lint reborrowing.~~
* Full slicing to deref should probably be handled here as well. e.g. `&vec[..]` when just `&vec` would do
changelog: new lint `explicit_auto_deref`
2022-06-28 18:09:26 +00:00
bors
23c6765276
Auto merge of #8921 - Jarcho:merge_passes, r=llogiq
...
Add `Operators` lint pass
changelog: None
2022-06-28 17:24:06 +00:00
Jason Newcomb
ffbba8550a
Move SelfAssignment
into Operators
lint pass
2022-06-28 13:03:08 -04:00
Jason Newcomb
5e2a2d3ac9
Fix dogfood
2022-06-28 13:02:08 -04:00
Jason Newcomb
92891a01a1
Move PtrEq
into Operators
lin pass
2022-06-28 12:51:30 -04:00
Jason Newcomb
fc5eac5894
Move NeedlessBitwiseBool
into Operators
lint pass
2022-06-28 12:51:30 -04:00
Jason Newcomb
71c2daa60a
Move ModuloArithmetic
into Operators
lint pass
2022-06-28 12:51:30 -04:00
Jason Newcomb
c0b0ee5bdc
Move some lints from Misc
to Operators
2022-06-28 12:51:30 -04:00
Jason Newcomb
a8df16ae1d
Move IntegerDivision
into Operators
lint pass
2022-06-28 12:51:30 -04:00
Jason Newcomb
83de67cfec
Move IdentityOp
into Operators
lint pass
2022-06-28 12:51:30 -04:00
Jason Newcomb
56f50d36e7
Move FloatEqualityWithoutAbs
into Operators
lint pass
2022-06-28 12:51:29 -04:00
Jason Newcomb
3de70a4996
Move ErasingOp
into Operators
lint pass
2022-06-28 12:51:29 -04:00
Jason Newcomb
0adb3c0518
Move EqOp
into Operators
lint pass
2022-06-28 12:51:29 -04:00
Jason Newcomb
732d7162ab
Move DurationSubsec
into Operators
lint pass
2022-06-28 12:51:29 -04:00
Jason Newcomb
4ac3626f2e
Move DoubleComparison
into Operators
lint pass
2022-06-28 12:51:29 -04:00
Jason Newcomb
68a7fd22ad
Move BitMask
into Operators
lint pass
2022-06-28 12:51:26 -04:00
Jason Newcomb
751131b4ac
Move AssignOps
into Operators
lint pass
2022-06-28 12:51:03 -04:00
Jason Newcomb
448b6f45bd
Move Arithmetic
into Operators
lint pass
2022-06-28 12:51:00 -04:00
Jason Newcomb
dd78ce7bbe
Add Operators
lint pass
2022-06-28 12:50:33 -04:00
Jason Newcomb
85c1f74fef
Add explicit_auto_deref
test for variadic function
2022-06-28 12:48:50 -04:00
Jason Newcomb
15df2289ea
Code cleanup
2022-06-28 12:48:49 -04:00
Jason Newcomb
9788107931
Handle future precedence issues in explicit_auto_deref
+ cleanup
2022-06-28 12:48:27 -04:00
Jason Newcomb
6d21b79be9
Fix needless_borrow
suggestion when calling a trait method taking self
2022-06-28 12:48:27 -04:00
Jason Newcomb
0b4ba734cb
Refactor dereference.rs
...
Merge `Position` and `AutoDerefStability`
2022-06-28 12:48:26 -04:00
Jason Newcomb
0204b95357
Lint explicit_auto_deref
immediately after needless_borrow
2022-06-28 12:48:26 -04:00
Jason Newcomb
65bc6cb8bf
Lint explicit_auto_deref
without a leading borrow
2022-06-28 12:48:26 -04:00
Jason Newcomb
442a68c64b
Only check parent node once in dereference.rs
2022-06-28 12:48:26 -04:00
Jason Newcomb
20ea26234a
Lint field accesses in explicit_auto_deref
2022-06-28 12:48:26 -04:00
Jason Newcomb
a187d6412b
Merge different parent walking loops in dereference.rs
...
`needless_borrow` will now walk further to find the target type.
2022-06-28 12:48:26 -04:00