Manish Goregaokar
1090509564
non_copy_const: remove incorrect suggestion
2019-09-25 14:45:18 -07:00
Manish Goregaokar
a9a3350455
needless_return: add allow()s to test, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
980650eec2
needless_collect: fix suggestion, make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
7f822e742d
needless_borrowed_ref: fix false positive, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
622b167eb8
needless_borrow: allow other lints, make fixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
0d8e4d7c37
mem_discriminant: split test, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
483e140bce
map_flatten: make it a rustfix test
2019-09-25 14:45:18 -07:00
Manish Goregaokar
d29f6d28b5
Leave note on non-rustfixable tests
2019-09-25 14:45:18 -07:00
Manish Goregaokar
329e224eba
Remove large-digit-groups test from literals.rs
2019-09-25 14:45:18 -07:00
Manish Goregaokar
4368771548
map_entry test: Fix semicolon, add run-rustfix
2019-09-25 14:45:18 -07:00
Manish Goregaokar
e2f4b60661
Split map_entry tests into fixable and unfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
d445bf2e89
Remove suggestion for complex map_entry cases
2019-09-25 13:54:53 -07:00
Manish Goregaokar
a756b9bd2d
allow osx failures
2019-09-25 13:51:45 -07:00
Manish Goregaokar
b5cadd734e
ignore single-match for or patterns
2019-09-25 13:34:55 -07:00
Manish Goregaokar
982c51e769
arm.pats -> arm.pat
2019-09-25 12:52:16 -07:00
Manish Goregaokar
68c26b325b
Rustup to rustc 1.39.0-nightly ( acf7b50c7
2019-09-25)
...
- Addresses inference error
- Updates compiletest
2019-09-25 11:11:14 -07:00
bors
d5ec41c442
Auto merge of #4567 - phansch:toplevel_ref_arg, r=flip1995
...
Add run-rustfix for toplevel_ref_arg lint
changelog: none
cc #3630
2019-09-23 17:01:13 +00:00
Philipp Hansch
df83732f09
Add run-rustfix for toplevel_ref_arg lint
2019-09-23 11:22:31 +02:00
bors
4d566b6959
Auto merge of #4561 - rust-lang:let-return-fix, r=phansch
...
Fix let_and_return lint
This fixes #4555 (false positive for the `let_and_return` lint).
changelog: none
2019-09-23 08:25:38 +00:00
Andre Bogus
2b7514154d
Fix let_and_return lint
2019-09-23 09:17:18 +02:00
bors
0fcb49ee30
Auto merge of #4566 - phansch:update_changelog2, r=flip1995
...
Update the changelog for Rust 1.38
[Rendered](https://github.com/phansch/rust-clippy/blob/update_changelog2/CHANGELOG.md#rust-138 )
changelog: none
2019-09-23 07:11:21 +00:00
bors
c23b3755f3
Auto merge of #4537 - mikerite:unneeded_wildcard_pattern, r=phansch
...
Add `unneeded-wildcard-pattern` lint
changelog: Add `unneeded-wildcard-pattern` lint
2019-09-23 05:51:04 +00:00
Michael Wright
ca6d36ba22
Merge branch 'master' into unneeded_wildcard_pattern
2019-09-23 05:26:47 +02:00
Philipp Hansch
b451e43098
Update the changelog for Rust 1.38
2019-09-22 19:19:59 +02:00
bors
157edad620
Auto merge of #4518 - imp:4517_license-file, r=phansch
...
clippy::cargo_common_metadata: check for license-file
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.
Fixes #4517
changelog: clippy::cargo_common_metadata now checks for license-file when license is missing
2019-09-22 11:40:35 +00:00
bors
dbb1bdea87
Auto merge of #4565 - matthiaskrgr:rustup_16, r=phansch
...
rustup https://github.com/rust-lang/rust/pull/64666
changelog: none
2019-09-22 10:36:32 +00:00
Matthias Krüger
d7b3e237db
rustup https://github.com/rust-lang/rust/pull/64666
2019-09-22 12:35:20 +02:00
Cyril Plisko
4c881d108a
clippy::cargo_common_metadata: check for license-file
...
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.
Fixes #4517
2019-09-22 10:49:36 +03:00
Michael Wright
be4e41562a
Add additional tests to unneeded_wildcard_pattern
2019-09-22 09:10:39 +02:00
Michael Wright
d04bf15114
Merge branch 'master' into unneeded_wildcard_pattern
2019-09-22 08:59:23 +02:00
bors
d07d001b74
Auto merge of #4562 - phansch:wildcard_enum_match_rustfix, r=llogiq
...
Add run-rustfix for wildcard_enum_match_arm lint
changelog: none
cc #3630
2019-09-21 11:42:15 +00:00
Philipp Hansch
afd7b180e5
Add run-rustfix for wildcard_enum_match_arm lint
2019-09-21 07:26:18 +02:00
bors
f21cd81949
Auto merge of #4558 - Manishearth:suggestions, r=phansch
...
Make more tests rustfixable
changelog: Fix various lint suggestions
Progress towards https://github.com/rust-lang/rust-clippy/issues/3630
r? @phansch
2019-09-21 01:01:21 +00:00
Manish Goregaokar
2fecf756f7
inline_fn_without_body: make it use a rustfix page
2019-09-21 10:01:06 +09:00
Manish Goregaokar
ee9e1af4ed
implicit_return: make it use a rustfix test
2019-09-21 10:01:06 +09:00
Manish Goregaokar
a2ab0698cc
identity_conversion: make it use a rustfix test
2019-09-21 10:01:06 +09:00
Manish Goregaokar
bbfb9a49e3
for_loop: Split test into fixable/unfixable, make needless_range_loop use updated range syntax
2019-09-21 10:01:06 +09:00
Manish Goregaokar
38a34b1bd7
eq_op: stop testing nonminimal_bool in same file
2019-09-20 23:21:37 +09:00
Manish Goregaokar
49adc99aed
op_ref: Move tests out of eq_op file
2019-09-20 23:21:37 +09:00
bors
ca9e4adf3d
Auto merge of #4511 - rust-lang:replace_uninitialized, r=flip1995
...
New lint: mem_replace_with_uninit
changelog: add `mem_replace_uninit` lint
This fixes #4485
2019-09-20 07:27:36 +00:00
Manish Goregaokar
d513a0b0a1
deref_addrof_double_trigger: Note why rustfix can't be used
2019-09-20 14:51:28 +09:00
Manish Goregaokar
fa969762a4
assign_ops: Remove MachineApplicable
2019-09-20 14:51:28 +09:00
Andre Bogus
8d884c8a1a
new lint: mem-replace-with-uninit
2019-09-20 00:25:57 +02:00
bors
cdaa93d695
Auto merge of #4544 - JoshMcguigan:issue-4542, r=flip1995
...
#4542 remove machine applicable suggestion
This helps #4542 (but does not completely resolve) by removing the machine applicable suggestion (which was incorrect) for that case.
I would have preferred to fix the machine applicable suggestion to handle format strings, but that's a bit beyond my current understanding of the clippy codebase. I'd be happy to give it a try given some guidance.
changelog: only produce machine applicable suggestions on `explicit_write` lint
2019-09-19 09:28:29 +00:00
bors
f08f171530
Auto merge of #4539 - jolson88:cast-lossless-pedantic, r=flip1995
...
Changes cast-lossless to a pedantic lint
As discussed in #4528 , this moves the cast-lossless lint from `all` to `pedantic`.
I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR).
fixes #4528
changelog: Moves cast-lossless from default to checking only as a `pedantic` lint.
2019-09-19 08:50:31 +00:00
bors
f783ff3d52
Auto merge of #4535 - rust-lang:unsafe-doc, r=flip1995
...
New lint: Require `# Safety` section in pub unsafe fn docs
changelog: add `missing_safety_doc` lint
This fixes #2207
2019-09-19 08:21:42 +00:00
Andre Bogus
70a7dab773
New lint: Require # Safety
section in pub unsafe fn docs
2019-09-19 09:19:55 +02:00
bors
a5e568bcc8
Auto merge of #4551 - mikerite:fix-ice-reporting, r=llogiq
...
Fix ice reporting
changelog: none
2019-09-19 04:12:43 +00:00
Michael Wright
16ce071bed
Work around qpath_res issue
2019-09-18 21:57:14 +02:00
Josh Mcguigan
24ec994001
remove machine applicable suggestion explicit_write format #4542
2019-09-18 01:59:58 -07:00