Aleksey Kladov
8dc68ecdfc
Introduce more appropriate assertion mechanism
...
rust-analyzer is a long-running program, so we *should* handle assertion
failures.
See also https://www.sqlite.org/assert.html .
2021-01-14 18:25:19 +03:00
Aleksey Kladov
2d0464a6f3
Encourage gifs
2021-01-11 16:29:29 +03:00
Laurențiu Nicola
a7db8abab7
Use T! for bool keywords
2021-01-10 17:47:12 +02:00
Aleksey Kladov
8f994dda68
typo
2021-01-07 20:27:22 +03:00
Aleksey Kladov
5aed769afe
Styleguide readability
2021-01-07 20:11:55 +03:00
Aleksey Kladov
eb710a63ca
Document std::ops style
2021-01-07 19:27:47 +03:00
bors[bot]
b821264f86
Merge #7195
...
7195: Update remaining serverPath references r=lnicola a=lnicola
Fixes https://github.com/rust-analyzer/rust-analyzer/pull/7156#issuecomment-755487667
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-01-07 15:30:23 +00:00
Laurențiu Nicola
56497ce925
Update remaining serverPath references
2021-01-07 17:06:11 +02:00
Kevaundray Wedderburn
72b9a4fbd3
Change <|> to $0 - Rebase
2021-01-07 12:09:23 +00:00
bors[bot]
1cc73d60bb
Merge #7068
...
7068: Add VSCode command to view the hir of a function body r=theotherphil a=theotherphil
Will fix https://github.com/rust-analyzer/rust-analyzer/issues/7061 . Very rough initial version just to work out where I needed to wire everything up.
@matklad would you be happy merging a hir visualiser of some kind? If so, do you have any thoughts on what you'd like it show, and how?
I've spent very little time on this thus far, so I'm fine with throwing away the contents of this PR, but I want to avoid taking the time to make this more polished/interactive/useful only to discover that no-one else has any interest in this functionality.
Co-authored-by: Phil Ellison <phil.j.ellison@gmail.com>
2021-01-03 09:03:15 +00:00
Phil Ellison
db53db8046
Address review suggestion, fix tidy tests
2021-01-01 19:25:18 +00:00
Aleksey Kladov
9c0c5f8e37
Improve commit message style
2020-12-28 13:43:07 +03:00
Aleksey Kladov
675390e012
Update docs/dev/README.md
...
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-12-16 18:07:21 +03:00
Aleksey Kladov
6e9023c763
Document new permissions
2020-12-16 18:04:24 +03:00
Aleksey Kladov
51f42db1d5
Add # to canonical test example
2020-12-15 11:49:22 +03:00
Aleksey Kladov
17f236c2b0
Normalize spelling to American English
2020-12-10 17:51:56 +03:00
Daiki Ihara
4f008bf8b2
fix typo of README in dev
2020-12-09 00:30:00 +09:00
Aleksey Kladov
3e00bfce2b
Document statelessness invariant
2020-12-03 18:08:27 +03:00
Jakob Hellermann
7c6c812a74
fix typos in syntax.md
2020-11-17 15:16:52 +01:00
kjeremy
233fdb12ce
Latest LSP 3.16 protocol
...
Pulls in https://github.com/gluon-lang/lsp-types/pull/186
2020-11-16 15:10:13 -05:00
Anatol Liu
b1b7727e04
add open Cargo.toml action
2020-11-12 17:48:07 -08:00
Aleksey Kladov
7d2eb000b0
Switch to upstream protocol for resolving code action
...
Note that we have to maintain custom implementation on the client
side: I don't see how to marry bulitin resolve support with groups and
snippets.
2020-11-10 18:48:46 +01:00
Aleksey Kladov
9b1d4cc8ab
don\t indent tests
2020-11-06 20:29:41 +01:00
Aleksey Kladov
412d6b3db5
Update docs/dev/style.md
...
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-11-02 12:17:34 +01:00
Aleksey Kladov
4318828f21
Document doer object anti-pattern
2020-11-02 12:13:59 +01:00
Laurențiu Nicola
f94d0252b3
Update client install command in dev docs
2020-10-27 09:49:57 +02:00
Adrian Stanciu
5f5b1ffdd1
Update debugging.md
2020-10-22 21:04:09 +03:00
Igor Aleksanov
d718366567
Document change of 'cargo' Runnable kind in lsp-extensions.md
2020-10-16 20:58:57 +03:00
Aleksey Kladov
0c67edc0f7
Expand code order section
2020-10-16 12:50:09 +02:00
Aleksey Kladov
86cc93ebe3
Document awkward names
2020-10-15 18:14:30 +02:00
Aleksey Kladov
dedfaa3844
Cleanup alloc advice
2020-10-15 12:21:38 +02:00
Aleksey Kladov
9c285b0341
Style: default over new
2020-10-14 20:02:03 +02:00
Aleksey Kladov
190011168d
Introduce S-actionable and S-unactionable labels
...
I've noticed that a significant fraction of issues are inert.
They are valid, acknowledged and useful, but effectively can't be
fixed for variety of reasons (no reproduction, dependencies on some
other issues, no review capacity, etc).
Marking issues that can be fixed by just applying some elbow grease
seems useful!
2020-10-14 15:20:31 +02:00
Aleksey Kladov
d852189e56
Add reminder to update lsp-extensions.md
2020-10-14 13:30:06 +02:00
Zac Pullar-Strecker
f1decfc110
Fix send->sent typo
2020-10-08 15:04:57 +13:00
Zac Pullar-Strecker
62b76e7004
Document the protocol extension
2020-10-08 15:04:20 +13:00
Aleksey Kladov
5359e8f742
minor
2020-10-07 13:11:33 +02:00
Aleksey Kladov
1688e481b3
minor
2020-10-07 13:03:13 +02:00
Aleksey Kladov
6976494781
Add comparisons guideline to style
2020-10-07 12:57:49 +02:00
Aleksey Kladov
fdf2f6226b
Reorg style
2020-10-07 12:50:46 +02:00
Aleksey Kladov
0599e64bb2
Document Clippy strategy
2020-10-02 10:13:58 +02:00
Laurențiu Nicola
2233749692
Improve grammar and fix code example in style guide
2020-10-01 21:02:39 +03:00
Aleksey Kladov
af8063fe37
Extend **Status** command to also show dep info for the file
...
This should help with troubleshooting wrong project configuration
2020-09-29 22:13:23 +02:00
Aleksey Kladov
b069c1c69a
More style advice
2020-09-29 14:42:09 +02:00
Yusuke Tanaka
4530b717cb
Fix typo
2020-09-21 01:44:38 +09:00
Yusuke Tanaka
203358a0d5
Fix typo
2020-09-21 00:53:14 +09:00
Aleksey Kladov
4f5d2ffac2
fmt import
2020-08-28 16:53:49 +02:00
Rüdiger Herrmann
3dbe062741
Update mentions of 'ra_vfs' in architecture doc
...
Adjust the paragraph about `ra_vfs` to point to the `vfs` crate that is used now.
2020-08-25 17:57:29 +02:00
bors[bot]
951c7c157a
Merge #5852
...
5852: Add Early Return rule to style r=matklad a=matklad
bors r+
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-24 10:56:04 +00:00
Aleksey Kladov
fc3e591bdb
Avoid monomorphization
2020-08-24 12:49:36 +02:00
