mcarton
7140eac484
Cleanup
2016-11-18 13:40:44 +01:00
mcarton
945c027768
Handle closure with single expression blocks
2016-11-17 19:44:18 +01:00
mcarton
19c5f5394b
Rustup to rustc 1.15.0-nightly ( 0ed951993 2016-11-14)
2016-11-16 23:05:26 +01:00
Oliver 'ker' Schneider
cfae1e9fda
fix ice in len_zero lint when type has no inherent impls at all
...
fixes #1336
2016-11-10 17:06:39 +01:00
Oliver Schneider
a260e65ead
Merge pull request #1312 from devonhollowood/get-unwrap
...
Implement `get_unwrap` lint
2016-11-09 09:49:20 +01:00
Oliver Schneider
a56af73fd8
mark cyclomatic complexity attribute as used
...
fixes #1315
2016-11-02 10:29:57 +01:00
Devon Hollowood
6a14dc7fd4
Remove false positives from get_unwrap lint
...
HashMap and BTreeMap don't implement `IndexMut`, so we shouldn't lint
for use of `get_mut().unwrap()` for those types.
2016-11-01 17:48:32 -07:00
Devon Hollowood
4e0d182d1d
Clean up get_unwrap code
2016-11-01 17:48:18 -07:00
Devon Hollowood
1187d333ec
Add tests for get_unwrap lint
2016-11-01 01:08:47 -07:00
Sebastian Ullrich
8664d03ec6
implement 'Re-implementing PartialEq::ne' lint
...
closes #86
2016-10-30 15:00:59 -04:00
d-dorazio
d213040381
Add lint for redundant pattern matching in iflet for Result/Option
2016-10-30 15:43:46 +01:00
Devon Hollowood
3a0d342a33
Fix false positive for wrong_self_convention
2016-10-27 01:11:34 -07:00
mcarton
984e15a0c0
Forbid default warnings in dogfood
2016-10-22 16:16:55 +02:00
d-dorazio
62831c6e29
Suggest nth(X) instead of skip(X).next()
2016-10-14 13:38:00 +02:00
mcarton
8d0431fd9a
Test for #1275
...
Close #1275 .
2016-10-12 12:00:26 +02:00
d-dorazio
a4d4a372e0
Avoid redundant multiple pattern suggested when one pattern is _
2016-10-08 16:29:19 +02:00
mcarton
47c2271497
Fix FP with print_with_newline and final arguments
2016-10-06 22:30:03 +02:00
Martin Carton
e851bc7404
Merge pull request #1257 from KitFreddura/master
...
If let some lint
2016-10-04 23:00:05 +02:00
Manish Goregaokar
7b94ef19bd
aux -> auxiliary (breaks Windows)
2016-10-04 09:15:03 +05:30
Manish Goregaokar
a4198c1108
Merge pull request #1255 from Manishearth/cov
...
Improve test coverage
2016-10-03 22:15:23 +05:30
mcarton
6800111c8e
Move all *.toml test files to tests/aux
2016-10-03 17:49:41 +02:00
Kit Freddura
72a653d8d4
readded files
2016-10-02 13:49:29 -07:00
mcarton
7b92fe0387
Test configuration file typing errors
2016-10-02 14:46:46 +02:00
mcarton
019e310861
Add more tests for bad configuration file
2016-10-02 14:43:09 +02:00
mcarton
f6f4af6adc
Add missing tests for ... and array indexing
2016-10-02 14:42:55 +02:00
mcarton
e50cfa7e77
Add a test for a shadow corner case
2016-10-02 02:38:54 +02:00
mcarton
9a3f53dee6
Partially hash let declaration in SpanlessHash
...
The hash never needs to be good but before it was simply doing nothing
for these.
2016-10-02 02:17:04 +02:00
mcarton
6302e41ccb
Improve test coverage of hir comparison
2016-10-01 22:27:25 +02:00
Martin Carton
8babb2d409
Merge pull request #1250 from elliottneilclark/explicit_into_iter
...
Add a lint to warn about un-necessary .into_iter()
2016-10-01 15:01:43 +02:00
Oliver Schneider
9c5d3f3b85
correctly traverse match expressions for diverging_sub_expr
2016-10-01 14:41:20 +02:00
Elliott Clark
5fa004313b
Add a lint to warn about un-necessary .into_iter()
...
This should close #1094 .
2016-09-30 17:42:43 -07:00
mcarton
84269478b0
chmod -x tests/compile-fail/print_with_newline.rs
2016-10-01 00:50:40 +02:00
Martin Carton
fe27ac5fd2
Merge pull request #1237 from Manishearth/rustup
...
Rustup to *rustc 1.13.0-nightly (d0623cf7b
2016-09-28 01:15:33 +02:00
mcarton
4f3920307a
Rustup to *rustc 1.13.0-nightly ( d0623cf7b 2016-09-26)*
2016-09-28 01:09:11 +02:00
mcarton
056b0c1cf2
Remove redundant labels in tests
2016-09-23 19:51:47 +02:00
Manish Goregaokar
fc9f2b99c7
Merge pull request #1235 from Manishearth/transmute_ptr_to_ref-suggs
...
Fix wrong suggestion in `TRANSMUTE_PTR_TO_REF` with lts
2016-09-19 22:02:47 +05:30
mcarton
f74dcaac0c
Fix wrong suggestion in TRANSMUTE_PTR_TO_REF with lts
2016-09-19 17:59:12 +02:00
Oliver Schneider
c89c5d21c1
Merge remote-tracking branch 'origin/master' into examples
2016-09-19 15:38:38 +02:00
mcarton
c8986b4676
Fix FP with WHILE_LET_ON_ITERATOR and refutable pats
2016-09-16 15:50:35 +02:00
Martin Carton
dc84759ac5
Merge pull request #1224 from oli-obk/divergence
...
lint diverging expressions that are sub-expressions of others
2016-09-13 15:58:31 +02:00
Oliver Schneider
9427a4ae80
also test match statements, return, continue and break
2016-09-13 14:52:21 +02:00
Oliver Schneider
e6bfe4b514
also lint diverging methods
2016-09-13 12:41:37 +02:00
Oliver Schneider
a2257280ec
don't lint expressions referencing ! objects, just expressions creating them
2016-09-13 12:41:20 +02:00
Oliver Schneider
40ce3a8f1c
add tests for stutter lints
2016-09-13 10:20:10 +02:00
Oliver Schneider
12a82b2007
also lint private modules for module_inception, as that is the main issue
2016-09-13 10:19:55 +02:00
Oliver Schneider
f469860dc2
lint diverging expressions that are sub-expressions of others
2016-09-12 14:24:11 +02:00
Oliver Schneider
03fa974855
Let the submodule #[allow] in module_inception
2016-09-12 10:30:42 +02:00
mcarton
8216036193
Add test for #[allow(module_inception)] on the inner module
2016-09-12 10:11:48 +02:00
mcarton
b08c7aa553
Remove EOL space
2016-09-09 20:24:15 +02:00
mcarton
b82f43f38e
Revert "Remove all union stuffs"
...
This reverts commit 888c34ad7070598e04f
2016-09-04 17:45:36 +02:00
mcarton
b2de244cfd
Restrict len_without_is_empty to exported items
2016-09-02 15:30:06 +02:00
kennytm
5f09020e90
Added a lint_without_lint_pass lint.
...
Four lints were missing from LintPass, making them unavailable unless the
`clippy` lint group is explicitly enabled:
* `for_loop_over_result`
* `for_loop_over_option`
* `match_overlapping_arm`
* `filter_next`
2016-09-01 15:07:37 +08:00
mcarton
888c34ad70
Remove all union stuffs
...
The rustc's PR wasn't merged. Hopefully this commit can simply be reverted when it's time.
2016-08-31 18:22:36 +02:00
mcarton
01424f5622
Support unions here and there
2016-08-31 18:22:36 +02:00
mcarton
ee3f3bf260
Remove temporary fix now unneeded
2016-08-31 18:22:36 +02:00
mcarton
d87f137254
Add a builtin_type_shadow lint
2016-08-28 19:56:18 +02:00
mcarton
e922fa80ce
Fix FP in ZERO_PREFIXED_LITERAL and 0b/Oo
2016-08-28 18:00:09 +02:00
mcarton
36d8ca04a1
Add a MISSING_DOCS_IN_PRIVATE_ITEMS lint
2016-08-23 18:28:39 +02:00
mcarton
507b626b36
Add zero_prefixed_literal lint
2016-08-23 18:15:12 +02:00
llogiq
cf2b0c8dd6
New cmp_null lint ( fixes #1184 ) ( #1186 )
...
* new cmp_null lint (fixes #1184 )
* adressed comments (still fails)
* fixed tests, dogfood, ran update_lints
2016-08-22 18:29:29 +02:00
Oliver Schneider
6dd003ac39
add regression test
2016-08-19 17:31:14 +02:00
Oliver Schneider
7b717d3152
fallout
2016-08-17 18:35:25 +02:00
Oliver Schneider
3ab6ad59c4
disallow lint attributes on use and extern crate items
2016-08-17 11:36:04 +02:00
Georg Brandl
ffad9a8c8c
Lint print!("...\n") ( closes #455 )
2016-08-16 20:52:48 +02:00
Oliver Schneider
b6f320a495
address nits and improve docs
2016-08-16 14:36:48 +02:00
Oliver Schneider
7ee4a9a659
lint modules that have the same name as their parent module
2016-08-16 14:29:21 +02:00
scurest
b0a96def09
Add lint for reads and writes that depend on evaluation order
2016-08-11 06:01:40 -05:00
llogiq
ce3be22021
Merge pull request #1151 from oli-obk/clone_ref
...
add suggestions to clone_on_copy
2016-08-09 06:30:25 +02:00
llogiq
8ac99162ea
Merge pull request #1152 from oli-obk/wrong_self_conv_fn_level
...
enable changing wrong_self_convention's lint level at the function level
2016-08-08 21:13:16 +02:00
Manish Goregaokar
4b8f6a0b0f
Merge pull request #1154 from oli-obk/no_dogfood_for_travis
...
don't run clippy on itself twice in travis
2016-08-08 21:48:29 +05:30
Oliver Schneider
dec3250ad6
don't run clippy on itself twice in travis
2016-08-08 17:33:41 +02:00
Oliver Schneider
331afc3246
extern fns often need to adhere to a specific api -> don't suggest api-changes
2016-08-08 17:21:47 +02:00
Oliver Schneider
49f276ec6f
enable changing wrong_self_convention's lint level at the function level
2016-08-08 17:09:36 +02:00
Oliver Schneider
7e67f447ce
add suggestions to clone_on_copy
...
also:
* don't report clone_on_copy when reporting clone_on_double_ref
* don't suggest `((x))`
2016-08-08 16:43:45 +02:00
Manish Goregaokar
74c7880597
Merge pull request #1145 from birkenfeld/issue-703-2
...
Lint literal suffixes not separated by underscores (idea also from #703 )
2016-08-07 09:57:16 +05:30
Georg Brandl
fa0df69a97
Add a configurable threshold for enum variants before name lints trigger ( fixes #1138 )
2016-08-06 20:59:27 +02:00
Georg Brandl
2f8247ada5
Lint literal suffixes not separated by underscores (see #703 )
2016-08-05 18:50:23 +02:00
Georg Brandl
ab58331f22
Lint inconsistent casing in hex literals ( closes #703 )
2016-08-05 18:30:49 +02:00
Oliver Schneider
81c5757f44
lint on by ref patterns for references
2016-08-01 16:59:14 +02:00
Oliver Schneider
100d381d2b
lint a += a + b (possible mis-refactoring of a = a + b)
2016-07-20 15:29:24 +02:00
llogiq
a371558bdb
Merge pull request #1093 from oli-obk/serde_specific_lint
...
lint on implementing `visit_string` without also implementing `visit_str`
2016-07-18 11:53:28 +02:00
Oliver Schneider
02c46f057f
add an internal lint that catches misordered paths
2016-07-18 11:19:33 +02:00
Manish Goregaokar
b8c5e5a89c
Fix position of mut in toplevel-ref-arg ( fixes #1100 , again)
2016-07-15 19:02:41 +05:30
Manish Goregaokar
60f354880f
Suggest mutability and fix type in toplevel-ref-arg
2016-07-15 17:52:34 +05:30
llogiq
b1becf41e4
Merge pull request #1099 from Manishearth/fix
...
Some small fixes
2016-07-14 21:32:45 +02:00
mcarton
ea665c38f1
Fix FP with USELESS_VEC and non-copy types
2016-07-14 19:31:17 +02:00
mcarton
c1eb5828fa
Fix suggestion spans for NEEDLESS_RETURN
2016-07-14 18:32:48 +02:00
Taylor Cramer
7450d842ea
Fix different NaNs in if const expressions test
2016-07-13 10:02:28 -07:00
Taylor Cramer
61d1a9b030
Check for comparison of -0.0 and 0.0 in PartialOrd for Constant
2016-07-13 09:55:16 -07:00
Taylor Cramer
0c21a6b0c4
Add test for different NaNs
2016-07-13 09:35:31 -07:00
Taylor Cramer
8907cbc0b8
Added sign check on Constant f64 PartialEq implementation
2016-07-13 00:43:33 -07:00
Oliver Schneider
319c66a2a4
lint on implementing visit_string without also implementing visit_str
2016-07-12 17:36:11 +02:00
Manish Goregaokar
c1421c6e82
Don't warn when boxing large arrays
2016-07-12 18:49:34 +05:30
mcarton
b8b6b7fee6
Try to explain MATCH_SAME_ARMS better
2016-07-10 14:46:39 +02:00
mcarton
eb75d4ee62
Fix suggestions for NEW_WITHOUT_DEFAULT
2016-07-10 14:20:38 +02:00
mcarton
3a7402a6d2
Fix FP with for loops and shadowed loop variable
2016-07-10 14:05:57 +02:00
llogiq
ad1cd99054
Merge pull request #1060 from Manishearth/sugg
...
Improve suggestions
2016-07-10 00:06:30 +02:00
mcarton
56d3bc7008
Handle /** and ~~~ in DOC_MARKDOWN
2016-07-08 18:24:47 +02:00
mcarton
c5e91e70d0
Use sugg::Sugg in transmute links
2016-07-04 02:22:57 +02:00
mcarton
9b79b1022c
Fix suggestions for needless_bool
2016-07-04 01:43:47 +02:00
