mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge #3072

Browse Source 
3072: vscode: removed unnecessary awaits feature r=matklad a=Veetaha

Found a feature that when the user has no internet connection the whole extension is blocked by waiting for the user to dismiss the error message and for making a sanity-check dns resolution.

Co-authored-by: Veetaha <gerzoh1@gmail.com>
This commit is contained in:
bors[bot] 2020-02-09 20:33:50 +00:00 committed by GitHub
commit c48c0f370a
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
editors/code/src/installation/language_server.ts
View File

@ -100,15 +100,21 @@ export async function ensureLanguageServerBinary(
try { try {
await downloadLatestLanguageServer(langServerSource); await downloadLatestLanguageServer(langServerSource);
} catch (err) { } catch (err) {
await vscode.window.showErrorMessage( vscode.window.showErrorMessage(
`Failed to download language server from ${langServerSource.repo.name} ` + `Failed to download language server from ${langServerSource.repo.name} ` +
`GitHub repository: ${err.message}` `GitHub repository: ${err.message}`
); );
await dns.resolve('www.google.com').catch(err => { dns.resolve('example.com').then(
console.error("DNS resolution failed, there might be an issue with Internet availability"); addrs => console.log("DNS resolution for example.com was successful", addrs),
err => {
console.error(
"DNS resolution for example.com failed, " +
"there might be an issue with Internet availability"
);
console.error(err); console.error(err);
}); }
);
return null; return null;
} }