mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Drop inaccurate comment

Browse Source 
The linked issue has an accurate description of the situation,
drop the inaccurate comment.
This commit is contained in:
Nikita Popov 2022-04-19 16:12:23 +02:00
parent 890cabac8a
commit 3cf0809a8d
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/codegen/panic-in-drop-abort.rs
View File

@ -6,11 +6,7 @@
// This test uses ignore-msvc, because the expected optimization does not happen on targets using // This test uses ignore-msvc, because the expected optimization does not happen on targets using
// SEH exceptions with the new LLVM pass manager anymore, see // SEH exceptions with the new LLVM pass manager anymore, see
// https://github.com/llvm/llvm-project/issues/51311. The core issue is that Rust promises that // https://github.com/llvm/llvm-project/issues/51311.
// the drop_in_place() function can't unwind, but implements it in a way that *can*, because we
// currently go out of our way to allow longjmps, which also use the unwinding mechanism on MSVC
// targets. We should either forbid longjmps, or not assume nounwind, making this optimization
// incompatible with the current behavior of running cleanuppads on longjmp unwinding.
// CHECK-NOT: {{(call|invoke).*}}should_not_appear_in_output // CHECK-NOT: {{(call|invoke).*}}should_not_appear_in_output