From 3cf0809a8d3ce66f468eed3dea96408d42eec33b Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Tue, 19 Apr 2022 16:12:23 +0200 Subject: [PATCH] Drop inaccurate comment The linked issue has an accurate description of the situation, drop the inaccurate comment. --- src/test/codegen/panic-in-drop-abort.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/test/codegen/panic-in-drop-abort.rs b/src/test/codegen/panic-in-drop-abort.rs index 7b9c41b658a..7a84484c419 100644 --- a/src/test/codegen/panic-in-drop-abort.rs +++ b/src/test/codegen/panic-in-drop-abort.rs @@ -6,11 +6,7 @@ // This test uses ignore-msvc, because the expected optimization does not happen on targets using // SEH exceptions with the new LLVM pass manager anymore, see -// https://github.com/llvm/llvm-project/issues/51311. The core issue is that Rust promises that -// the drop_in_place() function can't unwind, but implements it in a way that *can*, because we -// currently go out of our way to allow longjmps, which also use the unwinding mechanism on MSVC -// targets. We should either forbid longjmps, or not assume nounwind, making this optimization -// incompatible with the current behavior of running cleanuppads on longjmp unwinding. +// https://github.com/llvm/llvm-project/issues/51311. // CHECK-NOT: {{(call|invoke).*}}should_not_appear_in_output