2018-01-17 03:41:24 -06:00
|
|
|
//! checks for `#[inline]` on trait methods without bodies
|
|
|
|
|
2018-05-30 03:15:50 -05:00
|
|
|
use crate::utils::span_lint_and_then;
|
|
|
|
use crate::utils::sugg::DiagnosticBuilderExt;
|
2020-02-29 21:23:33 -06:00
|
|
|
use rustc_ast::ast::{Attribute, Name};
|
2018-12-29 09:04:45 -06:00
|
|
|
use rustc_errors::Applicability;
|
2020-02-21 02:39:38 -06:00
|
|
|
use rustc_hir::{TraitItem, TraitItemKind, TraitMethod};
|
2020-01-12 00:08:41 -06:00
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
2020-01-11 05:37:08 -06:00
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
2018-01-17 03:41:24 -06:00
|
|
|
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 10:50:33 -06:00
|
|
|
/// **What it does:** Checks for `#[inline]` on trait methods without bodies
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** Only implementations of trait methods may be inlined.
|
|
|
|
/// The inline attribute is ignored for trait methods without bodies.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// trait Animal {
|
|
|
|
/// #[inline]
|
|
|
|
/// fn name(&self) -> &'static str;
|
|
|
|
/// }
|
|
|
|
/// ```
|
2018-01-17 03:41:24 -06:00
|
|
|
pub INLINE_FN_WITHOUT_BODY,
|
2018-03-29 06:41:53 -05:00
|
|
|
correctness,
|
2018-01-17 03:41:24 -06:00
|
|
|
"use of `#[inline]` on trait methods without bodies"
|
|
|
|
}
|
|
|
|
|
2019-04-08 15:43:55 -05:00
|
|
|
declare_lint_pass!(InlineFnWithoutBody => [INLINE_FN_WITHOUT_BODY]);
|
2018-01-17 03:41:24 -06:00
|
|
|
|
2019-04-08 15:43:55 -05:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for InlineFnWithoutBody {
|
2019-12-22 08:42:41 -06:00
|
|
|
fn check_trait_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx TraitItem<'_>) {
|
2019-09-27 10:16:06 -05:00
|
|
|
if let TraitItemKind::Method(_, TraitMethod::Required(_)) = item.kind {
|
2018-06-28 08:46:58 -05:00
|
|
|
check_attrs(cx, item.ident.name, &item.attrs);
|
2018-01-17 03:41:24 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-23 06:01:12 -05:00
|
|
|
fn check_attrs(cx: &LateContext<'_, '_>, name: Name, attrs: &[Attribute]) {
|
2018-01-17 03:41:24 -06:00
|
|
|
for attr in attrs {
|
2019-05-17 16:53:54 -05:00
|
|
|
if !attr.check_name(sym!(inline)) {
|
2018-01-17 03:41:24 -06:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2018-01-17 13:08:03 -06:00
|
|
|
span_lint_and_then(
|
2018-01-17 03:41:24 -06:00
|
|
|
cx,
|
|
|
|
INLINE_FN_WITHOUT_BODY,
|
|
|
|
attr.span,
|
|
|
|
&format!("use of `#[inline]` on trait method `{}` which has no body", name),
|
2018-01-17 13:08:03 -06:00
|
|
|
|db| {
|
2018-09-18 12:01:17 -05:00
|
|
|
db.suggest_remove_item(cx, attr.span, "remove", Applicability::MachineApplicable);
|
2018-01-17 13:08:03 -06:00
|
|
|
},
|
2018-01-17 03:41:24 -06:00
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|