rust/clippy_lints/src/inline_fn_without_body.rs

59 lines
1.8 KiB
Rust
Raw Normal View History

//! checks for `#[inline]` on trait methods without bodies
2018-05-30 03:15:50 -05:00
use crate::utils::span_lint_and_then;
use crate::utils::sugg::DiagnosticBuilderExt;
2019-05-13 18:34:08 -05:00
use crate::utils::sym;
use rustc::hir::*;
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
2019-04-08 15:43:55 -05:00
use rustc::{declare_lint_pass, declare_tool_lint};
use rustc_errors::Applicability;
use syntax::ast::{Attribute, Name};
2018-03-28 08:24:26 -05:00
declare_clippy_lint! {
/// **What it does:** Checks for `#[inline]` on trait methods without bodies
///
/// **Why is this bad?** Only implementations of trait methods may be inlined.
/// The inline attribute is ignored for trait methods without bodies.
///
/// **Known problems:** None.
///
/// **Example:**
/// ```rust
/// trait Animal {
/// #[inline]
/// fn name(&self) -> &'static str;
/// }
/// ```
pub INLINE_FN_WITHOUT_BODY,
2018-03-29 06:41:53 -05:00
correctness,
"use of `#[inline]` on trait methods without bodies"
}
2019-04-08 15:43:55 -05:00
declare_lint_pass!(InlineFnWithoutBody => [INLINE_FN_WITHOUT_BODY]);
2019-04-08 15:43:55 -05:00
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for InlineFnWithoutBody {
fn check_trait_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx TraitItem) {
if let TraitItemKind::Method(_, TraitMethod::Required(_)) = item.node {
2018-06-28 08:46:58 -05:00
check_attrs(cx, item.ident.name, &item.attrs);
}
}
}
2018-07-23 06:01:12 -05:00
fn check_attrs(cx: &LateContext<'_, '_>, name: Name, attrs: &[Attribute]) {
for attr in attrs {
2019-05-13 18:34:08 -05:00
if !attr.check_name(*sym::inline) {
continue;
}
span_lint_and_then(
cx,
INLINE_FN_WITHOUT_BODY,
attr.span,
&format!("use of `#[inline]` on trait method `{}` which has no body", name),
|db| {
db.suggest_remove_item(cx, attr.span, "remove", Applicability::MachineApplicable);
},
);
}
}