rust/crates/ide_assists/src/handlers/add_missing_match_arms.rs

1134 lines
24 KiB
Rust
Raw Normal View History

2021-05-20 07:58:18 -05:00
use std::iter::{self, Peekable};
2019-02-03 12:26:35 -06:00
use either::Either;
2020-03-22 17:19:55 -05:00
use hir::{Adt, HasSource, ModuleDef, Semantics};
2020-11-28 08:30:39 -06:00
use ide_db::helpers::{mod_path_to_ast, FamousDefs};
2020-08-13 09:39:16 -05:00
use ide_db::RootDatabase;
2020-03-23 07:19:09 -05:00
use itertools::Itertools;
2020-08-12 11:26:51 -05:00
use syntax::ast::{self, make, AstNode, MatchArm, NameOwner, Pat};
2019-02-03 12:26:35 -06:00
2020-05-20 07:00:37 -05:00
use crate::{
2021-04-18 06:43:12 -05:00
utils::{self, render_snippet, Cursor},
2020-06-28 17:36:05 -05:00
AssistContext, AssistId, AssistKind, Assists,
2020-05-20 07:00:37 -05:00
};
2019-06-23 23:05:50 -05:00
2021-09-20 16:53:05 -05:00
// Assist: add_missing_match_arms
2019-10-26 09:37:04 -05:00
//
// Adds missing clauses to a `match` expression.
//
// ```
// enum Action { Move { distance: u32 }, Stop }
//
// fn handle(action: Action) {
// match action {
2021-01-06 14:15:48 -06:00
// $0
2019-10-26 09:37:04 -05:00
// }
// }
// ```
// ->
// ```
// enum Action { Move { distance: u32 }, Stop }
//
// fn handle(action: Action) {
// match action {
// $0Action::Move { distance } => todo!(),
// Action::Stop => todo!(),
2019-10-26 09:37:04 -05:00
// }
// }
// ```
2021-09-20 16:53:05 -05:00
pub(crate) fn add_missing_match_arms(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
2021-01-27 15:32:40 -06:00
let match_expr = ctx.find_node_at_offset_with_descend::<ast::MatchExpr>()?;
2019-08-22 13:31:21 -05:00
let match_arm_list = match_expr.match_arm_list()?;
2019-02-03 12:26:35 -06:00
let expr = match_expr.expr()?;
let mut arms: Vec<MatchArm> = match_arm_list.arms().collect();
if let [arm] = arms.as_slice() {
if let Some(Pat::WildcardPat(..)) = arm.pat() {
arms.clear();
}
}
let top_lvl_pats: Vec<_> = arms
.iter()
.filter_map(ast::MatchArm::pat)
.flat_map(|pat| match pat {
// Special case OrPat as separate top-level pats
Pat::OrPat(or_pat) => Either::Left(or_pat.pats()),
_ => Either::Right(iter::once(pat)),
})
2021-04-18 10:17:30 -05:00
// Exclude top level wildcards so that they are expanded by this assist, retains status quo in #8129.
.filter(|pat| !matches!(pat, Pat::WildcardPat(_)))
.collect();
let module = ctx.sema.scope(expr.syntax()).module()?;
2021-05-20 07:58:18 -05:00
let mut missing_pats: Peekable<Box<dyn Iterator<Item = ast::Pat>>> = if let Some(enum_def) =
resolve_enum_def(&ctx.sema, &expr)
{
2020-07-01 02:14:23 -05:00
let variants = enum_def.variants(ctx.db());
2021-05-20 07:58:18 -05:00
let missing_pats = variants
.into_iter()
2020-07-01 02:14:23 -05:00
.filter_map(|variant| build_pat(ctx.db(), module, variant))
2021-05-20 07:58:18 -05:00
.filter(|variant_pat| is_variant_missing(&top_lvl_pats, variant_pat));
let option_enum =
FamousDefs(&ctx.sema, Some(module.krate())).core_option_Option().map(lift_enum);
let missing_pats: Box<dyn Iterator<Item = _>> = if Some(enum_def) == option_enum {
2020-05-20 03:51:48 -05:00
// Match `Some` variant first.
2021-03-08 14:19:44 -06:00
cov_mark::hit!(option_order);
2021-05-20 07:58:18 -05:00
Box::new(missing_pats.rev())
} else {
Box::new(missing_pats)
};
missing_pats.peekable()
} else if let Some(enum_defs) = resolve_tuple_of_enum_def(&ctx.sema, &expr) {
let mut n_arms = 1;
let variants_of_enums: Vec<Vec<ExtendedVariant>> = enum_defs
.into_iter()
.map(|enum_def| enum_def.variants(ctx.db()))
.inspect(|variants| n_arms *= variants.len())
.collect();
2020-03-23 07:19:09 -05:00
// When calculating the match arms for a tuple of enums, we want
// to create a match arm for each possible combination of enum
// values. The `multi_cartesian_product` method transforms
// Vec<Vec<EnumVariant>> into Vec<(EnumVariant, .., EnumVariant)>
// where each tuple represents a proposed match arm.
// A number of arms grows very fast on even a small tuple of large enums.
// We skip the assist beyond an arbitrary threshold.
if n_arms > 256 {
return None;
}
let missing_pats = variants_of_enums
.into_iter()
.multi_cartesian_product()
2021-09-20 16:53:05 -05:00
.inspect(|_| cov_mark::hit!(add_missing_match_arms_lazy_computation))
.map(|variants| {
2020-03-23 07:19:09 -05:00
let patterns =
2020-07-01 02:14:23 -05:00
variants.into_iter().filter_map(|variant| build_pat(ctx.db(), module, variant));
ast::Pat::from(make::tuple_pat(patterns))
})
2021-05-20 07:58:18 -05:00
.filter(|variant_pat| is_variant_missing(&top_lvl_pats, variant_pat));
(Box::new(missing_pats) as Box<dyn Iterator<Item = _>>).peekable()
} else {
return None;
};
2021-05-20 07:58:18 -05:00
if missing_pats.peek().is_none() {
return None;
}
2021-01-27 15:32:40 -06:00
let target = ctx.sema.original_range(match_expr.syntax()).range;
2020-06-28 17:36:05 -05:00
acc.add(
2021-09-20 16:53:05 -05:00
AssistId("add_missing_match_arms", AssistKind::QuickFix),
2020-06-28 17:36:05 -05:00
"Fill match arms",
target,
|builder| {
let new_match_arm_list = match_arm_list.clone_for_update();
2021-05-20 07:58:18 -05:00
let missing_arms = missing_pats
2021-07-01 18:44:54 -05:00
.map(|pat| make::match_arm(iter::once(pat), None, make::ext::expr_todo()))
2021-05-20 07:58:18 -05:00
.map(|it| it.clone_for_update());
let catch_all_arm = new_match_arm_list
.arms()
.find(|arm| matches!(arm.pat(), Some(ast::Pat::WildcardPat(_))));
if let Some(arm) = catch_all_arm {
let is_empty_expr = arm.expr().map_or(true, |e| match e {
ast::Expr::BlockExpr(b) => {
b.statements().next().is_none() && b.tail_expr().is_none()
}
ast::Expr::TupleExpr(t) => t.fields().next().is_none(),
_ => false,
});
if is_empty_expr {
arm.remove();
} else {
2021-09-20 16:53:05 -05:00
cov_mark::hit!(add_missing_match_arms_empty_expr);
}
}
let mut first_new_arm = None;
for arm in missing_arms {
first_new_arm.get_or_insert_with(|| arm.clone());
new_match_arm_list.add_arm(arm);
}
2021-01-27 15:32:40 -06:00
let old_range = ctx.sema.original_range(match_arm_list.syntax()).range;
2020-06-28 17:36:05 -05:00
match (first_new_arm, ctx.config.snippet_cap) {
(Some(first_new_arm), Some(cap)) => {
let extend_lifetime;
2020-07-31 13:07:21 -05:00
let cursor =
match first_new_arm.syntax().descendants().find_map(ast::WildcardPat::cast)
{
Some(it) => {
extend_lifetime = it.syntax().clone();
Cursor::Replace(&extend_lifetime)
}
None => Cursor::Before(first_new_arm.syntax()),
};
let snippet = render_snippet(cap, new_match_arm_list.syntax(), cursor);
2020-06-28 17:36:05 -05:00
builder.replace_snippet(cap, old_range, snippet);
}
_ => builder.replace(old_range, new_match_arm_list.to_string()),
2020-05-20 07:00:37 -05:00
}
2020-06-28 17:36:05 -05:00
},
)
2019-02-03 12:26:35 -06:00
}
fn is_variant_missing(existing_pats: &[Pat], var: &Pat) -> bool {
2021-04-18 06:43:12 -05:00
!existing_pats.iter().any(|pat| does_pat_match_variant(pat, var))
}
// Fixme: this is still somewhat limited, use hir_ty::diagnostics::match_check?
fn does_pat_match_variant(pat: &Pat, var: &Pat) -> bool {
match (pat, var) {
(Pat::WildcardPat(_), _) => true,
(Pat::TuplePat(tpat), Pat::TuplePat(tvar)) => {
tpat.fields().zip(tvar.fields()).all(|(p, v)| does_pat_match_variant(&p, &v))
}
2021-04-18 06:43:12 -05:00
_ => utils::does_pat_match_variant(pat, var),
}
}
2021-05-20 07:58:18 -05:00
#[derive(Eq, PartialEq, Clone, Copy)]
enum ExtendedEnum {
Bool,
Enum(hir::Enum),
}
2021-05-20 07:58:18 -05:00
#[derive(Eq, PartialEq, Clone, Copy)]
enum ExtendedVariant {
True,
False,
Variant(hir::Variant),
}
fn lift_enum(e: hir::Enum) -> ExtendedEnum {
ExtendedEnum::Enum(e)
}
impl ExtendedEnum {
2021-05-20 07:58:18 -05:00
fn variants(self, db: &RootDatabase) -> Vec<ExtendedVariant> {
match self {
ExtendedEnum::Enum(e) => {
2021-06-12 22:59:36 -05:00
e.variants(db).into_iter().map(ExtendedVariant::Variant).collect::<Vec<_>>()
}
ExtendedEnum::Bool => {
Vec::<ExtendedVariant>::from([ExtendedVariant::True, ExtendedVariant::False])
}
}
}
}
fn resolve_enum_def(sema: &Semantics<RootDatabase>, expr: &ast::Expr) -> Option<ExtendedEnum> {
sema.type_of_expr(expr)?.adjusted().autoderef(sema.db).find_map(|ty| match ty.as_adt() {
Some(Adt::Enum(e)) => Some(ExtendedEnum::Enum(e)),
_ => ty.is_bool().then(|| ExtendedEnum::Bool),
})
2019-08-22 13:31:21 -05:00
}
fn resolve_tuple_of_enum_def(
sema: &Semantics<RootDatabase>,
expr: &ast::Expr,
) -> Option<Vec<ExtendedEnum>> {
2021-06-12 22:54:16 -05:00
sema.type_of_expr(expr)?
.adjusted()
2020-03-23 07:19:09 -05:00
.tuple_fields(sema.db)
.iter()
.map(|ty| {
ty.autoderef(sema.db).find_map(|ty| match ty.as_adt() {
Some(Adt::Enum(e)) => Some(lift_enum(e)),
2020-03-23 07:19:09 -05:00
// For now we only handle expansion for a tuple of enums. Here
// we map non-enum items to None and rely on `collect` to
// convert Vec<Option<hir::Enum>> into Option<Vec<hir::Enum>>.
_ => ty.is_bool().then(|| ExtendedEnum::Bool),
})
2020-03-23 07:19:09 -05:00
})
.collect()
}
fn build_pat(db: &RootDatabase, module: hir::Module, var: ExtendedVariant) -> Option<ast::Pat> {
match var {
ExtendedVariant::Variant(var) => {
let path = mod_path_to_ast(&module.find_use_path(db, ModuleDef::from(var))?);
2019-08-22 13:31:21 -05:00
// FIXME: use HIR for this; it doesn't currently expose struct vs. tuple vs. unit variants though
let pat: ast::Pat = match var.source(db)?.value.kind() {
ast::StructKind::Tuple(field_list) => {
let pats =
iter::repeat(make::wildcard_pat().into()).take(field_list.fields().count());
make::tuple_struct_pat(path, pats).into()
}
ast::StructKind::Record(field_list) => {
2021-07-02 18:33:34 -05:00
let pats = field_list
.fields()
.map(|f| make::ext::simple_ident_pat(f.name().unwrap()).into());
make::record_pat(path, pats).into()
}
ast::StructKind::Unit => make::path_pat(path),
};
2019-08-22 13:31:21 -05:00
Some(pat)
}
ExtendedVariant::True => Some(ast::Pat::from(make::literal_pat("true"))),
ExtendedVariant::False => Some(ast::Pat::from(make::literal_pat("false"))),
}
2019-08-22 13:31:21 -05:00
}
2019-02-03 12:26:35 -06:00
#[cfg(test)]
mod tests {
use crate::tests::{
check_assist, check_assist_not_applicable, check_assist_target, check_assist_unresolved,
};
2019-02-03 12:26:35 -06:00
2021-09-20 16:53:05 -05:00
use super::add_missing_match_arms;
2019-02-03 12:26:35 -06:00
#[test]
fn all_match_arms_provided() {
check_assist_not_applicable(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
enum A {
As,
Bs{x:i32, y:Option<i32>},
Cs(i32, Option<i32>),
}
fn main() {
match A::As$0 {
A::As,
A::Bs{x,y:Some(_)} => {}
A::Cs(_, Some(_)) => {}
}
}
"#,
);
}
#[test]
fn all_boolean_match_arms_provided() {
check_assist_not_applicable(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
fn foo(a: bool) {
match a$0 {
true => {}
false => {}
}
}
"#,
)
}
2020-03-23 07:19:09 -05:00
#[test]
fn tuple_of_non_enum() {
// for now this case is not handled, although it potentially could be
// in the future
check_assist_not_applicable(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
2020-03-23 07:19:09 -05:00
r#"
2021-05-16 07:14:57 -05:00
fn main() {
match (0, false)$0 {
}
}
"#,
2020-03-23 07:19:09 -05:00
);
}
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_boolean() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
fn foo(a: bool) {
match a$0 {
}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
fn foo(a: bool) {
match a {
$0true => todo!(),
false => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
)
}
#[test]
fn partial_fill_boolean() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
fn foo(a: bool) {
match a$0 {
true => {}
}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
fn foo(a: bool) {
match a {
true => {}
$0false => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
)
}
#[test]
fn all_boolean_tuple_arms_provided() {
check_assist_not_applicable(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
fn foo(a: bool) {
match (a, a)$0 {
(true, true) => {}
(true, false) => {}
(false, true) => {}
(false, false) => {}
}
}
"#,
)
}
#[test]
fn fill_boolean_tuple() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
fn foo(a: bool) {
match (a, a)$0 {
}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
fn foo(a: bool) {
match (a, a) {
$0(true, true) => todo!(),
(true, false) => todo!(),
(false, true) => todo!(),
(false, false) => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
)
}
#[test]
fn partial_fill_boolean_tuple() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
fn foo(a: bool) {
match (a, a)$0 {
(false, true) => {}
}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
fn foo(a: bool) {
match (a, a) {
(false, true) => {}
$0(true, true) => todo!(),
(true, false) => todo!(),
(false, false) => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
)
}
#[test]
fn partial_fill_record_tuple() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
enum A {
As,
Bs { x: i32, y: Option<i32> },
Cs(i32, Option<i32>),
}
fn main() {
match A::As$0 {
A::Bs { x, y: Some(_) } => {}
A::Cs(_, Some(_)) => {}
}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
enum A {
As,
Bs { x: i32, y: Option<i32> },
Cs(i32, Option<i32>),
}
fn main() {
match A::As {
A::Bs { x, y: Some(_) } => {}
A::Cs(_, Some(_)) => {}
$0A::As => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
);
}
2021-01-22 16:15:38 -06:00
#[test]
fn partial_fill_option() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
2021-01-22 16:15:38 -06:00
r#"
2021-06-18 15:38:19 -05:00
//- minicore: option
2021-01-22 16:15:38 -06:00
fn main() {
match None$0 {
None => {}
}
}
2021-06-18 15:38:19 -05:00
"#,
2021-01-22 16:15:38 -06:00
r#"
fn main() {
match None {
None => {}
Some(${0:_}) => todo!(),
2021-01-22 16:15:38 -06:00
}
}
2021-06-18 15:38:19 -05:00
"#,
2021-01-22 16:15:38 -06:00
);
}
#[test]
fn partial_fill_or_pat() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
enum A { As, Bs, Cs(Option<i32>) }
fn main() {
2021-01-06 14:15:48 -06:00
match A::As$0 {
A::Cs(_) | A::Bs => {}
}
}
"#,
r#"
enum A { As, Bs, Cs(Option<i32>) }
fn main() {
match A::As {
A::Cs(_) | A::Bs => {}
$0A::As => todo!(),
}
}
"#,
);
}
#[test]
fn partial_fill() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
enum A { As, Bs, Cs, Ds(String), Es(B) }
enum B { Xs, Ys }
fn main() {
2021-01-06 14:15:48 -06:00
match A::As$0 {
A::Bs if 0 < 1 => {}
A::Ds(_value) => { let x = 1; }
A::Es(B::Xs) => (),
}
}
"#,
r#"
enum A { As, Bs, Cs, Ds(String), Es(B) }
enum B { Xs, Ys }
fn main() {
match A::As {
A::Bs if 0 < 1 => {}
A::Ds(_value) => { let x = 1; }
A::Es(B::Xs) => (),
$0A::As => todo!(),
A::Cs => todo!(),
}
}
"#,
);
}
2020-06-14 16:43:16 -05:00
#[test]
fn partial_fill_bind_pat() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
2020-06-14 16:43:16 -05:00
r#"
enum A { As, Bs, Cs(Option<i32>) }
fn main() {
2021-01-06 14:15:48 -06:00
match A::As$0 {
A::As(_) => {}
a @ A::Bs(_) => {}
}
}
"#,
2020-06-14 16:43:16 -05:00
r#"
enum A { As, Bs, Cs(Option<i32>) }
fn main() {
match A::As {
A::As(_) => {}
a @ A::Bs(_) => {}
A::Cs(${0:_}) => todo!(),
}
}
"#,
2020-06-14 16:43:16 -05:00
);
}
2019-02-03 12:26:35 -06:00
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_empty_body() {
2019-02-03 12:26:35 -06:00
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
2019-02-03 12:26:35 -06:00
r#"
enum A { As, Bs, Cs(String), Ds(String, String), Es { x: usize, y: usize } }
2019-02-03 12:26:35 -06:00
fn main() {
let a = A::As;
2021-01-06 14:15:48 -06:00
match a$0 {}
}
"#,
2019-02-03 12:26:35 -06:00
r#"
enum A { As, Bs, Cs(String), Ds(String, String), Es { x: usize, y: usize } }
2019-02-03 12:26:35 -06:00
fn main() {
let a = A::As;
match a {
$0A::As => todo!(),
A::Bs => todo!(),
A::Cs(_) => todo!(),
A::Ds(_, _) => todo!(),
A::Es { x, y } => todo!(),
}
}
"#,
2019-02-03 12:26:35 -06:00
);
}
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_tuple_of_enum() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two }
enum B { One, Two }
2021-05-16 07:14:57 -05:00
fn main() {
let a = A::One;
let b = B::One;
match (a$0, b) {}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two }
enum B { One, Two }
fn main() {
let a = A::One;
let b = B::One;
match (a, b) {
$0(A::One, B::One) => todo!(),
(A::One, B::Two) => todo!(),
(A::Two, B::One) => todo!(),
(A::Two, B::Two) => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
);
}
2020-03-23 07:19:09 -05:00
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_tuple_of_enum_ref() {
2020-03-23 07:19:09 -05:00
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
2020-03-23 07:19:09 -05:00
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two }
enum B { One, Two }
2020-03-23 07:19:09 -05:00
2021-05-16 07:14:57 -05:00
fn main() {
let a = A::One;
let b = B::One;
match (&a$0, &b) {}
}
"#,
2020-03-23 07:19:09 -05:00
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two }
enum B { One, Two }
fn main() {
let a = A::One;
let b = B::One;
match (&a, &b) {
$0(A::One, B::One) => todo!(),
(A::One, B::Two) => todo!(),
(A::Two, B::One) => todo!(),
(A::Two, B::Two) => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
2020-03-23 07:19:09 -05:00
);
}
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_tuple_of_enum_partial() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
enum A { One, Two }
enum B { One, Two }
fn main() {
let a = A::One;
let b = B::One;
match (a$0, b) {
(A::Two, B::One) => {}
}
}
"#,
r#"
enum A { One, Two }
enum B { One, Two }
fn main() {
let a = A::One;
let b = B::One;
match (a, b) {
(A::Two, B::One) => {}
$0(A::One, B::One) => todo!(),
(A::One, B::Two) => todo!(),
(A::Two, B::Two) => todo!(),
}
}
"#,
);
}
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_tuple_of_enum_partial_with_wildcards() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
//- minicore: option
fn main() {
let a = Some(1);
let b = Some(());
match (a$0, b) {
(Some(_), _) => {}
(None, Some(_)) => {}
}
}
"#,
r#"
fn main() {
let a = Some(1);
let b = Some(());
match (a, b) {
(Some(_), _) => {}
(None, Some(_)) => {}
$0(None, None) => todo!(),
}
}
"#,
);
}
2021-04-18 06:43:12 -05:00
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_partial_with_deep_pattern() {
2021-04-18 06:43:12 -05:00
// Fixme: cannot handle deep patterns
check_assist_not_applicable(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
//- minicore: option
2021-04-18 06:43:12 -05:00
fn main() {
match $0Some(true) {
Some(true) => {}
None => {}
}
}
"#,
2021-04-18 06:43:12 -05:00
);
}
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_tuple_of_enum_not_applicable() {
check_assist_not_applicable(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two }
enum B { One, Two }
fn main() {
let a = A::One;
let b = B::One;
match (a$0, b) {
(A::Two, B::One) => {}
(A::One, B::One) => {}
(A::One, B::Two) => {}
(A::Two, B::Two) => {}
}
}
"#,
);
}
2020-03-23 07:19:09 -05:00
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_single_element_tuple_of_enum() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
2020-03-23 07:19:09 -05:00
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two }
2020-03-23 07:19:09 -05:00
2021-05-16 07:14:57 -05:00
fn main() {
let a = A::One;
match (a$0, ) {
}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two }
2021-05-16 07:14:57 -05:00
fn main() {
let a = A::One;
match (a, ) {
$0(A::One,) => todo!(),
(A::Two,) => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
2020-03-23 07:19:09 -05:00
);
}
#[test]
fn test_fill_match_arm_refs() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
enum A { As }
2021-05-16 07:14:57 -05:00
fn foo(a: &A) {
match a$0 {
}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
enum A { As }
2021-05-16 07:14:57 -05:00
fn foo(a: &A) {
match a {
$0A::As => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
);
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
enum A {
Es { x: usize, y: usize }
}
2021-05-16 07:14:57 -05:00
fn foo(a: &mut A) {
match a$0 {
}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
enum A {
Es { x: usize, y: usize }
}
2021-05-16 07:14:57 -05:00
fn foo(a: &mut A) {
match a {
$0A::Es { x, y } => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
2019-02-03 12:26:35 -06:00
);
}
2019-02-08 17:34:05 -06:00
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_target() {
2019-02-08 17:34:05 -06:00
check_assist_target(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
2019-02-08 17:34:05 -06:00
r#"
2021-05-16 07:14:57 -05:00
enum E { X, Y }
2019-02-08 17:34:05 -06:00
2021-05-16 07:14:57 -05:00
fn main() {
match E::X$0 {}
}
"#,
2019-02-08 17:34:05 -06:00
"match E::X {}",
);
}
2019-06-23 23:05:50 -05:00
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_trivial_arm() {
2019-06-23 23:05:50 -05:00
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
2019-06-23 23:05:50 -05:00
r#"
2021-05-16 07:14:57 -05:00
enum E { X, Y }
2019-06-23 23:05:50 -05:00
2021-05-16 07:14:57 -05:00
fn main() {
match E::X {
$0_ => {}
}
}
"#,
2019-06-23 23:05:50 -05:00
r#"
2021-05-16 07:14:57 -05:00
enum E { X, Y }
2019-06-23 23:05:50 -05:00
2021-05-16 07:14:57 -05:00
fn main() {
match E::X {
$0E::X => todo!(),
E::Y => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
2019-06-23 23:05:50 -05:00
);
}
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_qualifies_path() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
mod foo { pub enum E { X, Y } }
use foo::E::X;
2021-05-16 07:14:57 -05:00
fn main() {
match X {
$0
}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
mod foo { pub enum E { X, Y } }
use foo::E::X;
2021-05-16 07:14:57 -05:00
fn main() {
match X {
$0X => todo!(),
foo::E::Y => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
);
}
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_preserves_comments() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two }
fn foo(a: A) {
match a {
// foo bar baz$0
A::One => {}
// This is where the rest should be
}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two }
fn foo(a: A) {
match a {
// foo bar baz
A::One => {}
$0A::Two => todo!(),
2021-05-16 07:14:57 -05:00
// This is where the rest should be
}
}
"#,
);
}
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_preserves_comments_empty() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two }
fn foo(a: A) {
match a {
// foo bar baz$0
}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two }
fn foo(a: A) {
match a {
$0A::One => todo!(),
A::Two => todo!(),
2021-05-16 07:14:57 -05:00
// foo bar baz
}
}
"#,
);
}
#[test]
2021-09-20 16:53:05 -05:00
fn add_missing_match_arms_placeholder() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two, }
fn foo(a: A) {
match a$0 {
_ => (),
}
}
"#,
r#"
2021-05-16 07:14:57 -05:00
enum A { One, Two, }
fn foo(a: A) {
match a {
$0A::One => todo!(),
A::Two => todo!(),
2021-05-16 07:14:57 -05:00
}
}
"#,
);
}
2020-05-20 03:51:48 -05:00
#[test]
fn option_order() {
2021-03-08 14:19:44 -06:00
cov_mark::check!(option_order);
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
//- minicore: option
2020-05-20 03:51:48 -05:00
fn foo(opt: Option<i32>) {
2021-01-06 14:15:48 -06:00
match opt$0 {
2020-05-20 03:51:48 -05:00
}
2020-06-23 17:30:34 -05:00
}
"#,
2020-05-20 03:51:48 -05:00
r#"
fn foo(opt: Option<i32>) {
2020-05-20 07:00:37 -05:00
match opt {
Some(${0:_}) => todo!(),
None => todo!(),
2020-05-20 03:51:48 -05:00
}
}
"#,
);
}
2021-01-27 15:32:40 -06:00
#[test]
fn works_inside_macro_call() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
2021-01-27 15:32:40 -06:00
r#"
macro_rules! m { ($expr:expr) => {$expr}}
enum Test {
A,
B,
C,
}
fn foo(t: Test) {
m!(match t$0 {});
}"#,
2021-05-16 07:14:57 -05:00
r#"
macro_rules! m { ($expr:expr) => {$expr}}
2021-01-27 15:32:40 -06:00
enum Test {
A,
B,
C,
}
fn foo(t: Test) {
m!(match t {
$0Test::A => todo!(),
Test::B => todo!(),
Test::C => todo!(),
2021-01-27 15:32:40 -06:00
});
}"#,
);
}
#[test]
fn lazy_computation() {
// Computing a single missing arm is enough to determine applicability of the assist.
2021-09-20 16:53:05 -05:00
cov_mark::check_count!(add_missing_match_arms_lazy_computation, 1);
check_assist_unresolved(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
enum A { One, Two, }
fn foo(tuple: (A, A)) {
match $0tuple {};
}
"#,
);
}
#[test]
fn adds_comma_before_new_arms() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
fn foo(t: bool) {
match $0t {
true => 1 + 2
}
}"#,
r#"
fn foo(t: bool) {
match t {
true => 1 + 2,
$0false => todo!(),
}
}"#,
);
}
#[test]
fn does_not_add_extra_comma() {
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
fn foo(t: bool) {
match $0t {
true => 1 + 2,
}
}"#,
r#"
fn foo(t: bool) {
match t {
true => 1 + 2,
$0false => todo!(),
}
}"#,
);
}
#[test]
fn does_not_remove_catch_all_with_non_empty_expr() {
2021-09-20 16:53:05 -05:00
cov_mark::check!(add_missing_match_arms_empty_expr);
check_assist(
2021-09-20 16:53:05 -05:00
add_missing_match_arms,
r#"
fn foo(t: bool) {
match $0t {
_ => 1 + 2,
}
}"#,
r#"
fn foo(t: bool) {
match t {
_ => 1 + 2,
$0true => todo!(),
false => todo!(),
}
}"#,
);
}
2019-02-03 12:26:35 -06:00
}