rust/crates/ide_assists/src/handlers/fill_match_arms.rs

788 lines
19 KiB
Rust
Raw Normal View History

use std::iter;
2019-02-03 12:26:35 -06:00
2020-03-22 17:19:55 -05:00
use hir::{Adt, HasSource, ModuleDef, Semantics};
2020-11-28 08:30:39 -06:00
use ide_db::helpers::{mod_path_to_ast, FamousDefs};
2020-08-13 09:39:16 -05:00
use ide_db::RootDatabase;
2020-03-23 07:19:09 -05:00
use itertools::Itertools;
2020-08-12 11:26:51 -05:00
use syntax::ast::{self, make, AstNode, MatchArm, NameOwner, Pat};
2019-02-03 12:26:35 -06:00
2020-05-20 07:00:37 -05:00
use crate::{
2021-01-22 16:31:19 -06:00
utils::{does_pat_match_variant, render_snippet, Cursor},
2020-06-28 17:36:05 -05:00
AssistContext, AssistId, AssistKind, Assists,
2020-05-20 07:00:37 -05:00
};
2019-06-23 23:05:50 -05:00
2019-10-26 09:37:04 -05:00
// Assist: fill_match_arms
//
// Adds missing clauses to a `match` expression.
//
// ```
// enum Action { Move { distance: u32 }, Stop }
//
// fn handle(action: Action) {
// match action {
2021-01-06 14:15:48 -06:00
// $0
2019-10-26 09:37:04 -05:00
// }
// }
// ```
// ->
// ```
// enum Action { Move { distance: u32 }, Stop }
//
// fn handle(action: Action) {
// match action {
2020-05-20 07:00:37 -05:00
// $0Action::Move { distance } => {}
// Action::Stop => {}
2019-10-26 09:37:04 -05:00
// }
// }
// ```
pub(crate) fn fill_match_arms(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
2021-01-27 15:32:40 -06:00
let match_expr = ctx.find_node_at_offset_with_descend::<ast::MatchExpr>()?;
2019-08-22 13:31:21 -05:00
let match_arm_list = match_expr.match_arm_list()?;
2019-02-03 12:26:35 -06:00
let expr = match_expr.expr()?;
let mut arms: Vec<MatchArm> = match_arm_list.arms().collect();
if arms.len() == 1 {
2020-07-31 13:07:21 -05:00
if let Some(Pat::WildcardPat(..)) = arms[0].pat() {
arms.clear();
}
}
let module = ctx.sema.scope(expr.syntax()).module()?;
let missing_arms: Vec<MatchArm> = if let Some(enum_def) = resolve_enum_def(&ctx.sema, &expr) {
2020-07-01 02:14:23 -05:00
let variants = enum_def.variants(ctx.db());
2020-05-20 03:51:48 -05:00
let mut variants = variants
.into_iter()
2020-07-01 02:14:23 -05:00
.filter_map(|variant| build_pat(ctx.db(), module, variant))
.filter(|variant_pat| is_variant_missing(&mut arms, variant_pat))
.map(|pat| make::match_arm(iter::once(pat), make::expr_empty_block()))
2020-05-20 03:51:48 -05:00
.collect::<Vec<_>>();
if Some(enum_def) == FamousDefs(&ctx.sema, Some(module.krate())).core_option_Option() {
2020-05-20 03:51:48 -05:00
// Match `Some` variant first.
2021-03-08 14:19:44 -06:00
cov_mark::hit!(option_order);
2020-05-20 03:51:48 -05:00
variants.reverse()
}
variants
} else if let Some(enum_defs) = resolve_tuple_of_enum_def(&ctx.sema, &expr) {
2020-03-23 07:19:09 -05:00
// Partial fill not currently supported for tuple of enums.
if !arms.is_empty() {
return None;
}
2020-03-23 07:19:09 -05:00
// When calculating the match arms for a tuple of enums, we want
// to create a match arm for each possible combination of enum
// values. The `multi_cartesian_product` method transforms
// Vec<Vec<EnumVariant>> into Vec<(EnumVariant, .., EnumVariant)>
// where each tuple represents a proposed match arm.
enum_defs
.into_iter()
2020-07-01 02:14:23 -05:00
.map(|enum_def| enum_def.variants(ctx.db()))
.multi_cartesian_product()
.map(|variants| {
2020-03-23 07:19:09 -05:00
let patterns =
2020-07-01 02:14:23 -05:00
variants.into_iter().filter_map(|variant| build_pat(ctx.db(), module, variant));
ast::Pat::from(make::tuple_pat(patterns))
})
.filter(|variant_pat| is_variant_missing(&mut arms, variant_pat))
.map(|pat| make::match_arm(iter::once(pat), make::expr_empty_block()))
.collect()
} else {
return None;
};
if missing_arms.is_empty() {
return None;
}
2021-01-27 15:32:40 -06:00
let target = ctx.sema.original_range(match_expr.syntax()).range;
2020-06-28 17:36:05 -05:00
acc.add(
2020-07-02 16:48:35 -05:00
AssistId("fill_match_arms", AssistKind::QuickFix),
2020-06-28 17:36:05 -05:00
"Fill match arms",
target,
|builder| {
let new_arm_list = match_arm_list.remove_placeholder();
let n_old_arms = new_arm_list.arms().count();
let new_arm_list = new_arm_list.append_arms(missing_arms);
let first_new_arm = new_arm_list.arms().nth(n_old_arms);
2021-01-27 15:32:40 -06:00
let old_range = ctx.sema.original_range(match_arm_list.syntax()).range;
2020-06-28 17:36:05 -05:00
match (first_new_arm, ctx.config.snippet_cap) {
(Some(first_new_arm), Some(cap)) => {
let extend_lifetime;
2020-07-31 13:07:21 -05:00
let cursor =
match first_new_arm.syntax().descendants().find_map(ast::WildcardPat::cast)
{
Some(it) => {
extend_lifetime = it.syntax().clone();
Cursor::Replace(&extend_lifetime)
}
None => Cursor::Before(first_new_arm.syntax()),
};
let snippet = render_snippet(cap, new_arm_list.syntax(), cursor);
2020-06-28 17:36:05 -05:00
builder.replace_snippet(cap, old_range, snippet);
}
_ => builder.replace(old_range, new_arm_list.to_string()),
2020-05-20 07:00:37 -05:00
}
2020-06-28 17:36:05 -05:00
},
)
2019-02-03 12:26:35 -06:00
}
fn is_variant_missing(existing_arms: &mut Vec<MatchArm>, var: &Pat) -> bool {
existing_arms.iter().filter_map(|arm| arm.pat()).all(|pat| {
// Special casee OrPat as separate top-level pats
let top_level_pats: Vec<Pat> = match pat {
Pat::OrPat(pats) => pats.pats().collect::<Vec<_>>(),
_ => vec![pat],
};
!top_level_pats.iter().any(|pat| does_pat_match_variant(pat, var))
})
}
fn resolve_enum_def(sema: &Semantics<RootDatabase>, expr: &ast::Expr) -> Option<hir::Enum> {
sema.type_of_expr(&expr)?.autoderef(sema.db).find_map(|ty| match ty.as_adt() {
Some(Adt::Enum(e)) => Some(e),
2019-08-22 13:31:21 -05:00
_ => None,
})
2019-08-22 13:31:21 -05:00
}
fn resolve_tuple_of_enum_def(
sema: &Semantics<RootDatabase>,
expr: &ast::Expr,
) -> Option<Vec<hir::Enum>> {
2020-03-23 07:19:09 -05:00
sema.type_of_expr(&expr)?
.tuple_fields(sema.db)
.iter()
.map(|ty| {
ty.autoderef(sema.db).find_map(|ty| match ty.as_adt() {
Some(Adt::Enum(e)) => Some(e),
// For now we only handle expansion for a tuple of enums. Here
// we map non-enum items to None and rely on `collect` to
// convert Vec<Option<hir::Enum>> into Option<Vec<hir::Enum>>.
_ => None,
})
2020-03-23 07:19:09 -05:00
})
.collect()
}
2020-12-20 01:05:24 -06:00
fn build_pat(db: &RootDatabase, module: hir::Module, var: hir::Variant) -> Option<ast::Pat> {
let path = mod_path_to_ast(&module.find_use_path(db, ModuleDef::from(var))?);
2019-08-22 13:31:21 -05:00
// FIXME: use HIR for this; it doesn't currently expose struct vs. tuple vs. unit variants though
let pat: ast::Pat = match var.source(db)?.value.kind() {
2019-08-22 13:31:21 -05:00
ast::StructKind::Tuple(field_list) => {
2020-08-05 12:29:24 -05:00
let pats = iter::repeat(make::wildcard_pat().into()).take(field_list.fields().count());
2019-09-26 04:18:26 -05:00
make::tuple_struct_pat(path, pats).into()
2019-08-22 13:31:21 -05:00
}
2019-11-22 12:52:06 -06:00
ast::StructKind::Record(field_list) => {
2020-08-05 12:29:24 -05:00
let pats = field_list.fields().map(|f| make::ident_pat(f.name().unwrap()).into());
2019-09-26 04:18:26 -05:00
make::record_pat(path, pats).into()
2019-08-22 13:31:21 -05:00
}
ast::StructKind::Unit => make::path_pat(path),
2019-08-22 13:31:21 -05:00
};
Some(pat)
}
2019-02-03 12:26:35 -06:00
#[cfg(test)]
mod tests {
2020-11-28 08:30:39 -06:00
use ide_db::helpers::FamousDefs;
2020-05-20 05:59:20 -05:00
use crate::tests::{check_assist, check_assist_not_applicable, check_assist_target};
2019-02-03 12:26:35 -06:00
use super::fill_match_arms;
#[test]
fn all_match_arms_provided() {
check_assist_not_applicable(
fill_match_arms,
r#"
enum A {
As,
Bs{x:i32, y:Option<i32>},
Cs(i32, Option<i32>),
}
fn main() {
2021-01-06 14:15:48 -06:00
match A::As$0 {
A::As,
A::Bs{x,y:Some(_)} => {}
A::Cs(_, Some(_)) => {}
}
}
"#,
);
}
2020-03-23 07:19:09 -05:00
#[test]
fn tuple_of_non_enum() {
// for now this case is not handled, although it potentially could be
// in the future
check_assist_not_applicable(
fill_match_arms,
r#"
fn main() {
2021-01-06 14:15:48 -06:00
match (0, false)$0 {
2020-03-23 07:19:09 -05:00
}
}
"#,
);
}
#[test]
fn partial_fill_record_tuple() {
check_assist(
fill_match_arms,
r#"
enum A {
As,
2020-05-20 07:00:37 -05:00
Bs { x: i32, y: Option<i32> },
Cs(i32, Option<i32>),
}
fn main() {
2021-01-06 14:15:48 -06:00
match A::As$0 {
2020-05-20 07:00:37 -05:00
A::Bs { x, y: Some(_) } => {}
A::Cs(_, Some(_)) => {}
}
}
"#,
r#"
enum A {
As,
2020-05-20 07:00:37 -05:00
Bs { x: i32, y: Option<i32> },
Cs(i32, Option<i32>),
}
fn main() {
2020-05-20 07:00:37 -05:00
match A::As {
A::Bs { x, y: Some(_) } => {}
A::Cs(_, Some(_)) => {}
2020-05-20 07:00:37 -05:00
$0A::As => {}
}
}
"#,
);
}
2021-01-22 16:15:38 -06:00
#[test]
fn partial_fill_option() {
check_assist(
fill_match_arms,
r#"
enum Option<T> { Some(T), None }
use Option::*;
fn main() {
match None$0 {
None => {}
}
}
"#,
r#"
enum Option<T> { Some(T), None }
use Option::*;
fn main() {
match None {
None => {}
Some(${0:_}) => {}
}
}
"#,
);
}
#[test]
fn partial_fill_or_pat() {
check_assist(
fill_match_arms,
r#"
enum A { As, Bs, Cs(Option<i32>) }
fn main() {
2021-01-06 14:15:48 -06:00
match A::As$0 {
A::Cs(_) | A::Bs => {}
}
}
"#,
r#"
enum A { As, Bs, Cs(Option<i32>) }
fn main() {
match A::As {
A::Cs(_) | A::Bs => {}
$0A::As => {}
}
}
"#,
);
}
#[test]
fn partial_fill() {
check_assist(
fill_match_arms,
r#"
enum A { As, Bs, Cs, Ds(String), Es(B) }
enum B { Xs, Ys }
fn main() {
2021-01-06 14:15:48 -06:00
match A::As$0 {
A::Bs if 0 < 1 => {}
A::Ds(_value) => { let x = 1; }
A::Es(B::Xs) => (),
}
}
"#,
r#"
enum A { As, Bs, Cs, Ds(String), Es(B) }
enum B { Xs, Ys }
fn main() {
match A::As {
A::Bs if 0 < 1 => {}
A::Ds(_value) => { let x = 1; }
A::Es(B::Xs) => (),
$0A::As => {}
A::Cs => {}
}
}
"#,
);
}
2020-06-14 16:43:16 -05:00
#[test]
fn partial_fill_bind_pat() {
check_assist(
fill_match_arms,
r#"
enum A { As, Bs, Cs(Option<i32>) }
fn main() {
2021-01-06 14:15:48 -06:00
match A::As$0 {
A::As(_) => {}
a @ A::Bs(_) => {}
}
}
"#,
2020-06-14 16:43:16 -05:00
r#"
enum A { As, Bs, Cs(Option<i32>) }
fn main() {
match A::As {
A::As(_) => {}
a @ A::Bs(_) => {}
A::Cs(${0:_}) => {}
}
}
"#,
2020-06-14 16:43:16 -05:00
);
}
2019-02-03 12:26:35 -06:00
#[test]
fn fill_match_arms_empty_body() {
check_assist(
fill_match_arms,
r#"
enum A { As, Bs, Cs(String), Ds(String, String), Es { x: usize, y: usize } }
2019-02-03 12:26:35 -06:00
fn main() {
let a = A::As;
2021-01-06 14:15:48 -06:00
match a$0 {}
}
"#,
2019-02-03 12:26:35 -06:00
r#"
enum A { As, Bs, Cs(String), Ds(String, String), Es { x: usize, y: usize } }
2019-02-03 12:26:35 -06:00
fn main() {
let a = A::As;
match a {
$0A::As => {}
A::Bs => {}
A::Cs(_) => {}
A::Ds(_, _) => {}
A::Es { x, y } => {}
}
}
"#,
2019-02-03 12:26:35 -06:00
);
}
#[test]
fn fill_match_arms_tuple_of_enum() {
check_assist(
fill_match_arms,
r#"
2020-05-20 07:00:37 -05:00
enum A { One, Two }
enum B { One, Two }
fn main() {
let a = A::One;
let b = B::One;
2021-01-06 14:15:48 -06:00
match (a$0, b) {}
}
"#,
r#"
2020-05-20 07:00:37 -05:00
enum A { One, Two }
enum B { One, Two }
fn main() {
let a = A::One;
let b = B::One;
2020-05-20 07:00:37 -05:00
match (a, b) {
$0(A::One, B::One) => {}
(A::One, B::Two) => {}
(A::Two, B::One) => {}
(A::Two, B::Two) => {}
}
}
"#,
);
}
2020-03-23 07:19:09 -05:00
#[test]
fn fill_match_arms_tuple_of_enum_ref() {
check_assist(
fill_match_arms,
r#"
2020-05-20 07:00:37 -05:00
enum A { One, Two }
enum B { One, Two }
2020-03-23 07:19:09 -05:00
fn main() {
let a = A::One;
let b = B::One;
2021-01-06 14:15:48 -06:00
match (&a$0, &b) {}
2020-03-23 07:19:09 -05:00
}
"#,
r#"
2020-05-20 07:00:37 -05:00
enum A { One, Two }
enum B { One, Two }
2020-03-23 07:19:09 -05:00
fn main() {
let a = A::One;
let b = B::One;
2020-05-20 07:00:37 -05:00
match (&a, &b) {
$0(A::One, B::One) => {}
(A::One, B::Two) => {}
(A::Two, B::One) => {}
(A::Two, B::Two) => {}
2020-03-23 07:19:09 -05:00
}
}
"#,
);
}
#[test]
fn fill_match_arms_tuple_of_enum_partial() {
check_assist_not_applicable(
fill_match_arms,
r#"
2020-05-20 07:00:37 -05:00
enum A { One, Two }
enum B { One, Two }
fn main() {
let a = A::One;
let b = B::One;
2021-01-06 14:15:48 -06:00
match (a$0, b) {
(A::Two, B::One) => {}
}
}
"#,
);
}
#[test]
fn fill_match_arms_tuple_of_enum_not_applicable() {
check_assist_not_applicable(
fill_match_arms,
r#"
2020-05-20 07:00:37 -05:00
enum A { One, Two }
enum B { One, Two }
fn main() {
let a = A::One;
let b = B::One;
2021-01-06 14:15:48 -06:00
match (a$0, b) {
(A::Two, B::One) => {}
(A::One, B::One) => {}
(A::One, B::Two) => {}
(A::Two, B::Two) => {}
}
}
"#,
);
}
2020-03-23 07:19:09 -05:00
#[test]
fn fill_match_arms_single_element_tuple_of_enum() {
check_assist(
2020-03-23 07:19:09 -05:00
fill_match_arms,
r#"
2020-05-20 07:00:37 -05:00
enum A { One, Two }
2020-03-23 07:19:09 -05:00
fn main() {
let a = A::One;
2021-01-06 14:15:48 -06:00
match (a$0, ) {
2020-03-23 07:19:09 -05:00
}
}
"#,
r#"
enum A { One, Two }
fn main() {
let a = A::One;
match (a, ) {
$0(A::One,) => {}
(A::Two,) => {}
}
}
"#,
2020-03-23 07:19:09 -05:00
);
}
#[test]
fn test_fill_match_arm_refs() {
check_assist(
fill_match_arms,
r#"
2020-05-20 07:00:37 -05:00
enum A { As }
fn foo(a: &A) {
2021-01-06 14:15:48 -06:00
match a$0 {
}
}
"#,
r#"
2020-05-20 07:00:37 -05:00
enum A { As }
fn foo(a: &A) {
2020-05-20 07:00:37 -05:00
match a {
$0A::As => {}
}
}
"#,
);
check_assist(
fill_match_arms,
r#"
enum A {
2020-05-20 07:00:37 -05:00
Es { x: usize, y: usize }
}
fn foo(a: &mut A) {
2021-01-06 14:15:48 -06:00
match a$0 {
}
}
"#,
r#"
enum A {
2020-05-20 07:00:37 -05:00
Es { x: usize, y: usize }
}
fn foo(a: &mut A) {
2020-05-20 07:00:37 -05:00
match a {
$0A::Es { x, y } => {}
2019-02-03 12:26:35 -06:00
}
}
"#,
);
}
2019-02-08 17:34:05 -06:00
#[test]
fn fill_match_arms_target() {
check_assist_target(
fill_match_arms,
r#"
2019-08-22 13:31:21 -05:00
enum E { X, Y }
2019-02-08 17:34:05 -06:00
fn main() {
2021-01-06 14:15:48 -06:00
match E::X$0 {}
2019-02-08 17:34:05 -06:00
}
"#,
"match E::X {}",
);
}
2019-06-23 23:05:50 -05:00
#[test]
fn fill_match_arms_trivial_arm() {
check_assist(
fill_match_arms,
r#"
enum E { X, Y }
fn main() {
match E::X {
2021-01-06 14:15:48 -06:00
$0_ => {}
2019-06-23 23:05:50 -05:00
}
}
"#,
r#"
enum E { X, Y }
fn main() {
2020-05-20 07:00:37 -05:00
match E::X {
$0E::X => {}
E::Y => {}
2019-06-23 23:05:50 -05:00
}
}
"#,
);
}
#[test]
fn fill_match_arms_qualifies_path() {
check_assist(
fill_match_arms,
r#"
mod foo { pub enum E { X, Y } }
use foo::E::X;
fn main() {
match X {
2021-01-06 14:15:48 -06:00
$0
}
}
"#,
r#"
mod foo { pub enum E { X, Y } }
use foo::E::X;
fn main() {
2020-05-20 07:00:37 -05:00
match X {
$0X => {}
foo::E::Y => {}
}
}
"#,
);
}
#[test]
fn fill_match_arms_preserves_comments() {
check_assist(
fill_match_arms,
r#"
2020-05-20 07:00:37 -05:00
enum A { One, Two }
fn foo(a: A) {
match a {
2021-01-06 14:15:48 -06:00
// foo bar baz$0
A::One => {}
// This is where the rest should be
}
}
"#,
r#"
2020-05-20 07:00:37 -05:00
enum A { One, Two }
fn foo(a: A) {
2020-05-20 07:00:37 -05:00
match a {
2020-03-28 16:24:26 -05:00
// foo bar baz
A::One => {}
// This is where the rest should be
2020-05-20 07:00:37 -05:00
$0A::Two => {}
}
}
"#,
);
}
#[test]
fn fill_match_arms_preserves_comments_empty() {
check_assist(
fill_match_arms,
r#"
2020-05-20 07:00:37 -05:00
enum A { One, Two }
fn foo(a: A) {
match a {
2021-01-06 14:15:48 -06:00
// foo bar baz$0
}
}
"#,
r#"
2020-05-20 07:00:37 -05:00
enum A { One, Two }
fn foo(a: A) {
2020-05-20 07:00:37 -05:00
match a {
2020-03-28 16:24:26 -05:00
// foo bar baz
2020-05-20 07:00:37 -05:00
$0A::One => {}
A::Two => {}
}
}
"#,
);
}
#[test]
fn fill_match_arms_placeholder() {
check_assist(
fill_match_arms,
r#"
enum A { One, Two, }
fn foo(a: A) {
2021-01-06 14:15:48 -06:00
match a$0 {
_ => (),
}
}
"#,
r#"
enum A { One, Two, }
fn foo(a: A) {
2020-05-20 07:00:37 -05:00
match a {
$0A::One => {}
A::Two => {}
}
}
"#,
);
}
2020-05-20 03:51:48 -05:00
#[test]
fn option_order() {
2021-03-08 14:19:44 -06:00
cov_mark::check!(option_order);
2020-05-20 03:51:48 -05:00
let before = r#"
fn foo(opt: Option<i32>) {
2021-01-06 14:15:48 -06:00
match opt$0 {
2020-05-20 03:51:48 -05:00
}
2020-06-23 17:30:34 -05:00
}
"#;
let before = &format!("//- /main.rs crate:main deps:core{}{}", before, FamousDefs::FIXTURE);
2020-05-20 03:51:48 -05:00
check_assist(
fill_match_arms,
before,
r#"
fn foo(opt: Option<i32>) {
2020-05-20 07:00:37 -05:00
match opt {
Some(${0:_}) => {}
2020-05-20 03:51:48 -05:00
None => {}
}
}
"#,
);
}
2021-01-27 15:32:40 -06:00
#[test]
fn works_inside_macro_call() {
check_assist(
fill_match_arms,
r#"
macro_rules! m { ($expr:expr) => {$expr}}
enum Test {
A,
B,
C,
}
fn foo(t: Test) {
m!(match t$0 {});
}"#,
r#"macro_rules! m { ($expr:expr) => {$expr}}
enum Test {
A,
B,
C,
}
fn foo(t: Test) {
m!(match t {
$0Test::A => {}
Test::B => {}
Test::C => {}
});
}"#,
);
}
2019-02-03 12:26:35 -06:00
}