rust/crates/ide_assists/src/handlers/auto_import.rs

999 lines
23 KiB
Rust
Raw Normal View History

2020-11-28 08:30:39 -06:00
use ide_db::helpers::{
import_assets::{ImportAssets, ImportCandidate},
insert_use::{insert_use, ImportScope},
2021-03-10 03:30:25 -06:00
mod_path_to_ast,
};
use syntax::{ast, AstNode, SyntaxNode};
use crate::{AssistContext, AssistId, AssistKind, Assists, GroupLabel};
2020-10-19 08:53:48 -05:00
// Feature: Auto Import
2020-10-15 07:44:46 -05:00
//
// Using the `auto-import` assist it is possible to insert missing imports for unresolved items.
// When inserting an import it will do so in a structured manner by keeping imports grouped,
// separated by a newline in the following order:
//
// - `std` and `core`
// - External Crates
// - Current Crate, paths prefixed by `crate`
// - Current Module, paths prefixed by `self`
// - Super Module, paths prefixed by `super`
//
// Example:
// ```rust
// use std::fs::File;
//
// use itertools::Itertools;
// use syntax::ast;
//
// use crate::utils::insert_use;
//
// use self::auto_import;
//
// use super::AssistContext;
// ```
//
// .Import Granularity
2020-10-15 07:44:46 -05:00
//
// It is possible to configure how use-trees are merged with the `importGranularity` setting.
2020-10-15 07:44:46 -05:00
// It has the following configurations:
//
// - `crate`: Merge imports from the same crate into a single use statement. This kind of
2020-10-15 07:44:46 -05:00
// nesting is only supported in Rust versions later than 1.24.
// - `module`: Merge imports from the same module into a single use statement.
// - `item`: Don't merge imports at all, creating one import per item.
// - `preserve`: Do not change the granularity of any imports. For auto-import this has the same
// effect as `item`.
2020-10-15 07:44:46 -05:00
//
// In `VS Code` the configuration for this is `rust-analyzer.assist.importGranularity`.
2020-10-15 07:44:46 -05:00
//
// .Import Prefix
//
// The style of imports in the same crate is configurable through the `importPrefix` setting.
// It has the following configurations:
//
// - `by_crate`: This setting will force paths to be always absolute, starting with the `crate`
// prefix, unless the item is defined outside of the current crate.
// - `by_self`: This setting will force paths that are relative to the current module to always
// start with `self`. This will result in paths that always start with either `crate`, `self`,
// `super` or an extern crate identifier.
// - `plain`: This setting does not impose any restrictions in imports.
//
// In `VS Code` the configuration for this is `rust-analyzer.assist.importPrefix`.
//
// image::https://user-images.githubusercontent.com/48062697/113020673-b85be580-917a-11eb-9022-59585f35d4f8.gif[]
2020-10-15 07:44:46 -05:00
// Assist: auto_import
//
// If the name is unresolved, provides all possible imports for it.
//
// ```
// fn main() {
2021-01-06 14:15:48 -06:00
// let map = HashMap$0::new();
// }
2020-02-06 11:10:25 -06:00
// # pub mod std { pub mod collections { pub struct HashMap { } } }
// ```
// ->
// ```
// use std::collections::HashMap;
//
// fn main() {
2020-02-06 11:10:25 -06:00
// let map = HashMap::new();
// }
2020-02-06 11:10:25 -06:00
// # pub mod std { pub mod collections { pub struct HashMap { } } }
// ```
pub(crate) fn auto_import(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
let (import_assets, syntax_under_caret) = find_importable_node(ctx)?;
let proposed_imports =
import_assets.search_for_imports(&ctx.sema, ctx.config.insert_use.prefix_kind);
if proposed_imports.is_empty() {
return None;
}
let range = ctx.sema.original_range(&syntax_under_caret).range;
2021-03-10 03:30:25 -06:00
let group_label = group_label(import_assets.import_candidate());
2021-04-20 12:28:18 -05:00
let scope = ImportScope::find_insert_use_container_with_macros(&syntax_under_caret, &ctx.sema)?;
2021-02-24 17:06:31 -06:00
for import in proposed_imports {
acc.add_group(
2021-03-10 03:30:25 -06:00
&group_label,
2020-07-02 16:48:35 -05:00
AssistId("auto_import", AssistKind::QuickFix),
2021-03-10 03:30:25 -06:00
format!("Import `{}`", import.import_path),
range,
|builder| {
let scope = match scope.clone() {
2021-05-16 06:18:49 -05:00
ImportScope::File(it) => ImportScope::File(builder.make_mut(it)),
ImportScope::Module(it) => ImportScope::Module(builder.make_mut(it)),
ImportScope::Block(it) => ImportScope::Block(builder.make_mut(it)),
};
insert_use(&scope, mod_path_to_ast(&import.import_path), &ctx.config.insert_use);
},
);
2020-02-09 07:30:27 -06:00
}
Some(())
}
pub(super) fn find_importable_node(ctx: &AssistContext) -> Option<(ImportAssets, SyntaxNode)> {
if let Some(path_under_caret) = ctx.find_node_at_offset_with_descend::<ast::Path>() {
ImportAssets::for_exact_path(&path_under_caret, &ctx.sema)
.zip(Some(path_under_caret.syntax().clone()))
} else if let Some(method_under_caret) =
ctx.find_node_at_offset_with_descend::<ast::MethodCallExpr>()
{
ImportAssets::for_method_call(&method_under_caret, &ctx.sema)
.zip(Some(method_under_caret.syntax().clone()))
} else {
None
}
}
2021-03-10 03:30:25 -06:00
fn group_label(import_candidate: &ImportCandidate) -> GroupLabel {
let name = match import_candidate {
ImportCandidate::Path(candidate) => format!("Import {}", candidate.name.text()),
2020-10-13 13:02:14 -05:00
ImportCandidate::TraitAssocItem(candidate) => {
2021-03-08 06:09:20 -06:00
format!("Import a trait for item {}", candidate.assoc_item_name.text())
2020-02-12 06:41:34 -06:00
}
2020-10-13 13:02:14 -05:00
ImportCandidate::TraitMethod(candidate) => {
2021-03-08 06:09:20 -06:00
format!("Import a trait for method {}", candidate.assoc_item_name.text())
2020-02-10 08:55:20 -06:00
}
};
GroupLabel(name)
2020-02-11 10:24:43 -06:00
}
#[cfg(test)]
mod tests {
2020-02-07 08:12:51 -06:00
use super::*;
2020-05-06 03:16:55 -05:00
use crate::tests::{check_assist, check_assist_not_applicable, check_assist_target};
2020-02-07 08:12:51 -06:00
#[test]
fn applicable_when_found_an_import_partial() {
check_assist(
auto_import,
r"
mod std {
pub mod fmt {
pub struct Formatter;
}
}
use std::fmt;
2021-01-06 14:15:48 -06:00
$0Formatter
",
r"
mod std {
pub mod fmt {
pub struct Formatter;
}
}
use std::fmt::{self, Formatter};
Formatter
",
);
}
2020-01-26 16:16:18 -06:00
#[test]
fn applicable_when_found_an_import() {
2020-02-06 10:17:51 -06:00
check_assist(
2020-01-26 16:16:18 -06:00
auto_import,
r"
2021-01-06 14:15:48 -06:00
$0PubStruct
2020-01-26 16:16:18 -06:00
pub mod PubMod {
pub struct PubStruct;
}
",
r"
use PubMod::PubStruct;
PubStruct
2020-01-26 16:16:18 -06:00
pub mod PubMod {
pub struct PubStruct;
}
2020-01-26 16:16:18 -06:00
",
);
}
2020-05-02 14:24:55 -05:00
#[test]
fn applicable_when_found_an_import_in_macros() {
check_assist(
auto_import,
r"
macro_rules! foo {
($i:ident) => { fn foo(a: $i) {} }
}
2021-01-06 14:15:48 -06:00
foo!(Pub$0Struct);
2020-05-02 14:24:55 -05:00
pub mod PubMod {
pub struct PubStruct;
}
",
r"
use PubMod::PubStruct;
macro_rules! foo {
($i:ident) => { fn foo(a: $i) {} }
}
foo!(PubStruct);
2020-05-02 14:24:55 -05:00
pub mod PubMod {
pub struct PubStruct;
}
",
);
}
#[test]
2020-01-26 16:16:18 -06:00
fn applicable_when_found_multiple_imports() {
2020-02-06 10:17:51 -06:00
check_assist(
auto_import,
2020-01-26 16:16:18 -06:00
r"
2021-01-06 14:15:48 -06:00
PubSt$0ruct
2020-01-26 16:16:18 -06:00
pub mod PubMod1 {
pub struct PubStruct;
}
pub mod PubMod2 {
pub struct PubStruct;
}
pub mod PubMod3 {
pub struct PubStruct;
}
",
r"
2021-03-03 15:59:56 -06:00
use PubMod3::PubStruct;
2020-01-26 16:16:18 -06:00
PubStruct
2020-01-26 16:16:18 -06:00
pub mod PubMod1 {
pub struct PubStruct;
}
pub mod PubMod2 {
pub struct PubStruct;
}
2020-01-26 16:16:18 -06:00
pub mod PubMod3 {
pub struct PubStruct;
}
",
);
}
#[test]
fn not_applicable_for_already_imported_types() {
2020-02-06 10:17:51 -06:00
check_assist_not_applicable(
2020-01-26 16:16:18 -06:00
auto_import,
r"
use PubMod::PubStruct;
2021-01-06 14:15:48 -06:00
PubStruct$0
2020-01-26 16:16:18 -06:00
pub mod PubMod {
pub struct PubStruct;
}
",
);
}
#[test]
2020-01-26 16:16:18 -06:00
fn not_applicable_for_types_with_private_paths() {
2020-02-06 10:17:51 -06:00
check_assist_not_applicable(
auto_import,
2020-01-26 16:16:18 -06:00
r"
2021-01-06 14:15:48 -06:00
PrivateStruct$0
2020-01-26 16:16:18 -06:00
pub mod PubMod {
struct PrivateStruct;
}
2020-01-26 16:16:18 -06:00
",
);
}
2020-01-26 16:16:18 -06:00
#[test]
fn not_applicable_when_no_imports_found() {
2020-02-06 10:17:51 -06:00
check_assist_not_applicable(
2020-01-26 16:16:18 -06:00
auto_import,
"
2021-01-06 14:15:48 -06:00
PubStruct$0",
);
}
#[test]
fn not_applicable_in_import_statements() {
2020-02-06 10:17:51 -06:00
check_assist_not_applicable(
auto_import,
2020-01-26 16:16:18 -06:00
r"
2021-01-06 14:15:48 -06:00
use PubStruct$0;
2020-01-26 16:16:18 -06:00
pub mod PubMod {
pub struct PubStruct;
}",
);
}
2020-02-01 14:13:02 -06:00
#[test]
fn function_import() {
2020-02-06 10:17:51 -06:00
check_assist(
2020-02-01 14:13:02 -06:00
auto_import,
r"
2021-01-06 14:15:48 -06:00
test_function$0
2020-02-01 14:13:02 -06:00
pub mod PubMod {
pub fn test_function() {};
}
",
r"
use PubMod::test_function;
test_function
2020-02-01 14:13:02 -06:00
pub mod PubMod {
pub fn test_function() {};
}
",
);
}
2020-02-09 09:13:29 -06:00
2020-03-23 16:23:26 -05:00
#[test]
fn macro_import() {
check_assist(
auto_import,
r"
//- /lib.rs crate:crate_with_macro
#[macro_export]
macro_rules! foo {
() => ()
}
2020-03-23 16:23:26 -05:00
//- /main.rs crate:main deps:crate_with_macro
fn main() {
2021-01-06 14:15:48 -06:00
foo$0
}
",
2020-03-23 16:23:26 -05:00
r"use crate_with_macro::foo;
fn main() {
foo
2020-03-23 16:23:26 -05:00
}
",
);
}
2020-02-09 09:13:29 -06:00
#[test]
fn auto_import_target() {
check_assist_target(
auto_import,
r"
struct AssistInfo {
2021-01-06 14:15:48 -06:00
group_label: Option<$0GroupLabel>,
2020-02-09 09:13:29 -06:00
}
mod m { pub struct GroupLabel; }
",
"GroupLabel",
)
}
#[test]
fn not_applicable_when_path_start_is_imported() {
check_assist_not_applicable(
auto_import,
r"
pub mod mod1 {
pub mod mod2 {
pub mod mod3 {
pub struct TestStruct;
}
}
}
use mod1::mod2;
fn main() {
2021-01-06 14:15:48 -06:00
mod2::mod3::TestStruct$0
}
",
);
}
2020-02-09 16:22:12 -06:00
#[test]
fn not_applicable_for_imported_function() {
check_assist_not_applicable(
auto_import,
r"
pub mod test_mod {
pub fn test_function() {}
}
use test_mod::test_function;
fn main() {
2021-01-06 14:15:48 -06:00
test_function$0
2020-02-09 16:22:12 -06:00
}
",
);
}
2020-02-09 16:30:00 -06:00
#[test]
fn associated_struct_function() {
check_assist(
auto_import,
r"
mod test_mod {
pub struct TestStruct {}
impl TestStruct {
pub fn test_function() {}
}
}
fn main() {
2021-01-06 14:15:48 -06:00
TestStruct::test_function$0
2020-02-09 16:30:00 -06:00
}
",
r"
use test_mod::TestStruct;
mod test_mod {
pub struct TestStruct {}
impl TestStruct {
pub fn test_function() {}
}
}
fn main() {
TestStruct::test_function
2020-02-09 16:30:00 -06:00
}
",
);
}
2020-02-12 14:38:19 -06:00
#[test]
fn associated_struct_const() {
check_assist(
auto_import,
r"
mod test_mod {
pub struct TestStruct {}
impl TestStruct {
const TEST_CONST: u8 = 42;
}
}
fn main() {
2021-01-06 14:15:48 -06:00
TestStruct::TEST_CONST$0
2020-02-12 14:38:19 -06:00
}
",
r"
use test_mod::TestStruct;
mod test_mod {
pub struct TestStruct {}
impl TestStruct {
const TEST_CONST: u8 = 42;
}
}
fn main() {
TestStruct::TEST_CONST
2020-02-12 14:38:19 -06:00
}
",
);
}
2020-02-09 16:30:00 -06:00
#[test]
fn associated_trait_function() {
check_assist(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
fn test_function();
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_function() {}
}
}
fn main() {
2021-01-06 14:15:48 -06:00
test_mod::TestStruct::test_function$0
2020-02-09 16:30:00 -06:00
}
",
r"
use test_mod::TestTrait;
mod test_mod {
pub trait TestTrait {
fn test_function();
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_function() {}
}
}
fn main() {
test_mod::TestStruct::test_function
2020-02-09 16:30:00 -06:00
}
",
);
}
#[test]
2020-02-11 10:24:43 -06:00
fn not_applicable_for_imported_trait_for_function() {
2020-02-11 07:21:12 -06:00
check_assist_not_applicable(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
fn test_function();
}
pub trait TestTrait2 {
fn test_function();
}
pub enum TestEnum {
One,
Two,
}
impl TestTrait2 for TestEnum {
fn test_function() {}
}
impl TestTrait for TestEnum {
fn test_function() {}
}
}
use test_mod::TestTrait2;
fn main() {
2021-01-06 14:15:48 -06:00
test_mod::TestEnum::test_function$0;
2020-02-11 07:21:12 -06:00
}
",
)
}
2020-02-12 14:38:19 -06:00
#[test]
fn associated_trait_const() {
check_assist(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
const TEST_CONST: u8;
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
const TEST_CONST: u8 = 42;
}
}
fn main() {
2021-01-06 14:15:48 -06:00
test_mod::TestStruct::TEST_CONST$0
2020-02-12 14:38:19 -06:00
}
",
r"
use test_mod::TestTrait;
mod test_mod {
pub trait TestTrait {
const TEST_CONST: u8;
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
const TEST_CONST: u8 = 42;
}
}
fn main() {
test_mod::TestStruct::TEST_CONST
2020-02-12 14:38:19 -06:00
}
",
);
}
#[test]
fn not_applicable_for_imported_trait_for_const() {
check_assist_not_applicable(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
const TEST_CONST: u8;
}
pub trait TestTrait2 {
const TEST_CONST: f64;
}
pub enum TestEnum {
One,
Two,
}
impl TestTrait2 for TestEnum {
const TEST_CONST: f64 = 42.0;
}
impl TestTrait for TestEnum {
const TEST_CONST: u8 = 42;
}
}
use test_mod::TestTrait2;
fn main() {
2021-01-06 14:15:48 -06:00
test_mod::TestEnum::TEST_CONST$0;
2020-02-12 14:38:19 -06:00
}
",
)
}
2020-02-11 07:21:12 -06:00
#[test]
2020-02-09 16:30:00 -06:00
fn trait_method() {
check_assist(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
fn test_method(&self);
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_method(&self) {}
}
}
fn main() {
let test_struct = test_mod::TestStruct {};
2021-01-06 14:15:48 -06:00
test_struct.test_meth$0od()
2020-02-09 16:30:00 -06:00
}
",
r"
use test_mod::TestTrait;
mod test_mod {
pub trait TestTrait {
fn test_method(&self);
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_method(&self) {}
}
}
fn main() {
let test_struct = test_mod::TestStruct {};
test_struct.test_method()
2020-02-09 16:30:00 -06:00
}
",
);
}
2020-02-11 10:24:43 -06:00
#[test]
fn trait_method_cross_crate() {
check_assist(
auto_import,
r"
//- /main.rs crate:main deps:dep
fn main() {
let test_struct = dep::test_mod::TestStruct {};
2021-01-06 14:15:48 -06:00
test_struct.test_meth$0od()
}
//- /dep.rs crate:dep
pub mod test_mod {
pub trait TestTrait {
fn test_method(&self);
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_method(&self) {}
}
}
",
r"
use dep::test_mod::TestTrait;
fn main() {
let test_struct = dep::test_mod::TestStruct {};
test_struct.test_method()
}
",
);
}
#[test]
fn assoc_fn_cross_crate() {
check_assist(
auto_import,
r"
//- /main.rs crate:main deps:dep
fn main() {
2021-01-06 14:15:48 -06:00
dep::test_mod::TestStruct::test_func$0tion
}
//- /dep.rs crate:dep
pub mod test_mod {
pub trait TestTrait {
fn test_function();
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_function() {}
}
}
",
r"
use dep::test_mod::TestTrait;
fn main() {
dep::test_mod::TestStruct::test_function
}
",
);
}
#[test]
fn assoc_const_cross_crate() {
check_assist(
auto_import,
r"
//- /main.rs crate:main deps:dep
fn main() {
2021-01-06 14:15:48 -06:00
dep::test_mod::TestStruct::CONST$0
}
//- /dep.rs crate:dep
pub mod test_mod {
pub trait TestTrait {
const CONST: bool;
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
const CONST: bool = true;
}
}
",
r"
use dep::test_mod::TestTrait;
fn main() {
dep::test_mod::TestStruct::CONST
}
",
);
}
#[test]
fn assoc_fn_as_method_cross_crate() {
check_assist_not_applicable(
auto_import,
r"
//- /main.rs crate:main deps:dep
fn main() {
let test_struct = dep::test_mod::TestStruct {};
2021-01-06 14:15:48 -06:00
test_struct.test_func$0tion()
}
//- /dep.rs crate:dep
pub mod test_mod {
pub trait TestTrait {
fn test_function();
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_function() {}
}
}
",
);
}
#[test]
fn private_trait_cross_crate() {
check_assist_not_applicable(
auto_import,
r"
//- /main.rs crate:main deps:dep
fn main() {
let test_struct = dep::test_mod::TestStruct {};
2021-01-06 14:15:48 -06:00
test_struct.test_meth$0od()
}
//- /dep.rs crate:dep
pub mod test_mod {
trait TestTrait {
fn test_method(&self);
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_method(&self) {}
}
}
",
);
}
2020-02-11 10:24:43 -06:00
#[test]
fn not_applicable_for_imported_trait_for_method() {
check_assist_not_applicable(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
fn test_method(&self);
}
pub trait TestTrait2 {
fn test_method(&self);
}
pub enum TestEnum {
One,
Two,
}
impl TestTrait2 for TestEnum {
fn test_method(&self) {}
}
impl TestTrait for TestEnum {
fn test_method(&self) {}
}
}
use test_mod::TestTrait2;
fn main() {
let one = test_mod::TestEnum::One;
2021-01-06 14:15:48 -06:00
one.test$0_method();
2020-02-11 10:24:43 -06:00
}
",
)
}
#[test]
fn dep_import() {
check_assist(
auto_import,
r"
//- /lib.rs crate:dep
pub struct Struct;
//- /main.rs crate:main deps:dep
fn main() {
2021-01-06 14:15:48 -06:00
Struct$0
}
",
r"use dep::Struct;
fn main() {
Struct
}
",
);
}
#[test]
fn whole_segment() {
2020-06-10 04:39:06 -05:00
// Tests that only imports whose last segment matches the identifier get suggested.
check_assist(
auto_import,
r"
//- /lib.rs crate:dep
pub mod fmt {
pub trait Display {}
}
pub fn panic_fmt() {}
//- /main.rs crate:main deps:dep
struct S;
2021-01-06 14:15:48 -06:00
impl f$0mt::Display for S {}
",
r"use dep::fmt;
struct S;
impl fmt::Display for S {}
2020-06-10 04:39:06 -05:00
",
);
}
#[test]
fn macro_generated() {
// Tests that macro-generated items are suggested from external crates.
check_assist(
auto_import,
r"
//- /lib.rs crate:dep
macro_rules! mac {
() => {
pub struct Cheese;
};
}
2020-06-10 04:39:06 -05:00
mac!();
2020-06-10 04:39:06 -05:00
//- /main.rs crate:main deps:dep
fn main() {
2021-01-06 14:15:48 -06:00
Cheese$0;
}
",
2020-06-10 04:39:06 -05:00
r"use dep::Cheese;
fn main() {
Cheese;
}
",
);
}
#[test]
fn casing() {
// Tests that differently cased names don't interfere and we only suggest the matching one.
check_assist(
auto_import,
r"
//- /lib.rs crate:dep
pub struct FMT;
pub struct fmt;
//- /main.rs crate:main deps:dep
fn main() {
2021-01-06 14:15:48 -06:00
FMT$0;
}
",
r"use dep::FMT;
fn main() {
FMT;
}
",
);
}
2021-04-19 12:53:29 -05:00
#[test]
fn inner_items() {
check_assist(
auto_import,
r#"
mod baz {
pub struct Foo {}
}
mod bar {
fn bar() {
Foo$0;
println!("Hallo");
}
}
"#,
r#"
mod baz {
pub struct Foo {}
}
mod bar {
use crate::baz::Foo;
fn bar() {
Foo;
println!("Hallo");
}
}
"#,
);
}
#[test]
fn uses_abs_path_with_extern_crate_clash() {
check_assist(
auto_import,
r#"
//- /main.rs crate:main deps:foo
mod foo {}
const _: () = {
Foo$0
};
//- /foo.rs crate:foo
pub struct Foo
"#,
r#"
use ::foo::Foo;
mod foo {}
const _: () = {
Foo
};
2021-04-19 12:53:29 -05:00
"#,
);
}
}