Auto import functions

This commit is contained in:
Kirill Bulatov 2020-02-01 22:13:02 +02:00
parent 96bd4f5704
commit d3188769e4
2 changed files with 35 additions and 6 deletions

View File

@ -211,4 +211,28 @@ mod tests {
}",
);
}
#[test]
fn function_import() {
check_assist_with_imports_locator(
auto_import,
TestImportsLocator::new,
r"
test_function<|>
pub mod PubMod {
pub fn test_function() {};
}
",
r"
use PubMod::test_function;
test_function<|>
pub mod PubMod {
pub fn test_function() {};
}
",
);
}
}

View File

@ -119,7 +119,7 @@ impl_froms!(
BuiltinType
);
pub use hir_def::{attr::Attrs, visibility::Visibility, AssocItemId};
pub use hir_def::{attr::Attrs, item_scope::ItemInNs, visibility::Visibility, AssocItemId};
use rustc_hash::FxHashSet;
impl Module {
@ -238,11 +238,16 @@ impl Module {
item: ModuleDef,
) -> Option<hir_def::path::ModPath> {
// FIXME expose namespace choice
hir_def::find_path::find_path(
db,
hir_def::item_scope::ItemInNs::Types(item.into()),
self.into(),
)
hir_def::find_path::find_path(db, determine_item_namespace(item), self.into())
}
}
fn determine_item_namespace(module_def: ModuleDef) -> ItemInNs {
match module_def {
ModuleDef::Static(_) | ModuleDef::Const(_) | ModuleDef::Function(_) => {
ItemInNs::Values(module_def.into())
}
_ => ItemInNs::Types(module_def.into()),
}
}