2016-07-15 17:25:44 -05:00
|
|
|
//! Checks for uses of mutex where an atomic value could be used
|
2015-10-06 18:17:57 -05:00
|
|
|
//!
|
|
|
|
//! This lint is **warn** by default
|
|
|
|
|
2018-05-30 03:15:50 -05:00
|
|
|
use crate::utils::{match_type, paths, span_lint};
|
2020-01-11 05:37:08 -06:00
|
|
|
use rustc::lint::{LateContext, LateLintPass};
|
2018-12-29 09:04:45 -06:00
|
|
|
use rustc::ty::{self, Ty};
|
2020-01-06 10:39:50 -06:00
|
|
|
use rustc_hir::Expr;
|
2020-01-11 05:37:08 -06:00
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
2018-12-29 09:04:45 -06:00
|
|
|
use syntax::ast;
|
2015-10-06 18:17:57 -05:00
|
|
|
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 10:50:33 -06:00
|
|
|
/// **What it does:** Checks for usages of `Mutex<X>` where an atomic will do.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** Using a mutex just to make access to a plain bool or
|
|
|
|
/// reference sequential is shooting flies with cannons.
|
|
|
|
/// `std::sync::atomic::AtomicBool` and `std::sync::atomic::AtomicPtr` are leaner and
|
|
|
|
/// faster.
|
|
|
|
///
|
|
|
|
/// **Known problems:** This lint cannot detect if the mutex is actually used
|
|
|
|
/// for waiting before a critical section.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
2019-08-03 01:01:27 -05:00
|
|
|
/// # use std::sync::Mutex;
|
|
|
|
/// # let y = 1;
|
2019-03-05 10:50:33 -06:00
|
|
|
/// let x = Mutex::new(&y);
|
|
|
|
/// ```
|
2015-10-06 18:17:57 -05:00
|
|
|
pub MUTEX_ATOMIC,
|
2018-03-28 08:24:26 -05:00
|
|
|
perf,
|
2016-07-15 17:25:44 -05:00
|
|
|
"using a mutex where an atomic value could be used instead"
|
2015-10-06 18:17:57 -05:00
|
|
|
}
|
|
|
|
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 10:50:33 -06:00
|
|
|
/// **What it does:** Checks for usages of `Mutex<X>` where `X` is an integral
|
|
|
|
/// type.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** Using a mutex just to make access to a plain integer
|
|
|
|
/// sequential is
|
|
|
|
/// shooting flies with cannons. `std::sync::atomic::AtomicUsize` is leaner and faster.
|
|
|
|
///
|
|
|
|
/// **Known problems:** This lint cannot detect if the mutex is actually used
|
|
|
|
/// for waiting before a critical section.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
2019-08-03 14:01:23 -05:00
|
|
|
/// # use std::sync::Mutex;
|
2019-03-05 10:50:33 -06:00
|
|
|
/// let x = Mutex::new(0usize);
|
|
|
|
/// ```
|
2015-10-07 15:58:34 -05:00
|
|
|
pub MUTEX_INTEGER,
|
2018-03-29 06:41:53 -05:00
|
|
|
nursery,
|
2016-07-15 17:25:44 -05:00
|
|
|
"using a mutex for an integer type"
|
2015-10-07 15:58:34 -05:00
|
|
|
}
|
|
|
|
|
2019-04-08 15:43:55 -05:00
|
|
|
declare_lint_pass!(Mutex => [MUTEX_ATOMIC, MUTEX_INTEGER]);
|
2019-01-26 13:40:55 -06:00
|
|
|
|
2019-04-08 15:43:55 -05:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Mutex {
|
2019-12-27 01:12:26 -06:00
|
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr<'_>) {
|
2017-01-13 10:04:56 -06:00
|
|
|
let ty = cx.tables.expr_ty(expr);
|
2019-09-26 04:03:36 -05:00
|
|
|
if let ty::Adt(_, subst) = ty.kind {
|
2019-05-17 16:53:54 -05:00
|
|
|
if match_type(cx, ty, &paths::MUTEX) {
|
2017-06-10 21:57:25 -05:00
|
|
|
let mutex_param = subst.type_at(0);
|
2015-10-06 18:17:57 -05:00
|
|
|
if let Some(atomic_name) = get_atomic_name(mutex_param) {
|
2017-08-09 02:30:56 -05:00
|
|
|
let msg = format!(
|
2020-01-06 00:30:43 -06:00
|
|
|
"Consider using an `{}` instead of a `Mutex` here. If you just want the locking \
|
|
|
|
behavior and not the internal type, consider using `Mutex<()>`.",
|
2017-08-09 02:30:56 -05:00
|
|
|
atomic_name
|
|
|
|
);
|
2019-09-26 04:03:36 -05:00
|
|
|
match mutex_param.kind {
|
2018-08-22 16:34:52 -05:00
|
|
|
ty::Uint(t) if t != ast::UintTy::Usize => span_lint(cx, MUTEX_INTEGER, expr.span, &msg),
|
|
|
|
ty::Int(t) if t != ast::IntTy::Isize => span_lint(cx, MUTEX_INTEGER, expr.span, &msg),
|
2016-01-03 22:26:12 -06:00
|
|
|
_ => span_lint(cx, MUTEX_ATOMIC, expr.span, &msg),
|
2015-12-31 14:39:03 -06:00
|
|
|
};
|
2015-10-06 18:17:57 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-11-05 08:51:56 -06:00
|
|
|
fn get_atomic_name(ty: Ty<'_>) -> Option<&'static str> {
|
2019-09-26 04:03:36 -05:00
|
|
|
match ty.kind {
|
2018-08-22 16:34:52 -05:00
|
|
|
ty::Bool => Some("AtomicBool"),
|
|
|
|
ty::Uint(_) => Some("AtomicUsize"),
|
|
|
|
ty::Int(_) => Some("AtomicIsize"),
|
|
|
|
ty::RawPtr(_) => Some("AtomicPtr"),
|
2016-01-03 22:26:12 -06:00
|
|
|
_ => None,
|
2015-10-06 18:17:57 -05:00
|
|
|
}
|
|
|
|
}
|