52 lines
1.5 KiB
Rust
52 lines
1.5 KiB
Rust
|
//! Checks for uses of Mutex where an atomic value could be used
|
||
|
|
//!
|
||
|
|
//! This lint is **warn** by default
|
||
|
|
|
||
|
|
use rustc::lint::{LintPass, LintArray, LateLintPass, LateContext};
|
||
|
|
use rustc_front::hir::Expr;
|
||
|
|
|
||
|
|
use syntax::ast;
|
||
|
|
use rustc::middle::ty;
|
||
|
|
use rustc::middle::subst::ParamSpace;
|
||
|
|
|
||
|
|
use utils::{span_lint, MUTEX_PATH, match_type};
|
||
|
|
|
||
|
|
declare_lint! {
|
||
|
|
pub MUTEX_ATOMIC,
|
||
|
|
Warn,
|
||
|
|
"using a Mutex where an atomic value could be used instead"
|
||
|
|
}
|
||
|
|
|
||
|
|
impl LintPass for MutexAtomic {
|
||
|
|
fn get_lints(&self) -> LintArray {
|
||
|
|
lint_array!(MUTEX_ATOMIC)
|
||
|
|
}
|
||
|
|
}
|
||
|
|
pub struct MutexAtomic;
|
||
|
|
|
||
|
|
impl LateLintPass for MutexAtomic {
|
||
|
|
fn check_expr(&mut self, cx: &LateContext, expr: &Expr) {
|
||
|
|
let ty = cx.tcx.expr_ty(expr);
|
||
|
|
if let &ty::TyStruct(_, subst) = &ty.sty {
|
||
|
|
if match_type(cx, ty, &MUTEX_PATH) {
|
||
|
|
let mutex_param = &subst.types.get(ParamSpace::TypeSpace, 0).sty;
|
||
|
|
if let Some(atomic_name) = get_atomic_name(mutex_param) {
|
||
|
|
let msg = format!("Consider using an {} instead of a \
|
||
|
|
Mutex here.", atomic_name);
|
||
|
|
span_lint(cx, MUTEX_ATOMIC, expr.span, &msg);
|
||
|
|
}
|
||
|
|
}
|
||
|
|
}
|
||
|
|
}
|
||
|
|
}
|
||
|
|
|
||
|
|
fn get_atomic_name(ty: &ty::TypeVariants) -> Option<(&'static str)> {
|
||
|
|
match *ty {
|
||
|
|
ty::TyBool => Some("AtomicBool"),
|
||
|
|
ty::TyUint(ast::TyUs) => Some("AtomicUsize"),
|
||
|
|
ty::TyInt(ast::TyIs) => Some("AtomicIsize"),
|
||
|
|
ty::TyRawPtr(_) => Some("AtomicPtr"),
|
||
|
|
_ => None
|
||
|
|
}
|
||
|
|
}
|