rust/crates/ra_assists/src/handlers/auto_import.rs

716 lines
20 KiB
Rust
Raw Normal View History

2020-02-10 08:55:20 -06:00
use ra_ide_db::{imports_locator::ImportsLocator, RootDatabase};
2020-02-11 10:24:43 -06:00
use ra_syntax::{
ast::{self, AstNode},
SyntaxNode,
};
use crate::{
2020-02-09 07:30:27 -06:00
assist_ctx::{Assist, AssistCtx},
2020-02-07 15:35:34 -06:00
insert_use_statement, AssistId,
};
2020-02-11 07:21:12 -06:00
use hir::{
db::{DefDatabase, HirDatabase},
2020-02-11 10:24:43 -06:00
AssocContainerId, AssocItem, Crate, Function, ModPath, Module, ModuleDef, PathResolution,
SourceAnalyzer, Trait, Type,
2020-02-11 07:21:12 -06:00
};
2020-02-12 05:16:05 -06:00
use ra_prof::profile;
2020-02-11 07:21:12 -06:00
use rustc_hash::FxHashSet;
2020-02-07 08:12:51 -06:00
use std::collections::BTreeSet;
// Assist: auto_import
//
// If the name is unresolved, provides all possible imports for it.
//
// ```
// fn main() {
// let map = HashMap<|>::new();
// }
2020-02-06 11:10:25 -06:00
// # pub mod std { pub mod collections { pub struct HashMap { } } }
// ```
// ->
// ```
// use std::collections::HashMap;
//
// fn main() {
2020-02-06 11:10:25 -06:00
// let map = HashMap::new();
// }
2020-02-06 11:10:25 -06:00
// # pub mod std { pub mod collections { pub struct HashMap { } } }
// ```
2020-02-06 10:17:51 -06:00
pub(crate) fn auto_import(ctx: AssistCtx) -> Option<Assist> {
2020-02-11 10:24:43 -06:00
let auto_import_assets = if let Some(path_under_caret) = ctx.find_node_at_offset::<ast::Path>()
{
AutoImportAssets::for_regular_path(path_under_caret, &ctx)?
} else {
AutoImportAssets::for_method_call(ctx.find_node_at_offset()?, &ctx)?
};
2020-02-11 10:24:43 -06:00
let proposed_imports = auto_import_assets
.search_for_imports(ctx.db, auto_import_assets.module_with_name_to_import);
if proposed_imports.is_empty() {
return None;
}
2020-02-11 10:24:43 -06:00
let mut group =
// TODO kb create another method and add something about traits there
ctx.add_assist_group(format!("Import {}", auto_import_assets.get_search_query()));
2020-02-09 07:30:27 -06:00
for import in proposed_imports {
group.add_assist(AssistId("auto_import"), format!("Import `{}`", &import), |edit| {
2020-02-11 10:24:43 -06:00
edit.target(auto_import_assets.syntax_under_caret.text_range());
2020-02-09 07:30:27 -06:00
insert_use_statement(
2020-02-11 10:24:43 -06:00
&auto_import_assets.syntax_under_caret,
&auto_import_assets.syntax_under_caret,
2020-02-09 07:30:27 -06:00
&import,
edit.text_edit_builder(),
);
});
}
group.finish()
}
2020-02-11 10:24:43 -06:00
struct AutoImportAssets {
import_candidate: ImportCandidate,
module_with_name_to_import: Module,
syntax_under_caret: SyntaxNode,
2020-02-10 08:55:20 -06:00
}
2020-02-11 10:24:43 -06:00
impl AutoImportAssets {
fn for_method_call(method_call: ast::MethodCallExpr, ctx: &AssistCtx) -> Option<Self> {
let syntax_under_caret = method_call.syntax().to_owned();
let source_analyzer = ctx.source_analyzer(&syntax_under_caret, None);
let module_with_name_to_import = source_analyzer.module()?;
Some(Self {
import_candidate: ImportCandidate::for_method_call(
&method_call,
&source_analyzer,
ctx.db,
)?,
module_with_name_to_import,
syntax_under_caret,
})
}
fn for_regular_path(path_under_caret: ast::Path, ctx: &AssistCtx) -> Option<Self> {
let syntax_under_caret = path_under_caret.syntax().to_owned();
if syntax_under_caret.ancestors().find_map(ast::UseItem::cast).is_some() {
2020-02-10 08:55:20 -06:00
return None;
}
2020-02-11 10:24:43 -06:00
let source_analyzer = ctx.source_analyzer(&syntax_under_caret, None);
let module_with_name_to_import = source_analyzer.module()?;
Some(Self {
import_candidate: ImportCandidate::for_regular_path(
&path_under_caret,
&source_analyzer,
ctx.db,
)?,
module_with_name_to_import,
syntax_under_caret,
})
2020-02-10 08:55:20 -06:00
}
fn get_search_query(&self) -> String {
2020-02-11 10:24:43 -06:00
match &self.import_candidate {
2020-02-10 08:55:20 -06:00
ImportCandidate::UnqualifiedName(name_ref)
| ImportCandidate::QualifierStart(name_ref) => name_ref.syntax().to_string(),
ImportCandidate::TraitFunction(_, trait_function) => {
trait_function.syntax().to_string()
}
2020-02-11 10:24:43 -06:00
ImportCandidate::TraitMethod(_, trait_method) => trait_method.syntax().to_string(),
2020-02-10 08:55:20 -06:00
}
}
fn search_for_imports(
&self,
db: &RootDatabase,
module_with_name_to_import: Module,
) -> BTreeSet<ModPath> {
2020-02-12 05:16:05 -06:00
let _p = profile("auto_import::search_for_imports");
2020-02-10 08:55:20 -06:00
ImportsLocator::new(db)
.find_imports(&self.get_search_query())
.into_iter()
2020-02-11 10:24:43 -06:00
.map(|module_def| match &self.import_candidate {
2020-02-10 08:55:20 -06:00
ImportCandidate::TraitFunction(function_callee, _) => {
2020-02-11 07:21:12 -06:00
let mut applicable_traits = Vec::new();
if let ModuleDef::Function(located_function) = module_def {
let trait_candidates = Self::get_trait_candidates(
db,
located_function,
module_with_name_to_import.krate(),
)
.into_iter()
.map(|trait_candidate| trait_candidate.into())
.collect();
2020-02-11 10:24:43 -06:00
function_callee.iterate_path_candidates(
2020-02-11 07:21:12 -06:00
db,
module_with_name_to_import.krate(),
&trait_candidates,
None,
|_, assoc| {
if let AssocContainerId::TraitId(trait_id) = assoc.container(db) {
applicable_traits.push(
module_with_name_to_import
.find_use_path(db, ModuleDef::Trait(trait_id.into())),
);
};
None::<()>
},
);
2020-02-10 08:55:20 -06:00
}
2020-02-11 07:21:12 -06:00
applicable_traits
2020-02-10 08:55:20 -06:00
}
2020-02-11 10:24:43 -06:00
ImportCandidate::TraitMethod(function_callee, _) => {
let mut applicable_traits = Vec::new();
if let ModuleDef::Function(located_function) = module_def {
let trait_candidates: FxHashSet<_> = Self::get_trait_candidates(
db,
located_function,
module_with_name_to_import.krate(),
)
.into_iter()
.map(|trait_candidate| trait_candidate.into())
.collect();
if !trait_candidates.is_empty() {
function_callee.iterate_method_candidates(
db,
module_with_name_to_import.krate(),
&trait_candidates,
None,
|_, funciton| {
if let AssocContainerId::TraitId(trait_id) =
funciton.container(db)
{
applicable_traits.push(
module_with_name_to_import.find_use_path(
db,
ModuleDef::Trait(trait_id.into()),
),
);
};
None::<()>
},
);
}
}
applicable_traits
}
2020-02-11 07:21:12 -06:00
_ => vec![module_with_name_to_import.find_use_path(db, module_def)],
2020-02-10 08:55:20 -06:00
})
2020-02-11 07:21:12 -06:00
.flatten()
.filter_map(std::convert::identity)
2020-02-10 08:55:20 -06:00
.filter(|use_path| !use_path.segments.is_empty())
.take(20)
.collect::<BTreeSet<_>>()
}
2020-02-11 07:21:12 -06:00
fn get_trait_candidates(
db: &RootDatabase,
called_function: Function,
root_crate: Crate,
) -> FxHashSet<Trait> {
2020-02-12 05:16:05 -06:00
let _p = profile("auto_import::get_trait_candidates");
2020-02-11 07:21:12 -06:00
root_crate
.dependencies(db)
.into_iter()
.map(|dependency| db.crate_def_map(dependency.krate.into()))
.chain(std::iter::once(db.crate_def_map(root_crate.into())))
.map(|crate_def_map| {
crate_def_map
.modules
.iter()
2020-02-11 10:24:43 -06:00
.map(|(_, module_data)| {
let mut traits = Vec::new();
for module_def_id in module_data.scope.declarations() {
if let ModuleDef::Trait(trait_candidate) = module_def_id.into() {
if trait_candidate
.items(db)
.into_iter()
.any(|item| item == AssocItem::Function(called_function))
{
traits.push(trait_candidate)
2020-02-11 07:21:12 -06:00
}
}
}
2020-02-11 10:24:43 -06:00
traits
2020-02-11 07:21:12 -06:00
})
.flatten()
.collect::<FxHashSet<_>>()
})
.flatten()
.collect()
}
2020-02-10 08:55:20 -06:00
}
2020-02-11 10:24:43 -06:00
#[derive(Debug)]
// TODO kb rustdocs
enum ImportCandidate {
UnqualifiedName(ast::NameRef),
QualifierStart(ast::NameRef),
TraitFunction(Type, ast::PathSegment),
TraitMethod(Type, ast::NameRef),
}
impl ImportCandidate {
fn for_method_call(
method_call: &ast::MethodCallExpr,
source_analyzer: &SourceAnalyzer,
db: &impl HirDatabase,
) -> Option<Self> {
if source_analyzer.resolve_method_call(method_call).is_some() {
return None;
}
Some(Self::TraitMethod(
source_analyzer.type_of(db, &method_call.expr()?)?,
method_call.name_ref()?,
))
}
fn for_regular_path(
path_under_caret: &ast::Path,
source_analyzer: &SourceAnalyzer,
db: &impl HirDatabase,
) -> Option<Self> {
if source_analyzer.resolve_path(db, path_under_caret).is_some() {
return None;
}
let segment = path_under_caret.segment()?;
if let Some(qualifier) = path_under_caret.qualifier() {
let qualifier_start = qualifier.syntax().descendants().find_map(ast::NameRef::cast)?;
let qualifier_start_path =
qualifier_start.syntax().ancestors().find_map(ast::Path::cast)?;
if let Some(qualifier_start_resolution) =
source_analyzer.resolve_path(db, &qualifier_start_path)
{
let qualifier_resolution = if &qualifier_start_path == path_under_caret {
qualifier_start_resolution
} else {
source_analyzer.resolve_path(db, &qualifier)?
};
if let PathResolution::Def(ModuleDef::Adt(function_callee)) = qualifier_resolution {
Some(ImportCandidate::TraitFunction(function_callee.ty(db), segment))
} else {
None
}
} else {
Some(ImportCandidate::QualifierStart(qualifier_start))
}
} else {
if source_analyzer.resolve_path(db, path_under_caret).is_none() {
Some(ImportCandidate::UnqualifiedName(
segment.syntax().descendants().find_map(ast::NameRef::cast)?,
))
} else {
None
}
}
}
}
#[cfg(test)]
mod tests {
2020-02-09 09:13:29 -06:00
use crate::helpers::{check_assist, check_assist_not_applicable, check_assist_target};
2020-02-07 08:12:51 -06:00
use super::*;
2020-01-26 16:16:18 -06:00
#[test]
fn applicable_when_found_an_import() {
2020-02-06 10:17:51 -06:00
check_assist(
2020-01-26 16:16:18 -06:00
auto_import,
r"
<|>PubStruct
2020-01-26 16:16:18 -06:00
pub mod PubMod {
pub struct PubStruct;
}
",
r"
<|>use PubMod::PubStruct;
PubStruct
2020-01-26 16:16:18 -06:00
pub mod PubMod {
pub struct PubStruct;
}
2020-01-26 16:16:18 -06:00
",
);
}
2020-02-02 02:28:16 -06:00
#[test]
fn auto_imports_are_merged() {
2020-02-06 10:17:51 -06:00
check_assist(
2020-02-02 02:28:16 -06:00
auto_import,
r"
use PubMod::PubStruct1;
struct Test {
test: Pub<|>Struct2<u8>,
}
2020-02-02 02:28:16 -06:00
pub mod PubMod {
pub struct PubStruct1;
pub struct PubStruct2<T> {
_t: T,
}
2020-02-02 02:28:16 -06:00
}
",
r"
use PubMod::{PubStruct2, PubStruct1};
struct Test {
test: Pub<|>Struct2<u8>,
}
2020-02-02 02:28:16 -06:00
pub mod PubMod {
pub struct PubStruct1;
pub struct PubStruct2<T> {
_t: T,
}
2020-02-02 02:28:16 -06:00
}
",
);
}
#[test]
2020-01-26 16:16:18 -06:00
fn applicable_when_found_multiple_imports() {
2020-02-06 10:17:51 -06:00
check_assist(
auto_import,
2020-01-26 16:16:18 -06:00
r"
PubSt<|>ruct
2020-01-26 16:16:18 -06:00
pub mod PubMod1 {
pub struct PubStruct;
}
pub mod PubMod2 {
pub struct PubStruct;
}
pub mod PubMod3 {
pub struct PubStruct;
}
",
r"
use PubMod1::PubStruct;
PubSt<|>ruct
2020-01-26 16:16:18 -06:00
pub mod PubMod1 {
pub struct PubStruct;
}
pub mod PubMod2 {
pub struct PubStruct;
}
2020-01-26 16:16:18 -06:00
pub mod PubMod3 {
pub struct PubStruct;
}
",
);
}
#[test]
fn not_applicable_for_already_imported_types() {
2020-02-06 10:17:51 -06:00
check_assist_not_applicable(
2020-01-26 16:16:18 -06:00
auto_import,
r"
use PubMod::PubStruct;
PubStruct<|>
2020-01-26 16:16:18 -06:00
pub mod PubMod {
pub struct PubStruct;
}
",
);
}
#[test]
2020-01-26 16:16:18 -06:00
fn not_applicable_for_types_with_private_paths() {
2020-02-06 10:17:51 -06:00
check_assist_not_applicable(
auto_import,
2020-01-26 16:16:18 -06:00
r"
PrivateStruct<|>
pub mod PubMod {
struct PrivateStruct;
}
2020-01-26 16:16:18 -06:00
",
);
}
2020-01-26 16:16:18 -06:00
#[test]
fn not_applicable_when_no_imports_found() {
2020-02-06 10:17:51 -06:00
check_assist_not_applicable(
2020-01-26 16:16:18 -06:00
auto_import,
"
PubStruct<|>",
);
}
#[test]
fn not_applicable_in_import_statements() {
2020-02-06 10:17:51 -06:00
check_assist_not_applicable(
auto_import,
2020-01-26 16:16:18 -06:00
r"
use PubStruct<|>;
pub mod PubMod {
pub struct PubStruct;
}",
);
}
2020-02-01 14:13:02 -06:00
#[test]
fn function_import() {
2020-02-06 10:17:51 -06:00
check_assist(
2020-02-01 14:13:02 -06:00
auto_import,
r"
test_function<|>
pub mod PubMod {
pub fn test_function() {};
}
",
r"
use PubMod::test_function;
test_function<|>
pub mod PubMod {
pub fn test_function() {};
}
",
);
}
2020-02-09 09:13:29 -06:00
#[test]
fn auto_import_target() {
check_assist_target(
auto_import,
r"
struct AssistInfo {
group_label: Option<<|>GroupLabel>,
}
mod m { pub struct GroupLabel; }
",
"GroupLabel",
)
}
#[test]
fn not_applicable_when_path_start_is_imported() {
check_assist_not_applicable(
auto_import,
r"
pub mod mod1 {
pub mod mod2 {
pub mod mod3 {
pub struct TestStruct;
}
}
}
use mod1::mod2;
fn main() {
mod2::mod3::TestStruct<|>
}
",
);
}
2020-02-09 16:22:12 -06:00
#[test]
fn not_applicable_for_imported_function() {
check_assist_not_applicable(
auto_import,
r"
pub mod test_mod {
pub fn test_function() {}
}
use test_mod::test_function;
fn main() {
test_function<|>
}
",
);
}
2020-02-09 16:30:00 -06:00
#[test]
fn associated_struct_function() {
check_assist(
auto_import,
r"
mod test_mod {
pub struct TestStruct {}
impl TestStruct {
pub fn test_function() {}
}
}
fn main() {
TestStruct::test_function<|>
}
",
r"
use test_mod::TestStruct;
mod test_mod {
pub struct TestStruct {}
impl TestStruct {
pub fn test_function() {}
}
}
fn main() {
TestStruct::test_function<|>
}
",
);
}
#[test]
fn associated_trait_function() {
check_assist(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
fn test_function();
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_function() {}
}
}
fn main() {
test_mod::TestStruct::test_function<|>
}
",
r"
use test_mod::TestTrait;
mod test_mod {
pub trait TestTrait {
fn test_function();
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_function() {}
}
}
fn main() {
test_mod::TestStruct::test_function<|>
}
",
);
}
#[test]
2020-02-11 10:24:43 -06:00
fn not_applicable_for_imported_trait_for_function() {
2020-02-11 07:21:12 -06:00
check_assist_not_applicable(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
fn test_function();
}
pub trait TestTrait2 {
fn test_function();
}
pub enum TestEnum {
One,
Two,
}
impl TestTrait2 for TestEnum {
fn test_function() {}
}
impl TestTrait for TestEnum {
fn test_function() {}
}
}
use test_mod::TestTrait2;
fn main() {
test_mod::TestEnum::test_function<|>;
}
",
)
}
#[test]
2020-02-09 16:30:00 -06:00
fn trait_method() {
check_assist(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
fn test_method(&self);
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_method(&self) {}
}
}
fn main() {
let test_struct = test_mod::TestStruct {};
2020-02-11 10:24:43 -06:00
test_struct.test_meth<|>od()
2020-02-09 16:30:00 -06:00
}
",
r"
use test_mod::TestTrait;
mod test_mod {
pub trait TestTrait {
fn test_method(&self);
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_method(&self) {}
}
}
fn main() {
let test_struct = test_mod::TestStruct {};
2020-02-11 10:24:43 -06:00
test_struct.test_meth<|>od()
2020-02-09 16:30:00 -06:00
}
",
);
}
2020-02-11 10:24:43 -06:00
#[test]
fn not_applicable_for_imported_trait_for_method() {
check_assist_not_applicable(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
fn test_method(&self);
}
pub trait TestTrait2 {
fn test_method(&self);
}
pub enum TestEnum {
One,
Two,
}
impl TestTrait2 for TestEnum {
fn test_method(&self) {}
}
impl TestTrait for TestEnum {
fn test_method(&self) {}
}
}
use test_mod::TestTrait2;
fn main() {
let one = test_mod::TestEnum::One;
one.test<|>_method();
}
",
)
}
}