2015-08-11 13:53:50 -05:00
|
|
|
|
#![feature(plugin)]
|
2016-05-12 03:23:06 -05:00
|
|
|
|
#![feature(const_fn)]
|
2015-08-11 13:53:50 -05:00
|
|
|
|
#![plugin(clippy)]
|
|
|
|
|
|
2015-09-01 10:53:56 -05:00
|
|
|
|
#![deny(clippy, clippy_pedantic)]
|
2016-08-23 11:09:37 -05:00
|
|
|
|
#![allow(blacklisted_name, unused, print_stdout, non_ascii_literal, new_without_default, new_without_default_derive, missing_docs_in_private_items)]
|
2015-08-24 11:13:02 -05:00
|
|
|
|
|
2016-01-19 17:53:26 -06:00
|
|
|
|
use std::collections::BTreeMap;
|
|
|
|
|
use std::collections::HashMap;
|
2016-04-20 14:09:38 -05:00
|
|
|
|
use std::collections::HashSet;
|
2016-06-16 16:30:05 -05:00
|
|
|
|
use std::collections::VecDeque;
|
2015-08-24 11:13:02 -05:00
|
|
|
|
use std::ops::Mul;
|
2016-11-01 03:07:51 -05:00
|
|
|
|
use std::iter::FromIterator;
|
2015-08-24 11:13:02 -05:00
|
|
|
|
|
|
|
|
|
struct T;
|
|
|
|
|
|
|
|
|
|
impl T {
|
|
|
|
|
fn add(self, other: T) -> T { self } //~ERROR defining a method called `add`
|
|
|
|
|
fn drop(&mut self) { } //~ERROR defining a method called `drop`
|
|
|
|
|
|
|
|
|
|
fn sub(&self, other: T) -> &T { self } // no error, self is a ref
|
|
|
|
|
fn div(self) -> T { self } // no error, different #arguments
|
|
|
|
|
fn rem(self, other: T) { } // no error, wrong return type
|
2015-09-01 11:52:48 -05:00
|
|
|
|
|
|
|
|
|
fn into_u32(self) -> u32 { 0 } // fine
|
|
|
|
|
fn into_u16(&self) -> u16 { 0 } //~ERROR methods called `into_*` usually take self by value
|
2015-09-01 14:08:49 -05:00
|
|
|
|
|
|
|
|
|
fn to_something(self) -> u32 { 0 } //~ERROR methods called `to_*` usually take self by reference
|
2016-02-12 18:42:46 -06:00
|
|
|
|
|
2016-02-12 19:20:22 -06:00
|
|
|
|
fn new(self) {}
|
|
|
|
|
//~^ ERROR methods called `new` usually take no self
|
|
|
|
|
//~| ERROR methods called `new` usually return `Self`
|
2015-09-01 14:08:49 -05:00
|
|
|
|
}
|
|
|
|
|
|
2016-03-03 12:46:10 -06:00
|
|
|
|
struct Lt<'a> {
|
|
|
|
|
foo: &'a u32,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'a> Lt<'a> {
|
|
|
|
|
// The lifetime is different, but that’s irrelevant, see #734
|
|
|
|
|
#[allow(needless_lifetimes)]
|
|
|
|
|
pub fn new<'b>(s: &'b str) -> Lt<'b> { unimplemented!() }
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
struct Lt2<'a> {
|
|
|
|
|
foo: &'a u32,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'a> Lt2<'a> {
|
|
|
|
|
// The lifetime is different, but that’s irrelevant, see #734
|
|
|
|
|
pub fn new(s: &str) -> Lt2 { unimplemented!() }
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-26 16:14:55 -05:00
|
|
|
|
struct Lt3<'a> {
|
|
|
|
|
foo: &'a u32,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'a> Lt3<'a> {
|
|
|
|
|
// The lifetime is different, but that’s irrelevant, see #734
|
|
|
|
|
pub fn new() -> Lt3<'static> { unimplemented!() }
|
|
|
|
|
}
|
|
|
|
|
|
2015-09-01 14:08:49 -05:00
|
|
|
|
#[derive(Clone,Copy)]
|
|
|
|
|
struct U;
|
|
|
|
|
|
|
|
|
|
impl U {
|
2016-02-12 19:20:22 -06:00
|
|
|
|
fn new() -> Self { U }
|
2015-09-01 14:08:49 -05:00
|
|
|
|
fn to_something(self) -> u32 { 0 } // ok because U is Copy
|
2015-08-24 11:13:02 -05:00
|
|
|
|
}
|
|
|
|
|
|
2016-02-12 19:20:22 -06:00
|
|
|
|
struct V<T> {
|
|
|
|
|
_dummy: T
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<T> V<T> {
|
|
|
|
|
fn new() -> Option<V<T>> { None }
|
|
|
|
|
}
|
|
|
|
|
|
2015-08-24 11:13:02 -05:00
|
|
|
|
impl Mul<T> for T {
|
|
|
|
|
type Output = T;
|
|
|
|
|
fn mul(self, other: T) -> T { self } // no error, obviously
|
|
|
|
|
}
|
|
|
|
|
|
2015-11-22 23:48:19 -06:00
|
|
|
|
/// Utility macro to test linting behavior in `option_methods()`
|
|
|
|
|
/// The lints included in `option_methods()` should not lint if the call to map is partially
|
|
|
|
|
/// within a macro
|
|
|
|
|
macro_rules! opt_map {
|
|
|
|
|
($opt:expr, $map:expr) => {($opt).map($map)};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Checks implementation of the following lints:
|
2016-03-19 11:48:29 -05:00
|
|
|
|
/// * `OPTION_MAP_UNWRAP_OR`
|
|
|
|
|
/// * `OPTION_MAP_UNWRAP_OR_ELSE`
|
2015-11-22 23:48:19 -06:00
|
|
|
|
fn option_methods() {
|
|
|
|
|
let opt = Some(1);
|
|
|
|
|
|
|
|
|
|
// Check OPTION_MAP_UNWRAP_OR
|
|
|
|
|
// single line case
|
|
|
|
|
let _ = opt.map(|x| x + 1) //~ ERROR called `map(f).unwrap_or(a)`
|
2015-12-30 03:07:40 -06:00
|
|
|
|
//~| NOTE replace `map(|x| x + 1).unwrap_or(0)`
|
2015-11-22 23:48:19 -06:00
|
|
|
|
.unwrap_or(0); // should lint even though this call is on a separate line
|
|
|
|
|
// multi line cases
|
|
|
|
|
let _ = opt.map(|x| { //~ ERROR called `map(f).unwrap_or(a)`
|
|
|
|
|
x + 1
|
|
|
|
|
}
|
|
|
|
|
).unwrap_or(0);
|
|
|
|
|
let _ = opt.map(|x| x + 1) //~ ERROR called `map(f).unwrap_or(a)`
|
|
|
|
|
.unwrap_or({
|
|
|
|
|
0
|
|
|
|
|
});
|
|
|
|
|
// macro case
|
|
|
|
|
let _ = opt_map!(opt, |x| x + 1).unwrap_or(0); // should not lint
|
|
|
|
|
|
|
|
|
|
// Check OPTION_MAP_UNWRAP_OR_ELSE
|
|
|
|
|
// single line case
|
|
|
|
|
let _ = opt.map(|x| x + 1) //~ ERROR called `map(f).unwrap_or_else(g)`
|
2015-12-30 03:07:40 -06:00
|
|
|
|
//~| NOTE replace `map(|x| x + 1).unwrap_or_else(|| 0)`
|
2015-11-22 23:48:19 -06:00
|
|
|
|
.unwrap_or_else(|| 0); // should lint even though this call is on a separate line
|
|
|
|
|
// multi line cases
|
|
|
|
|
let _ = opt.map(|x| { //~ ERROR called `map(f).unwrap_or_else(g)`
|
|
|
|
|
x + 1
|
|
|
|
|
}
|
|
|
|
|
).unwrap_or_else(|| 0);
|
|
|
|
|
let _ = opt.map(|x| x + 1) //~ ERROR called `map(f).unwrap_or_else(g)`
|
|
|
|
|
.unwrap_or_else(||
|
|
|
|
|
0
|
|
|
|
|
);
|
|
|
|
|
// macro case
|
|
|
|
|
let _ = opt_map!(opt, |x| x + 1).unwrap_or_else(|| 0); // should not lint
|
|
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
2016-06-16 04:02:00 -05:00
|
|
|
|
/// Struct to generate false positives for things with .iter()
|
|
|
|
|
#[derive(Copy, Clone)]
|
|
|
|
|
struct HasIter;
|
|
|
|
|
|
|
|
|
|
impl HasIter {
|
|
|
|
|
fn iter(self) -> IteratorFalsePositives {
|
|
|
|
|
IteratorFalsePositives { foo: 0 }
|
|
|
|
|
}
|
2016-06-16 16:30:05 -05:00
|
|
|
|
|
|
|
|
|
fn iter_mut(self) -> IteratorFalsePositives {
|
|
|
|
|
IteratorFalsePositives { foo: 0 }
|
|
|
|
|
}
|
2016-06-16 04:02:00 -05:00
|
|
|
|
}
|
|
|
|
|
|
2015-12-30 02:38:03 -06:00
|
|
|
|
/// Struct to generate false positive for Iterator-based lints
|
|
|
|
|
#[derive(Copy, Clone)]
|
|
|
|
|
struct IteratorFalsePositives {
|
|
|
|
|
foo: u32,
|
2015-12-28 18:56:58 -06:00
|
|
|
|
}
|
|
|
|
|
|
2015-12-30 02:38:03 -06:00
|
|
|
|
impl IteratorFalsePositives {
|
|
|
|
|
fn filter(self) -> IteratorFalsePositives {
|
2015-12-28 18:56:58 -06:00
|
|
|
|
self
|
|
|
|
|
}
|
2015-12-30 02:38:03 -06:00
|
|
|
|
|
|
|
|
|
fn next(self) -> IteratorFalsePositives {
|
2015-12-28 18:56:58 -06:00
|
|
|
|
self
|
|
|
|
|
}
|
2015-12-30 02:38:03 -06:00
|
|
|
|
|
|
|
|
|
fn find(self) -> Option<u32> {
|
|
|
|
|
Some(self.foo)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn position(self) -> Option<u32> {
|
|
|
|
|
Some(self.foo)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn rposition(self) -> Option<u32> {
|
|
|
|
|
Some(self.foo)
|
|
|
|
|
}
|
2016-06-16 04:02:00 -05:00
|
|
|
|
|
|
|
|
|
fn nth(self, n: usize) -> Option<u32> {
|
|
|
|
|
Some(self.foo)
|
|
|
|
|
}
|
2016-10-14 06:35:25 -05:00
|
|
|
|
|
|
|
|
|
fn skip(self, _: usize) -> IteratorFalsePositives {
|
|
|
|
|
self
|
|
|
|
|
}
|
2015-12-28 18:56:58 -06:00
|
|
|
|
}
|
|
|
|
|
|
2016-11-19 09:21:40 -06:00
|
|
|
|
#[derive(Copy, Clone)]
|
|
|
|
|
struct HasChars;
|
|
|
|
|
|
|
|
|
|
impl HasChars {
|
|
|
|
|
fn chars(self) -> std::str::Chars<'static> {
|
|
|
|
|
"HasChars".chars()
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-19 11:48:29 -05:00
|
|
|
|
/// Checks implementation of `FILTER_NEXT` lint
|
2015-12-28 18:56:58 -06:00
|
|
|
|
fn filter_next() {
|
|
|
|
|
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
|
|
|
|
|
|
|
|
|
// check single-line case
|
2015-12-30 03:07:40 -06:00
|
|
|
|
let _ = v.iter().filter(|&x| *x < 0).next();
|
2016-06-21 07:46:02 -05:00
|
|
|
|
//~^ ERROR called `filter(p).next()` on an `Iterator`.
|
2015-12-30 03:07:40 -06:00
|
|
|
|
//~| NOTE replace `filter(|&x| *x < 0).next()`
|
2015-12-28 18:56:58 -06:00
|
|
|
|
|
|
|
|
|
// check multi-line case
|
2016-06-21 07:46:02 -05:00
|
|
|
|
let _ = v.iter().filter(|&x| { //~ERROR called `filter(p).next()` on an `Iterator`.
|
2015-12-28 18:56:58 -06:00
|
|
|
|
*x < 0
|
|
|
|
|
}
|
|
|
|
|
).next();
|
|
|
|
|
|
|
|
|
|
// check that we don't lint if the caller is not an Iterator
|
2015-12-30 02:38:03 -06:00
|
|
|
|
let foo = IteratorFalsePositives { foo: 0 };
|
2015-12-28 18:56:58 -06:00
|
|
|
|
let _ = foo.filter().next();
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-19 11:48:29 -05:00
|
|
|
|
/// Checks implementation of `SEARCH_IS_SOME` lint
|
2015-12-30 02:38:03 -06:00
|
|
|
|
fn search_is_some() {
|
|
|
|
|
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
|
|
|
|
|
|
|
|
|
// check `find().is_some()`, single-line
|
2015-12-30 03:07:40 -06:00
|
|
|
|
let _ = v.iter().find(|&x| *x < 0).is_some();
|
|
|
|
|
//~^ ERROR called `is_some()` after searching
|
|
|
|
|
//~| NOTE replace `find(|&x| *x < 0).is_some()`
|
|
|
|
|
|
2015-12-30 02:38:03 -06:00
|
|
|
|
// check `find().is_some()`, multi-line
|
|
|
|
|
let _ = v.iter().find(|&x| { //~ERROR called `is_some()` after searching
|
|
|
|
|
*x < 0
|
|
|
|
|
}
|
|
|
|
|
).is_some();
|
|
|
|
|
|
|
|
|
|
// check `position().is_some()`, single-line
|
2015-12-30 03:07:40 -06:00
|
|
|
|
let _ = v.iter().position(|&x| x < 0).is_some();
|
|
|
|
|
//~^ ERROR called `is_some()` after searching
|
|
|
|
|
//~| NOTE replace `position(|&x| x < 0).is_some()`
|
|
|
|
|
|
2015-12-30 02:38:03 -06:00
|
|
|
|
// check `position().is_some()`, multi-line
|
|
|
|
|
let _ = v.iter().position(|&x| { //~ERROR called `is_some()` after searching
|
|
|
|
|
x < 0
|
|
|
|
|
}
|
|
|
|
|
).is_some();
|
|
|
|
|
|
|
|
|
|
// check `rposition().is_some()`, single-line
|
2015-12-30 03:07:40 -06:00
|
|
|
|
let _ = v.iter().rposition(|&x| x < 0).is_some();
|
|
|
|
|
//~^ ERROR called `is_some()` after searching
|
|
|
|
|
//~| NOTE replace `rposition(|&x| x < 0).is_some()`
|
|
|
|
|
|
2015-12-30 02:38:03 -06:00
|
|
|
|
// check `rposition().is_some()`, multi-line
|
|
|
|
|
let _ = v.iter().rposition(|&x| { //~ERROR called `is_some()` after searching
|
|
|
|
|
x < 0
|
|
|
|
|
}
|
|
|
|
|
).is_some();
|
|
|
|
|
|
|
|
|
|
// check that we don't lint if the caller is not an Iterator
|
|
|
|
|
let foo = IteratorFalsePositives { foo: 0 };
|
|
|
|
|
let _ = foo.find().is_some();
|
|
|
|
|
let _ = foo.position().is_some();
|
|
|
|
|
let _ = foo.rposition().is_some();
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-19 11:48:29 -05:00
|
|
|
|
/// Checks implementation of the `OR_FUN_CALL` lint
|
2016-01-16 11:47:45 -06:00
|
|
|
|
fn or_fun_call() {
|
2016-01-18 06:36:58 -06:00
|
|
|
|
struct Foo;
|
|
|
|
|
|
|
|
|
|
impl Foo {
|
|
|
|
|
fn new() -> Foo { Foo }
|
|
|
|
|
}
|
|
|
|
|
|
2016-05-12 03:23:06 -05:00
|
|
|
|
enum Enum {
|
|
|
|
|
A(i32),
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const fn make_const(i: i32) -> i32 { i }
|
|
|
|
|
|
2016-01-18 06:11:07 -06:00
|
|
|
|
fn make<T>() -> T { unimplemented!(); }
|
|
|
|
|
|
2016-05-12 03:23:06 -05:00
|
|
|
|
let with_enum = Some(Enum::A(1));
|
|
|
|
|
with_enum.unwrap_or(Enum::A(5));
|
|
|
|
|
|
|
|
|
|
let with_const_fn = Some(1);
|
|
|
|
|
with_const_fn.unwrap_or(make_const(5));
|
|
|
|
|
|
2016-01-18 06:11:07 -06:00
|
|
|
|
let with_constructor = Some(vec![1]);
|
|
|
|
|
with_constructor.unwrap_or(make());
|
|
|
|
|
//~^ERROR use of `unwrap_or`
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION with_constructor.unwrap_or_else(make)
|
|
|
|
|
|
|
|
|
|
let with_new = Some(vec![1]);
|
|
|
|
|
with_new.unwrap_or(Vec::new());
|
|
|
|
|
//~^ERROR use of `unwrap_or`
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION with_new.unwrap_or_default();
|
|
|
|
|
|
|
|
|
|
let with_const_args = Some(vec![1]);
|
|
|
|
|
with_const_args.unwrap_or(Vec::with_capacity(12));
|
|
|
|
|
//~^ERROR use of `unwrap_or`
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION with_const_args.unwrap_or_else(|| Vec::with_capacity(12));
|
|
|
|
|
|
|
|
|
|
let with_err : Result<_, ()> = Ok(vec![1]);
|
|
|
|
|
with_err.unwrap_or(make());
|
|
|
|
|
//~^ERROR use of `unwrap_or`
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION with_err.unwrap_or_else(|_| make());
|
|
|
|
|
|
|
|
|
|
let with_err_args : Result<_, ()> = Ok(vec![1]);
|
|
|
|
|
with_err_args.unwrap_or(Vec::with_capacity(12));
|
2016-01-16 11:47:45 -06:00
|
|
|
|
//~^ERROR use of `unwrap_or`
|
|
|
|
|
//~|HELP try this
|
2016-01-18 06:11:07 -06:00
|
|
|
|
//~|SUGGESTION with_err_args.unwrap_or_else(|_| Vec::with_capacity(12));
|
2016-01-16 11:47:45 -06:00
|
|
|
|
|
2016-01-18 06:11:07 -06:00
|
|
|
|
let with_default_trait = Some(1);
|
|
|
|
|
with_default_trait.unwrap_or(Default::default());
|
2016-01-16 11:47:45 -06:00
|
|
|
|
//~^ERROR use of `unwrap_or`
|
|
|
|
|
//~|HELP try this
|
2016-01-18 06:11:07 -06:00
|
|
|
|
//~|SUGGESTION with_default_trait.unwrap_or_default();
|
2016-01-16 11:47:45 -06:00
|
|
|
|
|
2016-01-18 06:11:07 -06:00
|
|
|
|
let with_default_type = Some(1);
|
|
|
|
|
with_default_type.unwrap_or(u64::default());
|
2016-01-16 11:47:45 -06:00
|
|
|
|
//~^ERROR use of `unwrap_or`
|
|
|
|
|
//~|HELP try this
|
2016-01-18 06:11:07 -06:00
|
|
|
|
//~|SUGGESTION with_default_type.unwrap_or_default();
|
2016-01-16 11:47:45 -06:00
|
|
|
|
|
2016-01-18 06:11:07 -06:00
|
|
|
|
let with_vec = Some(vec![1]);
|
|
|
|
|
with_vec.unwrap_or(vec![]);
|
2016-01-16 11:47:45 -06:00
|
|
|
|
//~^ERROR use of `unwrap_or`
|
|
|
|
|
//~|HELP try this
|
2016-05-20 12:18:32 -05:00
|
|
|
|
// FIXME #944: ~|SUGGESTION with_vec.unwrap_or_else(|| vec![]);
|
2016-01-18 06:36:58 -06:00
|
|
|
|
|
|
|
|
|
let without_default = Some(Foo);
|
|
|
|
|
without_default.unwrap_or(Foo::new());
|
|
|
|
|
//~^ERROR use of `unwrap_or`
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION without_default.unwrap_or_else(Foo::new);
|
2016-01-19 17:53:26 -06:00
|
|
|
|
|
|
|
|
|
let mut map = HashMap::<u64, String>::new();
|
|
|
|
|
map.entry(42).or_insert(String::new());
|
|
|
|
|
//~^ERROR use of `or_insert` followed by a function call
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION map.entry(42).or_insert_with(String::new);
|
|
|
|
|
|
|
|
|
|
let mut btree = BTreeMap::<u64, String>::new();
|
|
|
|
|
btree.entry(42).or_insert(String::new());
|
|
|
|
|
//~^ERROR use of `or_insert` followed by a function call
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION btree.entry(42).or_insert_with(String::new);
|
2016-01-16 11:47:45 -06:00
|
|
|
|
}
|
|
|
|
|
|
2016-06-16 04:02:00 -05:00
|
|
|
|
/// Checks implementation of `ITER_NTH` lint
|
|
|
|
|
fn iter_nth() {
|
2016-06-16 16:30:05 -05:00
|
|
|
|
let mut some_vec = vec![0, 1, 2, 3];
|
|
|
|
|
let mut some_vec_deque: VecDeque<_> = some_vec.iter().cloned().collect();
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
// Make sure we lint `.iter()` for relevant types
|
|
|
|
|
let bad_vec = some_vec.iter().nth(3);
|
|
|
|
|
//~^ERROR called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
|
|
|
|
|
let bad_slice = &some_vec[..].iter().nth(3);
|
|
|
|
|
//~^ERROR called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
|
|
|
|
|
let bad_vec_deque = some_vec_deque.iter().nth(3);
|
|
|
|
|
//~^ERROR called `.iter().nth()` on a VecDeque. Calling `.get()` is both faster and more readable
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
// Make sure we lint `.iter_mut()` for relevant types
|
|
|
|
|
let bad_vec = some_vec.iter_mut().nth(3);
|
|
|
|
|
//~^ERROR called `.iter_mut().nth()` on a Vec. Calling `.get_mut()` is both faster and more readable
|
|
|
|
|
}
|
|
|
|
|
{
|
|
|
|
|
let bad_slice = &some_vec[..].iter_mut().nth(3);
|
|
|
|
|
//~^ERROR called `.iter_mut().nth()` on a slice. Calling `.get_mut()` is both faster and more readable
|
|
|
|
|
}
|
|
|
|
|
{
|
|
|
|
|
let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
|
|
|
|
|
//~^ERROR called `.iter_mut().nth()` on a VecDeque. Calling `.get_mut()` is both faster and more readable
|
|
|
|
|
}
|
2016-06-16 03:29:03 -05:00
|
|
|
|
|
2016-06-16 16:30:05 -05:00
|
|
|
|
// Make sure we don't lint for non-relevant types
|
2016-06-16 04:02:00 -05:00
|
|
|
|
let false_positive = HasIter;
|
|
|
|
|
let ok = false_positive.iter().nth(3);
|
2016-06-16 16:30:05 -05:00
|
|
|
|
let ok_mut = false_positive.iter_mut().nth(3);
|
2016-06-16 03:29:03 -05:00
|
|
|
|
}
|
|
|
|
|
|
2016-10-14 06:35:25 -05:00
|
|
|
|
/// Checks implementation of `ITER_SKIP_NEXT` lint
|
|
|
|
|
fn iter_skip_next() {
|
|
|
|
|
let mut some_vec = vec![0, 1, 2, 3];
|
|
|
|
|
|
|
|
|
|
let _ = some_vec.iter().skip(42).next();
|
|
|
|
|
//~^ERROR called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
|
|
|
|
|
|
|
|
|
|
let _ = some_vec.iter().cycle().skip(42).next();
|
|
|
|
|
//~^ERROR called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
|
|
|
|
|
|
|
|
|
|
let _ = (1..10).skip(10).next();
|
|
|
|
|
//~^ERROR called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
|
|
|
|
|
|
|
|
|
|
let _ = &some_vec[..].iter().skip(3).next();
|
|
|
|
|
//~^ERROR called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
|
|
|
|
|
|
|
|
|
|
let foo = IteratorFalsePositives { foo : 0 };
|
|
|
|
|
let _ = foo.skip(42).next();
|
|
|
|
|
let _ = foo.filter().skip(42).next();
|
|
|
|
|
}
|
|
|
|
|
|
2016-11-01 03:07:51 -05:00
|
|
|
|
struct GetFalsePositive {
|
|
|
|
|
arr: [u32; 3],
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl GetFalsePositive {
|
|
|
|
|
fn get(&self, pos: usize) -> Option<&u32> { self.arr.get(pos) }
|
|
|
|
|
fn get_mut(&mut self, pos: usize) -> Option<&mut u32> { self.arr.get_mut(pos) }
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Checks implementation of `GET_UNWRAP` lint
|
|
|
|
|
fn get_unwrap() {
|
|
|
|
|
let mut some_slice = &mut [0, 1, 2, 3];
|
|
|
|
|
let mut some_vec = vec![0, 1, 2, 3];
|
|
|
|
|
let mut some_vecdeque: VecDeque<_> = some_vec.iter().cloned().collect();
|
|
|
|
|
let mut some_hashmap: HashMap<u8, char> = HashMap::from_iter(vec![(1, 'a'), (2, 'b')]);
|
|
|
|
|
let mut some_btreemap: BTreeMap<u8, char> = BTreeMap::from_iter(vec![(1, 'a'), (2, 'b')]);
|
|
|
|
|
let mut false_positive = GetFalsePositive { arr: [0, 1, 2] };
|
|
|
|
|
|
|
|
|
|
{ // Test `get().unwrap()`
|
|
|
|
|
let _ = some_slice.get(0).unwrap();
|
|
|
|
|
//~^ERROR called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION some_slice[0]
|
|
|
|
|
let _ = some_vec.get(0).unwrap();
|
|
|
|
|
//~^ERROR called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION some_vec[0]
|
|
|
|
|
let _ = some_vecdeque.get(0).unwrap();
|
|
|
|
|
//~^ERROR called `.get().unwrap()` on a VecDeque. Using `[]` is more clear and more concise
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION some_vecdeque[0]
|
|
|
|
|
let _ = some_hashmap.get(&1).unwrap();
|
|
|
|
|
//~^ERROR called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION some_hashmap[&1]
|
|
|
|
|
let _ = some_btreemap.get(&1).unwrap();
|
|
|
|
|
//~^ERROR called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION some_btreemap[&1]
|
|
|
|
|
|
|
|
|
|
let _ = false_positive.get(0).unwrap();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{ // Test `get_mut().unwrap()`
|
|
|
|
|
*some_slice.get_mut(0).unwrap() = 1;
|
|
|
|
|
//~^ERROR called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise
|
|
|
|
|
//~|HELP try this
|
2016-11-01 19:33:43 -05:00
|
|
|
|
//~|SUGGESTION &mut some_slice[0]
|
2016-11-01 03:07:51 -05:00
|
|
|
|
*some_vec.get_mut(0).unwrap() = 1;
|
|
|
|
|
//~^ERROR called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
|
|
|
|
|
//~|HELP try this
|
2016-11-01 19:33:43 -05:00
|
|
|
|
//~|SUGGESTION &mut some_vec[0]
|
2016-11-01 03:07:51 -05:00
|
|
|
|
*some_vecdeque.get_mut(0).unwrap() = 1;
|
|
|
|
|
//~^ERROR called `.get_mut().unwrap()` on a VecDeque. Using `[]` is more clear and more concise
|
|
|
|
|
//~|HELP try this
|
2016-11-01 19:33:43 -05:00
|
|
|
|
//~|SUGGESTION &mut some_vecdeque[0]
|
2016-11-01 19:48:32 -05:00
|
|
|
|
|
|
|
|
|
// Check false positives
|
2016-11-01 03:07:51 -05:00
|
|
|
|
*some_hashmap.get_mut(&1).unwrap() = 'b';
|
|
|
|
|
*some_btreemap.get_mut(&1).unwrap() = 'b';
|
|
|
|
|
*false_positive.get_mut(0).unwrap() = 1;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-10-14 06:35:25 -05:00
|
|
|
|
|
2016-03-01 03:13:54 -06:00
|
|
|
|
#[allow(similar_names)]
|
2015-08-11 13:53:50 -05:00
|
|
|
|
fn main() {
|
2015-11-19 07:39:27 -06:00
|
|
|
|
use std::io;
|
|
|
|
|
|
2015-08-11 13:53:50 -05:00
|
|
|
|
let opt = Some(0);
|
2015-08-13 01:12:07 -05:00
|
|
|
|
let _ = opt.unwrap(); //~ERROR used unwrap() on an Option
|
2015-08-11 13:53:50 -05:00
|
|
|
|
|
|
|
|
|
let res: Result<i32, ()> = Ok(0);
|
2015-08-13 01:12:07 -05:00
|
|
|
|
let _ = res.unwrap(); //~ERROR used unwrap() on a Result
|
2015-08-12 10:02:49 -05:00
|
|
|
|
|
2015-11-19 07:39:27 -06:00
|
|
|
|
res.ok().expect("disaster!"); //~ERROR called `ok().expect()`
|
|
|
|
|
// the following should not warn, since `expect` isn't implemented unless
|
|
|
|
|
// the error type implements `Debug`
|
|
|
|
|
let res2: Result<i32, MyError> = Ok(0);
|
|
|
|
|
res2.ok().expect("oh noes!");
|
|
|
|
|
let res3: Result<u32, MyErrorWithParam<u8>>= Ok(0);
|
2016-02-12 18:38:55 -06:00
|
|
|
|
res3.ok().expect("whoof"); //~ERROR called `ok().expect()`
|
2015-11-19 07:39:27 -06:00
|
|
|
|
let res4: Result<u32, io::Error> = Ok(0);
|
|
|
|
|
res4.ok().expect("argh"); //~ERROR called `ok().expect()`
|
|
|
|
|
let res5: io::Result<u32> = Ok(0);
|
|
|
|
|
res5.ok().expect("oops"); //~ERROR called `ok().expect()`
|
2015-11-19 13:13:36 -06:00
|
|
|
|
let res6: Result<u32, &str> = Ok(0);
|
|
|
|
|
res6.ok().expect("meh"); //~ERROR called `ok().expect()`
|
2015-11-19 07:39:27 -06:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
struct MyError(()); // doesn't implement Debug
|
|
|
|
|
|
|
|
|
|
#[derive(Debug)]
|
|
|
|
|
struct MyErrorWithParam<T> {
|
|
|
|
|
x: T
|
2015-08-11 13:53:50 -05:00
|
|
|
|
}
|
2016-01-19 19:23:39 -06:00
|
|
|
|
|
2016-05-13 09:43:47 -05:00
|
|
|
|
#[allow(unnecessary_operation)]
|
2016-01-19 19:23:39 -06:00
|
|
|
|
fn starts_with() {
|
|
|
|
|
"".chars().next() == Some(' ');
|
|
|
|
|
//~^ ERROR starts_with
|
|
|
|
|
//~| HELP like this
|
|
|
|
|
//~| SUGGESTION "".starts_with(' ')
|
|
|
|
|
|
|
|
|
|
Some(' ') != "".chars().next();
|
|
|
|
|
//~^ ERROR starts_with
|
|
|
|
|
//~| HELP like this
|
|
|
|
|
//~| SUGGESTION !"".starts_with(' ')
|
|
|
|
|
}
|
2016-01-25 07:02:47 -06:00
|
|
|
|
|
|
|
|
|
fn use_extend_from_slice() {
|
|
|
|
|
let mut v : Vec<&'static str> = vec![];
|
2016-06-07 11:33:11 -05:00
|
|
|
|
v.extend(&["Hello", "World"]);
|
|
|
|
|
//~^ ERROR use of `extend`
|
|
|
|
|
//~| HELP try this
|
|
|
|
|
//~| SUGGESTION v.extend_from_slice(&["Hello", "World"]);
|
2016-01-27 13:13:15 -06:00
|
|
|
|
v.extend(&vec!["Some", "more"]);
|
2016-06-07 11:33:11 -05:00
|
|
|
|
//~^ ERROR use of `extend`
|
2016-01-27 13:13:15 -06:00
|
|
|
|
//~| HELP try this
|
|
|
|
|
//~| SUGGESTION v.extend_from_slice(&vec!["Some", "more"]);
|
2016-02-02 15:35:01 -06:00
|
|
|
|
|
2016-06-07 11:33:11 -05:00
|
|
|
|
v.extend(vec!["And", "even", "more"].iter());
|
|
|
|
|
//~^ ERROR use of `extend`
|
|
|
|
|
//~| HELP try this
|
|
|
|
|
//FIXME: the suggestion if broken because of the macro
|
2016-01-25 12:46:56 -06:00
|
|
|
|
let o : Option<&'static str> = None;
|
|
|
|
|
v.extend(o);
|
|
|
|
|
v.extend(Some("Bye"));
|
2016-01-26 16:51:06 -06:00
|
|
|
|
v.extend(vec!["Not", "like", "this"]);
|
2016-02-02 15:35:01 -06:00
|
|
|
|
v.extend(["But", "this"].iter());
|
2016-01-27 13:13:15 -06:00
|
|
|
|
//~^ERROR use of `extend
|
|
|
|
|
//~| HELP try this
|
|
|
|
|
//~| SUGGESTION v.extend_from_slice(&["But", "this"]);
|
2016-01-25 07:02:47 -06:00
|
|
|
|
}
|
2016-02-02 15:35:01 -06:00
|
|
|
|
|
2016-11-19 09:21:40 -06:00
|
|
|
|
fn str_extend_chars() {
|
|
|
|
|
let abc = "abc";
|
2016-11-19 09:36:23 -06:00
|
|
|
|
let def = String::from("def");
|
2016-11-19 09:21:40 -06:00
|
|
|
|
let mut s = String::new();
|
|
|
|
|
|
|
|
|
|
s.push_str(abc);
|
|
|
|
|
s.extend(abc.chars());
|
|
|
|
|
//~^ERROR calling `.extend(_.chars())`
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION s.push_str(abc)
|
|
|
|
|
|
|
|
|
|
s.push_str("abc");
|
|
|
|
|
s.extend("abc".chars());
|
|
|
|
|
//~^ERROR calling `.extend(_.chars())`
|
|
|
|
|
//~|HELP try this
|
|
|
|
|
//~|SUGGESTION s.push_str("abc")
|
|
|
|
|
|
2016-11-20 10:19:36 -06:00
|
|
|
|
s.push_str(&def);
|
2016-11-19 09:36:23 -06:00
|
|
|
|
s.extend(def.chars());
|
|
|
|
|
//~^ERROR calling `.extend(_.chars())`
|
|
|
|
|
//~|HELP try this
|
2016-11-20 10:19:36 -06:00
|
|
|
|
//~|SUGGESTION s.push_str(&def)
|
2016-11-19 09:36:23 -06:00
|
|
|
|
|
2016-11-19 09:21:40 -06:00
|
|
|
|
s.extend(abc.chars().skip(1));
|
|
|
|
|
s.extend("abc".chars().skip(1));
|
|
|
|
|
s.extend(['a', 'b', 'c'].iter());
|
|
|
|
|
|
|
|
|
|
let f = HasChars;
|
|
|
|
|
s.extend(f.chars());
|
|
|
|
|
}
|
|
|
|
|
|
2016-02-02 15:35:01 -06:00
|
|
|
|
fn clone_on_copy() {
|
|
|
|
|
42.clone(); //~ERROR using `clone` on a `Copy` type
|
2016-08-08 09:43:45 -05:00
|
|
|
|
//~| HELP try removing the `clone` call
|
|
|
|
|
//~| SUGGESTION 42
|
2016-02-02 15:35:01 -06:00
|
|
|
|
vec![1].clone(); // ok, not a Copy type
|
|
|
|
|
Some(vec![1]).clone(); // ok, not a Copy type
|
2016-08-08 09:43:45 -05:00
|
|
|
|
(&42).clone(); //~ERROR using `clone` on a `Copy` type
|
|
|
|
|
//~| HELP try dereferencing it
|
|
|
|
|
//~| SUGGESTION *(&42)
|
2016-02-02 15:35:01 -06:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn clone_on_copy_generic<T: Copy>(t: T) {
|
|
|
|
|
t.clone(); //~ERROR using `clone` on a `Copy` type
|
2016-08-08 09:43:45 -05:00
|
|
|
|
//~| HELP try removing the `clone` call
|
|
|
|
|
//~| SUGGESTION t
|
2016-02-02 15:35:01 -06:00
|
|
|
|
Some(t).clone(); //~ERROR using `clone` on a `Copy` type
|
2016-08-08 09:43:45 -05:00
|
|
|
|
//~| HELP try removing the `clone` call
|
|
|
|
|
//~| SUGGESTION Some(t)
|
2016-02-02 15:35:01 -06:00
|
|
|
|
}
|
2016-02-05 04:34:59 -06:00
|
|
|
|
|
|
|
|
|
fn clone_on_double_ref() {
|
|
|
|
|
let x = vec![1];
|
|
|
|
|
let y = &&x;
|
|
|
|
|
let z: &Vec<_> = y.clone(); //~ERROR using `clone` on a double
|
|
|
|
|
//~| HELP try dereferencing it
|
|
|
|
|
//~| SUGGESTION let z: &Vec<_> = (*y).clone();
|
|
|
|
|
println!("{:p} {:p}",*y, z);
|
|
|
|
|
}
|
2016-02-14 21:40:43 -06:00
|
|
|
|
|
|
|
|
|
fn single_char_pattern() {
|
|
|
|
|
let x = "foo";
|
|
|
|
|
x.split("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.split('x');
|
|
|
|
|
|
|
|
|
|
x.split("xx");
|
|
|
|
|
|
|
|
|
|
x.split('x');
|
|
|
|
|
|
|
|
|
|
let y = "x";
|
|
|
|
|
x.split(y);
|
|
|
|
|
|
|
|
|
|
// Not yet testing for multi-byte characters
|
|
|
|
|
// Changing `r.len() == 1` to `r.chars().count() == 1` in `lint_single_char_pattern`
|
|
|
|
|
// should have done this but produced an ICE
|
2016-02-15 12:36:10 -06:00
|
|
|
|
//
|
|
|
|
|
// We may not want to suggest changing these anyway
|
|
|
|
|
// See: https://github.com/Manishearth/rust-clippy/issues/650#issuecomment-184328984
|
2016-02-14 21:40:43 -06:00
|
|
|
|
x.split("ß");
|
|
|
|
|
x.split("ℝ");
|
|
|
|
|
x.split("💣");
|
|
|
|
|
// Can't use this lint for unicode code points which don't fit in a char
|
|
|
|
|
x.split("❤️");
|
|
|
|
|
|
|
|
|
|
x.contains("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.contains('x');
|
|
|
|
|
x.starts_with("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.starts_with('x');
|
|
|
|
|
x.ends_with("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.ends_with('x');
|
|
|
|
|
x.find("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.find('x');
|
|
|
|
|
x.rfind("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.rfind('x');
|
|
|
|
|
x.rsplit("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.rsplit('x');
|
|
|
|
|
x.split_terminator("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.split_terminator('x');
|
|
|
|
|
x.rsplit_terminator("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.rsplit_terminator('x');
|
|
|
|
|
x.splitn(0, "x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.splitn(0, 'x');
|
|
|
|
|
x.rsplitn(0, "x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.rsplitn(0, 'x');
|
|
|
|
|
x.matches("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.matches('x');
|
|
|
|
|
x.rmatches("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.rmatches('x');
|
|
|
|
|
x.match_indices("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.match_indices('x');
|
|
|
|
|
x.rmatch_indices("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.rmatch_indices('x');
|
|
|
|
|
x.trim_left_matches("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.trim_left_matches('x');
|
|
|
|
|
x.trim_right_matches("x");
|
|
|
|
|
//~^ ERROR single-character string constant used as pattern
|
|
|
|
|
//~| HELP try using a char instead:
|
|
|
|
|
//~| SUGGESTION x.trim_right_matches('x');
|
2016-04-20 14:09:38 -05:00
|
|
|
|
|
|
|
|
|
let h = HashSet::<String>::new();
|
|
|
|
|
h.contains("X"); // should not warn
|
2016-02-15 12:36:10 -06:00
|
|
|
|
}
|
2016-04-14 10:25:31 -05:00
|
|
|
|
|
|
|
|
|
#[allow(result_unwrap_used)]
|
|
|
|
|
fn temporary_cstring() {
|
|
|
|
|
use std::ffi::CString;
|
|
|
|
|
|
2016-05-23 09:34:09 -05:00
|
|
|
|
CString::new("foo").unwrap().as_ptr();
|
2016-04-14 10:25:31 -05:00
|
|
|
|
//~^ ERROR you are getting the inner pointer of a temporary `CString`
|
|
|
|
|
//~| NOTE that pointer will be invalid outside this expression
|
2016-05-23 09:34:09 -05:00
|
|
|
|
//~| HELP assign the `CString` to a variable to extend its lifetime
|
2016-04-14 10:25:31 -05:00
|
|
|
|
}
|