Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
//! A pass that annotates every item and method with its stability level,
|
|
|
|
//! propagating default levels lexically from parent to children ast nodes.
|
|
|
|
|
2020-01-07 10:25:33 -06:00
|
|
|
use rustc::hir::map::Map;
|
2019-12-29 04:20:20 -06:00
|
|
|
use rustc::lint;
|
|
|
|
use rustc::middle::privacy::AccessLevels;
|
|
|
|
use rustc::middle::stability::{DeprecationEntry, Index};
|
2020-01-02 05:42:42 -06:00
|
|
|
use rustc::session::parse::feature_err;
|
2019-12-29 04:20:20 -06:00
|
|
|
use rustc::session::Session;
|
2020-01-07 12:36:50 -06:00
|
|
|
use rustc::traits::misc::can_type_implement_copy;
|
2019-12-29 04:20:20 -06:00
|
|
|
use rustc::ty::query::Providers;
|
|
|
|
use rustc::ty::TyCtxt;
|
2020-01-11 06:15:20 -06:00
|
|
|
use rustc_attr::{self as attr, Stability};
|
2019-12-23 22:02:53 -06:00
|
|
|
use rustc_data_structures::fx::{FxHashMap, FxHashSet};
|
2020-01-09 04:18:47 -06:00
|
|
|
use rustc_errors::struct_span_err;
|
2020-01-04 19:37:57 -06:00
|
|
|
use rustc_hir as hir;
|
|
|
|
use rustc_hir::def::{DefKind, Res};
|
|
|
|
use rustc_hir::def_id::{DefId, CRATE_DEF_INDEX, LOCAL_CRATE};
|
2020-01-07 11:12:06 -06:00
|
|
|
use rustc_hir::intravisit::{self, NestedVisitorMap, Visitor};
|
2020-01-04 19:37:57 -06:00
|
|
|
use rustc_hir::{Generics, HirId, Item, StructField, Variant};
|
2020-01-01 12:30:57 -06:00
|
|
|
use rustc_span::symbol::{sym, Symbol};
|
2019-12-29 04:20:20 -06:00
|
|
|
use rustc_span::Span;
|
|
|
|
use syntax::ast::Attribute;
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
|
2015-06-11 19:18:46 -05:00
|
|
|
use std::cmp::Ordering;
|
2019-11-11 11:33:30 -06:00
|
|
|
use std::mem::replace;
|
|
|
|
use std::num::NonZeroU32;
|
2014-09-12 05:10:30 -05:00
|
|
|
|
2015-11-16 10:53:41 -06:00
|
|
|
#[derive(PartialEq)]
|
|
|
|
enum AnnotationKind {
|
|
|
|
// Annotation is required if not inherited from unstable parents
|
2015-11-16 12:01:06 -06:00
|
|
|
Required,
|
2015-11-16 10:53:41 -06:00
|
|
|
// Annotation is useless, reject it
|
2015-11-16 12:01:06 -06:00
|
|
|
Prohibited,
|
2015-11-16 10:53:41 -06:00
|
|
|
// Annotation itself is useless, but it can be propagated to children
|
2015-11-16 12:01:06 -06:00
|
|
|
Container,
|
2015-11-16 10:53:41 -06:00
|
|
|
}
|
|
|
|
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
// A private tree-walker for producing an Index.
|
2019-06-14 11:39:39 -05:00
|
|
|
struct Annotator<'a, 'tcx> {
|
2019-06-13 16:48:52 -05:00
|
|
|
tcx: TyCtxt<'tcx>,
|
2015-05-25 16:41:27 -05:00
|
|
|
index: &'a mut Index<'tcx>,
|
2015-12-04 10:34:28 -06:00
|
|
|
parent_stab: Option<&'tcx Stability>,
|
2016-08-04 08:18:36 -05:00
|
|
|
parent_depr: Option<DeprecationEntry>,
|
2015-11-16 10:53:41 -06:00
|
|
|
in_trait_impl: bool,
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
}
|
|
|
|
|
2019-06-14 11:39:39 -05:00
|
|
|
impl<'a, 'tcx> Annotator<'a, 'tcx> {
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
// Determine the stability for a node based on its attributes and inherited
|
2014-09-12 05:10:30 -05:00
|
|
|
// stability. The stability is recorded in the index and used as the parent.
|
2019-12-22 16:42:04 -06:00
|
|
|
fn annotate<F>(
|
|
|
|
&mut self,
|
|
|
|
hir_id: HirId,
|
|
|
|
attrs: &[Attribute],
|
|
|
|
item_sp: Span,
|
|
|
|
kind: AnnotationKind,
|
|
|
|
visit_children: F,
|
|
|
|
) where
|
|
|
|
F: FnOnce(&mut Self),
|
2014-12-08 19:26:43 -06:00
|
|
|
{
|
2018-02-14 09:11:02 -06:00
|
|
|
if self.tcx.features().staged_api {
|
2017-08-20 09:49:03 -05:00
|
|
|
// This crate explicitly wants staged API.
|
2019-02-18 08:35:20 -06:00
|
|
|
debug!("annotate(id = {:?}, attrs = {:?})", hir_id, attrs);
|
2018-10-09 06:49:18 -05:00
|
|
|
if let Some(..) = attr::find_deprecation(&self.tcx.sess.parse_sess, attrs, item_sp) {
|
2019-12-22 16:42:04 -06:00
|
|
|
self.tcx.sess.span_err(
|
|
|
|
item_sp,
|
|
|
|
"`#[deprecated]` cannot be used in staged API; \
|
|
|
|
use `#[rustc_deprecated]` instead",
|
|
|
|
);
|
2015-12-04 10:34:28 -06:00
|
|
|
}
|
2019-12-22 16:42:04 -06:00
|
|
|
let (stab, const_stab) =
|
|
|
|
attr::find_stability(&self.tcx.sess.parse_sess, attrs, item_sp);
|
2019-12-07 18:43:10 -06:00
|
|
|
if let Some(const_stab) = const_stab {
|
|
|
|
let const_stab = self.tcx.intern_const_stability(const_stab);
|
|
|
|
self.index.const_stab_map.insert(hir_id, const_stab);
|
|
|
|
}
|
|
|
|
if let Some(mut stab) = stab {
|
2019-02-28 16:43:53 -06:00
|
|
|
// Error if prohibited, or can't inherit anything from a container.
|
2019-12-22 16:42:04 -06:00
|
|
|
if kind == AnnotationKind::Prohibited
|
|
|
|
|| (kind == AnnotationKind::Container
|
|
|
|
&& stab.level.is_stable()
|
|
|
|
&& stab.rustc_depr.is_none())
|
|
|
|
{
|
2015-11-16 10:53:41 -06:00
|
|
|
self.tcx.sess.span_err(item_sp, "This stability annotation is useless");
|
|
|
|
}
|
2015-06-06 17:52:28 -05:00
|
|
|
|
2015-11-16 10:53:41 -06:00
|
|
|
debug!("annotate: found {:?}", stab);
|
|
|
|
// If parent is deprecated and we're not, inherit this by merging
|
|
|
|
// deprecated_since and its reason.
|
2015-12-04 10:34:28 -06:00
|
|
|
if let Some(parent_stab) = self.parent_stab {
|
|
|
|
if parent_stab.rustc_depr.is_some() && stab.rustc_depr.is_none() {
|
2020-01-16 16:15:52 -06:00
|
|
|
stab.rustc_depr = parent_stab.rustc_depr
|
2015-11-16 10:53:41 -06:00
|
|
|
}
|
|
|
|
}
|
2015-06-11 19:18:46 -05:00
|
|
|
|
2015-11-16 10:53:41 -06:00
|
|
|
let stab = self.tcx.intern_stability(stab);
|
|
|
|
|
|
|
|
// Check if deprecated_since < stable_since. If it is,
|
|
|
|
// this is *almost surely* an accident.
|
2019-12-22 16:42:04 -06:00
|
|
|
if let (
|
|
|
|
&Some(attr::RustcDeprecation { since: dep_since, .. }),
|
|
|
|
&attr::Stable { since: stab_since },
|
|
|
|
) = (&stab.rustc_depr, &stab.level)
|
|
|
|
{
|
2015-11-16 10:53:41 -06:00
|
|
|
// Explicit version of iter::order::lt to handle parse errors properly
|
2019-12-22 16:42:04 -06:00
|
|
|
for (dep_v, stab_v) in
|
|
|
|
dep_since.as_str().split('.').zip(stab_since.as_str().split('.'))
|
2018-10-02 11:29:48 -05:00
|
|
|
{
|
2015-11-16 10:53:41 -06:00
|
|
|
if let (Ok(dep_v), Ok(stab_v)) = (dep_v.parse::<u64>(), stab_v.parse()) {
|
|
|
|
match dep_v.cmp(&stab_v) {
|
|
|
|
Ordering::Less => {
|
2019-12-22 16:42:04 -06:00
|
|
|
self.tcx.sess.span_err(
|
|
|
|
item_sp,
|
|
|
|
"An API can't be stabilized \
|
|
|
|
after it is deprecated",
|
|
|
|
);
|
|
|
|
break;
|
2015-06-11 19:18:46 -05:00
|
|
|
}
|
2015-11-16 10:53:41 -06:00
|
|
|
Ordering::Equal => continue,
|
|
|
|
Ordering::Greater => break,
|
2015-06-11 19:18:46 -05:00
|
|
|
}
|
2015-11-16 10:53:41 -06:00
|
|
|
} else {
|
|
|
|
// Act like it isn't less because the question is now nonsensical,
|
|
|
|
// and this makes us not do anything else interesting.
|
2019-12-22 16:42:04 -06:00
|
|
|
self.tcx.sess.span_err(
|
|
|
|
item_sp,
|
|
|
|
"Invalid stability or deprecation \
|
|
|
|
version found",
|
|
|
|
);
|
|
|
|
break;
|
2015-11-16 10:53:41 -06:00
|
|
|
}
|
2015-06-11 19:18:46 -05:00
|
|
|
}
|
2015-11-16 10:53:41 -06:00
|
|
|
}
|
2015-06-11 19:18:46 -05:00
|
|
|
|
2017-08-31 17:08:34 -05:00
|
|
|
self.index.stab_map.insert(hir_id, stab);
|
2015-11-16 10:53:41 -06:00
|
|
|
|
2015-12-04 10:34:28 -06:00
|
|
|
let orig_parent_stab = replace(&mut self.parent_stab, Some(stab));
|
2015-11-16 10:53:41 -06:00
|
|
|
visit_children(self);
|
2015-12-04 10:34:28 -06:00
|
|
|
self.parent_stab = orig_parent_stab;
|
2015-11-16 10:53:41 -06:00
|
|
|
} else {
|
2015-12-04 10:34:28 -06:00
|
|
|
debug!("annotate: not found, parent = {:?}", self.parent_stab);
|
|
|
|
if let Some(stab) = self.parent_stab {
|
2015-11-16 10:53:41 -06:00
|
|
|
if stab.level.is_unstable() {
|
2017-08-31 17:08:34 -05:00
|
|
|
self.index.stab_map.insert(hir_id, stab);
|
2015-04-13 20:42:24 -05:00
|
|
|
}
|
|
|
|
}
|
2015-11-16 10:53:41 -06:00
|
|
|
visit_children(self);
|
2014-09-12 05:10:30 -05:00
|
|
|
}
|
2015-04-13 20:42:24 -05:00
|
|
|
} else {
|
2015-11-16 10:53:41 -06:00
|
|
|
// Emit errors for non-staged-api crates.
|
2019-12-04 15:00:28 -06:00
|
|
|
let unstable_attrs = [
|
2019-12-22 16:42:04 -06:00
|
|
|
sym::unstable,
|
|
|
|
sym::stable,
|
2019-12-04 15:00:28 -06:00
|
|
|
sym::rustc_deprecated,
|
|
|
|
sym::rustc_const_unstable,
|
2019-12-07 18:43:10 -06:00
|
|
|
sym::rustc_const_stable,
|
2019-12-04 15:00:28 -06:00
|
|
|
];
|
2015-04-13 20:42:24 -05:00
|
|
|
for attr in attrs {
|
2019-03-17 06:17:47 -05:00
|
|
|
let name = attr.name_or_empty();
|
2019-12-04 15:00:28 -06:00
|
|
|
if unstable_attrs.contains(&name) {
|
2019-03-17 06:17:47 -05:00
|
|
|
attr::mark_used(attr);
|
2019-09-25 06:23:53 -05:00
|
|
|
struct_span_err!(
|
|
|
|
self.tcx.sess,
|
|
|
|
attr.span,
|
|
|
|
E0734,
|
|
|
|
"stability attributes may not be used outside of the standard library",
|
2019-12-22 16:42:04 -06:00
|
|
|
)
|
|
|
|
.emit();
|
2014-12-17 22:12:41 -06:00
|
|
|
}
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
}
|
2015-12-04 10:34:28 -06:00
|
|
|
|
2017-08-20 09:49:03 -05:00
|
|
|
// Propagate unstability. This can happen even for non-staged-api crates in case
|
|
|
|
// -Zforce-unstable-if-unmarked is set.
|
|
|
|
if let Some(stab) = self.parent_stab {
|
|
|
|
if stab.level.is_unstable() {
|
2017-08-31 17:08:34 -05:00
|
|
|
self.index.stab_map.insert(hir_id, stab);
|
2017-08-20 09:49:03 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-10-09 06:49:18 -05:00
|
|
|
if let Some(depr) = attr::find_deprecation(&self.tcx.sess.parse_sess, attrs, item_sp) {
|
2015-12-04 10:34:28 -06:00
|
|
|
if kind == AnnotationKind::Prohibited {
|
|
|
|
self.tcx.sess.span_err(item_sp, "This deprecation annotation is useless");
|
|
|
|
}
|
|
|
|
|
|
|
|
// `Deprecation` is just two pointers, no need to intern it
|
2017-08-31 17:08:34 -05:00
|
|
|
let depr_entry = DeprecationEntry::local(depr, hir_id);
|
|
|
|
self.index.depr_map.insert(hir_id, depr_entry.clone());
|
2015-12-04 10:34:28 -06:00
|
|
|
|
2019-12-22 16:42:04 -06:00
|
|
|
let orig_parent_depr = replace(&mut self.parent_depr, Some(depr_entry));
|
2015-12-04 10:34:28 -06:00
|
|
|
visit_children(self);
|
|
|
|
self.parent_depr = orig_parent_depr;
|
2017-08-31 17:08:34 -05:00
|
|
|
} else if let Some(parent_depr) = self.parent_depr.clone() {
|
|
|
|
self.index.depr_map.insert(hir_id, parent_depr);
|
2015-12-04 10:34:28 -06:00
|
|
|
visit_children(self);
|
|
|
|
} else {
|
|
|
|
visit_children(self);
|
|
|
|
}
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-11-09 15:45:26 -06:00
|
|
|
impl<'a, 'tcx> Visitor<'tcx> for Annotator<'a, 'tcx> {
|
2015-11-17 17:56:13 -06:00
|
|
|
/// Because stability levels are scoped lexically, we want to walk
|
|
|
|
/// nested items in the context of the outer item, so enable
|
|
|
|
/// deep-walking.
|
2020-01-07 10:25:33 -06:00
|
|
|
type Map = Map<'tcx>;
|
|
|
|
|
|
|
|
fn nested_visit_map(&mut self) -> NestedVisitorMap<'_, Self::Map> {
|
2018-12-04 06:45:36 -06:00
|
|
|
NestedVisitorMap::All(&self.tcx.hir())
|
2016-11-04 17:20:15 -05:00
|
|
|
}
|
|
|
|
|
2019-11-28 12:28:50 -06:00
|
|
|
fn visit_item(&mut self, i: &'tcx Item<'tcx>) {
|
2015-11-16 10:53:41 -06:00
|
|
|
let orig_in_trait_impl = self.in_trait_impl;
|
2015-11-16 12:01:06 -06:00
|
|
|
let mut kind = AnnotationKind::Required;
|
2019-09-26 11:51:36 -05:00
|
|
|
match i.kind {
|
2015-11-16 10:53:41 -06:00
|
|
|
// Inherent impls and foreign modules serve only as containers for other items,
|
|
|
|
// they don't have their own stability. They still can be annotated as unstable
|
|
|
|
// and propagate this unstability to children, but this annotation is completely
|
|
|
|
// optional. They inherit stability from their parents when unannotated.
|
2020-01-17 18:14:29 -06:00
|
|
|
hir::ItemKind::Impl { of_trait: None, .. } | hir::ItemKind::ForeignMod(..) => {
|
2015-11-16 10:53:41 -06:00
|
|
|
self.in_trait_impl = false;
|
2015-11-16 12:01:06 -06:00
|
|
|
kind = AnnotationKind::Container;
|
2015-11-16 10:53:41 -06:00
|
|
|
}
|
2020-01-17 18:14:29 -06:00
|
|
|
hir::ItemKind::Impl { of_trait: Some(_), .. } => {
|
2015-11-16 10:53:41 -06:00
|
|
|
self.in_trait_impl = true;
|
2015-10-01 19:53:28 -05:00
|
|
|
}
|
2018-07-11 10:36:06 -05:00
|
|
|
hir::ItemKind::Struct(ref sd, _) => {
|
2019-03-21 17:38:50 -05:00
|
|
|
if let Some(ctor_hir_id) = sd.ctor_hir_id() {
|
|
|
|
self.annotate(ctor_hir_id, &i.attrs, i.span, AnnotationKind::Required, |_| {})
|
2015-11-16 10:53:41 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
_ => {}
|
2014-11-11 14:46:47 -06:00
|
|
|
}
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
|
2019-12-22 16:42:04 -06:00
|
|
|
self.annotate(i.hir_id, &i.attrs, i.span, kind, |v| intravisit::walk_item(v, i));
|
2015-11-16 10:53:41 -06:00
|
|
|
self.in_trait_impl = orig_in_trait_impl;
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
}
|
|
|
|
|
2019-11-28 14:47:10 -06:00
|
|
|
fn visit_trait_item(&mut self, ti: &'tcx hir::TraitItem<'tcx>) {
|
2019-02-18 08:35:20 -06:00
|
|
|
self.annotate(ti.hir_id, &ti.attrs, ti.span, AnnotationKind::Required, |v| {
|
2015-11-17 17:56:13 -06:00
|
|
|
intravisit::walk_trait_item(v, ti);
|
2015-11-16 10:53:41 -06:00
|
|
|
});
|
2015-03-10 05:28:44 -05:00
|
|
|
}
|
2014-08-05 21:44:21 -05:00
|
|
|
|
2019-11-28 15:16:44 -06:00
|
|
|
fn visit_impl_item(&mut self, ii: &'tcx hir::ImplItem<'tcx>) {
|
2019-12-22 16:42:04 -06:00
|
|
|
let kind =
|
|
|
|
if self.in_trait_impl { AnnotationKind::Prohibited } else { AnnotationKind::Required };
|
2019-02-18 08:35:20 -06:00
|
|
|
self.annotate(ii.hir_id, &ii.attrs, ii.span, kind, |v| {
|
2015-11-17 17:56:13 -06:00
|
|
|
intravisit::walk_impl_item(v, ii);
|
2015-11-16 10:53:41 -06:00
|
|
|
});
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
}
|
|
|
|
|
2019-11-30 10:46:46 -06:00
|
|
|
fn visit_variant(&mut self, var: &'tcx Variant<'tcx>, g: &'tcx Generics<'tcx>, item_id: HirId) {
|
2019-12-22 16:42:04 -06:00
|
|
|
self.annotate(var.id, &var.attrs, var.span, AnnotationKind::Required, |v| {
|
|
|
|
if let Some(ctor_hir_id) = var.data.ctor_hir_id() {
|
|
|
|
v.annotate(ctor_hir_id, &var.attrs, var.span, AnnotationKind::Required, |_| {});
|
|
|
|
}
|
2019-03-21 17:38:50 -05:00
|
|
|
|
2019-12-22 16:42:04 -06:00
|
|
|
intravisit::walk_variant(v, var, g, item_id)
|
|
|
|
})
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
}
|
|
|
|
|
2019-11-29 02:40:33 -06:00
|
|
|
fn visit_struct_field(&mut self, s: &'tcx StructField<'tcx>) {
|
2019-02-18 08:35:20 -06:00
|
|
|
self.annotate(s.hir_id, &s.attrs, s.span, AnnotationKind::Required, |v| {
|
2015-11-17 17:56:13 -06:00
|
|
|
intravisit::walk_struct_field(v, s);
|
2015-11-16 10:53:41 -06:00
|
|
|
});
|
2014-07-10 13:17:40 -05:00
|
|
|
}
|
2014-12-20 12:08:16 -06:00
|
|
|
|
2019-11-28 13:18:29 -06:00
|
|
|
fn visit_foreign_item(&mut self, i: &'tcx hir::ForeignItem<'tcx>) {
|
2019-02-18 08:35:20 -06:00
|
|
|
self.annotate(i.hir_id, &i.attrs, i.span, AnnotationKind::Required, |v| {
|
2015-11-17 17:56:13 -06:00
|
|
|
intravisit::walk_foreign_item(v, i);
|
2015-11-16 10:53:41 -06:00
|
|
|
});
|
|
|
|
}
|
|
|
|
|
2019-11-28 16:50:47 -06:00
|
|
|
fn visit_macro_def(&mut self, md: &'tcx hir::MacroDef<'tcx>) {
|
2019-02-18 08:35:20 -06:00
|
|
|
self.annotate(md.hir_id, &md.attrs, md.span, AnnotationKind::Required, |_| {});
|
2014-12-20 12:08:16 -06:00
|
|
|
}
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
}
|
|
|
|
|
2019-06-14 11:39:39 -05:00
|
|
|
struct MissingStabilityAnnotations<'a, 'tcx> {
|
2019-06-13 16:48:52 -05:00
|
|
|
tcx: TyCtxt<'tcx>,
|
2016-11-10 11:08:21 -06:00
|
|
|
access_levels: &'a AccessLevels,
|
|
|
|
}
|
|
|
|
|
2019-06-14 11:39:39 -05:00
|
|
|
impl<'a, 'tcx> MissingStabilityAnnotations<'a, 'tcx> {
|
2019-02-18 08:35:20 -06:00
|
|
|
fn check_missing_stability(&self, hir_id: HirId, span: Span, name: &str) {
|
2017-08-31 17:08:34 -05:00
|
|
|
let stab = self.tcx.stability().local_stability(hir_id);
|
2019-12-22 16:42:04 -06:00
|
|
|
let is_error =
|
|
|
|
!self.tcx.sess.opts.test && stab.is_none() && self.access_levels.is_reachable(hir_id);
|
2016-11-10 11:08:21 -06:00
|
|
|
if is_error {
|
2019-12-22 16:42:04 -06:00
|
|
|
self.tcx.sess.span_err(span, &format!("{} has missing stability attribute", name));
|
2016-11-10 11:08:21 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-11-28 11:10:37 -06:00
|
|
|
impl<'a, 'tcx> Visitor<'tcx> for MissingStabilityAnnotations<'a, 'tcx> {
|
2020-01-07 10:25:33 -06:00
|
|
|
type Map = Map<'tcx>;
|
|
|
|
|
|
|
|
fn nested_visit_map(&mut self) -> NestedVisitorMap<'_, Self::Map> {
|
2018-12-04 06:45:36 -06:00
|
|
|
NestedVisitorMap::OnlyBodies(&self.tcx.hir())
|
2016-11-28 11:10:37 -06:00
|
|
|
}
|
|
|
|
|
2019-11-28 12:28:50 -06:00
|
|
|
fn visit_item(&mut self, i: &'tcx Item<'tcx>) {
|
2019-09-26 11:51:36 -05:00
|
|
|
match i.kind {
|
2016-11-10 11:08:21 -06:00
|
|
|
// Inherent impls and foreign modules serve only as containers for other items,
|
|
|
|
// they don't have their own stability. They still can be annotated as unstable
|
|
|
|
// and propagate this unstability to children, but this annotation is completely
|
|
|
|
// optional. They inherit stability from their parents when unannotated.
|
2020-01-17 18:14:29 -06:00
|
|
|
hir::ItemKind::Impl { of_trait: None, .. } | hir::ItemKind::ForeignMod(..) => {}
|
2016-11-10 11:08:21 -06:00
|
|
|
|
2019-12-22 16:42:04 -06:00
|
|
|
_ => self.check_missing_stability(i.hir_id, i.span, i.kind.descriptive_variant()),
|
2016-11-10 11:08:21 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
intravisit::walk_item(self, i)
|
|
|
|
}
|
|
|
|
|
2019-11-28 14:47:10 -06:00
|
|
|
fn visit_trait_item(&mut self, ti: &'tcx hir::TraitItem<'tcx>) {
|
2019-02-18 08:35:20 -06:00
|
|
|
self.check_missing_stability(ti.hir_id, ti.span, "item");
|
2016-11-10 11:08:21 -06:00
|
|
|
intravisit::walk_trait_item(self, ti);
|
|
|
|
}
|
|
|
|
|
2019-11-28 15:16:44 -06:00
|
|
|
fn visit_impl_item(&mut self, ii: &'tcx hir::ImplItem<'tcx>) {
|
2019-12-22 16:42:04 -06:00
|
|
|
let impl_def_id = self.tcx.hir().local_def_id(self.tcx.hir().get_parent_item(ii.hir_id));
|
2016-11-10 11:08:21 -06:00
|
|
|
if self.tcx.impl_trait_ref(impl_def_id).is_none() {
|
2019-02-18 08:35:20 -06:00
|
|
|
self.check_missing_stability(ii.hir_id, ii.span, "item");
|
2016-11-10 11:08:21 -06:00
|
|
|
}
|
|
|
|
intravisit::walk_impl_item(self, ii);
|
|
|
|
}
|
|
|
|
|
2019-11-30 10:46:46 -06:00
|
|
|
fn visit_variant(&mut self, var: &'tcx Variant<'tcx>, g: &'tcx Generics<'tcx>, item_id: HirId) {
|
2019-08-13 19:40:21 -05:00
|
|
|
self.check_missing_stability(var.id, var.span, "variant");
|
2016-11-10 11:08:21 -06:00
|
|
|
intravisit::walk_variant(self, var, g, item_id);
|
|
|
|
}
|
|
|
|
|
2019-11-29 02:40:33 -06:00
|
|
|
fn visit_struct_field(&mut self, s: &'tcx StructField<'tcx>) {
|
2019-02-18 08:35:20 -06:00
|
|
|
self.check_missing_stability(s.hir_id, s.span, "field");
|
2016-11-10 11:08:21 -06:00
|
|
|
intravisit::walk_struct_field(self, s);
|
|
|
|
}
|
|
|
|
|
2019-11-28 13:18:29 -06:00
|
|
|
fn visit_foreign_item(&mut self, i: &'tcx hir::ForeignItem<'tcx>) {
|
2019-09-26 11:58:14 -05:00
|
|
|
self.check_missing_stability(i.hir_id, i.span, i.kind.descriptive_variant());
|
2016-11-10 11:08:21 -06:00
|
|
|
intravisit::walk_foreign_item(self, i);
|
|
|
|
}
|
|
|
|
|
2019-11-28 16:50:47 -06:00
|
|
|
fn visit_macro_def(&mut self, md: &'tcx hir::MacroDef<'tcx>) {
|
2019-02-18 08:35:20 -06:00
|
|
|
self.check_missing_stability(md.hir_id, md.span, "macro");
|
2016-11-10 11:08:21 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-12-29 04:20:20 -06:00
|
|
|
fn new_index(tcx: TyCtxt<'tcx>) -> Index<'tcx> {
|
|
|
|
let is_staged_api =
|
|
|
|
tcx.sess.opts.debugging_opts.force_unstable_if_unmarked || tcx.features().staged_api;
|
|
|
|
let mut staged_api = FxHashMap::default();
|
|
|
|
staged_api.insert(LOCAL_CRATE, is_staged_api);
|
|
|
|
let mut index = Index {
|
|
|
|
staged_api,
|
|
|
|
stab_map: Default::default(),
|
|
|
|
const_stab_map: Default::default(),
|
|
|
|
depr_map: Default::default(),
|
|
|
|
active_features: Default::default(),
|
|
|
|
};
|
2017-08-31 17:08:34 -05:00
|
|
|
|
2019-12-29 04:20:20 -06:00
|
|
|
let active_lib_features = &tcx.features().declared_lib_features;
|
|
|
|
let active_lang_features = &tcx.features().declared_lang_features;
|
2017-05-08 15:36:26 -05:00
|
|
|
|
2019-12-29 04:20:20 -06:00
|
|
|
// Put the active features into a map for quick lookup.
|
|
|
|
index.active_features = active_lib_features
|
|
|
|
.iter()
|
2020-01-22 09:30:15 -06:00
|
|
|
.map(|&(s, ..)| s)
|
|
|
|
.chain(active_lang_features.iter().map(|&(s, ..)| s))
|
2019-12-29 04:20:20 -06:00
|
|
|
.collect();
|
2017-05-08 15:36:26 -05:00
|
|
|
|
2019-12-29 04:20:20 -06:00
|
|
|
{
|
|
|
|
let krate = tcx.hir().krate();
|
|
|
|
let mut annotator = Annotator {
|
|
|
|
tcx,
|
|
|
|
index: &mut index,
|
|
|
|
parent_stab: None,
|
|
|
|
parent_depr: None,
|
|
|
|
in_trait_impl: false,
|
|
|
|
};
|
2015-02-03 09:46:08 -06:00
|
|
|
|
2019-12-29 04:20:20 -06:00
|
|
|
// If the `-Z force-unstable-if-unmarked` flag is passed then we provide
|
|
|
|
// a parent stability annotation which indicates that this is private
|
|
|
|
// with the `rustc_private` feature. This is intended for use when
|
|
|
|
// compiling librustc crates themselves so we can leverage crates.io
|
|
|
|
// while maintaining the invariant that all sysroot crates are unstable
|
|
|
|
// by default and are unable to be used.
|
|
|
|
if tcx.sess.opts.debugging_opts.force_unstable_if_unmarked {
|
|
|
|
let reason = "this crate is being loaded from the sysroot, an \
|
|
|
|
unstable location; did you mean to load this crate \
|
|
|
|
from crates.io via `Cargo.toml` instead?";
|
|
|
|
let stability = tcx.intern_stability(Stability {
|
|
|
|
level: attr::StabilityLevel::Unstable {
|
|
|
|
reason: Some(Symbol::intern(reason)),
|
|
|
|
issue: NonZeroU32::new(27812),
|
|
|
|
is_soft: false,
|
|
|
|
},
|
|
|
|
feature: sym::rustc_private,
|
|
|
|
rustc_depr: None,
|
|
|
|
});
|
|
|
|
annotator.parent_stab = Some(stability);
|
|
|
|
}
|
2019-12-07 18:43:10 -06:00
|
|
|
|
2019-12-29 04:20:20 -06:00
|
|
|
annotator.annotate(
|
|
|
|
hir::CRATE_HIR_ID,
|
|
|
|
&krate.attrs,
|
|
|
|
krate.span,
|
|
|
|
AnnotationKind::Required,
|
|
|
|
|v| intravisit::walk_crate(v, krate),
|
|
|
|
);
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
}
|
2019-12-29 04:20:20 -06:00
|
|
|
return index;
|
2014-06-26 13:37:39 -05:00
|
|
|
}
|
Add stability inheritance
This commit makes several changes to the stability index infrastructure:
* Stability levels are now inherited lexically, i.e., each item's
stability level becomes the default for any nested items.
* The computed stability level for an item is stored as part of the
metadata. When using an item from an external crate, this data is
looked up and cached.
* The stability lint works from the computed stability level, rather
than manual stability attribute annotations. However, the lint still
checks only a limited set of item uses (e.g., it does not check every
component of a path on import). This will be addressed in a later PR,
as part of issue #8962.
* The stability lint only applies to items originating from external
crates, since the stability index is intended as a promise to
downstream crates.
* The "experimental" lint is now _allow_ by default. This is because
almost all existing crates have been marked "experimental", pending
library stabilization. With inheritance in place, this would generate
a massive explosion of warnings for every Rust program.
The lint should be changed back to deny-by-default after library
stabilization is complete.
* The "deprecated" lint still warns by default.
The net result: we can begin tracking stability index for the standard
libraries as we stabilize, without impacting most clients.
Closes #13540.
2014-06-11 19:23:11 -05:00
|
|
|
|
2015-01-14 17:20:14 -06:00
|
|
|
/// Cross-references the feature names of unstable APIs with enabled
|
2016-11-10 11:08:21 -06:00
|
|
|
/// features and possibly prints errors.
|
2019-06-21 16:49:03 -05:00
|
|
|
fn check_mod_unstable_api_usage(tcx: TyCtxt<'_>, module_def_id: DefId) {
|
2019-01-10 21:58:46 -06:00
|
|
|
tcx.hir().visit_item_likes_in_module(module_def_id, &mut Checker { tcx }.as_deep_visitor());
|
2018-06-06 15:13:52 -05:00
|
|
|
}
|
|
|
|
|
2019-12-29 04:20:20 -06:00
|
|
|
pub(crate) fn provide(providers: &mut Providers<'_>) {
|
2019-12-22 16:42:04 -06:00
|
|
|
*providers = Providers { check_mod_unstable_api_usage, ..*providers };
|
2019-12-29 04:20:20 -06:00
|
|
|
providers.stability_index = |tcx, cnum| {
|
|
|
|
assert_eq!(cnum, LOCAL_CRATE);
|
|
|
|
tcx.arena.alloc(new_index(tcx))
|
2019-06-21 18:44:45 -05:00
|
|
|
};
|
|
|
|
}
|
|
|
|
|
2019-06-11 14:03:44 -05:00
|
|
|
struct Checker<'tcx> {
|
2019-06-13 16:48:52 -05:00
|
|
|
tcx: TyCtxt<'tcx>,
|
2015-01-14 17:20:14 -06:00
|
|
|
}
|
|
|
|
|
2019-06-11 14:03:44 -05:00
|
|
|
impl Visitor<'tcx> for Checker<'tcx> {
|
2020-01-07 10:25:33 -06:00
|
|
|
type Map = Map<'tcx>;
|
|
|
|
|
2016-11-28 13:00:26 -06:00
|
|
|
/// Because stability levels are scoped lexically, we want to walk
|
|
|
|
/// nested items in the context of the outer item, so enable
|
|
|
|
/// deep-walking.
|
2020-01-07 10:25:33 -06:00
|
|
|
fn nested_visit_map(&mut self) -> NestedVisitorMap<'_, Self::Map> {
|
2018-12-04 06:45:36 -06:00
|
|
|
NestedVisitorMap::OnlyBodies(&self.tcx.hir())
|
2016-10-28 15:58:32 -05:00
|
|
|
}
|
|
|
|
|
2019-11-28 12:28:50 -06:00
|
|
|
fn visit_item(&mut self, item: &'tcx hir::Item<'tcx>) {
|
2019-09-26 11:51:36 -05:00
|
|
|
match item.kind {
|
2018-07-11 10:36:06 -05:00
|
|
|
hir::ItemKind::ExternCrate(_) => {
|
2016-11-10 11:08:21 -06:00
|
|
|
// compiler-generated `extern crate` items have a dummy span.
|
2019-12-22 16:42:04 -06:00
|
|
|
if item.span.is_dummy() {
|
|
|
|
return;
|
|
|
|
}
|
2016-11-10 11:08:21 -06:00
|
|
|
|
2019-06-27 04:28:14 -05:00
|
|
|
let def_id = self.tcx.hir().local_def_id(item.hir_id);
|
2017-09-08 15:51:57 -05:00
|
|
|
let cnum = match self.tcx.extern_mod_stmt_cnum(def_id) {
|
2016-11-10 11:08:21 -06:00
|
|
|
Some(cnum) => cnum,
|
|
|
|
None => return,
|
|
|
|
};
|
|
|
|
let def_id = DefId { krate: cnum, index: CRATE_DEF_INDEX };
|
2019-02-24 02:33:17 -06:00
|
|
|
self.tcx.check_stability(def_id, Some(item.hir_id), item.span);
|
2015-02-17 15:56:06 -06:00
|
|
|
}
|
|
|
|
|
2016-11-10 11:08:21 -06:00
|
|
|
// For implementations of traits, check the stability of each item
|
|
|
|
// individually as it's possible to have a stable trait with unstable
|
|
|
|
// items.
|
2020-01-17 18:14:29 -06:00
|
|
|
hir::ItemKind::Impl { of_trait: Some(ref t), items, .. } => {
|
2019-04-20 11:36:05 -05:00
|
|
|
if let Res::Def(DefKind::Trait, trait_did) = t.path.res {
|
2020-01-17 18:14:29 -06:00
|
|
|
for impl_item_ref in items {
|
2018-12-04 06:45:36 -06:00
|
|
|
let impl_item = self.tcx.hir().impl_item(impl_item_ref.id);
|
2019-12-22 16:42:04 -06:00
|
|
|
let trait_item_def_id = self
|
|
|
|
.tcx
|
|
|
|
.associated_items(trait_did)
|
2020-02-06 16:21:44 -06:00
|
|
|
.iter()
|
2018-06-10 14:24:24 -05:00
|
|
|
.find(|item| item.ident.name == impl_item.ident.name)
|
|
|
|
.map(|item| item.def_id);
|
2016-11-10 11:08:21 -06:00
|
|
|
if let Some(def_id) = trait_item_def_id {
|
2018-03-03 03:02:01 -06:00
|
|
|
// Pass `None` to skip deprecation warnings.
|
|
|
|
self.tcx.check_stability(def_id, None, impl_item.span);
|
2016-09-05 17:26:02 -05:00
|
|
|
}
|
|
|
|
}
|
2016-11-10 11:08:21 -06:00
|
|
|
}
|
2015-02-25 05:34:21 -06:00
|
|
|
}
|
2015-01-14 17:20:14 -06:00
|
|
|
|
2017-05-17 16:22:52 -05:00
|
|
|
// There's no good place to insert stability check for non-Copy unions,
|
|
|
|
// so semi-randomly perform it here in stability.rs
|
2018-07-11 10:36:06 -05:00
|
|
|
hir::ItemKind::Union(..) if !self.tcx.features().untagged_unions => {
|
2019-06-27 04:28:14 -05:00
|
|
|
let def_id = self.tcx.hir().local_def_id(item.hir_id);
|
2017-05-17 16:22:52 -05:00
|
|
|
let adt_def = self.tcx.adt_def(def_id);
|
|
|
|
let ty = self.tcx.type_of(def_id);
|
|
|
|
|
|
|
|
if adt_def.has_dtor(self.tcx) {
|
2019-11-30 00:40:28 -06:00
|
|
|
feature_err(
|
2019-12-22 16:42:04 -06:00
|
|
|
&self.tcx.sess.parse_sess,
|
|
|
|
sym::untagged_unions,
|
|
|
|
item.span,
|
|
|
|
"unions with `Drop` implementations are unstable",
|
2019-11-30 00:40:28 -06:00
|
|
|
)
|
|
|
|
.emit();
|
2017-05-17 16:22:52 -05:00
|
|
|
} else {
|
|
|
|
let param_env = self.tcx.param_env(def_id);
|
2020-01-05 16:43:45 -06:00
|
|
|
if !can_type_implement_copy(self.tcx, param_env, ty).is_ok() {
|
2019-11-30 00:40:28 -06:00
|
|
|
feature_err(
|
2019-12-22 16:42:04 -06:00
|
|
|
&self.tcx.sess.parse_sess,
|
|
|
|
sym::untagged_unions,
|
|
|
|
item.span,
|
|
|
|
"unions with non-`Copy` fields are unstable",
|
2019-11-30 00:40:28 -06:00
|
|
|
)
|
|
|
|
.emit();
|
2017-05-17 16:22:52 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-12-22 16:42:04 -06:00
|
|
|
_ => (/* pass */),
|
2015-02-25 05:34:21 -06:00
|
|
|
}
|
2016-11-10 11:08:21 -06:00
|
|
|
intravisit::walk_item(self, item);
|
2015-02-25 05:34:21 -06:00
|
|
|
}
|
2016-10-26 21:17:42 -05:00
|
|
|
|
2019-11-30 10:46:46 -06:00
|
|
|
fn visit_path(&mut self, path: &'tcx hir::Path<'tcx>, id: hir::HirId) {
|
2019-04-20 11:36:05 -05:00
|
|
|
if let Some(def_id) = path.res.opt_def_id() {
|
2018-11-11 11:28:56 -06:00
|
|
|
self.tcx.check_stability(def_id, Some(id), path.span)
|
2016-11-10 11:08:21 -06:00
|
|
|
}
|
|
|
|
intravisit::walk_path(self, path)
|
2016-10-26 21:17:42 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-11-26 20:59:49 -06:00
|
|
|
/// Given the list of enabled features that were not language features (i.e., that
|
2015-01-14 17:20:14 -06:00
|
|
|
/// were expected to be library features), and the list of features used from
|
|
|
|
/// libraries, identify activated features that don't exist and error about them.
|
2019-06-21 16:49:03 -05:00
|
|
|
pub fn check_unused_or_stable_features(tcx: TyCtxt<'_>) {
|
2017-04-24 09:23:36 -05:00
|
|
|
let access_levels = &tcx.privacy_access_levels(LOCAL_CRATE);
|
2017-03-23 14:13:29 -05:00
|
|
|
|
2017-08-31 17:08:34 -05:00
|
|
|
if tcx.stability().staged_api[&LOCAL_CRATE] {
|
2018-12-04 06:45:36 -06:00
|
|
|
let krate = tcx.hir().krate();
|
2019-12-22 16:42:04 -06:00
|
|
|
let mut missing = MissingStabilityAnnotations { tcx, access_levels };
|
2019-02-18 08:35:20 -06:00
|
|
|
missing.check_missing_stability(hir::CRATE_HIR_ID, krate.span, "crate");
|
2016-11-10 11:08:21 -06:00
|
|
|
intravisit::walk_crate(&mut missing, krate);
|
2016-11-28 13:00:26 -06:00
|
|
|
krate.visit_all_item_likes(&mut missing.as_deep_visitor());
|
2016-11-10 11:08:21 -06:00
|
|
|
}
|
|
|
|
|
2018-07-22 20:03:01 -05:00
|
|
|
let declared_lang_features = &tcx.features().declared_lang_features;
|
2018-10-16 03:44:26 -05:00
|
|
|
let mut lang_features = FxHashSet::default();
|
2018-07-23 11:34:04 -05:00
|
|
|
for &(feature, span, since) in declared_lang_features {
|
2018-07-22 20:03:01 -05:00
|
|
|
if let Some(since) = since {
|
|
|
|
// Warn if the user has enabled an already-stable lang feature.
|
2018-07-23 11:34:04 -05:00
|
|
|
unnecessary_stable_feature_lint(tcx, span, feature, since);
|
2018-07-22 20:03:01 -05:00
|
|
|
}
|
2019-10-15 23:48:20 -05:00
|
|
|
if !lang_features.insert(feature) {
|
2018-07-22 20:03:01 -05:00
|
|
|
// Warn if the user enables a lang feature multiple times.
|
2018-07-23 11:34:04 -05:00
|
|
|
duplicate_feature_err(tcx.sess, span, feature);
|
2018-07-22 20:03:01 -05:00
|
|
|
}
|
|
|
|
}
|
2018-07-22 19:20:33 -05:00
|
|
|
|
2018-07-22 20:03:01 -05:00
|
|
|
let declared_lib_features = &tcx.features().declared_lib_features;
|
2018-10-16 03:44:26 -05:00
|
|
|
let mut remaining_lib_features = FxHashMap::default();
|
2018-07-22 20:03:01 -05:00
|
|
|
for (feature, span) in declared_lib_features {
|
2018-07-22 19:22:01 -05:00
|
|
|
if remaining_lib_features.contains_key(&feature) {
|
2018-07-23 11:34:04 -05:00
|
|
|
// Warn if the user enables a lib feature multiple times.
|
|
|
|
duplicate_feature_err(tcx.sess, *span, *feature);
|
2018-07-22 19:22:01 -05:00
|
|
|
}
|
2018-07-22 20:03:01 -05:00
|
|
|
remaining_lib_features.insert(feature, span.clone());
|
2018-07-22 19:20:33 -05:00
|
|
|
}
|
2018-07-23 18:56:00 -05:00
|
|
|
// `stdbuild` has special handling for `libc`, so we need to
|
|
|
|
// recognise the feature when building std.
|
2018-08-06 10:46:08 -05:00
|
|
|
// Likewise, libtest is handled specially, so `test` isn't
|
|
|
|
// available as we'd like it to be.
|
2018-07-23 18:56:00 -05:00
|
|
|
// FIXME: only remove `libc` when `stdbuild` is active.
|
2018-08-06 10:46:08 -05:00
|
|
|
// FIXME: remove special casing for `test`.
|
2018-07-22 19:20:33 -05:00
|
|
|
remaining_lib_features.remove(&Symbol::intern("libc"));
|
2019-05-21 21:42:23 -05:00
|
|
|
remaining_lib_features.remove(&sym::test);
|
2018-07-22 19:20:33 -05:00
|
|
|
|
2019-12-22 16:42:04 -06:00
|
|
|
let check_features = |remaining_lib_features: &mut FxHashMap<_, _>, defined_features: &[_]| {
|
|
|
|
for &(feature, since) in defined_features {
|
|
|
|
if let Some(since) = since {
|
|
|
|
if let Some(span) = remaining_lib_features.get(&feature) {
|
|
|
|
// Warn if the user has enabled an already-stable lib feature.
|
|
|
|
unnecessary_stable_feature_lint(tcx, *span, feature, since);
|
2018-08-20 19:39:48 -05:00
|
|
|
}
|
|
|
|
}
|
2019-12-22 16:42:04 -06:00
|
|
|
remaining_lib_features.remove(&feature);
|
|
|
|
if remaining_lib_features.is_empty() {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
};
|
2018-08-20 19:39:48 -05:00
|
|
|
|
|
|
|
// We always collect the lib features declared in the current crate, even if there are
|
|
|
|
// no unknown features, because the collection also does feature attribute validation.
|
|
|
|
let local_defined_features = tcx.lib_features().to_vec();
|
|
|
|
if !remaining_lib_features.is_empty() {
|
|
|
|
check_features(&mut remaining_lib_features, &local_defined_features);
|
|
|
|
|
|
|
|
for &cnum in &*tcx.crates() {
|
|
|
|
if remaining_lib_features.is_empty() {
|
|
|
|
break;
|
2018-07-22 19:21:35 -05:00
|
|
|
}
|
2018-12-01 09:57:29 -06:00
|
|
|
check_features(&mut remaining_lib_features, tcx.defined_lib_features(cnum));
|
2018-07-22 19:21:35 -05:00
|
|
|
}
|
2018-07-22 19:20:33 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
for (feature, span) in remaining_lib_features {
|
2018-07-23 15:05:39 -05:00
|
|
|
struct_span_err!(tcx.sess, span, E0635, "unknown feature `{}`", feature).emit();
|
2018-07-22 19:20:33 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// FIXME(#44232): the `used_features` table no longer exists, so we
|
|
|
|
// don't lint about unused features. We should reenable this one day!
|
2017-08-31 17:08:34 -05:00
|
|
|
}
|
2015-01-16 12:25:16 -06:00
|
|
|
|
2019-12-22 16:42:04 -06:00
|
|
|
fn unnecessary_stable_feature_lint(tcx: TyCtxt<'_>, span: Span, feature: Symbol, since: Symbol) {
|
2020-01-31 06:24:57 -06:00
|
|
|
tcx.struct_span_lint_hir(lint::builtin::STABLE_FEATURES, hir::CRATE_HIR_ID, span, |lint| {
|
|
|
|
lint.build(&format!(
|
2019-12-22 16:42:04 -06:00
|
|
|
"the feature `{}` has been stable since {} and no longer requires \
|
2020-01-31 06:24:57 -06:00
|
|
|
an attribute to enable",
|
|
|
|
feature, since
|
|
|
|
)).emit();
|
|
|
|
}
|
2019-12-22 16:42:04 -06:00
|
|
|
);
|
2018-07-23 11:34:04 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
fn duplicate_feature_err(sess: &Session, span: Span, feature: Symbol) {
|
|
|
|
struct_span_err!(sess, span, E0636, "the feature `{}` has already been declared", feature)
|
|
|
|
.emit();
|
Preliminary feature staging
This partially implements the feature staging described in the
[release channel RFC][rc]. It does not yet fully conform to the RFC as
written, but does accomplish its goals sufficiently for the 1.0 alpha
release.
It has three primary user-visible effects:
* On the nightly channel, use of unstable APIs generates a warning.
* On the beta channel, use of unstable APIs generates a warning.
* On the beta channel, use of feature gates generates a warning.
Code that does not trigger these warnings is considered 'stable',
modulo pre-1.0 bugs.
Disabling the warnings for unstable APIs continues to be done in the
existing (i.e. old) style, via `#[allow(...)]`, not that specified in
the RFC. I deem this marginally acceptable since any code that must do
this is not using the stable dialect of Rust.
Use of feature gates is itself gated with the new 'unstable_features'
lint, on nightly set to 'allow', and on beta 'warn'.
The attribute scheme used here corresponds to an older version of the
RFC, with the `#[staged_api]` crate attribute toggling the staging
behavior of the stability attributes, but the user impact is only
in-tree so I'm not concerned about having to make design changes later
(and I may ultimately prefer the scheme here after all, with the
`#[staged_api]` crate attribute).
Since the Rust codebase itself makes use of unstable features the
compiler and build system to a midly elaborate dance to allow it to
bootstrap while disobeying these lints (which would otherwise be
errors because Rust builds with `-D warnings`).
This patch includes one significant hack that causes a
regression. Because the `format_args!` macro emits calls to unstable
APIs it would trigger the lint. I added a hack to the lint to make it
not trigger, but this in turn causes arguments to `println!` not to be
checked for feature gates. I don't presently understand macro
expansion well enough to fix. This is bug #20661.
Closes #16678
[rc]: https://github.com/rust-lang/rfcs/blob/master/text/0507-release-channels.md
2015-01-06 08:26:08 -06:00
|
|
|
}
|