pjht/buku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not commit if no records deleted.

Browse Source
This commit is contained in:
Arun Prakash Jana 2016-12-27 09:10:08 +05:30
parent aef76e94c8
commit 9c7768e84d
No known key found for this signature in database
GPG Key ID: A75979F35C080412
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
buku.py
View File

@ -988,8 +988,8 @@ class BukuDb:
'''Delete a single record or remove the table if index is None
:param index: DB index of deleted entry
:param low: lower index of range
:param low: higher index of range
:param low: actual lower index of range
:param high: actual higher index of range
:param is_range: a range is passed using low and high arguments
:param delay_commit: do not commit to DB, caller's responsibility
:return: True on success, False on failure
@ -1003,7 +1003,10 @@ class BukuDb:
try:
query = 'DELETE from bookmarks where id BETWEEN ? AND ?'
self.cur.execute(query, (low, high))
print('Bookmarks from index %d to %d deleted' % (low, high))
print('Index %d-%d: %d deleted'
% (low, high, self.cur.rowcount))
if not self.cur.rowcount:
return False
# Compact DB by ascending order of index to ensure
# the existing higher indices move only once
@ -1023,7 +1026,7 @@ class BukuDb:
query = 'DELETE FROM bookmarks WHERE id = ?'
self.cur.execute(query, (index,))
if self.cur.rowcount == 1:
print('Removed index %d' % index)
print('Index %d deleted' % index)
self.compactdb(index, delay_commit=True)
if not delay_commit:
self.conn.commit()